sr-dev October 2011

sr-dev@lists.kamailio.org

37 participants
283 discussions

[tracker] Assignee added: tm lw_parser skips 4 bytes past Call-ID:

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#168 - tm lw_parser skips 4 bytes past Call-ID: User who did this - Walter Doekes (wdoekes) http://sip-router.org/tracker/index.php?do=details&task_id=168 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 11 months

[tracker] Task opened: tm lw_parser skips 4 bytes past Call-ID: (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Walter Doekes (wdoekes) Attached to Project - sip-router Summary - tm lw_parser skips 4 bytes past Call-ID: Task Type - Bug Report Category - tm Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - All Severity - Very Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hi, while looking for something else, I stumbled on a very very minor issue: build_local_reparse() .... /* parse HF name */ s = lw_get_hf_name(s, invite_buf_end, &hf_type); When hf_type == HDR_CALLID_T then s points 4 bytes past the ':'. So, when we have buffer = "Call-ID: abc...", then s is not ": abc..." but s is "c...". This is because p gets incremented by 4 and later by 7, instead of 4+3. This issue is completely harmless, because build_local_reparse seeks to EOL (s = lw_next_line(s, invite_buf_end)) and uses the entire line. (This would only cause funny behaviour if you have a very short -- one octet -- Call-ID.) See patch. Regards, Walter Doekes OSSO B.V. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=168 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 11 months

branch 3.2 was created

by Daniel-Constantin Mierla

Hello, short notice to let everyone know that the branch for 3.2.x release series was created with the name 3.2. For example, downloading sources from GIT and building Kamailio flavour form this branch can be done with: git clone --depth 1 git://git.sip-router.org/sip-router kamailio cd kamailio git checkout -b 3.2 origin/3.2 make FLAVOUR=kamailio cfg make all make install The official release of 3.2.0 will follow just a bit later today. Cheers, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Dec 5-8, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

12 years, 11 months

git:3.2: INSTALL: added short note about wiki site

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: 94d3b8cf8f4827ec7b77572f8a86ce4c044b9628 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=94d3b8c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 18 13:39:20 2011 +0200 INSTALL: added short note about wiki site (cherry picked from commit e3eb4e3e8471a3715f014a80adb79e0d93a88a5e) --- INSTALL | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/INSTALL b/INSTALL index e631567..aed811a 100644 --- a/INSTALL +++ b/INSTALL @@ -64,6 +64,9 @@ very few, Kamailio enabling next compile time flags: Switching between flavours is a matter of 'make' command parameters. +Several installation tutorials for Kamailio are available on the web wiki: + - http://www.kamailio.org/wiki/ + 2. Supported Architectures and Requirements -------------------------------------------

12 years, 11 months

git:master: INSTALL: added short note about wiki site

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: e3eb4e3e8471a3715f014a80adb79e0d93a88a5e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e3eb4e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 18 13:39:20 2011 +0200 INSTALL: added short note about wiki site --- INSTALL | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/INSTALL b/INSTALL index e631567..aed811a 100644 --- a/INSTALL +++ b/INSTALL @@ -64,6 +64,9 @@ very few, Kamailio enabling next compile time flags: Switching between flavours is a matter of 'make' command parameters. +Several installation tutorials for Kamailio are available on the web wiki: + - http://www.kamailio.org/wiki/ + 2. Supported Architectures and Requirements -------------------------------------------

12 years, 11 months

git:master: Makefile: version set to 3.3.0-dev0

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 43b060254191279f2257366acf35d86c076a48a0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=43b0602… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 18 13:10:33 2011 +0200 Makefile: version set to 3.3.0-dev0 --- Makefile.defs | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index b344a7e..69f8d74 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -160,9 +160,9 @@ INSTALL_FLAVOUR=$(FLAVOUR) #version number VERSION = 3 -PATCHLEVEL = 2 +PATCHLEVEL = 3 SUBLEVEL = 0 -EXTRAVERSION = -pre4 +EXTRAVERSION = -dev0 # memory debugger switcher # 0 - off (release mode)

12 years, 11 months

git:3.2: ChangeLog: file updated for version 3.2.0

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: 3d5e14ee66bba29a26070811282818fbf977b3ac URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3d5e14e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 18 13:06:30 2011 +0200 ChangeLog: file updated for version 3.2.0 --- ChangeLog |17318 ++++++++++++++++++++++++++++--------------------------------- 1 files changed, 7950 insertions(+), 9368 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=3d5…

12 years, 11 months

git:3.2: Makefile: version set to 3.2.0

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: bd71957fe6ba1a1b45e530ae623163f7dd56b5cb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bd71957… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 18 13:05:17 2011 +0200 Makefile: version set to 3.2.0 --- Makefile.defs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index b344a7e..2fc5211 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -162,7 +162,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 3 PATCHLEVEL = 2 SUBLEVEL = 0 -EXTRAVERSION = -pre4 +EXTRAVERSION = # memory debugger switcher # 0 - off (release mode)

12 years, 11 months

git:3.2: core and modules: fix compile warnings on freebsd

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: 7bbcaadba5674ecde5086037e802b1078e0a5a47 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7bbcaad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 18 12:50:49 2011 +0200 core and modules: fix compile warnings on freebsd (cherry picked from commit 7dfda822e579a543bbda65dc4764b0f426a144e5) --- lib/srdb2/db_uri.c | 4 +++- modules_k/acc/acc_cdr.c | 4 ++-- modules_k/dmq/bind_dmq.c | 3 ++- modules_k/dmq/bind_dmq.h | 3 ++- modules_k/dmq/dmq.c | 3 ++- modules_k/dmq/dmq.h | 3 ++- modules_k/dmq/dmq_funcs.c | 1 + modules_k/dmq/dmq_funcs.h | 3 ++- modules_k/dmq/dmqnode.c | 1 + modules_k/dmq/dmqnode.h | 3 ++- modules_k/dmq/message.c | 3 ++- modules_k/dmq/message.h | 3 ++- modules_k/dmq/notification_peer.c | 1 + modules_k/dmq/notification_peer.h | 3 ++- modules_k/dmq/peer.c | 3 ++- modules_k/dmq/peer.h | 3 ++- modules_k/dmq/worker.c | 1 + modules_k/dmq/worker.h | 3 ++- modules_k/nat_traversal/nat_traversal.c | 4 ++-- modules_k/p_usrloc/ul_db_handle.c | 2 +- modules_k/presence_xml/pidf.c | 3 ++- modules_k/pv/pv_xavp.c | 4 ++-- 22 files changed, 40 insertions(+), 21 deletions(-) diff --git a/lib/srdb2/db_uri.c b/lib/srdb2/db_uri.c index e87e8f2..0c37c89 100644 --- a/lib/srdb2/db_uri.c +++ b/lib/srdb2/db_uri.c @@ -71,6 +71,7 @@ db_uri_t* db_uri(const char* uri) char* colon; int len; db_uri_t* newp; + char *turi; newp = (db_uri_t*)pkg_malloc(sizeof(db_uri_t)); if (newp == NULL) goto error; @@ -78,7 +79,8 @@ db_uri_t* db_uri(const char* uri) if (db_gen_init(&newp->gen) < 0) goto error; len = strlen(uri); - colon = q_memchr((char *)uri, ':', len); + turi = (char*)uri; + colon = q_memchr(turi, ':', len); if (colon == NULL) { newp->scheme.s = pkg_malloc(len + 1); if (newp->scheme.s == NULL) goto error; diff --git a/modules_k/acc/acc_cdr.c b/modules_k/acc/acc_cdr.c index f4b9348..88d4a22 100644 --- a/modules_k/acc/acc_cdr.c +++ b/modules_k/acc/acc_cdr.c @@ -242,9 +242,9 @@ static int time2string( struct timeval* time_value, str* time_str) buffer_length = snprintf( time_buffer, TIME_BUFFER_LENGTH, "%ld%c%03d", - time_value->tv_sec, + (long int)time_value->tv_sec, time_separator, - (int)time_value->tv_usec/1000); + (int)(time_value->tv_usec/1000)); if( buffer_length < 0) { diff --git a/modules_k/dmq/bind_dmq.c b/modules_k/dmq/bind_dmq.c index 88e02ff..472babb 100644 --- a/modules_k/dmq/bind_dmq.c +++ b/modules_k/dmq/bind_dmq.c @@ -8,4 +8,5 @@ int bind_dmq(dmq_api_t* api) { api->send_message = send_dmq_message; api->bcast_message = bcast_dmq_message; return 0; -} \ No newline at end of file +} + diff --git a/modules_k/dmq/bind_dmq.h b/modules_k/dmq/bind_dmq.h index f15e673..d89b534 100644 --- a/modules_k/dmq/bind_dmq.h +++ b/modules_k/dmq/bind_dmq.h @@ -18,4 +18,5 @@ typedef int (*bind_dmq_f)(dmq_api_t* api); int bind_dmq(dmq_api_t* api); -#endif \ No newline at end of file +#endif + diff --git a/modules_k/dmq/dmq.c b/modules_k/dmq/dmq.c index c8fbff9..7a62302 100644 --- a/modules_k/dmq/dmq.c +++ b/modules_k/dmq/dmq.c @@ -280,4 +280,5 @@ static int parse_server_address(str* uri, struct sip_uri* parsed_uri) { empty: uri->s = NULL; return 0; -} \ No newline at end of file +} + diff --git a/modules_k/dmq/dmq.h b/modules_k/dmq/dmq.h index e4c639c..df92cea 100644 --- a/modules_k/dmq/dmq.h +++ b/modules_k/dmq/dmq.h @@ -49,4 +49,5 @@ static inline int dmq_load_api(dmq_api_t* api) { int handle_dmq_message(struct sip_msg* msg, char* str1 ,char* str2); -#endif \ No newline at end of file +#endif + diff --git a/modules_k/dmq/dmq_funcs.c b/modules_k/dmq/dmq_funcs.c index afb50f4..a71da87 100644 --- a/modules_k/dmq/dmq_funcs.c +++ b/modules_k/dmq/dmq_funcs.c @@ -167,3 +167,4 @@ void ping_servers(unsigned int ticks,void *param) { LM_ERR("error broadcasting message\n"); } } + diff --git a/modules_k/dmq/dmq_funcs.h b/modules_k/dmq/dmq_funcs.h index 8ba2503..1c6dd91 100644 --- a/modules_k/dmq/dmq_funcs.h +++ b/modules_k/dmq/dmq_funcs.h @@ -25,4 +25,5 @@ dmq_peer_t* register_dmq_peer(dmq_peer_t* peer); int send_dmq_message(dmq_peer_t* peer, str* body, dmq_node_t* node, dmq_resp_cback_t* resp_cback, int max_forwards); int bcast_dmq_message(dmq_peer_t* peer, str* body, dmq_node_t* except, dmq_resp_cback_t* resp_cback, int max_forwards); -#endif \ No newline at end of file +#endif + diff --git a/modules_k/dmq/dmqnode.c b/modules_k/dmq/dmqnode.c index d567a34..36971e9 100644 --- a/modules_k/dmq/dmqnode.c +++ b/modules_k/dmq/dmqnode.c @@ -246,3 +246,4 @@ int build_node_str(dmq_node_t* node, char* buf, int buflen) { len += get_status_str(node->status)->len; return len; } + diff --git a/modules_k/dmq/dmqnode.h b/modules_k/dmq/dmqnode.h index e2c2437..43b4820 100644 --- a/modules_k/dmq/dmqnode.h +++ b/modules_k/dmq/dmqnode.h @@ -54,4 +54,5 @@ int build_node_str(dmq_node_t* node, char* buf, int buflen); extern dmq_node_t* self_node; extern dmq_node_t* notification_node; -#endif \ No newline at end of file +#endif + diff --git a/modules_k/dmq/message.c b/modules_k/dmq/message.c index 434f80d..3971ab5 100644 --- a/modules_k/dmq/message.c +++ b/modules_k/dmq/message.c @@ -47,4 +47,5 @@ int handle_dmq_message(struct sip_msg* msg, char* str1, char* str2) { return 0; error: return -1; -} \ No newline at end of file +} + diff --git a/modules_k/dmq/message.h b/modules_k/dmq/message.h index 7e0cb95..e9a01a7 100644 --- a/modules_k/dmq/message.h +++ b/modules_k/dmq/message.h @@ -1,2 +1,3 @@ -int handle_dmq_message(struct sip_msg*, char*, char*); \ No newline at end of file +int handle_dmq_message(struct sip_msg*, char*, char*); + diff --git a/modules_k/dmq/notification_peer.c b/modules_k/dmq/notification_peer.c index ea12dd8..a6d134b 100644 --- a/modules_k/dmq/notification_peer.c +++ b/modules_k/dmq/notification_peer.c @@ -218,3 +218,4 @@ int notification_resp_callback_f(struct sip_msg* msg, int code, dmq_node_t* node } return 0; } + diff --git a/modules_k/dmq/notification_peer.h b/modules_k/dmq/notification_peer.h index 78cf190..001b530 100644 --- a/modules_k/dmq/notification_peer.h +++ b/modules_k/dmq/notification_peer.h @@ -23,4 +23,5 @@ dmq_node_t* add_server_and_notify(str* server_address); /* helper functions */ extern int notification_resp_callback_f(struct sip_msg* msg, int code, dmq_node_t* node, void* param); -extern dmq_resp_cback_t notification_callback; \ No newline at end of file +extern dmq_resp_cback_t notification_callback; + diff --git a/modules_k/dmq/peer.c b/modules_k/dmq/peer.c index 39ae836..588445f 100644 --- a/modules_k/dmq/peer.c +++ b/modules_k/dmq/peer.c @@ -41,4 +41,5 @@ dmq_peer_t* find_peer(str peer_id) { dmq_peer_t foo_peer; foo_peer.peer_id = peer_id; return search_peer_list(peer_list, &foo_peer); -} \ No newline at end of file +} + diff --git a/modules_k/dmq/peer.h b/modules_k/dmq/peer.h index 0d543bd..b2ec9a2 100644 --- a/modules_k/dmq/peer.h +++ b/modules_k/dmq/peer.h @@ -41,4 +41,5 @@ dmq_peer_t* add_peer(dmq_peer_list_t* peer_list, dmq_peer_t* peer); dmq_peer_t* find_peer(str peer_id); -#endif \ No newline at end of file +#endif + diff --git a/modules_k/dmq/worker.c b/modules_k/dmq/worker.c index fbf5443..9da3b9f 100644 --- a/modules_k/dmq/worker.c +++ b/modules_k/dmq/worker.c @@ -183,3 +183,4 @@ dmq_job_t* job_queue_pop(job_queue_t* queue) { lock_release(&queue->lock); return front; } + diff --git a/modules_k/dmq/worker.h b/modules_k/dmq/worker.h index 61eda09..d6f8dbd 100644 --- a/modules_k/dmq/worker.h +++ b/modules_k/dmq/worker.h @@ -40,4 +40,5 @@ void job_queue_push(job_queue_t* queue, dmq_job_t* job); dmq_job_t* job_queue_pop(job_queue_t* queue); int job_queue_size(job_queue_t* queue); -#endif \ No newline at end of file +#endif + diff --git a/modules_k/nat_traversal/nat_traversal.c b/modules_k/nat_traversal/nat_traversal.c index 62227e4..9877766 100644 --- a/modules_k/nat_traversal/nat_traversal.c +++ b/modules_k/nat_traversal/nat_traversal.c @@ -1626,8 +1626,8 @@ save_keepalive_state(void) fprintf(f, "%s %.*s %ld %ld\n", contact->uri, contact->socket->sock_str.len, contact->socket->sock_str.s, - contact->registration_expire, - contact->subscription_expire); + (long int)contact->registration_expire, + (long int)contact->subscription_expire); contact = contact->next; } } diff --git a/modules_k/p_usrloc/ul_db_handle.c b/modules_k/p_usrloc/ul_db_handle.c index 3216426..49dc464 100644 --- a/modules_k/p_usrloc/ul_db_handle.c +++ b/modules_k/p_usrloc/ul_db_handle.c @@ -458,7 +458,7 @@ int check_handle(db_func_t * dbf, db1_con_t * dbh, ul_db_handle_t * handle){ } else if((handle->db[i].status == DB_ON) && handle->db[i].dbh) { if((handle->db[i].failover_time < (time(NULL) - expire_time)) && (handle->db[i].failover_time != UL_DB_ZERO_TIME)){ LM_ERR("%s: failover_time: %ld, now: %ld, delta: %ld, now going to reset failover time\n", __FUNCTION__, - handle->db[i].failover_time, time(NULL), (time(NULL) - handle->db[i].failover_time)); + (long int)handle->db[i].failover_time, (long int)time(NULL), (long int)(time(NULL) - handle->db[i].failover_time)); if(db_reset_failover_time(handle, handle->db[i].no) < 0) { LM_ERR("could not reset failover time for id %i, db %i.\n", handle->id, handle->db[i].no); diff --git a/modules_k/presence_xml/pidf.c b/modules_k/presence_xml/pidf.c index 95b0a47..822ebea 100644 --- a/modules_k/presence_xml/pidf.c +++ b/modules_k/presence_xml/pidf.c @@ -31,6 +31,8 @@ * \ingroup presence_xml */ +#include "../../sr_module.h" + /** * make strptime available * use 600 for 'Single UNIX Specification, Version 3' @@ -55,7 +57,6 @@ #include <stdlib.h> #include <libxml/parser.h> #include "../../dprint.h" -#include "../../sr_module.h" #include "pidf.h" xmlAttrPtr xmlNodeGetAttrByName(xmlNodePtr node, const char *name) diff --git a/modules_k/pv/pv_xavp.c b/modules_k/pv/pv_xavp.c index e706d04..b434794 100644 --- a/modules_k/pv/pv_xavp.c +++ b/modules_k/pv/pv_xavp.c @@ -42,11 +42,11 @@ int pv_xavp_get_value(struct sip_msg *msg, pv_param_t *param, return pv_get_strval(msg, param, res, &avp->val.v.s); break; case SR_XTYPE_TIME: - if(snprintf(_pv_xavp_buf, 128, "%lu", avp->val.v.t)<0) + if(snprintf(_pv_xavp_buf, 128, "%lu", (long unsigned)avp->val.v.t)<0) return pv_get_null(msg, param, res); break; case SR_XTYPE_LONG: - if(snprintf(_pv_xavp_buf, 128, "%ld", avp->val.v.l)<0) + if(snprintf(_pv_xavp_buf, 128, "%ld", (long unsigned)avp->val.v.l)<0) return pv_get_null(msg, param, res); break; case SR_XTYPE_LLONG:

12 years, 11 months

git:3.2: presence_xml: remove unecessary include

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: f3694bbc88b7693a6aab693e4aab79de19ab8459 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f3694bb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 18 13:02:53 2011 +0200 presence_xml: remove unecessary include - adds warnings about strptime (cherry picked from commit 82b44dc4b97a9bd9a3e0720e06c4dda69995b998) --- modules_k/presence_xml/pidf.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/modules_k/presence_xml/pidf.c b/modules_k/presence_xml/pidf.c index 822ebea..85f4041 100644 --- a/modules_k/presence_xml/pidf.c +++ b/modules_k/presence_xml/pidf.c @@ -31,7 +31,6 @@ * \ingroup presence_xml */ -#include "../../sr_module.h" /** * make strptime available

12 years, 11 months

← Newer
1
...
9
10
11
12
13
14
15
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2011