THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#121 - Fault upon UA registration
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Not a bug
Additional comments about closing: No feedback for 6 months and no similar report so far from other users. If you still get the issue with latest stables, reopen and provide details from the gdb backtrace.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=121
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab.
FS#158 - Changing R-URI in dialog-info PUBLISH in event_route[tm:local-request]
User who did this: Daniel-Constantin Mierla (miconda)
Category: Core -> tm
Task Type: Bug Report -> Feature Request
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=158
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
Daniel-Constantin Mierla has taken ownership of the following task:
FS#158 - Changing R-URI in dialog-info PUBLISH in event_route[tm:local-request]
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=158
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#158 - Changing R-URI in dialog-info PUBLISH in event_route[tm:local-request]
User who did this - Daniel-Constantin Mierla (miconda)
----------
This is the way the functionality was implemented from first time (openser 1.4 when this route block was named local_route). The reason was that the destination address was set by the internal initiator of the request and should not be changed. Updates to headers should be visible instead.
Isn't possible to set the r-uri to final form from the application that generates the PUBLISH?
I will change this to feature request and see for the next major version (3.3) if there are enough good reasons to implement it.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=158#comment307
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab.
FS#153 - dialplan replacement with AVPs doesn't work
User who did this: Daniel-Constantin Mierla (miconda)
Percent Complete: 0% -> 80%
Severity: Low -> Very Low
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=153
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#153 - dialplan replacement with AVPs doesn't work
User who did this - Daniel-Constantin Mierla (miconda)
----------
It seems the problem is with some variables, including AVPs with string names. I just did a commit to fix the usage of avps with string names (as well as other variables with string names), but other variables that have dynamic name (i.e., variables having the name including variables to be expanded at runtime) still may have the issue. The problem was that the parsing of replacement was done against the value stored in private memory, thus the AVP spec was pointing there, which was invalid at runtime. Now the replacement value is cloned in shared memory and then parsed.
The problem with variables with dynamic names is that at this moment there is now way to clone their parsed name easily to shared memory. It will stay so for future fixes.
The commit is now on master branch, if you can test, then it will be backported to 3.1.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=153#comment306
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Module: sip-router
Branch: master
Commit: 08390a9a79e111e2d22533476d397dd9a92744ac
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=08390a9…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Mon Oct 17 18:42:39 2011 +0200
dialplan: added sample records to readme
- added note about limitation in using pseudo-variables in replacement
expressions
---
modules/dialplan/README | 32 ++++++++++++++++++++++++
modules/dialplan/doc/dialplan_admin.xml | 40 +++++++++++++++++++++++++++++-
2 files changed, 70 insertions(+), 2 deletions(-)
diff --git a/modules/dialplan/README b/modules/dialplan/README
index 3036a3f..95f2950 100644
--- a/modules/dialplan/README
+++ b/modules/dialplan/README
@@ -78,6 +78,7 @@ Juha Heinanen
1.12. Set fetch_rows parameter
1.13. dp_translate usage
1.14. dp_translate usage
+ 1.15. Example of rules
Chapter 1. Admin Guide
@@ -456,6 +457,37 @@ xlog("translated to var $var(y) \n");
the complete database documentation on the project webpage,
http://www.kamailio.org/docs/db-tables/kamailio-db-devel.html.
+ Some sample records fromd dialplan table are presented in the next
+ figure.
+
+ Example 1.15. Example of rules
+...
+dpid: 1
+pr: 1
+match_op: 1
+match_exp: ^0([1-9][0-9]+)$
+match_len: 0
+subst_exp: ^0([1-9][0-9]+)$
+repl_exp: 0049\1
+attrs: xyz
+...
+dpid: 1
+pr: 1
+match_op: 1
+match_exp: ^0([1-9][0-9]+)$
+match_len: 0
+subst_exp: ^0(.+)$
+repl_exp: $var(prefix)\1
+attrs: xyz
+...
+
+ Note that you can use config variables in the replacement expression
+ (repl_exp) field. However, not all of config variables are safe to use
+ there - specifically the variables that have in their name other
+ variables (variables with dinamic name). References to sip message,
+ private variables ($var(...)) and AVPs with static name are among those
+ that are safe to use in replacement expressions.
+
Chapter 2. Developer's Guide
The module does not provide any API to use in other Kamailio modules.
diff --git a/modules/dialplan/doc/dialplan_admin.xml b/modules/dialplan/doc/dialplan_admin.xml
index 9e9610b..398b934 100644
--- a/modules/dialplan/doc/dialplan_admin.xml
+++ b/modules/dialplan/doc/dialplan_admin.xml
@@ -563,12 +563,48 @@ xlog("translated to var $var(y) \n");
<section>
<title>Installation</title>
<para>
- The modules requires one table in &kamailio; database: dialplan. The SQL
- syntax to create them can be found in dialplan-create.sql
+ The modules requires one table in &kamailio; database: dialplan.
+ The SQL syntax to create them can be found in dialplan-create.sql
script in the database directories in the kamailio/scripts folder.
You can also find the complete database documentation on the
project webpage, &kamailiodbdocslink;.
</para>
+ <para>
+ Some sample records fromd dialplan table are presented in the next
+ figure.
+ </para>
+ <example>
+ <title>Example of rules</title>
+ <programlisting format="linespecific">
+...
+dpid: 1
+pr: 1
+match_op: 1
+match_exp: ^0([1-9][0-9]+)$
+match_len: 0
+subst_exp: ^0([1-9][0-9]+)$
+repl_exp: 0049\1
+attrs: xyz
+...
+dpid: 1
+pr: 1
+match_op: 1
+match_exp: ^0([1-9][0-9]+)$
+match_len: 0
+subst_exp: ^0(.+)$
+repl_exp: $var(prefix)\1
+attrs: xyz
+...
+ </programlisting>
+ </example>
+ <para>
+ Note that you can use config variables in the replacement expression
+ (repl_exp) field. However, not all of config variables are safe to use
+ there - specifically the variables that have in their name other
+ variables (variables with dinamic name). References to sip message,
+ private variables ($var(...)) and AVPs with static name are among
+ those that are safe to use in replacement expressions.
+ </para>
</section>
</chapter>
Module: sip-router
Branch: master
Commit: ae89dc494ff9ef046adf1fb954d41a162e12cfd9
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ae89dc4…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Mon Oct 17 18:27:42 2011 +0200
dialplan: fix usage of avps in replacement expression
- clone the replacement expression to shared memory before parsing it in
order to have variables names available at runtime
- most of variables should be safe to use now in replacement
expressions, including avps with string name. This fixes FS#153
reported by Andrew Pogrebennyk
- variables with dynamic name have no easy way to clone at this moment,
thus avoid using them directly. Use instead avps or script vars
($var(...)), copying the value from initial variable to it. Variables
pointing to sip message attributes are safe to use.
---
modules/dialplan/dialplan.c | 116 ++++++++++++++++++++--------------------
modules/dialplan/dp_db.c | 122 +++++++++++++++++++++----------------------
modules/dialplan/dp_repl.c | 108 +++++++++++++++++++++-----------------
3 files changed, 178 insertions(+), 168 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=ae8…
Module: sip-router
Branch: 3.1
Commit: 76fff5a2b2c24e5a7aac08375acf32346fa8f80a
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=76fff5a…
Author: Timo Reimann <timo.reimann(a)1und1.de>
Committer: Timo Reimann <timo.reimann(a)1und1.de>
Date: Mon Oct 17 11:46:45 2011 +0200
dialog(k): Note dependency between dlg_manage() and transactions
in docs.
(cherry picked from commit 807f07499b4875cf77463c3bdb6a47e099f18f58)
---
modules_k/dialog/doc/dialog_admin.xml | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/modules_k/dialog/doc/dialog_admin.xml b/modules_k/dialog/doc/dialog_admin.xml
index 9305b73..649223b 100644
--- a/modules_k/dialog/doc/dialog_admin.xml
+++ b/modules_k/dialog/doc/dialog_admin.xml
@@ -1291,6 +1291,15 @@ dlg_refer("caller", "sip:annoucement@kamailio.org");
<para>
This function can be used from REQUEST_ROUTE.
</para>
+ <para>
+ <b>IMPORTANT</b>: Users of this function should make sure that the
+ dialog created is further processed statefully. Specifically, if a
+ stateless response is sent out after dlg_manage() is called, the
+ dialog cannot be handled properly. So make sure that a transaction
+ exists or create it explicitly using the tm module.<br>This is a
+ shortcoming of the current implementation that may be resolved in a
+ future version hopefully.
+ </para>
<example>
<title><function>dlg_manage</function> usage</title>
<programlisting format="linespecific">
Module: sip-router
Branch: master
Commit: 807f07499b4875cf77463c3bdb6a47e099f18f58
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=807f074…
Author: Timo Reimann <timo.reimann(a)1und1.de>
Committer: Timo Reimann <timo.reimann(a)1und1.de>
Date: Mon Oct 17 11:46:45 2011 +0200
dialog(k): Note dependency between dlg_manage() and transactions
in docs.
---
modules_k/dialog/doc/dialog_admin.xml | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/modules_k/dialog/doc/dialog_admin.xml b/modules_k/dialog/doc/dialog_admin.xml
index 2fccc78..9bcbea1 100644
--- a/modules_k/dialog/doc/dialog_admin.xml
+++ b/modules_k/dialog/doc/dialog_admin.xml
@@ -1434,6 +1434,15 @@ dlg_refer("caller", "sip:annoucement@kamailio.org");
<para>
This function can be used from REQUEST_ROUTE.
</para>
+ <para>
+ <b>IMPORTANT</b>: Users of this function should make sure that the
+ dialog created is further processed statefully. Specifically, if a
+ stateless response is sent out after dlg_manage() is called, the
+ dialog cannot be handled properly. So make sure that a transaction
+ exists or create it explicitly using the tm module.<br>This is a
+ shortcoming of the current implementation that may be resolved in a
+ future version hopefully.
+ </para>
<example>
<title><function>dlg_manage</function> usage</title>
<programlisting format="linespecific">