THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#180 - DOUBLE FREE / CRASH in parse_to.c
User who did this - Bayan Towfiq (btowfiq)
----------
3.2
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=180#comment394
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive …
[View More]mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#181 - Kamailio / Crash / Textops (302 Redirect)
User who did this - Brandon Armstead (CRYY2010)
----------
Running this patch now - will let you know very shortly how it works out. This crash is pretty much reproducible within a 5-10 minute span.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=181#comment393
You are …
[View More]receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#180 - DOUBLE FREE / CRASH in parse_to.c
User who did this - Daniel-Constantin Mierla (miconda)
----------
What is the version of kamailio?
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=180#comment392
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect …
[View More]this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#182 - PV $ds in xlog in branch_route
User who did this - Pawel Sternal (Sternik)
----------
Thanks. This patch fixes the problem. Regards.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=182#comment391
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect …
[View More]this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#181 - Kamailio / Crash / Textops (302 Redirect)
User who did this - Daniel-Constantin Mierla (miconda)
----------
Can you try the attached patch (it is for 3.1 branch)? I'm uploading it for convenience, it includes the three commits I just did in master branch, touching core, tm and textops.
The issue is related to set_body(), which was not really safe to use in failure_route if there were other …
[View More]changes to body done in request_route. Let me know if works ok now, then I will backport.
----------
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=181#comment390
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#182 - PV $ds in xlog in branch_route
User who did this - Daniel-Constantin Mierla (miconda)
----------
I committed a patch to be safe to use $ds in branch_route (backup/restore the branch iterator). Here is the link to the commit:
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c5f101d…
If you can test it and all goes ok, I will backport to 3.2/3.1. Thanks.
----------
More …
[View More]information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=182#comment389
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
Module: sip-router
Branch: master
Commit: c5f101dfac9a50f428e3452893c402d8b1e0400b
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c5f101d…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Thu Nov 24 12:56:28 2011 +0100
core: save and restore branch_iterator in print_dset
- safe usage in branch_route where branch_interator is used to add the
new brnaches, but some variables can …
[View More]change it if used in config
branch_route
- closes FS#182, reported by Pawel Sternal
---
dset.c | 21 ++++++++++++++++++++-
dset.h | 8 ++++++--
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/dset.c b/dset.c
index f8bb337..4ba5ccf 100644
--- a/dset.c
+++ b/dset.c
@@ -191,11 +191,21 @@ void init_branch_iterator(void)
branch_iterator = 0;
}
+/**
+ * return the value of current branch iterator
+ */
int get_branch_iterator(void)
{
return branch_iterator;
}
+/**
+ * set the value of current branch interator
+ */
+void set_branch_iterator(int n)
+{
+ branch_iterator = n;
+}
/** \brief Get a branch from the destination set
@@ -366,6 +376,7 @@ char* print_dset(struct sip_msg* msg, int* len)
qvalue_t q;
str uri;
char* p, *qbuf;
+ int crt_branch;
static char dset[MAX_REDIRECTION_LEN];
if (msg->new_uri.s) {
@@ -379,6 +390,9 @@ char* print_dset(struct sip_msg* msg, int* len)
*len = 0;
}
+ /* backup current branch index to restore it later */
+ crt_branch = get_branch_iterator();
+
init_branch_iterator();
while ((uri.s = next_branch(&uri.len, &q, 0, 0, 0, 0))) {
cnt++;
@@ -394,7 +408,7 @@ char* print_dset(struct sip_msg* msg, int* len)
if (*len + 1 > MAX_REDIRECTION_LEN) {
LOG(L_ERR, "ERROR: redirection buffer length exceed\n");
- return 0;
+ goto error;
}
memcpy(dset, CONTACT, CONTACT_LEN);
@@ -445,7 +459,12 @@ char* print_dset(struct sip_msg* msg, int* len)
}
memcpy(p, CRLF " ", CRLF_LEN + 1);
+ set_branch_iterator(crt_branch);
return dset;
+
+error:
+ set_branch_iterator(crt_branch);
+ return 0;
}
diff --git a/dset.h b/dset.h
index 6f9f067..dfc3083 100644
--- a/dset.h
+++ b/dset.h
@@ -107,15 +107,19 @@ static inline int ser_append_branch(struct sip_msg* msg,
/*! \brief
- * Iterate through the list of transaction branches
+ * Init the index to iterate through the list of transaction branches
*/
void init_branch_iterator(void);
/*! \brief
- * Return branch iterator position
+ * Return branch iterator position
*/
int get_branch_iterator(void);
+/*! \brief
+ * Set branch iterator position
+ */
+void set_branch_iterator(int n);
/*! \brief Get the next branch in the current transaction.
* @return pointer to the uri of the next branch (which the length written in
[View Less]