sr-dev November 2011

sr-dev@lists.kamailio.org

31 participants
340 discussions

[tracker] Assignee added: DOUBLE FREE / CRASH in parse_to.c
by sip-router 24 Nov '11

24 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#180 - DOUBLE FREE / CRASH in parse_to.c User who did this - Bayan Towfiq (btowfiq) http://sip-router.org/tracker/index.php?do=details&task_id=180 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 23 Nov '11

23 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Brandon Armstead (CRYY2010) ---------- Daniel - Thanks! I've tried the patch for the time being and it appears that it is working so far. I will be sure to try the new dlg reference counting branch soon as well. Thanks! ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment385 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

releasing v3.2.1
by Daniel-Constantin Mierla 23 Nov '11

23 Nov '11

Hello, I plan to package v3.2.1 after mid of next week (most probably on Thursday) -- it is about 1 month and a half since 3.2.0 was released and branch 3.2 accumulated a bunch of patches. Anyone having comments about it? Cheers, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Dec 5-8, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 23 Nov '11

23 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Daniel-Constantin Mierla (miconda) ---------- There are two options of fixing provided above, that means we looked into it. Have you tried any of them and it is still a problem? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment384 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 23 Nov '11

23 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Brandon Armstead (CRYY2010) ---------- Wow - please look into this - very bad :(. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment383 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 23 Nov '11

23 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Bayan Towfiq (btowfiq) ---------- Timo, just a note: on the unpatched 3.2 (not including the new patches/branch/ or workaround solution) changing the config file stopped it from crashing. Here is the diff. Do you think it may have something to do with the dlg variables in branch_route or the dlg_manage changing to setflag(4)? 1 --- natproxy.cfg.old 2011-11-22 09:17:31.888043699 +0000 2 +++ natproxy.cfg 2011-11-22 08:30:52.182372274 +0000 3 @@ -94,11 +95,13 @@ 4 5 modparam("ctl", "binrpc", "/tmp/ser_ctl") 6 7 modparam("sanity", "autodrop", 0) 8 9 include_file "/usr/local/etc/kamailio/natproxy-modulesconfig.cfg" 10 11 -flags inbound_call, hash_id, hash_entry; 12 +flags inbound_call; 13 14 15 route{ 16 @@ -172,10 +175,7 @@ 17 } 18 19 if(allow_trusted() && is_method("INVITE")) { 20 - dlg_manage(); 21 - $avp(hash_entry) = $dlg(h_entry); 22 - $avp(hash_id) = $dlg(h_id); 23 + setflag(4); 24 $dlg_ctx(timeout_bye) = 1; 25 setflag(inbound_call); 26 if(is_present_hf("X-Reject")) { 27 @@ -690,8 +687,7 @@ 28 29 onreply_route[1] { 30 if($rm == "INVITE" && isflagset(inbound_call)) { 31 - append_hf("X-Hash: $avp(hash_entry):$avp(hash_id)\r\n"); #Appending hash in onreply_route here 32 append_hf("X-XMLRPC: $sel(cfg_get.xmlrpc.hostport)\r\n"); 33 }; 34 } 35 @@ -765,12 +761,7 @@ 36 } 37 38 branch_route[1] { 39 - if($avp(s:dlghash1) == $null) { 40 - $avp(s:dlghash1) = $dlg(h_entry); 41 - $avp(s:dlghash2) = $dlg(h_id); 42 - }; 43 - append_hf("X-Hash: $avp(s:dlghash1):$avp(s:dlghash2)\r\n"); #Appending hash in branch_route here 44 append_hf("X-XMLRPC: $sel(cfg_get.xmlrpc.hostport)\r\n"); 45 } 46 ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment382 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 22 Nov '11

22 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Timo Reimann (tr) ---------- Daniel, great you pushed the patch. I couldn't manage to do it myself yesterday so thanks for taking care of things. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment381 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

(no subject)
by Charles Wang 22 Nov '11

22 Nov '11

http://functioncatering.co.za/modules/mod_wdbanners/blog.php?html143

1 0

git:3.2: libkcore: set pid attribute for fake msg
by Daniel-Constantin Mierla 22 Nov '11

22 Nov '11

Module: sip-router Branch: 3.2 Commit: addbd17723585197ea41c58904be1c4b6be2fe7d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=addbd17… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Nov 18 00:10:26 2011 +0100 libkcore: set pid attribute for fake msg (cherry picked from commit 950b1e52ed8a94462be17e206d6970fd13a41661) --- lib/kcore/faked_msg.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/kcore/faked_msg.c b/lib/kcore/faked_msg.c index 9a51723..efaba59 100644 --- a/lib/kcore/faked_msg.c +++ b/lib/kcore/faked_msg.c @@ -58,7 +58,8 @@ int faked_msg_init(void) struct sip_msg* faked_msg_next(void) { - _faked_msg.id=_faked_msg_no++; + _faked_msg.id = 1 + _faked_msg_no++; + _faked_msg.pid = my_pid(); clear_branches(); return &_faked_msg; }

1 0

git:3.2: pv: use msg pid to check the integrity of cached time
by Daniel-Constantin Mierla 22 Nov '11

22 Nov '11

Module: sip-router Branch: 3.2 Commit: 24f138c9c39ac6475347ed76e311e1759d4d8531 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=24f138c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 22 11:30:02 2011 +0100 pv: use msg pid to check the integrity of cached time - safer when dealing with async or failure processing (cherry picked from commit cc33486a8c17ae2cb4cbb5fce42f7a73646cd3c1) --- modules_k/pv/pv_time.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/modules_k/pv/pv_time.c b/modules_k/pv/pv_time.c index 72f1134..ad7dd2c 100644 --- a/modules_k/pv/pv_time.c +++ b/modules_k/pv/pv_time.c @@ -36,13 +36,16 @@ #include "pv_time.h" static unsigned int _pv_msg_id = 0; +static int _pv_msg_pid = 0; static time_t _pv_msg_tm = 0; + static int pv_update_time(struct sip_msg *msg, time_t *t) { - if(_pv_msg_id != msg->id || _pv_msg_tm==0) + if(_pv_msg_id != msg->id || _pv_msg_pid != msg->pid || _pv_msg_tm==0) { _pv_msg_tm = time(NULL); _pv_msg_id = msg->id; + _pv_msg_pid = msg->pid; if(t!=NULL) *t=_pv_msg_tm;

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
34
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2011