sr-dev November 2011

sr-dev@lists.kamailio.org

31 participants
340 discussions

git:tmp/dlgnewref: dialog(k): refactored dlg ref counting

by Daniel-Constantin Mierla

Module: sip-router Branch: tmp/dlgnewref Commit: 9ba4ee25e32368a9c17c3f86784a52a97b748b93 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9ba4ee2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 21 23:52:43 2011 +0100 dialog(k): refactored dlg ref counting - dlg pointer is no longer stored in tm callbacks parameter and ref counting for these kind of needs was removed - the internal id (hash entry, dlg id) is given now to tm callbacks. The callbacks will do dlg lookup to get the structure - there are longer-time persistent ref counting for: * storing dlg structure in dialog hash table * keeping dlg in timer list * waiting for the reply of BYE to destroy dialog structure - all the other ref countings are for short time, only for the period of doing specific processing - the new ref counting is safer in relation with tm callbacks and avoids tight dependecy which may have been easily broken by future tm changes --- modules_k/dialog/dialog.c | 102 +++++++---- modules_k/dialog/dlg_db_handler.c | 8 +- modules_k/dialog/dlg_handlers.c | 387 +++++++++++++++++++------------------ modules_k/dialog/dlg_handlers.h | 23 ++- modules_k/dialog/dlg_hash.c | 60 +++++-- modules_k/dialog/dlg_hash.h | 73 +++++--- modules_k/dialog/dlg_profile.c | 145 ++++++--------- modules_k/dialog/dlg_profile.h | 44 ++--- modules_k/dialog/dlg_req_within.c | 12 +- modules_k/dialog/dlg_timer.h | 8 +- modules_k/dialog/dlg_var.c | 338 ++++++++++++++++++++++---------- modules_k/dialog/dlg_var.h | 34 ++-- 12 files changed, 716 insertions(+), 518 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=9ba…

13 years

[tracker] Comment added: segfault in tm/timers?

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#179 - segfault in tm/timers? User who did this - Bayan Towfiq (btowfiq) ---------- Hi Ovi, I'm not sure--what would you like me to check in gdb. Please give me any commands you'd like to run on the backtrace. Bayan ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=179#comment377 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: segfault in tm/timers?

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#179 - segfault in tm/timers? User who did this - Ovidiu Sas (osas) ---------- That's "s-3level". Maybe something is miss-aligned or the pointer is not properly set to point to the right field inside a dialog structure. It would be interesting to see what's before and after that memory block. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=179#comment373 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Daniel-Constantin Mierla (miconda) ---------- Try with attached patch -- an workaround solution for now discussed with Timo, but I guess he had no time to check and commit it yet. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment376 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Brandon Armstead (CRYY2010) ---------- Timo, This bug is turning into a nightmare! :(. It is totally weird since it seems to be present in 3.1 and 3.2 --- we've been running the 3.1 build since you worked out the last dialog issue. However it appears to be present in all recent builds (origin/3.1, origin/3.2, and several dialog commits downwards from HEAD of 3.1 & 3.2). I really really really appreciate any time and effort you can put into resolving this matter. Thanks for your help as always! ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment375 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Timo Reimann (tr) ---------- I know of quite a few people who use dlg_manage() regularly and repeatedly for subsequent requests, so I wouldn't consider it to be the #1 suspect. I'll take a closer look at it though, just to be sure. Thanks! ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment374 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: segfault in tm/timers?

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#179 - segfault in tm/timers? User who did this - Bayan Towfiq (btowfiq) ---------- (gdb) p *cbp Cannot access memory at address 0x732d336c6576656c :-\ ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=179#comment372 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: segfault in tm/timers?

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#179 - segfault in tm/timers? User who did this - Daniel-Constantin Mierla (miconda) ---------- It does not look related to timer at all, but to callbacks execution, which looks very strange considering the line where happens. Can you print the content of cbp in frame 0: gdb> p *cbp I see in the logs there are some errors related to some private development you did to flatstore module. Check also there not to have some buffer overflow or inadequate write to the parameters received from tm callback. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=179#comment371 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

New module: presence_profile

by MÉSZÁROS Mihály

Hello All, I've committed a new module named 'presence_profile' which provides UA config provisioniong according RFC6080. http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=commitdiff;h=cd… The README describes the module function: http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob_plain;f=mo… The modul is very very simple in it's current stage. The modul added only the event 'ua-profile' handling. Best Regards, Mihály Mészáros

13 years

git:master: Added reg_timer_interval modparam to uac to allow user to regulate the

by Alex Balashov

Module: sip-router Branch: master Commit: 455b64088b7ace99c767a3320b79f7069a3202b8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=455b640… Author: Alex Balashov - Diminuendo-2 <evariste-admins(a)evaristesys.com> Committer: Alex Balashov - Diminuendo-2 <evariste-admins(a)evaristesys.com> Date: Mon Nov 21 06:13:05 2011 -0500 Added reg_timer_interval modparam to uac to allow user to regulate the frequency with which registrations are renewed and otherwise managed. Previously, this has been hardcoded to 90 seconds. --- modules_k/uac/doc/uac_admin.xml | 40 +++++++++++++++++++++++++++++++++++++++ modules_k/uac/uac.c | 2 + 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/modules_k/uac/doc/uac_admin.xml b/modules_k/uac/doc/uac_admin.xml index da6a93d..e278be6 100644 --- a/modules_k/uac/doc/uac_admin.xml +++ b/modules_k/uac/doc/uac_admin.xml @@ -272,6 +272,7 @@ modparam("uac", "reg_db_url", </programlisting> </example> </section> + <section id="reg-contact-addr-id"> <title><varname>reg_contact_addr</varname> (string)</title> <para> @@ -287,6 +288,45 @@ modparam("uac", "reg_contact_addr", "192.168.1.2:5080") </programlisting> </example> </section> + + <section id="reg-timer-interval-id"> + <title><varname>reg_timer_interval</varname> (string)</title> + <para> + Timer interval (in seconds) at which registrations are managed, e.g. renewed as needed. + </para> + <para> + <emphasis> + The default value is 90 seconds. + </emphasis> + </para> + + <example> + <title>Set <varname>reg_timer_inteval</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("uac", "reg_timer_interval", 60) +... + </programlisting> + </example> + </section> + + </section> + + + <section id="reg-contact-addr-id"> + <title><varname>reg_contact_addr</varname> (string)</title> + <para> + Address to be used to build contact address. Must be at least + host part, can have port and parameters. Must not include 'sip:'. + </para> + <example> + <title>Set <varname>reg_contact_addr</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("uac", "reg_contact_addr", "192.168.1.2:5080") +... + </programlisting> + </example> </section> diff --git a/modules_k/uac/uac.c b/modules_k/uac/uac.c index 5f6112a..e1d2209 100644 --- a/modules_k/uac/uac.c +++ b/modules_k/uac/uac.c @@ -91,6 +91,7 @@ static int mod_init(void); static void mod_destroy(void); static int child_init(int rank); +extern int reg_timer_interval; static pv_export_t mod_pvs[] = { { {"uac_req", sizeof("uac_req")-1}, PVT_OTHER, pv_get_uac_req, pv_set_uac_req, @@ -134,6 +135,7 @@ static param_export_t params[] = { {"auth_password_avp", STR_PARAM, &auth_password_avp }, {"reg_db_url", STR_PARAM, &reg_db_url.s }, {"reg_contact_addr", STR_PARAM, &reg_contact_addr.s }, + {"reg_timer_interval", STR_PARAM, &reg_timer_interval }, {0, 0, 0} };

13 years

← Newer
1
...
13
14
15
16
17
18
19
...
34
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2011