sr-dev April 2012

sr-dev@lists.kamailio.org

29 participants
347 discussions

[tracker] Task closed: pua_reginfo callid XML string assignment small bug
by sip-router 17 Apr '12

17 Apr '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#212 - pua_reginfo callid XML string assignment small bug User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Thanks, patch applied More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=212 You are receiving this message because you have requested it from the Flyspray bugtracking system. … [View More]

1 0

[tracker] Task closed: pua_reginfo: registration state may be incorrect when unregistering single contact
by sip-router 17 Apr '12

17 Apr '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#213 - pua_reginfo: registration state may be incorrect when unregistering single contact User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Thanks, patch applied. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=213 You are receiving this message because you have requested it from … [View More]

1 0

git:master: pua_reginfo: fix for state of the registration during unregister
by Daniel-Constantin Mierla 17 Apr '12

17 Apr '12

Module: sip-router Branch: master Commit: c4be935b40b23b87b321fd604e761332bb07b8f8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c4be935… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 17 22:55:35 2012 +0200 pua_reginfo: fix for state of the registration during unregister - when unregistering a single contact, the state of the registration may be incorrectly reported .… [View More] - fix of a small inefficiency of repeatedly calling time(2) in the same function. - patch by Stefan Sayer, FS#213 --- modules_k/pua_reginfo/usrloc_cb.c | 30 ++++++++++++++++-------------- 1 files changed, 16 insertions(+), 14 deletions(-) diff --git a/modules_k/pua_reginfo/usrloc_cb.c b/modules_k/pua_reginfo/usrloc_cb.c index addeea9..92cf427 100644 --- a/modules_k/pua_reginfo/usrloc_cb.c +++ b/modules_k/pua_reginfo/usrloc_cb.c @@ -60,6 +60,8 @@ str* build_reginfo_full(urecord_t * record, str uri, ucontact_t* c, int type) { ucontact_t * ptr; char buf[512]; int buf_len; + int reg_active = 0; + time_t cur_time = time(0); /* create the XML-Body */ doc = xmlNewDoc(BAD_CAST "1.0"); @@ -94,18 +96,9 @@ str* build_reginfo_full(urecord_t * record, str uri, ucontact_t* c, int type) { buf_len = snprintf(buf, sizeof(buf), "%p", record); xmlNewProp(registration_node, BAD_CAST "id", BAD_CAST buf); - /* look first for an un-expired and suported contact */ - ptr = record->contacts; - while ((ptr) && !(VALID_CONTACT(ptr,time(0)))) - ptr = ptr->next; - if (ptr==0) - xmlNewProp(registration_node, BAD_CAST "state", BAD_CAST "terminated"); - else - xmlNewProp(registration_node, BAD_CAST "state", BAD_CAST "active"); - ptr = record->contacts; while (ptr) { - if (VALID_CONTACT(ptr, time(0))) { + if (VALID_CONTACT(ptr, cur_time)) { LM_DBG("Contact %.*s, %p\n", ptr->c.len, ptr->c.s, ptr); /* Contact-Node */ contact_node =xmlNewChild(registration_node, NULL, BAD_CAST "contact", NULL) ; @@ -118,9 +111,10 @@ str* build_reginfo_full(urecord_t * record, str uri, ucontact_t* c, int type) { xmlNewProp(contact_node, BAD_CAST "id", BAD_CAST buf); /* Check, if this is the modified contact: */ if (ptr == c) { - if ((type & UL_CONTACT_INSERT) || (type & UL_CONTACT_UPDATE)) + if ((type & UL_CONTACT_INSERT) || (type & UL_CONTACT_UPDATE)) { + reg_active = 1; xmlNewProp(contact_node, BAD_CAST "state", BAD_CAST "active"); - else + } else xmlNewProp(contact_node, BAD_CAST "state", BAD_CAST "terminated"); if (type & UL_CONTACT_INSERT) xmlNewProp(contact_node, BAD_CAST "event", BAD_CAST "created"); else if (type & UL_CONTACT_UPDATE) xmlNewProp(contact_node, BAD_CAST "event", BAD_CAST "refreshed"); @@ -128,13 +122,14 @@ str* build_reginfo_full(urecord_t * record, str uri, ucontact_t* c, int type) { else if (type & UL_CONTACT_DELETE) xmlNewProp(contact_node, BAD_CAST "event", BAD_CAST "unregistered"); else xmlNewProp(contact_node, BAD_CAST "event", BAD_CAST "unknown"); memset(buf, 0, sizeof(buf)); - buf_len = snprintf(buf, sizeof(buf), "%i", (int)(ptr->expires-time(0))); + buf_len = snprintf(buf, sizeof(buf), "%i", (int)(ptr->expires-cur_time)); xmlNewProp(contact_node, BAD_CAST "expires", BAD_CAST buf); } else { + reg_active = 1; xmlNewProp(contact_node, BAD_CAST "state", BAD_CAST "active"); xmlNewProp(contact_node, BAD_CAST "event", BAD_CAST "registered"); memset(buf, 0, sizeof(buf)); - buf_len = snprintf(buf, sizeof(buf), "%i", (int)(ptr->expires-time(0))); + buf_len = snprintf(buf, sizeof(buf), "%i", (int)(ptr->expires-cur_time)); xmlNewProp(contact_node, BAD_CAST "expires", BAD_CAST buf); } if (ptr->q != Q_UNSPECIFIED) { @@ -163,6 +158,13 @@ str* build_reginfo_full(urecord_t * record, str uri, ucontact_t* c, int type) { ptr = ptr->next; } + /* add registration state (at least one active contact): */ + if (reg_active==0) + xmlNewProp(registration_node, BAD_CAST "state", BAD_CAST "terminated"); + else + xmlNewProp(registration_node, BAD_CAST "state", BAD_CAST "active"); + + /* create the body */ body = (str*)pkg_malloc(sizeof(str)); if(body == NULL) { [View Less]

1 0

[tracker] Task closed: Problem with Max-Forwards header parsing
by sip-router 17 Apr '12

17 Apr '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#214 - Problem with Max-Forwards header parsing User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: I pushed a patch in git master branch to return false in case MF header cannot be processed. http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a15428e… More information can be found at the following URL: http://sip-router.org/… [View More]

1 0

[tracker] User took ownership: Problem with Max-Forwards header parsing
by sip-router 17 Apr '12

17 Apr '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#214 - Problem with Max-Forwards header parsing More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=214 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification … [View More]

1 0

git:master: maxfwd(k): return -2 (false) if MF header cannot be processed
by Daniel-Constantin Mierla 17 Apr '12

17 Apr '12

Module: sip-router Branch: master Commit: a15428e688049e7ef49174a2e24cbf49eb7a7cad URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a15428e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 17 22:40:06 2012 +0200 maxfwd(k): return -2 (false) if MF header cannot be processed - reported by Ladislav Jurak, FS#214 --- modules_k/maxfwd/maxfwd.c | 2 +- 1 files changed, 1 … [View More]

1 0

[tracker] Task opened: Problem with Max-Forwards header parsing
by sip-router 17 Apr '12

17 Apr '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Ladislav Jurak (ladis) Attached to Project - sip-router Summary - Problem with Max-Forwards header parsing Task Type - Bug Report Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - Linux Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hello, I am testing … [View More]

1 0

[tracker] Assignee added: Problem with Max-Forwards header parsing
by sip-router 17 Apr '12

17 Apr '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#214 - Problem with Max-Forwards header parsing User who did this - Ladislav Jurak (ladis) http://sip-router.org/tracker/index.php?do=details&task_id=214 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at … [View More]

1 0

registrar/usrloc updates - gruu support (rfc 5627)
by Daniel-Constantin Mierla 17 Apr '12

17 Apr '12

Hello, I just pushed GRUU support in git master branch. That implied adding two new columns to location table, therefore if you use devel version, **you have to update your db schema**. Perhaps a bit of tuning will follow in the next days, but GRUU support should be fully functional in terms of routing. Testing and feedback will be very appreciated as well as hints on what SIP hard/phones support GRUU properly. Be also aware that now you may have to do lookup location even for within … [View More]

1 1

git:master: usrloc(k): handle reg-id Contact parameter defined by RFC5626
by Daniel-Constantin Mierla 17 Apr '12

17 Apr '12

Module: sip-router Branch: master Commit: 221073eb54dbf9a29d8b68d6af86c3bbccdc2b17 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=221073e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 17 11:48:46 2012 +0200 usrloc(k): handle reg-id Contact parameter defined by RFC5626 - if reg-id is given in the Contact header, use it to match the usrloc record along with +sip.… [View More]

1 0

← Newer
1
...
22
23
24
25
26
27
28
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2012