sr-dev June 2012

sr-dev@lists.kamailio.org

31 participants
250 discussions

git:3.3: usrloc(k): better safety check for null record access

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.3 Commit: 493612344630a2e0b1f80687c8c650e97801ddf6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4936123… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 13 17:29:51 2012 +0200 usrloc(k): better safety check for null record access (cherry picked from commit 748b79fdeba12736b109dfbd77a3e9bb04c80b97) --- modules_k/usrloc/udomain.c | 16 +++++++--------- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/modules_k/usrloc/udomain.c b/modules_k/usrloc/udomain.c index 1464c29..cf7807e 100644 --- a/modules_k/usrloc/udomain.c +++ b/modules_k/usrloc/udomain.c @@ -1003,16 +1003,14 @@ int get_urecord(udomain_t* _d, str* _aor, struct urecord** _r) sl = aorhash&(_d->size-1); r = _d->table[sl].first; - if(r!=NULL) { - for(i = 0; i < _d->table[sl].n; i++) { - if((r->aorhash==aorhash) && (r->aor.len==_aor->len) - && !memcmp(r->aor.s,_aor->s,_aor->len)){ - *_r = r; - return 0; - } - - r = r->next; + for(i = 0; r!=NULL && i < _d->table[sl].n; i++) { + if((r->aorhash==aorhash) && (r->aor.len==_aor->len) + && !memcmp(r->aor.s,_aor->s,_aor->len)){ + *_r = r; + return 0; } + + r = r->next; } } else { /* search in DB */

12 years, 5 months

[tracker] Comment added: kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#234 - kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46 User who did this - David Kovarik (kovik) ---------- I insert something like this to route and there is nothing special happens about 50 times per hour without crash. if(is_method("INVITE")){ if($sht(call=>$ci::prot)==$null){ $sht(call=>$ci::prot)=$pr; $sht(call=>$ci::port)=$sp; }else{ if($sht(call=>$ci::prot)!=$pr && $sht(call=>$ci::port)!=$sp){ xlogl("L_INFO","$ci - CRASH - another port an protocol INVITE si:$si,fU:$fU,ua:$ua,pr:$pr != $sht(call=>$ci::prot),$sp != $sht(call=>$ci::port)"); } } } ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=234#comment678 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 5 months

git:master: usrloc(k): better safety check for null record access

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 748b79fdeba12736b109dfbd77a3e9bb04c80b97 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=748b79f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 13 17:29:51 2012 +0200 usrloc(k): better safety check for null record access --- modules_k/usrloc/udomain.c | 16 +++++++--------- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/modules_k/usrloc/udomain.c b/modules_k/usrloc/udomain.c index 1464c29..cf7807e 100644 --- a/modules_k/usrloc/udomain.c +++ b/modules_k/usrloc/udomain.c @@ -1003,16 +1003,14 @@ int get_urecord(udomain_t* _d, str* _aor, struct urecord** _r) sl = aorhash&(_d->size-1); r = _d->table[sl].first; - if(r!=NULL) { - for(i = 0; i < _d->table[sl].n; i++) { - if((r->aorhash==aorhash) && (r->aor.len==_aor->len) - && !memcmp(r->aor.s,_aor->s,_aor->len)){ - *_r = r; - return 0; - } - - r = r->next; + for(i = 0; r!=NULL && i < _d->table[sl].n; i++) { + if((r->aorhash==aorhash) && (r->aor.len==_aor->len) + && !memcmp(r->aor.s,_aor->s,_aor->len)){ + *_r = r; + return 0; } + + r = r->next; } } else { /* search in DB */

12 years, 5 months

[tracker] Comment added: kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#234 - kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46 User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you send me the backtrace via email (miconda at gmail dot com), i deleted it from here, now thinking a bit more, I may have overlooked some values there. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=234#comment677 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 5 months

[tracker] Comment added: kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#234 - kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46 User who did this - David Kovarik (kovik) ---------- I compiled the last git, and I will follow if the problem persists. Thank you ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=234#comment676 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 5 months

git:3.2: usrloc(k): safety check for first record in udomain slot

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: cc952f8469dea60b9e7f0e70063046f086a2866f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cc952f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 13 16:33:17 2012 +0200 usrloc(k): safety check for first record in udomain slot - reported by David Kovarik, FS#234 (cherry picked from commit 31f404a98b09b5a6270e860574b16c9f9112c305) --- modules_k/usrloc/udomain.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/modules_k/usrloc/udomain.c b/modules_k/usrloc/udomain.c index cd41bd2..ab753bb 100644 --- a/modules_k/usrloc/udomain.c +++ b/modules_k/usrloc/udomain.c @@ -856,14 +856,16 @@ int get_urecord(udomain_t* _d, str* _aor, struct urecord** _r) sl = aorhash&(_d->size-1); r = _d->table[sl].first; - for(i = 0; i < _d->table[sl].n; i++) { - if((r->aorhash==aorhash) && (r->aor.len==_aor->len) - && !memcmp(r->aor.s,_aor->s,_aor->len)){ - *_r = r; - return 0; - } + if(r!=NULL) { + for(i = 0; i < _d->table[sl].n; i++) { + if((r->aorhash==aorhash) && (r->aor.len==_aor->len) + && !memcmp(r->aor.s,_aor->s,_aor->len)){ + *_r = r; + return 0; + } - r = r->next; + r = r->next; + } } } else { /* search in DB */

12 years, 5 months

git:3.3: usrloc(k): safety check for first record in udomain slot

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.3 Commit: 6af1d548ad0191030f4ef57df05b1c1b9ba699e8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6af1d54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 13 16:33:17 2012 +0200 usrloc(k): safety check for first record in udomain slot - reported by David Kovarik, FS#234 (cherry picked from commit 31f404a98b09b5a6270e860574b16c9f9112c305) --- modules_k/usrloc/udomain.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/modules_k/usrloc/udomain.c b/modules_k/usrloc/udomain.c index c812e7a..1464c29 100644 --- a/modules_k/usrloc/udomain.c +++ b/modules_k/usrloc/udomain.c @@ -1003,14 +1003,16 @@ int get_urecord(udomain_t* _d, str* _aor, struct urecord** _r) sl = aorhash&(_d->size-1); r = _d->table[sl].first; - for(i = 0; i < _d->table[sl].n; i++) { - if((r->aorhash==aorhash) && (r->aor.len==_aor->len) - && !memcmp(r->aor.s,_aor->s,_aor->len)){ - *_r = r; - return 0; - } + if(r!=NULL) { + for(i = 0; i < _d->table[sl].n; i++) { + if((r->aorhash==aorhash) && (r->aor.len==_aor->len) + && !memcmp(r->aor.s,_aor->s,_aor->len)){ + *_r = r; + return 0; + } - r = r->next; + r = r->next; + } } } else { /* search in DB */

12 years, 5 months

[tracker] Comment added: kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#234 - kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46 User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you try with latest git master branch? I made a commit to fix, hopefully being the reason: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=31f404a… The backtrace was related to a REGISTER, you added sip trace of an INVITE, all being over UDP (no TCP). If you have sensitive data, don't post on the tracker unless you obfuscate it (e.g., replace the IP). It might be too late to delete them even after few minutes, as the web is indexed by many crawlers. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=234#comment675 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 5 months

git:master: usrloc(k): safety check for first record in udomain slot

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 31f404a98b09b5a6270e860574b16c9f9112c305 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=31f404a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 13 16:33:17 2012 +0200 usrloc(k): safety check for first record in udomain slot - reported by David Kovarik, FS#234 --- modules_k/usrloc/udomain.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/modules_k/usrloc/udomain.c b/modules_k/usrloc/udomain.c index c812e7a..1464c29 100644 --- a/modules_k/usrloc/udomain.c +++ b/modules_k/usrloc/udomain.c @@ -1003,14 +1003,16 @@ int get_urecord(udomain_t* _d, str* _aor, struct urecord** _r) sl = aorhash&(_d->size-1); r = _d->table[sl].first; - for(i = 0; i < _d->table[sl].n; i++) { - if((r->aorhash==aorhash) && (r->aor.len==_aor->len) - && !memcmp(r->aor.s,_aor->s,_aor->len)){ - *_r = r; - return 0; - } + if(r!=NULL) { + for(i = 0; i < _d->table[sl].n; i++) { + if((r->aorhash==aorhash) && (r->aor.len==_aor->len) + && !memcmp(r->aor.s,_aor->s,_aor->len)){ + *_r = r; + return 0; + } - r = r->next; + r = r->next; + } } } else { /* search in DB */

12 years, 5 months

[tracker] Comment added: kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46 (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#234 - kamailio crah [pass_fd.c:293]: ERROR: receive_fd: EOF on 46 User who did this - David Kovarik (kovik) ---------- Can you delete files (dump,out,pcap) after use it? For privaci reason. Thank you ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=234#comment674 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 5 months

← Newer
1
...
12
13
14
15
16
17
18
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2012