Module: sip-router
Branch: 4.1
Commit: 8c7aa83346e18792d9a622c63c83cff81dcc144b
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8c7aa83…
Author: Jason Penton <jason.penton(a)smilecoms.com>
Committer: Jason Penton <jason.penton(a)smilecoms.com>
Date: Wed Nov 13 15:12:48 2013 +0200
modules/dialog_ng: fixed double shm memory free
- happens when calling get_dlg function from cfg file
---
modules/dialog_ng/dialog.c | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/modules/dialog_ng/dialog.c b/modules/dialog_ng/dialog.c
index 4e1b547..078d198 100644
--- a/modules/dialog_ng/dialog.c
+++ b/modules/dialog_ng/dialog.c
@@ -306,11 +306,17 @@ static int w_dlg_get(struct sip_msg *msg, char *ci, char *ft, char *tt)
dlg = get_dlg(&sc, &sf, &st, &dir);
if(dlg==NULL)
return -1;
-
- unref_dlg(dlg, 1);
- set_current_dialog(msg, dlg);
- _dlg_ctx.dlg = dlg;
- _dlg_ctx.dir = dir;
+
+ /*
+ note: we should unref the dlg here (from get_dlg). BUT, because we are setting the current dialog
+ we can ignore the unref... instead of unreffing and reffing again for the set_current_dialog. NB.
+ this function is generally called from the cfg file. If used via API, remember to unref the dlg
+ afterwards
+ */
+
+ set_current_dialog(msg, dlg);
+ _dlg_ctx.dlg = dlg;
+ _dlg_ctx.dir = dir;
return 1;
}
Hello,
we are preparing for a new VUC session to give an update about Kamailio
project - a perfect timing as we are just about to release a new major
version.
We will like to get many developers involved to be able to highlight
properly what is new, especially those that did new development for v4.1
- new modules or enhancement to existing modules. However, any developer
and community member is welcome to join, we will appreciate it very
much, in support of the project.
Those that have a google hangout account can participate with video,
otherwise there are options to join via sip or pstn audio calls - you
can see more details at:
- http://vuc.me
The number of participants with video is limited, therefore if you plan
to do it, let me know to be able to coordinate and send you the invite
link when the session starts.
No matter you participate with audio/video, you can join the IRC channel
#vuc on freenode.net for text chatting during the event.
I made quickly a news about the event:
- http://www.kamailio.org/w/2013/10/kamailio-update-on-vuc-nov-15-2013/
I will add names of other participants as I get confirmations. Do
suggest topics to highlight/discuss there as well.
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Trainings - Berlin, Nov 25-28
- more details about Kamailio trainings at http://www.asipto.com -
Hello,
it's now one month since we froze the development for release of v4.1.0.
No critical issues in on the table for this particular version, so
perhaps next week is time to create a dedicated branch for it, to be
named in GIT as 4.1, and open development for v4.2.
If all goes fine for one more week or so, then we can do the release.
Don't forget to add any open issues you are aware of to the tracker so
we can solve them in time. If any of devs or community members have
spare time, adding ids to the xml docbook files (for modules) will help
getting a better alpha-numeric index for parameters and functions -- see
more at:
- http://www.kamailio.org/wiki/devel/module-docbook-readme#section_ids
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Trainings - Berlin, Nov 25-28
- more details about Kamailio trainings at http://www.asipto.com -
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Dmitry Davletbaev (ddomgn)
Attached to Project - sip-router
Summary - iptrtpproxy compilation error
Task Type - Bug Report
Category - Module
Status - Unconfirmed
Assigned To -
Operating System - Linux
Severity - Low
Priority - Normal
Reported Version - 4.0
Due in Version - Undecided
Due Date - Undecided
Details - **System**: Debian Wheezy
**Description**: when building Kamailio 4.0.4 from source, unable to compile **iptrtpproxy** module due to invalid gcc options:
# make cfg prefix=/opt/kamailio-4.0.3 exclude_modules="" \
skip_modules="db_cassandra db_oracle"
[...]
# make all
[...]
CC (gcc) [M iptrtpproxy.so] iptrtpproxy.o
gcc: error: /root/iptables/iptables/include: No such file or directory
make[1]: *** [iptrtpproxy.o] Error 1
make: *** [modules] Error 1
**Additional information**: as "make --dry-run" shows, gcc is executed with following options:
[...]
echo "CC (gcc) [M iptrtpproxy.so] iptrtpproxy.o" ;
gcc [...] -I ~/iptables/linux-2.6/include -I -I ~/iptables/iptables/include [...]
[...]
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=370
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Module: sip-router
Branch: master
Commit: 8c7aa83346e18792d9a622c63c83cff81dcc144b
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8c7aa83…
Author: Jason Penton <jason.penton(a)smilecoms.com>
Committer: Jason Penton <jason.penton(a)smilecoms.com>
Date: Wed Nov 13 15:12:48 2013 +0200
modules/dialog_ng: fixed double shm memory free
- happens when calling get_dlg function from cfg file
---
modules/dialog_ng/dialog.c | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/modules/dialog_ng/dialog.c b/modules/dialog_ng/dialog.c
index 4e1b547..078d198 100644
--- a/modules/dialog_ng/dialog.c
+++ b/modules/dialog_ng/dialog.c
@@ -306,11 +306,17 @@ static int w_dlg_get(struct sip_msg *msg, char *ci, char *ft, char *tt)
dlg = get_dlg(&sc, &sf, &st, &dir);
if(dlg==NULL)
return -1;
-
- unref_dlg(dlg, 1);
- set_current_dialog(msg, dlg);
- _dlg_ctx.dlg = dlg;
- _dlg_ctx.dir = dir;
+
+ /*
+ note: we should unref the dlg here (from get_dlg). BUT, because we are setting the current dialog
+ we can ignore the unref... instead of unreffing and reffing again for the set_current_dialog. NB.
+ this function is generally called from the cfg file. If used via API, remember to unref the dlg
+ afterwards
+ */
+
+ set_current_dialog(msg, dlg);
+ _dlg_ctx.dlg = dlg;
+ _dlg_ctx.dir = dir;
return 1;
}
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#369 - Crash in cancel_branch on Kamailio 4.0.3
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Duplicate
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=369
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#369 - Crash in cancel_branch on Kamailio 4.0.3
User who did this - Daniel-Constantin Mierla (miconda)
----------
You opened another issue, #367, for the same case - it was answered, a fix being in place for few weeks, see:
- http://sip-router.org/tracker/index.php?do=details&task_id=367&project=1
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=369#comment1163
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
