Hi,
Kamailio's NAPTR behavior by default ignores the Order field, which it is
not allowed to do. Excerpt from RFC 2915:
Order
A 16-bit unsigned integer specifying the order in which the NAPTR
records MUST be processed to ensure the correct ordering of
rules. Low numbers are processed before high numbers, and once a
NAPTR is found whose rule "matches" the target, the client MUST
NOT consider any NAPTRs with a higher value for order (except as
noted below for the Flags field).
Currently one can set dns_{udp,tcp,tls,sctp}_pref to the same value and
then it will respect the Order field. This has the problem that the SRV
lookup order is forced to udp, tcp, tls and sctp.¹ Hence you can not
follow the RFC for NAPTR and also set your own priorities for SRV. E.g. I
want to have tls -> tcp -> udp and adhere to the NAPTR.
Made a core option, dns_naptr_ignore_rfc, default off, to preserve today's
behavior. See attached patch.
One implementation detail is that one currently can disable a protocol
by setting the priority to -1. In my patch that is currently ignored.
Can add a check for that in init_naptr_proto_prefs() before setting
a protocol's preference to 1.
¹ Mandated by the order of ip_addr.h's enum sip_protos.
--
Øyvind Kolbu
Hello,
I'm the maintainer of the Kamailio package and I would like to push
the inclusion of the openssl linking exception to upstream but I'm not
sure about what parts of the upstream program should be changed in
order to satisfy the GPL.
Kamailio is a project with more that 10 years of existence and it's
almost impossible to contact every single author of every single part
of the program, but
AFAIK it's quite possible to be able to add the exception to the core
of the program.
Kamailio runs with a core process that loads the user's configured
plugins. The tls module is the only module that needs openssl to run.
This module provides the ability to use a TLS transport and the core
process is the one that creates and maintains the different
transports.
For sure that any plugin can use the provided transports, but all of
them are using the core functions/structures to connect. They never
connect directly to the tls module by themselves.
Modules are being packaged by groups and the tls module will have it's
own package. The kamailio program can be used without the tls module.
Upstream is willing to add the openssl exception to core files but we
want to be sure that this is enough to satisfy the GPL.
Thanks in advance,
Victor Seva
http://people.gnome.org/~markmc/openssl-and-the-gpl.htmlhttp://lists.debian.org/debian-legal/2004/05/msg00595.htmlhttp://lists.debian.org/debian-legal/2004/07/msg00754.htmlhttp://www.gnu.org/licenses/gpl-faq.html#GPLAndPlugins
2013/11/12 Steve Langasek <vorlon(a)debian.org>:
> On Tue, Nov 12, 2013 at 10:10:58PM +0100, Victor Seva wrote:
>> Is is then ok to have the tls module in Recommneds?
>
> In that case, yes: because combining the plugin into a single program is an
> action taken by the user (by modifying the config), not by the maintainer.
OK. Now it's clear to me.
Thank you so much Steve,
Victor Seva
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Hugh Waite (hugh.waite)
Attached to Project - sip-router
Summary - location not updated correctly when using GRUUs
Task Type - Bug Report
Category - usrloc (k)
Status - Unconfirmed
Assigned To -
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - If a REGISTER is being processed that has a different Call-ID from the stored entry, all temporary GRUUs should be invalidated. (rfc5627 sec. 5.1)
Next, the registrar checks for any existing contacts registered to
the same AOR, instance ID, and if the contact in the REGISTER request
is registering a flow [14], reg-id. If there is at least one, the
registrar finds the one that was most recently registered, and
examines the Call-ID value associated with that registered contact.
If it differs from the one in the REGISTER request, the registrar
MUST invalidate all previously generated temporary GRUUs for the AOR
and instance ID.
We are seeing entries being updated using the RUID (the temporary GRUU), but not updating the ruid or contact columns.
This results in a location entry that does not work.
The attached file shows the 2 REGISTER requests and the INSERT/UPDATE SQL queries they generate.
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=368
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Hi Steve,
Thanks for your quick reply.
2013/11/12 Steve Langasek <vorlon(a)debian.org>:
> If, however, you are enabling the tls plugin *by default* - for
> instance, by providing a metapackage that pulls the two separate packages in
> together, or by having a Recommends: that automatically pulls the tls module
> in and automatically activates it
Ok. But in this case installing the module *by default* via Recommends
will *not* get the module active nor loaded.
The user has to change the default configuration file and explicitly
activate the tls module in order to get the tls loaded.
Is is then ok to have the tls module in Recommneds?
Thanks in advance,
Victor Seva
Module: sip-router
Branch: 4.0
Commit: c3e5b2cbf941d7463abdfe5df53a803b2a877d09
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c3e5b2c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Tue Nov 12 21:06:15 2013 +0100
itm: init sock_str to null value if no sock pointer is set in branch
- case of creating branches from a 3xx reply
- reported by juliabo [at] gmail
- identation made coherent with tm module style
- corresponding to master commit 254d0c43a84ec87801e58b4f990a2029c0e27c6f
---
modules/tm/t_serial.c | 1193 +++++++++++++++++++++++++------------------------
1 files changed, 598 insertions(+), 595 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c3e…
Module: sip-router
Branch: master
Commit: 254d0c43a84ec87801e58b4f990a2029c0e27c6f
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=254d0c4…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Tue Nov 12 21:03:01 2013 +0100
tm: init sock_str to null value if no sock pointer is set in branch
- case of creating branches from a 3xx reply
- reported by juliabo [at] gmail
- identation made coherent with tm module style
---
modules/tm/t_serial.c | 993 +++++++++++++++++++++++++------------------------
1 files changed, 498 insertions(+), 495 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=254…
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#364 - Crash in TCP Read on Kamailio 4.0.1
User who did this - Daniel-Constantin Mierla (miconda)
----------
Also, can you give the output from gdb of:
<code>
frame 0
p *frag
p *((char*)frag + sizeof(struct qm_frag))
</code>
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=364#comment1162
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.