sr-dev April 2013

sr-dev@lists.kamailio.org

38 participants
401 discussions

git:hpw/branch_failure_route: modules/tmx: Add $T_reply_ruid pv to return ruid for a branch reply

by Hugh Waite

Module: sip-router Branch: hpw/branch_failure_route Commit: 6759d6bbdd5ff918759789bde00b8e74235b4051 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6759d6b… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:55:47 2013 +0100 modules/tmx: Add $T_reply_ruid pv to return ruid for a branch reply - Can be run from a failure_route or branch_failure_route --- modules/tmx/README | 141 +++++++++++++++++++++-------------------- modules/tmx/doc/tmx_admin.xml | 3 + modules/tmx/t_var.c | 37 +++++++++++ modules/tmx/t_var.h | 2 + modules/tmx/tmx_mod.c | 3 + 5 files changed, 117 insertions(+), 69 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=675…

11 years, 10 months

git:hpw/branch_failure_route: modules/registrar: Allow unregister for ruids in branch_failure_route

by Hugh Waite

Module: sip-router Branch: hpw/branch_failure_route Commit: 4cdd9f7502a11bc48d0413811606444b24b984e2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4cdd9f7… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:06:35 2013 +0100 modules/registrar: Allow unregister for ruids in branch_failure_route - unregister(domain, uri, ruid) is accepted in branch_failure_route - unregister(domain) is not. --- modules/registrar/reg_mod.c | 2 +- modules/registrar/save.c | 1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/modules/registrar/reg_mod.c b/modules/registrar/reg_mod.c index f07a44a..a32909a 100644 --- a/modules/registrar/reg_mod.c +++ b/modules/registrar/reg_mod.c @@ -188,7 +188,7 @@ static cmd_export_t cmds[] = { {"unregister", (cmd_function)w_unregister, 2, unreg_fixup, 0, REQUEST_ROUTE| FAILURE_ROUTE }, {"unregister", (cmd_function)w_unregister2, 3, unreg_fixup, 0, - REQUEST_ROUTE| FAILURE_ROUTE }, + REQUEST_ROUTE| FAILURE_ROUTE | BRANCH_FAILURE_ROUTE }, {"reg_fetch_contacts", (cmd_function)pv_fetch_contacts, 3, fetchc_fixup, 0, REQUEST_ROUTE| FAILURE_ROUTE }, diff --git a/modules/registrar/save.c b/modules/registrar/save.c index 9c76ef7..54de08b 100644 --- a/modules/registrar/save.c +++ b/modules/registrar/save.c @@ -997,7 +997,6 @@ int unregister(struct sip_msg* _m, udomain_t* _d, str* _uri, str *_ruid) LM_WARN("could not delete contact\n"); return -1; } - ul.release_urecord(r); ul.unlock_udomain(_d, &aor); }

11 years, 10 months

git:hpw/branch_failure_route: modules/tm: Make ruid available in uac structure

by Hugh Waite

Module: sip-router Branch: hpw/branch_failure_route Commit: ef9115b65fc21f8d64687b2787a50aa025d188c7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ef9115b… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:18:22 2013 +0100 modules/tm: Make ruid available in uac structure - ruid is stored per uac - ruid can be retrieved when a response to the branch is received --- modules/tm/h_table.h | 1 + modules/tm/t_fwd.c | 90 +++++++++++++++++++++++++++++++++++++++++++------ modules/tm/t_reply.c | 26 ++++++++++++++ modules/tm/t_reply.h | 1 + 4 files changed, 107 insertions(+), 11 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=ef9…

11 years, 10 months

git:hpw/branch_failure_route: modules/usrloc: Fix get_urecord_by_ruid to return static aor

by Hugh Waite

Module: sip-router Branch: hpw/branch_failure_route Commit: 445e23e221d54e105f256e54c06c6e5a28ba848c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=445e23e… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:04:38 2013 +0100 modules/usrloc: Fix get_urecord_by_ruid to return static aor - Fixed a bug which returned a pointer to a stack variable - Fixed some potential (?) infinite loops --- modules/usrloc/udomain.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/usrloc/udomain.c b/modules/usrloc/udomain.c index 13632d2..f587c1b 100644 --- a/modules/usrloc/udomain.c +++ b/modules/usrloc/udomain.c @@ -648,7 +648,7 @@ urecord_t* db_load_urecord_by_ruid(db1_con_t* _c, udomain_t* _d, str *_ruid) db_row_t *row; str contact; str aor; - char aorbuf[512]; + static char aorbuf[512]; str domain; urecord_t* r; @@ -1031,7 +1031,7 @@ int get_urecord(udomain_t* _d, str* _aor, struct urecord** _r) * \param _ruid record internal unique id * \param _r store pointer to location record * \param _c store pointer to contact structure - * \return 0 if a record was found, 1 if nothing could be found + * \return 0 if a record was found, -1 if nothing could be found */ int get_urecord_by_ruid(udomain_t* _d, unsigned int _aorhash, str *_ruid, struct urecord** _r, struct ucontact** _c) @@ -1057,6 +1057,7 @@ int get_urecord_by_ruid(udomain_t* _d, unsigned int _aorhash, *_c = c; return 0; } + c = c->next; } } r = r->next; @@ -1074,6 +1075,7 @@ int get_urecord_by_ruid(udomain_t* _d, unsigned int _aorhash, *_c = c; return 0; } + c = c->next; } } }

11 years, 10 months

[tracker] Task closed: dialog flags in onreply route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#151 - dialog flags in onreply route User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: Reopen if still some issue related, the item is too old without follow up, dialog module got a lot of work meanwhile. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=151 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

[tracker] Task changed: handle dialog tracking properly when non-failing 4xx responses are involved

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#146 - handle dialog tracking properly when non-failing 4xx responses are involved User who did this: Timo Reimann (tr) Assigned To: Timo Reimann -> [-] More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=146 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

[tracker] Task changed: handle dialog tracking properly when non-failing 4xx responses are involved

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#146 - handle dialog tracking properly when non-failing 4xx responses are involved User who did this: Timo Reimann (tr) Status: Assigned -> New More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=146 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

[tracker] Task changed: dialog flags in onreply route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#151 - dialog flags in onreply route User who did this: Timo Reimann (tr) Status: Assigned -> New More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=151 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

[tracker] Task changed: dialog flags in onreply route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#151 - dialog flags in onreply route User who did this: Timo Reimann (tr) Assigned To: Timo Reimann -> [-] More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=151 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

[tracker] Task opened: Dialog bugs

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Eduardo Lejarreta (lejarreta.e) Attached to Project - sip-router Summary - Dialog bugs Task Type - Bug Report Category - dialog Status - Unconfirmed Assigned To - Operating System - Linux Severity - Medium Priority - Normal Reported Version - 3.2 Due in Version - Undecided Due Date - Undecided Details - Good morning. I think I've found 2 bugs and 1 improvement. Please correct me if I'm wrong. 1.- Having for instance "modparam("dialog", "default_timeout", 10800)" -> after a "kamctl restart" no timeout was triggered On "dlg_db_handler.c" -> on "load_dialog_info_from_db" function we should change this: """""""""""""""""""" ... dlg->tl.timeout = (unsigned int)(VAL_INT(values+9)) + get_ticks(); if (dlg->tl.timeout<=(unsigned int)time(0)) dlg->tl.timeout = 0; else dlg->tl.timeout -= (unsigned int)time(0); dlg->lifetime = dlg->tl.timeout - get_ticks(); --------------->(NEW) GET_STR_VALUE(cseq1, values, 10 , 1, 1); GET_STR_VALUE(cseq2, values, 11 , 1, 1); GET_STR_VALUE(rroute1, values, 12, 0, 0); GET_STR_VALUE(rroute2, values, 13, 0, 0); GET_STR_VALUE(contact1, values, 14, 1, 1); GET_STR_VALUE(contact2, values, 15, 1, 1); ... if (0 != insert_dlg_timer( &(dlg->tl), dlg->lifetime )) { ... --------------->(CORRECT) ... //dlg->lifetime = 0; ---------------> (no sense on this) dlg->dflags = 0; dlg->dflags |= DLG_FLAG_TOBYE; --------------->(IMPROVEMENT: DLG_FLAG_TOBYE should be also saved in any way on DB. After a "kamctl restart" we loose this contextual flag. As for us it's very important we've forced on code.) ... """""""""""""""""""" instead of """""""""""""""""""" ... dlg->tl.timeout = (unsigned int)(VAL_INT(values+9)) + get_ticks(); if (dlg->tl.timeout<=(unsigned int)time(0)) dlg->tl.timeout = 0; else dlg->tl.timeout -= (unsigned int)time(0); GET_STR_VALUE(cseq1, values, 10 , 1, 1); GET_STR_VALUE(cseq2, values, 11 , 1, 1); GET_STR_VALUE(rroute1, values, 12, 0, 0); GET_STR_VALUE(rroute2, values, 13, 0, 0); GET_STR_VALUE(contact1, values, 14, 1, 1); GET_STR_VALUE(contact2, values, 15, 1, 1); ... if (0 != insert_dlg_timer( &(dlg->tl), (int)dlg->tl.timeout )) { ... " --------------->(INCORRECT) ... dlg->lifetime = 0; dlg->dflags = 0; ... """""""""""""""""""" 2.- In this scenario, if a RE-INVITE was received by Kamailio after restart, the call was dropped automatically (the timeout left was ignored). On "dlg_handlers.c" -> on "dlg_onroute" function we should change this: """""""""""""""""""" ... timeout = get_dlg_timeout(req); dlg->lifetime = timeout; ... """""""""""""""""""" --------------->(CORRECT) instead of """""""""""""""""""" ... timeout = get_dlg_timeout(req); if (timeout!=default_timeout) { dlg->lifetime = timeout; } ... """""""""""""""""""" --------------->(INCORRECT) As always, only for helping purpose not to bother anyone. Thanks and best regards. Eduardo Lejarreta. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=282 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2013