Module: sip-router
Branch: master
Commit: 43d59fe1093e7319848794a7c266d3605f764d1a
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=43d59fe…
Author: Olle E. Johansson <oej(a)edvina.net>
Committer: Olle E. Johansson <oej(a)edvina.net>
Date: Tue Apr 2 20:31:07 2013 +0200
db_cluster Add section IDs to XML file and update some text
---
modules/db_cluster/README | 21 +++++++++++++--------
modules/db_cluster/doc/db_cluster_admin.xml | 25 +++++++++++++++----------
2 files changed, 28 insertions(+), 18 deletions(-)
diff --git a/modules/db_cluster/README b/modules/db_cluster/README
index 6ece6af..cbdf261 100644
--- a/modules/db_cluster/README
+++ b/modules/db_cluster/README
@@ -62,10 +62,10 @@ Chapter 1. Admin Guide
used as a middle layer between modules and database connectors.
Via clustering, database operations can be executed across multiple
- servers, based on policies such as paraller write, serial or round
+ servers, based on policies such as parallel write, serial or round
robin write and read.
- Following database commands are considered to be write operations:
+ The following database commands are considered to be write operations:
INSERT, DELETE, UPDATE, REPLACE, INSERT-DELAYED, INSERT-UPDATE. The
read operations are done for database commands: QUERY and RAW-QUERY.
@@ -94,7 +94,8 @@ Chapter 1. Admin Guide
3.1. connection (str)
Specify the connection to a real database system. The format is
- 'conid=>DBURL' - providing a connection id and the database URL.
+ 'conid=>DBURL' - providing a connection id and the database URL used by
+ the database driver used.
Default value is NULL.
@@ -112,18 +113,22 @@ modparam("db_cluster", "connection",
'clsid=>conid1=def1;conid2=def2' - providing a cluster id and the list
of database connections to be used. For each connection you have to
provide a usage definition. The usage definition is a 4-char long
- string, specifying priority and command mode for read an write
- operations to be done on that connection.
+ string, specifying priority and command mode for read and write
+ operations to be performed on that connection.
- The priority is a digit between 0 and 9, higher value is higher
- priority. Priority 0 means that connection is not going to be used in
- that cluster.
+ The priority is a digit between 0 and 9, where a higher value means
+ higher priority. Priority 0 means that the connection is not going to
+ be used in that cluster.
Command mode is a character among s, r and p. s is for doing serial
operations (try first and if fails, try next); r is for doing round
robin operations; p - is for doing parallel operations (this is valid
only for write operations).
+ The first two characters is priority and mode for read, followed by two
+ characters for priority and mode for write operations. "p" is only used
+ for write operations.
+
Default value is NULL.
Example 1.2. Set cluster parameter
diff --git a/modules/db_cluster/doc/db_cluster_admin.xml b/modules/db_cluster/doc/db_cluster_admin.xml
index eef8eb9..d95cdaf 100644
--- a/modules/db_cluster/doc/db_cluster_admin.xml
+++ b/modules/db_cluster/doc/db_cluster_admin.xml
@@ -21,11 +21,11 @@
</para>
<para>
Via clustering, database operations can be executed across multiple
- servers, based on policies such as paraller write, serial or round
+ servers, based on policies such as parallel write, serial or round
robin write and read.
</para>
<para>
- Following database commands are considered to be write operations:
+ The following database commands are considered to be write operations:
INSERT, DELETE, UPDATE, REPLACE, INSERT-DELAYED, INSERT-UPDATE. The
read operations are done for database commands: QUERY and RAW-QUERY.
</para>
@@ -63,12 +63,12 @@
</section>
<section>
<title>Parameters</title>
- <section>
+ <section id="db_cluster.p.connection">
<title><varname>connection</varname> (str)</title>
<para>
Specify the connection to a real database system. The format is
'conid=>DBURL' - providing a connection id and the database
- URL.
+ URL used by the database driver used.
</para>
<para>
<emphasis>
@@ -87,19 +87,19 @@ modparam("db_cluster", "connection",
</programlisting>
</example>
</section>
- <section>
+ <section id="db_cluster.p.cluster">
<title><varname>cluster</varname> (str)</title>
<para>
Specify the cluster definition. The format is
'clsid=>conid1=def1;conid2=def2' - providing a cluster id and the list of
database connections to be used. For each connection you have to provide
a usage definition. The usage definition is a 4-char long string,
- specifying priority and command mode for read an write operations to be
- done on that connection.
+ specifying priority and command mode for read and write operations to be
+ performed on that connection.
</para>
<para>
- The priority is a digit between 0 and 9, higher value is higher priority.
- Priority 0 means that connection is not going to be used in that cluster.
+ The priority is a digit between 0 and 9, where a higher value means higher priority.
+ Priority 0 means that the connection is not going to be used in that cluster.
</para>
<para>
Command mode is a character among s, r and p. s is for doing serial
@@ -108,6 +108,11 @@ modparam("db_cluster", "connection",
only for write operations).
</para>
<para>
+ <para>
+ The first two characters is priority and mode for read, followed by
+ two characters for priority and mode for write operations. "p" is
+ only used for write operations.
+ </para>
<emphasis>
Default value is NULL.
</emphasis>
@@ -121,7 +126,7 @@ modparam("db_cluster", "cluster", "cls1=>con1=9s8p;con2=9s8p")
</programlisting>
</example>
</section>
- <section>
+ <section id="db_cluster.p.inactive_interval">
<title><varname>inactive_interval</varname> (int)</title>
<para>
How long (seconds) a connection is considered inactive after a DB
Module: sip-router
Branch: master
Commit: 70c5705a6cfd9ba8fc8f5519145eb5d4b13770da
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=70c5705…
Author: Olle E. Johansson <oej(a)edvina.net>
Committer: Olle E. Johansson <oej(a)edvina.net>
Date: Tue Apr 2 19:26:35 2013 +0200
db_mysql Correct e-mail address that had a typo.
---
modules/db_mysql/mysql_mod.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/modules/db_mysql/mysql_mod.c b/modules/db_mysql/mysql_mod.c
index 328965d..4041370 100644
--- a/modules/db_mysql/mysql_mod.c
+++ b/modules/db_mysql/mysql_mod.c
@@ -5,19 +5,19 @@
*
* Copyright (C) 2001-2003 FhG Fokus
*
- * This file is part of ser, a free SIP server.
+ * This file is part of Kamailio, a free SIP server.
*
* ser is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version
*
- * For a license to use the ser software under conditions
+ * For a license to use the Kamailio software under conditions
* other than those described here, or to purchase support for this
* software, please contact iptel.org by e-mail at the following addresses:
* info(a)iptel.org
*
- * ser is distributed in the hope that it will be useful,
+ * Kamailio is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
@@ -31,6 +31,7 @@
* --------
* 2003-03-11 updated to the new module exports interface (andrei)
* 2003-03-16 flags export parameter added (janakj)
+ * 2013-04-02 added transaction support (haakon.nessjoen(a)gmail.com)
*/
/** @addtogroup mysql
* @{
Hi Alexandr,
I find few anomalies regarding sipcapture modul.
May you could correct it?
Issues i found:
1. kamailio-4.0.0/modules/sipcapture/sql/create_sipcapture.sql in table
sip_trace.
`auth` varchar(256) NOT NULL,
but on page
http://code.google.com/p/homer/source/browse/sql/create_sipcapture.sql
`authorization` varchar(256) NOT NULL,
So what is the correct?
I am experiencing problem if i use git version of homer.
db_mysql [km_dbase.c:122]: driver error on query: Unknown column
'auth' in 'field list'
2. on http://kamailio.org/docs/modules/4.0.x/modules/sipcapture.html
6. Database setup
Before running Kamailio with the sipcapture module, you have to
setup the database tables where the module will store the data. For
that, if the table were not created by the installation script or
you choose to install everything by yourself you can use the
sipcapture_create.sql, SQL script in the sql folder of sipcapture
module as template. You can also find the complete database
documentation on the project webpage,
http://www.kamailio.org/docs/db-tables/kamailio-db-devel.html.
I couldn't find any information about sipcapture database on this
page, not even the complete db doc:
http://www.kamailio.org/docs/db-tables/kamailio-db-devel.html
Many Thanks,
Misi
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#281 - add basic sip-t / sip-i support to sip router
User who did this - Torrey Searle (tsearle)
----------
Fixed the makefile and figured out how to make git spit out a single file for the diffing
----------
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=281#comment818
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#256 - [sr-dev] Dialog module: dlg_terminate_dlg and register_dlgcb function
User who did this - Eduardo Lejarreta (lejarreta.e)
----------
As mentioned above, the problem for acc_cdr.c accounting is that "BYE messages" are generated internally so these messages are not tracked by kamailio nor acc_cdr accounting because they are sent directly to end UAs (legs)
I propose to add a small change on "dlg_req_within.c" just to force this messages to be tracked by Kamailio changing the internal record_set of dialog just to force then to pass through REQUEST_ROUTE.
On "dlg_bye_all" function add a call to "build_route_set" function (better to isolate this small change)
int dlg_bye_all(struct dlg_cell *dlg, str *hdrs)
{
str all_hdrs = { 0, 0 };
int ret;
if ((build_extra_hdr(dlg, hdrs, &all_hdrs)) != 0)
{
LM_ERR("failed to build dlg headers\n");
return -1;
}
if ( (build_route_set(dlg)) != 0 )
{
LM_ERR("failed to build dlg route set\n");
return -1;
}
ret = send_bye(dlg, DLG_CALLER_LEG, &all_hdrs);
ret |= send_bye(dlg, DLG_CALLEE_LEG, &all_hdrs);
pkg_free(all_hdrs.s);
return ret;
}
"build_route_set" function will "trick" Kamailio to route these BYE messages as "end UA generated" allowing acc_cdr to correctly to the accounting.
static inline int build_route_set( struct dlg_cell *dlg )
{
char *p=0;
dlg->route_set[0].len = strlen("<sip:") + dlg->bind_addr[0]->address_str.len + strlen(";lr>");
dlg->route_set[1].len = strlen("<sip:") + dlg->bind_addr[1]->address_str.len + strlen(";lr>");
dlg->route_set[0].s = (char*)pkg_malloc( dlg->route_set[0].len * sizeof(char) );
dlg->route_set[1].s = (char*)pkg_malloc( dlg->route_set[1].len * sizeof(char) );
if ( !dlg->route_set[0].s || !dlg->route_set[1].s ){
LM_ERR("out of pkg memory\n");
goto error;
}
p = dlg->route_set[0].s;
if ( dlg->route_set[0].len ){
memcpy( p, "<sip:", strlen("<sip:") );
p += strlen("<sip:");
memcpy( p, dlg->bind_addr[0]->address_str.s, dlg->bind_addr[0]->address_str.len);
p += dlg->bind_addr[0]->address_str.len;
memcpy( p, ";lr>", strlen(";lr>") );
}
p = dlg->route_set[1].s;
if ( dlg->route_set[1].len ){
memcpy( p, "<sip:", strlen("<sip:") );
p += strlen("<sip:");
memcpy( p, dlg->bind_addr[1]->address_str.s, dlg->bind_addr[1]->address_str.len);
p += dlg->bind_addr[1]->address_str.len;
memcpy( p, ";lr>", strlen(";lr>") );
}
return 0;
error:
return -1;
}
Could you please deep test this ?
I've done several trials and everything seems to be OK.
Any security issue idea ?
Forgive my poor programming.
Thanks and regards.
Eduardo Lejarreta.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=256#comment817
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#281 - add basic sip-t / sip-i support to sip router
User who did this - Daniel-Constantin Mierla (miconda)
----------
Looks fine at first sight. The file you attached contains 4 patches or so, it has to be split back to apply one by one. Anyhow, to get the new module in, the easiest way is to join the devel team and maintain the module for at least one year. If that is not possible for you, we will try to get someone else to care of it.
Assuming you want to maintain it, email me:
- desired unix username for git write access
- email address to be used for git commit notifications
- your ssh public key
>From the attached file above, one thing that I noticed is the Makefile of the module, its content has to be updated a bit, because the comments refer to a different one. It can be a new commit once the above patches are in git master.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=281#comment816
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.