sr-dev June 2013

sr-dev@lists.kamailio.org

33 participants
235 discussions

negative values in branch picking priority - integer overflow

by Jasmin Schnatterbeck

Hi, I think I discovered a bug in t_pick_branch, lines 1194 if (get_prio(inc_code, rpl)<get_prio(best_s, rpl)) { ... 1210 get_prio(t->uac[b].last_received, rpl)<get_prio(best_s, rpl) ) the second argument of get_prio() does ALWAYS corresponds to the branch b, which is iterated within the loop: rpl = t->uac[b].reply; The "best_s"-branch may have a different rpl - nevertheless, get_prio() is always called with the same "rpl"! So e.g. it can happen, that in the first iteration (best_s is 0) if the branch "b" has a faked reply (=> rpl== FAKED_REPLY) and the module parameter "faked_reply_prio" is +1000, get_prio() does the following 1168 if (rpl == FAKED_REPLY) { 1169 /* Add faked_reply penalty */ 1170 return prio + faked_reply_prio; => 32000 + 1000 !!! overflow !!! rpl == FAKED_REPLY because get_prio(best_s, rpl) is called with the currently-iterated rpl parameter! In my opinion it needs to be stored for the best_s, whether it has a FAKED_REPLY or not, best_s_rpl or something.... Cheers Jasmin

11 years, 5 months

git:master: siputils: added new function is_first_hop()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: c8e928a2c78ee963f807791bea5aacdd31e05936 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c8e928a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 6 09:05:28 2013 +0200 siputils: added new function is_first_hop() - detect if it is first hop after original sender - added section ids for functions, remove a duplicate content for is_rpid_user_e164() --- modules/siputils/README | 188 +++++++++++++++--------------- modules/siputils/doc/siputils_admin.xml | 104 +++++++++--------- modules/siputils/sipops.c | 89 +++++++++++++-- modules/siputils/sipops.h | 1 + modules/siputils/siputils.c | 2 + 5 files changed, 229 insertions(+), 155 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c8e…

11 years, 5 months

git:4.0: Makefile: update de-stable target: squeeze -> wheezy

by Ovidiu Sas

Module: sip-router Branch: 4.0 Commit: 1fefe2feae9fec5621d949fe3857fcf8fb62068e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1fefe2f… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Fri Jun 7 12:09:38 2013 -0400 Makefile: update de-stable target: squeeze -> wheezy (cherry picked from commit fd8dfb71d0eeae891ad0c83ff332929d54f3a3ec) --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b7443e0..cbe4700 100644 --- a/Makefile +++ b/Makefile @@ -681,7 +681,7 @@ deb-stable: dpkg-buildpackage -rfakeroot -tc; \ rm debian; \ else \ - ln -s pkg/$(MAIN_NAME)/deb/squeeze debian; \ + ln -s pkg/$(MAIN_NAME)/deb/wheezy debian; \ dpkg-buildpackage -rfakeroot -tc; \ rm debian; \ fi

11 years, 5 months

git:master: Makefile: update de-stable target: squeeze -> wheezy

by Ovidiu Sas

Module: sip-router Branch: master Commit: fd8dfb71d0eeae891ad0c83ff332929d54f3a3ec URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fd8dfb7… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Fri Jun 7 12:09:38 2013 -0400 Makefile: update de-stable target: squeeze -> wheezy --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 898f99e..ca4fcff 100644 --- a/Makefile +++ b/Makefile @@ -682,7 +682,7 @@ deb-stable: dpkg-buildpackage -rfakeroot -tc; \ rm debian; \ else \ - ln -s pkg/$(MAIN_NAME)/deb/squeeze debian; \ + ln -s pkg/$(MAIN_NAME)/deb/wheezy debian; \ dpkg-buildpackage -rfakeroot -tc; \ rm debian; \ fi

11 years, 5 months

debian stable

by Ovidiu Sas

Should we update the deb-stable target to wheezy? --- a/Makefile +++ b/Makefile @@ -681,7 +681,7 @@ deb-stable: dpkg-buildpackage -rfakeroot -tc; \ rm debian; \ else \ - ln -s pkg/$(MAIN_NAME)/deb/squeeze debian; \ + ln -s pkg/$(MAIN_NAME)/deb/wheezy debian; \ dpkg-buildpackage -rfakeroot -tc; \ rm debian; \ fi Regards, Ovidiu Sas -- VoIP Embedded, Inc. http://www.voipembedded.com

11 years, 5 months

git:4.0: nathelper: fix IPV6 compiler warning

by Ovidiu Sas

Module: sip-router Branch: 4.0 Commit: a9089d05121e05287ce91fddb12769acfae866c8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a9089d0… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Fri Jun 7 11:17:10 2013 -0400 nathelper: fix IPV6 compiler warning --- modules/nathelper/nathelper.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/modules/nathelper/nathelper.c b/modules/nathelper/nathelper.c index ab1c66a..48f8dfd 100644 --- a/modules/nathelper/nathelper.c +++ b/modules/nathelper/nathelper.c @@ -880,8 +880,11 @@ add_contact_alias_0_f(struct sip_msg* msg, char* str1, char* str2) } /* Compare source ip and port against contact uri */ - if (((ip = str2ip(&(uri.host))) == NULL) && - ((ip = str2ip6(&(uri.host))) == NULL)) { + if (((ip = str2ip(&(uri.host))) == NULL) +#ifdef USE_IPV6 + && ((ip = str2ip6(&(uri.host))) == NULL) +#endif + ) { LM_DBG("contact uri host is not an ip address\n"); } else { if (ip_addr_cmp(ip, &(msg->rcv.src_ip)) &&

11 years, 5 months

by Ravindra Gowda

Dear All, I was successful in integrating kamailio 4.0.1 server with Asterisk 11.4.0 in Ubuntu 12.04 LTS version, by using the following link : http://kb.asipto.com/asterisk:realtime:kamailio-4.0.x-asterisk-11.3.0-astdb. Both the servers are running parallely without any problems. And i choosen siremis-4.0.0 to get the control panel of kamailio server and i got its GUI (By following below link): http://kb.asipto.com/siremis:install32x:main But when i tried to register my VoIP phones with the Kamailio server, I am getting the status code reply as *'401 Unauthorized* (0 bindings)'. What could be the wrong? How can i solve it? And how can i retrieve my Users (are which i had added to MySQL database) in SIP server (kamailio) GUI? Any help will greatly appreciate. *Thank you and Best regards,* *R Ravindra **Gowda* *Engineer - Systems and Products*. *Thrikasa Technologies* *| Office: +91 40 23260434 | Mob: +918885284050 * *| Fax:+91 40 23221045* *| email: ravindra(a)thrikasa.in* *| Web: www.thrikasa.in* 'If you don't give up,you cannot fail'. The information contained in this communication is proprietary to Thrikasa Technologies., and/or third parties, may contain classified or privileged information, and is intended only for the use of the intended addressee thereof. If you are not the intended addressee, please be aware that any use, disclosure, distribution and/or copying of this communication is strictly prohibited.If you receive this communication in error, please notify the sender immediately and delete it from your computer.

11 years, 5 months

[tracker] Assignee added: Crash in ims_registrar_scscf caused by log

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#305 - Crash in ims_registrar_scscf caused by log User who did this - Camille Oudot (coudot) http://sip-router.org/tracker/index.php?do=details&task_id=305 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

New commits on branch 4.0

by Daniel-Constantin Mierla

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=21747d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 6 11:47:10 2013 +0200 cfgutils: updated docs to specify correct time unit for usleep - it is microseconds, pointed by David K (cherry picked from commit 8e937d260d0ff41f50be56e0a46ede44554f3f99) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e52f1d6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 6 09:09:14 2013 +0200 kamailio.cfg: reset $du for voicemail re-routing in failure route (cherry picked from commit c4b29f6fac6155b9b087737df5956b687ff4e36a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3dc0b79… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 5 22:44:13 2013 +0200 kamailio.cfg: few updates related to nat traversal - added "co" flags to rtpproxy_manage() to change all IPs in sdp, many phone get confused if only media ip is changed - add nat=yes parameter only for in branch route to avoid multiple occurences (cherry picked from commit 0193489cca56f58b512f5379c078c98a366c17e2) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=72b4833… Author: Jason Penton <jason.penton(a)smilecoms.com> Date: Wed Jun 5 08:58:29 2013 +0200 module/ims_auth: protection against crash if there is no auth vector initialised. - patch submitted by Camille Oudot (cherry picked from commit 4b65964dbe1f38bcf867301d43933f9bbf91ab7d) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=51fc214… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 3 20:53:05 2013 +0200 dialog: shift next timer run for keepalives of dialog - reported by Daniel Tryba (cherry picked from commit a17a32e5f7a3120c200d6e48fe91d7aa1dfd28b1) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=de96070… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon May 27 16:54:02 2013 +0200 core: enclose uri in angle brakets for redirect contact header - safer for uri with parameters and no q - reported by Dan Bogos (cherry picked from commit 74bf08ef30cf18fb609c2c067584f1515ede23da) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f01889d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 26 10:43:24 2013 +0200 dmq: many safety checks for mem mallocs and function return codes - added license header in the files (cherry picked from commit 1977645ceb12ca2d0f2f767046606f6c5ae2c3bb) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2c04dd8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat May 25 16:30:33 2013 +0200 protoshoot: use Makefile pattern for utils - link to libsctp if SCTP support is enabled (cherry picked from commit 1bdbdb64e4862ddb69c2bf13be0f9be93968bb1e) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd1120c… Author: Konstantin Mosesov <ez(a)voipgroup.org.ua> Date: Sat May 18 13:56:22 2013 +0300 parser/sdp: Fixed segfault in sdp_print() when no SDP body. - Failed scenario: remove_body(); msg_apply_changes(); sdp_print("1"); - Result: sdp=0x0 (cherry picked from commit e81b3aac19ab567813d6cb21fcba3d9bd6e1cc90) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=edde8d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri May 17 00:46:42 2013 +0200 core: fixed printing function name in log message - based on http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html (cherry picked from commit e081c2880b46174ad836ab1f56e3062bb17b4332) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=959cab2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 15 22:45:18 2013 +0200 pv: clone result of several string transformations - it is safer for assigning back to the same variable on which the transformation was applied - reported by Martin Mikkelsen (cherry picked from commit fe7e4a5152674aa9c81c09dd2fc9938d9e9e762e) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c3017b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue May 14 19:52:45 2013 +0200 utils/misc: updated vim syntax file (cherry picked from commit 6038bae188863f541994976d299c38f50b0a699b) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=90a8f28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon May 13 10:59:20 2013 +0200 core: debug message to show mapping of routing block names to ids (cherry picked from commit 80e8058d9acea7c994819d043456fd1b449b048b) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=369143a… Author: Juha Heinanen <jh(a)tutpro.com> Date: Sun May 12 16:10:40 2013 +0300 modules/presence: downgraded unsupported event syslog message - Downgraded unsupported event syslog message from error to notice. (cherry picked from commit afdae93c5eba15496498be292c0c99608d801757) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2c4bc86… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue May 7 19:15:36 2013 +0200 core: get rid of deferencing type-punned warning in deb wheezy - reported by Victor Seva (cherry picked from commit 81d3eebd51089686949ab22da60166d4f3a460a7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=62071fd… Author: Henning Westerholt <hw(a)kamailio.org> Date: Thu May 2 21:17:57 2013 +0200 mangler: fix double definition of contact_flds_separator, reported from ld (cherry picked from commit 003d87edc23f62de98a1a22db03b12ea58abcbc6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bb9a8ea… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Mon Apr 29 20:54:52 2013 +0100 modules/websocket: fixed mandatory headers check (cherry picked from commit 8f74c57605fdd1d31c7808a3b8afc79cc981b370) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=61f68ea… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Mon Apr 29 20:38:06 2013 +0100 modules/websocket: doubled the size of the buffer for adding headers to WebSocket handshake responses (cherry picked from commit a2e7f65ee8b86d37a6772619ae10087a05219192)

11 years, 5 months

[tracker] Assignee added: ims_registrar_scscf: unexpected 200 OK response after calling assign_server_unreg()

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#309 - ims_registrar_scscf: unexpected 200 OK response after calling assign_server_unreg() User who did this - Camille Oudot (coudot) http://sip-router.org/tracker/index.php?do=details&task_id=309 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

← Newer
1
...
13
14
15
16
17
18
19
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2013