THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#312 - modules/app_lua: fixed runtime warning: exports dlflags interface is deprecated
User who did this - Víctor Seva (linuxmaniac)
----------
I've tested calling sr.get and sr.seti on a lua script. Reload the script by RPC command. This seems to work fine.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=312#comment941
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Module: sip-router
Branch: 4.0
Commit: 6eb6d92af2fe55d14b255bb5c5c939cc2f78ba79
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6eb6d92…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Fri Jun 7 11:00:51 2013 +0200
modules/rr: completely reverted after_strict() to its pre-outbound form
- backported from c9448d9657f0e5792072c6803643c8d9075d711a by Peter
Dunkley
---
modules/rr/loose.c | 28 ++++++++--------------------
1 files changed, 8 insertions(+), 20 deletions(-)
diff --git a/modules/rr/loose.c b/modules/rr/loose.c
index ccd08d9..8141bd0 100644
--- a/modules/rr/loose.c
+++ b/modules/rr/loose.c
@@ -568,7 +568,6 @@ static inline int after_strict(struct sip_msg* _m)
char* rem_off;
str uri;
struct socket_info *si;
- int use_ob, next_is_strict;
hdr = _m->route;
rt = (rr_t*)hdr->parsed;
@@ -584,13 +583,7 @@ static inline int after_strict(struct sip_msg* _m)
return RR_ERROR;
}
- next_is_strict = is_strict(&puri.params);
- if ((use_ob = process_outbound(_m, puri.user, &uri)) < 0) {
- LM_ERR("processing outbound flow-token\n");
- return FLOW_TOKEN_BROKEN;
- }
-
- if (!use_ob && enable_double_rr && is_2rr(&puri.params) && is_myself(&puri)) {
+ if ( enable_double_rr && is_2rr(&puri.params) && is_myself(&puri)) {
/* double route may occure due different IP and port, so force as
* send interface the one advertise in second Route */
si = grep_sock_info( &puri.host, puri.port_no, puri.proto);
@@ -627,7 +620,6 @@ static inline int after_strict(struct sip_msg* _m)
LM_ERR("failed to parse URI\n");
return RR_ERROR;
}
- next_is_strict = is_strict(&puri.params);
}
/* set the hooks for the param
@@ -636,7 +628,7 @@ static inline int after_strict(struct sip_msg* _m)
routed_msg_id = _m->id;
routed_params = _m->parsed_uri.params;
- if (next_is_strict) {
+ if (is_strict(&puri.params)) {
LM_DBG("Next hop: '%.*s' is strict router\n", uri.len, ZSW(uri.s));
/* Previous hop was a strict router and the next hop is strict
* router too. There is no need to save R-URI again because it
@@ -647,11 +639,9 @@ static inline int after_strict(struct sip_msg* _m)
* always be a strict router because endpoints don't use ;lr parameter
* In this case we will simply put the URI in R-URI and forward it,
* which will work perfectly */
- if (!use_ob) {
- if(get_maddr_uri(&uri, &puri)!=0) {
- LM_ERR("failed to check maddr\n");
- return RR_ERROR;
- }
+ if(get_maddr_uri(&uri, &puri)!=0) {
+ LM_ERR("failed to check maddr\n");
+ return RR_ERROR;
}
if (rewrite_uri(_m, &uri) < 0) {
LM_ERR("failed to rewrite request URI\n");
@@ -673,11 +663,9 @@ static inline int after_strict(struct sip_msg* _m)
LM_DBG("Next hop: '%.*s' is loose router\n",
uri.len, ZSW(uri.s));
- if (!use_ob) {
- if(get_maddr_uri(&uri, &puri)!=0) {
- LM_ERR("failed to check maddr\n");
- return RR_ERROR;
- }
+ if(get_maddr_uri(&uri, &puri)!=0) {
+ LM_ERR("failed to check maddr\n");
+ return RR_ERROR;
}
if (set_dst_uri(_m, &uri) < 0) {
LM_ERR("failed to set dst_uri\n");
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#312 - modules/app_lua: fixed runtime warning: exports dlflags interface is deprecated
User who did this - Daniel-Constantin Mierla (miconda)
----------
Probably yes, I will have to check the core code for loading modules. Anyhow, maybe you can do some tests to be sure all goes fine with executed lua scripts.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=312#comment940
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#312 - modules/app_lua: fixed runtime warning: exports dlflags interface is deprecated
User who did this - Víctor Seva (linuxmaniac)
----------
Ok. Something like this?
----------
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=312#comment939
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#312 - modules/app_lua: fixed runtime warning: exports dlflags interface is deprecated
User who did this - Daniel-Constantin Mierla (miconda)
----------
AFAIK RTLD_NOW | RTLD_GLOBAL is needed for embedded interpreter to propagate the objects.
The fix should be setting this flags via mod_register() or something like that -- don't remember exactly how Andrei Pelinescu-Onciul planned to do it when introduced the warning in the core. Or maybe just make the warning message in core an INFO, the message is for developers not for users.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=312#comment938
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Víctor Seva (linuxmaniac)
Attached to Project - sip-router
Summary - modules/app_lua: fixed runtime warning: exports dlflags interface is deprecated
Task Type - Bug Report
Category - Module
Status - Unconfirmed
Assigned To -
Operating System - All
Severity - Very Low
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - Get rid off the runtime warning message
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=312
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Hi,
I have just noticed, that onreply_route is not executed for replies,
which correspond to branches added by dns_failover.
Is there any reason for that behaviour?
Cheers
Jasmin
Hi,
finally I found out, what makes dns failover selecting a different send
socket compared to the failed branches' send socket (when force_socket
is NOT set):
http://lists.kamailio.org/pipermail/sr-dev/2013-January/017880.html
For a consistent default behaviour (set send socket to received socket
if no force socket set) I suggest to fix t_fwd.c as follows:
Change line 1071 to :
old_uac->request.dst.send_sock:msg->rcv.bind_address,
Change line 1086 to:
old_uac->request.dst.send_sock:msg->rcv.bind_address,
Cheers
Jasmin