THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#311 - Patch to Add s.urlencode.param
User who did this - Josh (JoshE)
----------
Updated patch to reflect what I actually implemented.
This is working in my environment now.
----------
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=311#comment965
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#303 - Crash in topoh module when To header missing
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Fixed
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=303
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#303 - Crash in topoh module when To header missing
User who did this - Daniel-Constantin Mierla (miconda)
----------
Added a safety check for the case when sanity module checks are not enabled. It is committed in master branch for now - 4f3d04d547c66a1b59398cf80e93974175141514
Reopen if the issue is still there.
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=303#comment964
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#303 - Crash in topoh module when To header missing
User who did this - Daniel-Constantin Mierla (miconda)
----------
You have to set another parameter for topoh:
modparam("topoh", "sanity_checks", 1)
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=303#comment963
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#312 - modules/app_lua: fixed runtime warning: exports dlflags interface is deprecated
User who did this - Daniel-Constantin Mierla (miconda)
----------
Patch can be committed.
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=312#comment962
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#310 - K. crush with radiusclient.conf error
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Won't fix
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=310
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#310 - K. crush with radiusclient.conf error
User who did this - Daniel-Constantin Mierla (miconda)
----------
The crash is inside the radiusclient-ng library:
#0 0x000000080881f71c in rc_read_config () from /usr/local/lib/libradiusclient-ng.so.2
It is nothing we can do in kamailio acc_radius module. It has to be fixed in the library.
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=310#comment961
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#307 - modules/debugger: add dbg_pv_dump config function. It dumps on json format the content of pv_cache
User who did this - Daniel-Constantin Mierla (miconda)
----------
In first patch, you do pkg_malloc but don't check if you get a non-NULL result. Then you memset and fill the structure.
In second patch, there is a return 0 in the function executed by config, meaning that config file execution will be interrupted (like being an exit) -- probably you wanted to be FALSE in config check, so should be -1 (or other negative value).
Otherwise (once the above are fixed), the patches could be committed -- the part in core in modules are related only to this functionality, not interfering with other code.
But I think cloning all the items in the cache each time you want to use this function is a bit of overhead, although it is just for debugging purposes, thus not expected to be heavily used in production. Therefore I exposed the pv cache via pv_cache_get_table() function, its size is also defined in pvar.h. Now you can walk through the cache from the module. If you decide to go for this option, your first patch is no longer needed, second patch needs to be adapted.
One improvement that I would suggest - add a second parameter (optional) to the new config function to specify the log level -- now it prints to DEBUG, implying that debug=3 must be used.
Also, in the readme, you only pasted the defines for the flags that can be used in the first parameter. You should explain a bit what each is supposed to do.
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=307#comment960
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.