sr-dev June 2013

sr-dev@lists.kamailio.org

33 participants
236 discussions

[tracker] Comment added: modules/debugger: add dbg_pv_dump config function. It dumps on json format the content of pv_cache
by sip-router 16 Jun '13

16 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#307 - modules/debugger: add dbg_pv_dump config function. It dumps on json format the content of pv_cache User who did this - Daniel-Constantin Mierla (miconda) ---------- In first patch, you do pkg_malloc but don't check if you get a non-NULL result. Then you memset and fill the structure. In second patch, there is a return 0 in the function executed by config, meaning that config file execution will be interrupted (like being an exit) -- probably you wanted to be FALSE in config check, so should be -1 (or other negative value). Otherwise (once the above are fixed), the patches could be committed -- the part in core in modules are related only to this functionality, not interfering with other code. But I think cloning all the items in the cache each time you want to use this function is a bit of overhead, although it is just for debugging purposes, thus not expected to be heavily used in production. Therefore I exposed the pv cache via pv_cache_get_table() function, its size is also defined in pvar.h. Now you can walk through the cache from the module. If you decide to go for this option, your first patch is no longer needed, second patch needs to be adapted. One improvement that I would suggest - add a second parameter (optional) to the new config function to specify the log level -- now it prints to DEBUG, implying that debug=3 must be used. Also, in the readme, you only pasted the defines for the flags that can be used in the first parameter. You should explain a bit what each is supposed to do. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=307#comment960 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core: added function to get the pv cache table
by Daniel-Constantin Mierla 16 Jun '13

16 Jun '13

Module: sip-router Branch: master Commit: 69c409e14c568fae45e449122e5b4efbf009bf41 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=69c409e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Jun 16 16:39:14 2013 +0200 core: added function to get the pv cache table - pv cache struct moved to header file --- pvapi.c | 17 ++++++++--------- pvar.h | 16 ++++++++++++++++ 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/pvapi.c b/pvapi.c index 98b3d90..7f5fcc2 100644 --- a/pvapi.c +++ b/pvapi.c @@ -41,7 +41,6 @@ #include "pvar.h" #define PV_TABLE_SIZE 32 /*!< pseudo-variables table size */ -#define PV_CACHE_SIZE 32 /*!< pseudo-variables table size */ #define TR_TABLE_SIZE 16 /*!< transformations table size */ @@ -58,14 +57,6 @@ typedef struct _pv_item static pv_item_t* _pv_table[PV_TABLE_SIZE]; static int _pv_table_set = 0; -typedef struct _pv_cache -{ - str pvname; - unsigned int pvid; - pv_spec_t spec; - struct _pv_cache *next; -} pv_cache_t; - static pv_cache_t* _pv_cache[PV_CACHE_SIZE]; static int _pv_cache_set = 0; @@ -87,6 +78,14 @@ void pv_init_cache(void) _pv_cache_set = 1; } +/** + * + */ +pv_cache_t **pv_cache_get_table(void) +{ + if(_pv_cache_set==1) return _pv_cache; + return NULL; +} /** * @brief Check if a char is valid according to the PV syntax diff --git a/pvar.h b/pvar.h index c3d7b44..75c4914 100644 --- a/pvar.h +++ b/pvar.h @@ -226,6 +226,22 @@ int pv_get_intstrval(struct sip_msg *msg, pv_param_t *param, pv_value_t *res, int ival, str *sval); /** + * Core PV Cache + */ +typedef struct _pv_cache +{ + str pvname; + unsigned int pvid; + pv_spec_t spec; + struct _pv_cache *next; +} pv_cache_t; + +#define PV_CACHE_SIZE 32 /*!< pseudo-variables cache table size */ + +pv_cache_t **pv_cache_get_table(void); + + +/** * Transformations */ #define TR_LBRACKET_STR "{"

1 0

git:master: mtree: fixed typo in log function name
by Daniel-Constantin Mierla 16 Jun '13

16 Jun '13

Module: sip-router Branch: master Commit: 330aeda83dc7ed927cf994e4b21ff44ab2d2c215 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=330aeda… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Jun 16 16:40:59 2013 +0200 mtree: fixed typo in log function name --- modules/mtree/mtree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/mtree/mtree.c b/modules/mtree/mtree.c index 4dfada4..6587909 100644 --- a/modules/mtree/mtree.c +++ b/modules/mtree/mtree.c @@ -309,7 +309,7 @@ is_t* mt_get_tvalue(m_tree_t *pt, str *tomatch) /* check validity */ if(_mt_char_table[(unsigned int)tomatch->s[l]]==255) { - LM_BG("not matching char at %d in [%.*s]\n", + LM_DBG("not matching char at %d in [%.*s]\n", l, tomatch->len, tomatch->s); return NULL; }

1 0

[tracker] Task closed: DBTEXT
by sip-router 15 Jun '13

15 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#132 - DBTEXT User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: openser db name was replaced by kamailio More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=132 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: alias_db: support user to alias conversion
by sip-router 15 Jun '13

15 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#110 - alias_db: support user to alias conversion User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Not a bug Additional comments about closing: No patch provided for very long time. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=110 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: tls module 'config' param can point to directory
by sip-router 15 Jun '13

15 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#89 - tls module 'config' param can point to directory User who did this - Daniel-Constantin Mierla (miconda) ---------- Was this committed? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=89#comment959 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: tls module 'config' param can point to directory
by sip-router 15 Jun '13

15 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#89 - tls module 'config' param can point to directory More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=89 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Extending TM timeout/408 handling
by sip-router 15 Jun '13

15 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#55 - Extending TM timeout/408 handling User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=55 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Extending TM timeout/408 handling
by sip-router 15 Jun '13

15 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#55 - Extending TM timeout/408 handling User who did this - Daniel-Constantin Mierla (miconda) ---------- $T(reply_type)==1 can be used to detect if the reply is generated locally, probably helping to detect the case you were looking for. Reopen if otherwise. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=55#comment958 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: per module debug level
by sip-router 15 Jun '13

15 Jun '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#49 - per module debug level User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=49 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2013