sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
297 discussions

git:master: Fix fixup functions.
by Carsten Bock 12 Sep '13

12 Sep '13

Module: sip-router Branch: master Commit: b23a74a4732f276315176d9b438bd2596e616799 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b23a74a… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Wed Aug 21 20:14:16 2013 +0200 Fix fixup functions. --- modules/utils/utils.c | 61 ++++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 53 insertions(+), 8 deletions(-) diff --git a/modules/utils/utils.c b/modules/utils/utils.c index 8109a11..735ea0d 100644 --- a/modules/utils/utils.c +++ b/modules/utils/utils.c @@ -101,11 +101,11 @@ int utils_forward(struct sip_msg *msg, int id, int proto); /* Exported functions */ static cmd_export_t cmds[] = { - {"http_query", (cmd_function)w_http_query, 2, fixup_http_query, - fixup_free_http_query, + {"http_query", (cmd_function)w_http_query, 2, fixup_http_query_get, + fixup_free_http_query_get, REQUEST_ROUTE|ONREPLY_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE}, - {"http_query", (cmd_function)w_http_query_post, 3, fixup_http_query, - fixup_free_http_query, + {"http_query", (cmd_function)w_http_query_post, 3, fixup_http_query_post, + fixup_free_http_query_post, REQUEST_ROUTE|ONREPLY_ROUTE|FAILURE_ROUTE|BRANCH_ROUTE}, {"xcap_auth_status", (cmd_function)xcap_auth_status, 2, fixup_pvar_pvar, fixup_free_pvar_pvar, REQUEST_ROUTE}, @@ -327,13 +327,13 @@ static void destroy(void) * Fix http_query params: url (string that may contain pvars) and * result (writable pvar). */ -static int fixup_http_query(void** param, int param_no) +static int fixup_http_query_get(void** param, int param_no) { if (param_no == 1) { return fixup_spve_null(param, 1); } - if ((param_no == 2) || (param_no == 3)) { + if (param_no == 2) { if (fixup_pvar_null(param, 1) != 0) { LM_ERR("failed to fixup result pvar\n"); return -1; @@ -352,14 +352,59 @@ static int fixup_http_query(void** param, int param_no) /* * Free http_query params. */ -static int fixup_free_http_query(void** param, int param_no) +static int fixup_free_http_query_get(void** param, int param_no) { if (param_no == 1) { LM_WARN("free function has not been defined for spve\n"); return 0; } - if ((param_no == 2) || (param_no == 3)) { + if (param_no == 2) { + return fixup_free_pvar_null(param, 1); + } + + LM_ERR("invalid parameter number <%d>\n", param_no); + return -1; +} + + +/* + * Fix http_query params: url (string that may contain pvars) and + * result (writable pvar). + */ +static int fixup_http_query_post(void** param, int param_no) +{ + if ((param_no == 1) || (param_no == 2)) { + return fixup_spve_null(param, 1); + } + + if (param_no == 3) { + if (fixup_pvar_null(param, 1) != 0) { + LM_ERR("failed to fixup result pvar\n"); + return -1; + } + if (((pv_spec_t *)(*param))->setf == NULL) { + LM_ERR("result pvar is not writeble\n"); + return -1; + } + return 0; + } + + LM_ERR("invalid parameter number <%d>\n", param_no); + return -1; +} + +/* + * Free http_query params. + */ +static int fixup_free_http_query_post(void** param, int param_no) +{ + if ((param_no == 1) || (param_no == 2)) { + LM_WARN("free function has not been defined for spve\n"); + return 0; + } + + if (param_no == 3) { return fixup_free_pvar_null(param, 1); }

1 0

git:master: Define missing fixup_functions.
by Carsten Bock 12 Sep '13

12 Sep '13

Module: sip-router Branch: master Commit: 6cea9227c7dc973757d03150685e322fcff115b9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6cea922… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Thu Aug 22 16:36:48 2013 +0200 Define missing fixup_functions. --- modules/utils/utils.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/utils/utils.c b/modules/utils/utils.c index 735ea0d..13b7f07 100644 --- a/modules/utils/utils.c +++ b/modules/utils/utils.c @@ -89,8 +89,10 @@ static int child_init(int); static void destroy(void); /* Fixup functions to be defined later */ -static int fixup_http_query(void** param, int param_no); -static int fixup_free_http_query(void** param, int param_no); +static int fixup_http_query_get(void** param, int param_no); +static int fixup_free_http_query_get(void** param, int param_no); +static int fixup_http_query_post(void** param, int param_no); +static int fixup_free_http_query_post(void** param, int param_no); /* Wrappers for http_query to be defined later */ static int w_http_query(struct sip_msg* _m, char* _url, char* _result);

1 0

[tracker] Comment added: pua_reginfo: Fails to insert the contact into the location table
by sip-router 12 Sep '13

12 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#339 - pua_reginfo: Fails to insert the contact into the location table User who did this - Wonbin Cho (wbcho) ---------- A suggestion is: "kamailio-4.0.1/modules/pua_reginfo/pua_reginfo.c" #include "../../lib/srutils/sruid.h" ... sruid_t _reginfo_sruid; ... static int mod_init(void) { ... if(sruid_init(&_reginfo_sruid, (char)'-', "regi", SRUID_INC)<0) return -1; return 0; } "kamailio-4.0.1/modules/pua_reginfo/notify.c" #include "../../lib/srutils/sruid.h" ... extern sruid_t _reginfo_sruid; int process_contact(udomain_t * domain, urecord_t ** ul_record, str aor, str callid, int cseq, int expires, int event, str contact_uri) { ... /* set ruid */ if(sruid_next(&_reginfo_sruid)<0) { LM_ERR("failed to generate ruid"); } else { ci.ruid = _reginfo_sruid.uid; LM_DBG("generated ruid is: %.*s\n", ci.ruid.len, ci.ruid.s); } ... } ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=339#comment1070 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: pua_reginfo: Fails to insert the contact into the location table
by sip-router 12 Sep '13

12 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Wonbin Cho (wbcho) Attached to Project - sip-router Summary - pua_reginfo: Fails to insert the contact into the location table Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - High Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - The PUA_REGINFO module does not follow the latest 'location' table scheme and it fails to add a record to the table. Especially the 'ruid' column is mandatory and does not allow a null value. A proper 'ruid' value should be generated in the 'process_contact' function defined in "pua_reginfo/notify.c". More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=339 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 4.0.x crash with pua_reginfo : reginfo_handle_notify
by sip-router 12 Sep '13

12 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#338 - Kamailio 4.0.x crash with pua_reginfo : reginfo_handle_notify User who did this - Wonbin Cho (wbcho) ---------- "kamailio-4.0.1/modules/pua_reginfo/notify.c" Line 227: registrations = doc_root->children; while (registrations) { /* Only process registration sub-items */ if (xmlStrcasecmp(registrations->name, BAD_CAST "registration") != 0) goto next_registration; ... It seems that the first "registration" item of "reginfo" node is not loaded at the first loop. The first loop hits "goto next_registration" and jumps to the line where unlock_udomain function is called. The segfault occurs when referring to an unallocated address of 'aor'. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=338#comment1069 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: Kamailio 4.0.x crash with pua_reginfo : reginfo_handle_notify
by sip-router 12 Sep '13

12 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Wonbin Cho (wbcho) Attached to Project - sip-router Summary - Kamailio 4.0.x crash with pua_reginfo : reginfo_handle_notify Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Critical Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - Kamailio would crash when called the reginfo_handle_notify function of the PUA_REGINFO module. Following is the log with debug level 9. daemon.info /usr/sbin/kamailio[14933]: INFO: <script>: New Message: NOTIFY: sip:reginfo@10.49.80.48 (<null> 10.49.80.40:5060) -> sip:reginfo@10.49.80.48 (<null> 10.49.80.48:5060) daemon.debug /usr/sbin/kamailio[14933]: DEBUG: <core> [select.c:425]: Calling SELECT 0x7e0cc81d2400 daemon.debug /usr/sbin/kamailio[14932]: DEBUG: pua [hash.c:397]: core_hash= 397 daemon.debug /usr/sbin/kamailio[14933]: DEBUG: tm [t_lookup.c:1395]: DEBUG: t_newtran: msg id=1 , global msg id=0 , T on entrance=0xffffffffffffffff daemon.debug /usr/sbin/kamailio[14932]: DEBUG: pua [hash.c:406]: pres_uri= sip:6000@phs3.kor.jwm2.net watcher_uri=sip:reginfo@10.49.80.48 callid= 7464330662d7a359-14926(a)127.0.0.1 from_tag= 533cb9e91f4b999cf76861cbb9ed54ed-2088 daemon.debug /usr/sbin/kamailio[14932]: DEBUG: pua [hash.c:413]: FOUND temporary dialog daemon.debug /usr/sbin/kamailio[14932]: DEBUG: tm [t_reply.c:1547]: DEBUG: cleanup_uac_timers: RETR/FR timers reset daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [usr_avp.c:644]: DEBUG:destroy_avp_list: destroying list (nil) daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [usr_avp.c:644]: DEBUG:destroy_avp_list: destroying list (nil) daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [usr_avp.c:644]: DEBUG:destroy_avp_list: destroying list (nil) daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [usr_avp.c:644]: DEBUG:destroy_avp_list: destroying list (nil) daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [usr_avp.c:644]: DEBUG:destroy_avp_list: destroying list (nil) daemon.debug /usr/sbin/kamailio[14933]: DEBUG: <core> [parser/msg_parser.c:106]: found end of header daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [usr_avp.c:644]: DEBUG:destroy_avp_list: destroying list (nil) daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [xavp.c:447]: destroying xavp list (nil) daemon.debug /usr/sbin/kamailio[14933]: DEBUG: tm [t_lookup.c:534]: t_lookup_request: start searching: hash=33078, isACK=0 daemon.debug /usr/sbin/kamailio[14932]: DEBUG: <core> [receive.c:293]: receive_msg: cleaning up daemon.debug /usr/sbin/kamailio[14933]: DEBUG: tm [t_lookup.c:492]: DEBUG: RFC3261 transaction matching failed daemon.debug /usr/sbin/kamailio[14933]: DEBUG: tm [t_lookup.c:716]: DEBUG: t_lookup_request: no transaction found daemon.debug /usr/sbin/kamailio[14933]: DEBUG: tm [t_hooks.c:374]: DBG: trans=0x7e0cc631d5b0, callback type 1, id 0 entered daemon.debug /usr/sbin/kamailio[14933]: DEBUG: pua [hash.c:558]: 'To' header ALREADY PARSED: <sip:reginfo@10.49.80.48> daemon.debug /usr/sbin/kamailio[14933]: DEBUG: pua [hash.c:361]: core_hash= 397 daemon.err /usr/sbin/kamailio[14933]: ERROR: pua [hash.c:607]: no record for the dialog found in hash table daemon.debug /usr/sbin/kamailio[14933]: DEBUG: pua_reginfo [notify.c:409]: Body is <?xml version="1.0"?> <reginfo xmlns="urn:ietf:params:xml:ns:reginfo" version="0" state="full"> <registration aor="sip:6000@phs3.kor.jwm2.net" id="0x692a484bf5f0" kern.info kernel: [1824899.083979] kamailio[14933]: segfault at 0 ip 00007e0cc4edcd77 sp 00007ef57b8d3de0 error 4 in usrloc.so[7e0cc4ec6000+1c000] kern.alert kernel: [1824899.084043] grsec: From 10.49.8.78: Segmentation fault occurred at (nil) in /usr/sbin/kamailio[kamailio:14933] uid/euid:1000/1000 gid/egid:1000/1000, parent /usr/sbin/kamailio[kamailio:14902] uid/euid:1000/1000 g daemon.crit /usr/sbin/kamailio[14962]: : <core> [pass_fd.c:293]: ERROR: receive_fd: EOF on 18 daemon.debug /usr/sbin/kamailio[14962]: DEBUG: <core> [tcp_main.c:3605]: DBG: handle_ser_child: dead child 8, pid 14933 (shutting down?) daemon.debug /usr/sbin/kamailio[14962]: DEBUG: <core> [io_wait.h:617]: DBG: io_watch_del (0xb9762d347b0, 18, -1, 0x0) fd_no=21 called daemon.alert /usr/sbin/kamailio[14902]: ALERT: <core> [main.c:788]: child process 14933 exited by a signal 11 daemon.alert /usr/sbin/kamailio[14902]: ALERT: <core> [main.c:791]: core was not generated daemon.info /usr/sbin/kamailio[14902]: INFO: <core> [main.c:803]: INFO: terminating due to SIGCHLD daemon.info /usr/sbin/kamailio[14959]: INFO: <core> [main.c:854]: INFO: signal 15 received A simple fix for this might be: "kamailio-4.0.1/modules/pua_reginfo/notify.c" Line 374 next_registration: // if (ul_record) ul.release_urecord(ul_record); /* Unlock the domain for this AOR: */ if(aor.len > 0) { ul.unlock_udomain(domain, &aor); } registrations = registrations->next; } More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=338 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: pkg/kamailio/centos: CentOS build updates
by Peter Dunkley 11 Sep '13

11 Sep '13

Module: sip-router Branch: master Commit: 5651be2fa5a5d923a89aa70a050d23bcbfda9c38 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5651be2… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Committer: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Wed Sep 11 13:09:31 2013 +0100 pkg/kamailio/centos: CentOS build updates - CentOS .spec is now separate from Fedora .spec. This is because I no longer have a Fedora system to test/maintain this on. Old .spec with Fedora support is in pkg/kamailio/fedora and can be taken on by someone else if needed. - Updated rel in .spec to dev8 --- pkg/kamailio/centos/6/README | 1 - pkg/kamailio/centos/6/kamailio.spec | 1157 ++++++++++++++++++++++++++++++++++- 2 files changed, 1156 insertions(+), 2 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=565…

1 0

git:master: core: Raspberry-pi builds now work without needing to specify extra flags
by Peter Dunkley 11 Sep '13

11 Sep '13

Module: sip-router Branch: master Commit: 0f7bc9da0d132720531f3176ee216466f5877146 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0f7bc9d… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Committer: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Wed Sep 11 11:30:50 2013 +0100 core: Raspberry-pi builds now work without needing to specify extra flags --- Makefile.defs | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index ccd4b3f..fe28b8b 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -838,6 +838,7 @@ endif ifeq ($(ARCH), arm6) use_fast_lock=yes + C_DEFS+=-DNOSMP # very unlikely to have an smp arm endif ifeq ($(ARCH), ppc)

1 0

Kamailio master build failing on Raspberry Pi (raspbian)
by Peter Dunkley 11 Sep '13

11 Sep '13

Hello, I am trying to build a Kamailio Raspberry Pi for my presentation at AstriCon but the build fails on the very first file (action.c). This was working before (although I was using Fedora on the Pi last time). Has anyone changed anything recently or have any ideas about this? It may be as simple as tweaking the build arguments, but as this worked for me before I thought I'd ask first... Here is the build output: CC (gcc) [kamailio] action.o In file included from parser/../mem/../atomic/atomic_native.h:74:0, from parser/../mem/../futexlock.h:44, from parser/../mem/../lock_ops.h:85, from parser/../mem/shm_mem.h:75, from parser/../ut.h:64, from parser/../ip_addr.h:50, from parser/msg_parser.h:61, from select.h:38, from route_struct.h:47, from action.h:42, from action.c:69: parser/../mem/../atomic/atomic_arm.h:69:2: warning: #warning SMP not supported for arm atomic ops, try compiling with -DNOSMP [-Wcpp] In file included from parser/../mem/../atomic/atomic_arm.h:81:0, from parser/../mem/../atomic/atomic_native.h:74, from parser/../mem/../futexlock.h:44, from parser/../mem/../lock_ops.h:85, from parser/../mem/shm_mem.h:75, from parser/../ut.h:64, from parser/../ip_addr.h:50, from parser/msg_parser.h:61, from select.h:38, from route_struct.h:47, from action.h:42, from action.c:69: parser/../mem/../atomic/atomic_unknown.h:59:2: warning: #warning no native memory barrier implementations, falling back to slow lock based workarround [-Wcpp] parser/../mem/../atomic/atomic_unknown.h:64:1: error: unknown type name ‘gen_lock_t’ In file included from parser/../mem/../atomic/atomic_native.h:74:0, from parser/../mem/../futexlock.h:44, from parser/../mem/../lock_ops.h:85, from parser/../mem/shm_mem.h:75, from parser/../ut.h:64, from parser/../ip_addr.h:50, from parser/msg_parser.h:61, from select.h:38, from route_struct.h:47, from action.h:42, from action.c:69: parser/../mem/../atomic/atomic_arm.h: In function ‘mb_atomic_get_int’: parser/../mem/../atomic/atomic_arm.h:229:2: warning: implicit declaration of function ‘lock_release’ [-Wimplicit-function-declaration] parser/../mem/../atomic/atomic_arm.h:229:2: warning: implicit declaration of function ‘lock_get’ [-Wimplicit-function-declaration] make: *** [action.o] Error 1 Regards, Peter -- Peter Dunkley Technical Director Crocodile RCS Ltd

3 8

Query regarding Kamailio
by Owais ul Haq 11 Sep '13

11 Sep '13

Hello, Here is a query about kamailio deployment. If some one can please help in this regard.We have deployed a Kamailio server.. But due to some unaviodable issues, our internet connection is unreliable. So to counter this we have got two internet connection with static IP's. Can some one advice some mechanism so that our Kamailio server automatically switches itself from one IP to other one in case of internet connection failure. How can this be achieved ? Any help will be appreciated. Thanks.

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013