sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
296 discussions

patch: kamdbctl.pgsql missing dbuid_create function
by elactrum＠jamailca.com 10 Sep '13

10 Sep '13

Hi all, Thanks for the work to consolidate SER modules for Kamailio 4.0. This has been a great improvement! When I run kamdbctl dbuid (added in http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=commitdiff;h=1f…) when using PostgreSQL as database engine, I get the following error: ~# kamdbctl dbuid /usr/sbin/kamdbctl: line 464: dbuid_create: not found I tested this on Kamailio 4.0.1, but it seems that the issue exists in the latest git as well. The attached patch causes kamdbctl dbuid to successfully create the uid tables. Hope this helps, -elactrum

2 1

git:4.0: kamdbctl: added missing dbuid tables group creation
by Daniel-Constantin Mierla 10 Sep '13

10 Sep '13

Module: sip-router Branch: 4.0 Commit: 120b736c14b3dae780cfc9ef7fc8fd1c79d32d92 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=120b736… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 10 14:14:52 2013 +0200 kamdbctl: added missing dbuid tables group creation - patch by elactrum [at] jamailca.com (cherry picked from commit 6f17209a70e84d91976ea42b476ae248b9b37501) --- utils/kamctl/kamdbctl.pgsql | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/utils/kamctl/kamdbctl.pgsql b/utils/kamctl/kamdbctl.pgsql index 4a0fe7a..ae39f62 100644 --- a/utils/kamctl/kamdbctl.pgsql +++ b/utils/kamctl/kamdbctl.pgsql @@ -246,3 +246,24 @@ done minfo "Extra tables succesfully created." } # end extra_create + + +dbuid_create () # pars: <database name> +{ + if [ $# -ne 1 ] ; then + merr "dbuid_create function takes one param" + exit 1 + fi + + minfo "creating uid tables into $1 ..." + + for TABLE in $DBUID_MODULES; do + mdbg "Creating uid table: $TABLE" + sql_query $1 < $DB_SCHEMA/$TABLE-create.sql + if [ $? -ne 0 ] ; then + merr "Creating uid tables failed at $TABLE!" + exit 1 + fi + done + minfo "UID tables succesfully created." +} # end uid_create

1 0

git:master: kamdbctl: added missing dbuid tables group creation
by Daniel-Constantin Mierla 10 Sep '13

10 Sep '13

Module: sip-router Branch: master Commit: 6f17209a70e84d91976ea42b476ae248b9b37501 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6f17209… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 10 14:14:52 2013 +0200 kamdbctl: added missing dbuid tables group creation - patch by elactrum [at] jamailca.com --- utils/kamctl/kamdbctl.pgsql | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/utils/kamctl/kamdbctl.pgsql b/utils/kamctl/kamdbctl.pgsql index 4a0fe7a..ae39f62 100644 --- a/utils/kamctl/kamdbctl.pgsql +++ b/utils/kamctl/kamdbctl.pgsql @@ -246,3 +246,24 @@ done minfo "Extra tables succesfully created." } # end extra_create + + +dbuid_create () # pars: <database name> +{ + if [ $# -ne 1 ] ; then + merr "dbuid_create function takes one param" + exit 1 + fi + + minfo "creating uid tables into $1 ..." + + for TABLE in $DBUID_MODULES; do + mdbg "Creating uid table: $TABLE" + sql_query $1 < $DB_SCHEMA/$TABLE-create.sql + if [ $? -ne 0 ] ; then + merr "Creating uid tables failed at $TABLE!" + exit 1 + fi + done + minfo "UID tables succesfully created." +} # end uid_create

1 0

testing more than one flag with a single isflagset() call
by Juha Heinanen 10 Sep '13

10 Sep '13

currently isflagset core function accepts only one flag as argument. it would be nice if more that one flag could be tested with one function call, e.g., isflagset(1|2) or isflagset(1&2) since i'm not familiar with adding syntax related stuff to core, is it ok if i create a tracker wish list item on this? -- juha

2 1

[tracker] Task closed: uac_redirect: get_redirects() with no second parameter raises a core dump
by sip-router 10 Sep '13

10 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#337 - uac_redirect: get_redirects() with no second parameter raises a core dump User who did this - Víctor Seva (linuxmaniac) Reason for closing: Fixed Additional comments about closing: Fixed applied on 4.0 branch too. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=337 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.0: uac_redirect: get_redirect() check reason value before using it.
by Victor Seva 10 Sep '13

10 Sep '13

Module: sip-router Branch: 4.0 Commit: 51f40460096d9c249ce34d9b4fbecf366b5f974e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=51f4046… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Mon Sep 9 16:52:47 2013 +0200 uac_redirect: get_redirect() check reason value before using it. This fix a core dump when get_redirects() config fuction is called with just the one parameter. (cherry picked from commit abf0026782c0ba4643feb25ded022e8c12725584) --- modules/uac_redirect/rd_funcs.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/modules/uac_redirect/rd_funcs.c b/modules/uac_redirect/rd_funcs.c index 19b4dad..d1e4d46 100644 --- a/modules/uac_redirect/rd_funcs.c +++ b/modules/uac_redirect/rd_funcs.c @@ -96,9 +96,12 @@ int get_redirect( struct sip_msg *msg , int maxt, int maxb, } if (max==0) continue; - /* put the response code into the acc_param reason struct */ - reason->code = t->uac[i].last_received; - reason->code_s.s = int2bstr((unsigned long)reason->code, code_buf, &reason->code_s.len); + if(reason!=NULL) + { + /* put the response code into the acc_param reason struct */ + reason->code = t->uac[i].last_received; + reason->code_s.s = int2bstr((unsigned long)reason->code, code_buf, &reason->code_s.len); + } /* get the contact from it */ n = shmcontact2dset( msg, t->uac[i].reply, max, reason, bflags); if ( n<0 ) {

1 0

git:master: uac_redirect: get_redirect() check reason value before using it .
by Victor Seva 10 Sep '13

10 Sep '13

Module: sip-router Branch: master Commit: abf0026782c0ba4643feb25ded022e8c12725584 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=abf0026… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Mon Sep 9 16:52:47 2013 +0200 uac_redirect: get_redirect() check reason value before using it. This fix a core dump when get_redirects() config fuction is called with just the one parameter. --- modules/uac_redirect/rd_funcs.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/modules/uac_redirect/rd_funcs.c b/modules/uac_redirect/rd_funcs.c index ca34e0c..aa8dbd0 100644 --- a/modules/uac_redirect/rd_funcs.c +++ b/modules/uac_redirect/rd_funcs.c @@ -96,9 +96,12 @@ int get_redirect( struct sip_msg *msg , int maxt, int maxb, } if (max==0) continue; - /* put the response code into the acc_param reason struct */ - reason->code = t->uac[i].last_received; - reason->code_s.s = int2bstr((unsigned long)reason->code, code_buf, &reason->code_s.len); + if(reason!=NULL) + { + /* put the response code into the acc_param reason struct */ + reason->code = t->uac[i].last_received; + reason->code_s.s = int2bstr((unsigned long)reason->code, code_buf, &reason->code_s.len); + } /* get the contact from it */ n = shmcontact2dset( msg, t->uac[i].reply, max, reason, bflags); if ( n<0 ) {

1 0

[tracker] Comment added: uac_redirect: get_redirects() with no second parameter raises a core dump
by sip-router 10 Sep '13

10 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#337 - uac_redirect: get_redirects() with no second parameter raises a core dump User who did this - Daniel-Constantin Mierla (miconda) ---------- Thanks, can be pushed to repository. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=337#comment1068 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: uac_redirect: get_redirects() with no second parameter raises a core dump
by sip-router 09 Sep '13

09 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Víctor Seva has taken ownership of the following task: FS#337 - uac_redirect: get_redirects() with no second parameter raises a core dump More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=337 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: uac_redirect: get_redirects() with no second parameter raises a core dump (Attachment added)
by sip-router 09 Sep '13

09 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Víctor Seva (linuxmaniac) Attached to Project - sip-router Summary - uac_redirect: get_redirects() with no second parameter raises a core dump Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - We are getting a core dump on uac_redirect module when calling get_redirects() config function using just one parameter. One or more files have been attached. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=337 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
21
22
23
24
25
26
27
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013