December 2014 - sr-dev - kamailio.org

[tracker] Task closed: new tls_method that only accepts TLSv1, but allows SSLv2 client hello
by sip-router 23 Dec '14

23 Dec '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#90 - new tls_method that only accepts TLSv1, but allows SSLv2 client hello User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Won't implement Additional comments about closing: SSv2 support has been deprecated out there. If you still find this useful to implement, re-open on github issues. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=90 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: downgrade tcp_send ERRORs
by sip-router 23 Dec '14

23 Dec '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#68 - downgrade tcp_send ERRORs User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=68 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master:40971d1e: core: use corelog level for debug messages when sending out fails
by Daniel-Constantin Mierla 23 Dec '14

23 Dec '14

Module: kamailio Branch: master Commit: 40971d1ed829bc8e18a684cd4431649acd47999e URL: https://github.com/kamailio/kamailio/commit/40971d1ed829bc8e18a684cd4431649… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2014-12-23T10:25:58+01:00 core: use corelog level for debug messages when sending out fails - allow better control of what is printed, FS#68 --- Modified: forward.h --- Diff: https://github.com/kamailio/kamailio/commit/40971d1ed829bc8e18a684cd4431649… Patch: https://github.com/kamailio/kamailio/commit/40971d1ed829bc8e18a684cd4431649… --- diff --git a/forward.h b/forward.h index 2babd74..e1cd093 100644 --- a/forward.h +++ b/forward.h @@ -205,7 +205,7 @@ static inline int msg_send(struct dest_info* dst, char* buf, int len) } if (unlikely(udp_send(dst, outb.s, outb.len)==-1)){ STATS_TX_DROPS; - LM_ERR("udp_send failed\n"); + LOG(cfg_get(core, core_cfg, corelog), "udp_send failed\n"); goto error; } } @@ -224,7 +224,7 @@ static inline int msg_send(struct dest_info* dst, char* buf, int len) } if (unlikely(tcp_send(dst, from, outb.s, outb.len)<0)){ STATS_TX_DROPS; - LM_ERR("tcp_send failed\n"); + LOG(cfg_get(core, core_cfg, corelog), "tcp_send failed\n"); goto error; } } @@ -244,7 +244,7 @@ static inline int msg_send(struct dest_info* dst, char* buf, int len) } if (unlikely(tcp_send(dst, from, outb.s, outb.len)<0)){ STATS_TX_DROPS; - LM_ERR("tcp_send failed\n"); + LOG(cfg_get(core, core_cfg, corelog), "tcp_send failed\n"); goto error; } } @@ -269,7 +269,7 @@ static inline int msg_send(struct dest_info* dst, char* buf, int len) } if (unlikely(sctp_core_msg_send(dst, outb.s, outb.len)<0)){ STATS_TX_DROPS; - LM_ERR("sctp_msg_send failed\n"); + LOG(cfg_get(core, core_cfg, corelog), "sctp_msg_send failed\n"); goto error; } }

1 0

git:master:c10c13b2: tm: downgraded err to warn when sending out for a branch fails
by Daniel-Constantin Mierla 23 Dec '14

23 Dec '14

Module: kamailio Branch: master Commit: c10c13b2582fd667d24e691219939e224cffaf30 URL: https://github.com/kamailio/kamailio/commit/c10c13b2582fd667d24e691219939e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2014-12-23T10:24:32+01:00 tm: downgraded err to warn when sending out for a branch fails - can happen if tcp connection is not active and no connect is set, FS#68 --- Modified: modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/c10c13b2582fd667d24e691219939e2… Patch: https://github.com/kamailio/kamailio/commit/c10c13b2582fd667d24e691219939e2… --- diff --git a/modules/tm/t_fwd.c b/modules/tm/t_fwd.c index 706ae11..33ee375 100644 --- a/modules/tm/t_fwd.c +++ b/modules/tm/t_fwd.c @@ -1604,7 +1604,7 @@ int t_send_branch( struct cell *t, int branch, struct sip_msg* p_msg , } #endif uac->icode = 908; /* internal code set to delivery failure */ - LOG(L_ERR, "ERROR: t_send_branch: sending request on branch %d " + LOG(L_WARN, "ERROR: t_send_branch: sending request on branch %d " "failed\n", branch); if (proxy) { proxy->errors++; proxy->ok=0; } if(tm_failure_exec_mode==1) {

1 0

[tracker] Task closed: iptrtpproxy compilation error
by sip-router 23 Dec '14

23 Dec '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#370 - iptrtpproxy compilation error User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Won't implement Additional comments about closing: Module is obsoleted, unless someone will revive it. rtpengine offers more or less same functionality with kernel forwarding, plus many other features. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=370 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Some modules not being generated in RPM Build
by sip-router 23 Dec '14

23 Dec '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#488 - Some modules not being generated in RPM Build User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Carrierroute rpm re-enabled, in future releases should be bundled with standard modules rpm. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=488 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: SIPTRACE populates method=INVITE for received response to CANCEL
by sip-router 23 Dec '14

23 Dec '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#489 - SIPTRACE populates method=INVITE for received response to CANCEL User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: I pushed a patch to take cseq from message, not transaction fields, because cancel is bound to invite transaction. If still an issue, open a new issue on github project. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=489 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master:88173da2: siptrace: use the method from cseq header for tm replies
by Daniel-Constantin Mierla 23 Dec '14

23 Dec '14

Module: kamailio Branch: master Commit: 88173da2b684a3a3f86ee01ac5de401f492ff240 URL: https://github.com/kamailio/kamailio/commit/88173da2b684a3a3f86ee01ac5de401… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2014-12-23T00:51:45+01:00 siptrace: use the method from cseq header for tm replies - the hook in transaction structure is invalid for cancel replies, because the transaction structure is built for invite - reported by Klaus Darilion, FS#489 --- Modified: modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/88173da2b684a3a3f86ee01ac5de401… Patch: https://github.com/kamailio/kamailio/commit/88173da2b684a3a3f86ee01ac5de401… --- diff --git a/modules/siptrace/siptrace.c b/modules/siptrace/siptrace.c index aad69a0..0ccef7d 100644 --- a/modules/siptrace/siptrace.c +++ b/modules/siptrace/siptrace.c @@ -533,6 +533,13 @@ static int sip_trace_prepare(sip_msg_t *msg) goto error; } + if(msg->cseq==NULL && ((parse_headers(msg, HDR_CSEQ_F, 0)==-1) + || (msg->cseq==NULL))) + { + LM_ERR("cannot parse cseq\n"); + goto error; + } + return 0; error: return -1; @@ -1249,7 +1256,7 @@ static void trace_onreply_in(struct cell* t, int type, struct tmcb_params *ps) sto.callid = msg->callid->body; - sto.method = t->method; + sto.method = get_cseq(msg)->method; strcpy(statusbuf, int2str(ps->code, &sto.status.len)); sto.status.s = statusbuf; @@ -1349,7 +1356,7 @@ static void trace_onreply_out(struct cell* t, int type, struct tmcb_params *ps) } sto.callid = msg->callid->body; - sto.method = t->method; + sto.method = get_cseq(msg)->method; if(trace_local_ip.s && trace_local_ip.len > 0) { sto.fromip = trace_local_ip;

1 0

[tracker] Comment added: FreeBSD + mariadb make fail
by sip-router 23 Dec '14

23 Dec '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#503 - FreeBSD + mariadb make fail User who did this - Victor (coyote) ---------- 4.3.0-dev0 Oh, sorry, backward: # diff -u modules/db_mysql/Makefile{-,} --- modules/db_mysql/Makefile- 2014-12-22 12:47:50.818588504 +0300 +++ modules/db_mysql/Makefile 2014-12-22 12:47:36.631590149 +0300 @@ -21,7 +21,7 @@ ifneq ($(MYSQLCFG),) # use autodetection - DEFS += $(shell $(MYSQLCFG) --include | sed 's/$-I.*$\/mysql/\1/g' ) + DEFS += $(shell $(MYSQLCFG) --include ) LIBS = $(shell $(MYSQLCFG) --libs) else # mysql.h locations (freebsd,openbsd solaris) ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=503#comment1742 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: FreeBSD + mariadb make fail (Attachment added)
by sip-router 23 Dec '14

23 Dec '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#503 - FreeBSD + mariadb make fail User who did this - Victor (coyote) ---------- # diff -u modules/db_mysql/Makefile{,-} --- modules/db_mysql/Makefile 2014-12-22 12:47:36.631590149 +0300 +++ modules/db_mysql/Makefile- 2014-12-22 12:47:50.818588504 +0300 @@ -21,7 +21,7 @@ ifneq ($(MYSQLCFG),) # use autodetection - DEFS += $(shell $(MYSQLCFG) --include ) + DEFS += $(shell $(MYSQLCFG) --include | sed 's/$-I.*$\/mysql/\1/g' ) LIBS = $(shell $(MYSQLCFG) --libs) else # mysql.h locations (freebsd,openbsd solaris) ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=503#comment1741 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0