sr-dev December 2014

sr-dev@lists.kamailio.org

33 participants
255 discussions

[tracker] Task closed: our Record-Route is doubled on subsequent branches

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#466 - our Record-Route is doubled on subsequent branches User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: If still an issue, open with the afferent details on github tracker. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=466 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Task closed: add support to auth_db to validate source IP address

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#499 - add support to auth_db to validate source IP address User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Won't implement More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=499 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Task closed: Implement "u" rpc formating char

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#64 - Implement "u" rpc formating char User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: u has been implemented for jsonrpc-s, should be propagated to other modules. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=64 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Task closed: crash in dns_cache.c when using natping

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#491 - crash in dns_cache.c when using natping User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Pushed safety check to master. To be backported soon. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=491 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

git:master:aff1dcd3: core: safety checks on proto variable for dsn resolving

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: aff1dcd3dc63c0fe124fc138d553da0723c615a8 URL: https://github.com/kamailio/kamailio/commit/aff1dcd3dc63c0fe124fc138d553da0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2014-12-22T21:41:53+01:00 core: safety checks on proto variable for dsn resolving - avoid crashes if functions used inadequately with a null pointer --- Modified: dns_cache.c Modified: msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/aff1dcd3dc63c0fe124fc138d553da0… Patch: https://github.com/kamailio/kamailio/commit/aff1dcd3dc63c0fe124fc138d553da0… --- diff --git a/dns_cache.c b/dns_cache.c index 285c6ad..2e963a8 100644 --- a/dns_cache.c +++ b/dns_cache.c @@ -2808,7 +2808,11 @@ struct hostent* dns_naptr_sip_resolvehost(str* name, unsigned short* port, char origproto; str srv_name; - origproto=*proto; + if(proto) { + origproto=*proto; + } else { + origproto=PROTO_NONE; + } he=0; if (dns_hash==0){ /* not init => use normal, non-cached version */ LM_WARN("called before dns cache initialization\n"); @@ -2848,7 +2852,7 @@ struct hostent* dns_naptr_sip_resolvehost(str* name, unsigned short* port, dns_hash_put(e); } naptr_not_found: - *proto = origproto; + if(proto) *proto = origproto; he = no_naptr_srv_sip_resolvehost(name,port,proto); /* fallback all the way down to A/AAAA */ if (he==0) { diff --git a/msg_translator.c b/msg_translator.c index df1a753..8bca35f 100644 --- a/msg_translator.c +++ b/msg_translator.c @@ -197,6 +197,7 @@ static int check_via_address(struct ip_addr* ip, str *name, int i; char* s; int len; + char lproto; /* maybe we are lucky and name it's an ip */ s=ip_addr2a(ip); @@ -229,7 +230,8 @@ static int check_via_address(struct ip_addr* ip, str *name, if (resolver&DO_DNS){ DBG("check_via_address: doing dns lookup\n"); /* try all names ips */ - he=sip_resolvehost(name, &port, 0); /* don't use naptr */ + lproto = PROTO_NONE; + he=sip_resolvehost(name, &port, &lproto); /* don't use naptr */ if (he && ip->af==he->h_addrtype){ for(i=0;he && he->h_addr_list[i];i++){ if ( memcmp(&he->h_addr_list[i], ip->u.addr, ip->len)==0)

9 years, 11 months

git:master:0bbcbe83: nat_traversal: use local variable for port and proto on keepalive resolve

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0bbcbe8328d558a9bf3cb151ab53be93b09c2669 URL: https://github.com/kamailio/kamailio/commit/0bbcbe8328d558a9bf3cb151ab53be9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2014-12-22T21:40:52+01:00 nat_traversal: use local variable for port and proto on keepalive resolve - safe execution for those resolving functions expecting PROTO_NONE - reported by Jason Penton, FS#491 --- Modified: modules/nat_traversal/nat_traversal.c --- Diff: https://github.com/kamailio/kamailio/commit/0bbcbe8328d558a9bf3cb151ab53be9… Patch: https://github.com/kamailio/kamailio/commit/0bbcbe8328d558a9bf3cb151ab53be9… --- diff --git a/modules/nat_traversal/nat_traversal.c b/modules/nat_traversal/nat_traversal.c index 2f0ffbe..87aaf50 100644 --- a/modules/nat_traversal/nat_traversal.c +++ b/modules/nat_traversal/nat_traversal.c @@ -1510,6 +1510,8 @@ send_keepalive(NAT_Contact *contact) struct dest_info dst; int nat_port, len; str nat_ip; + unsigned short lport; + char lproto; if (keepalive_params.from == NULL) { if (contact->socket != last_socket) { @@ -1554,7 +1556,9 @@ send_keepalive(NAT_Contact *contact) ptr = strchr(nat_ip.s, ':'); nat_ip.len = ptr - nat_ip.s; nat_port = strtol(ptr+1, NULL, 10); - hostent = sip_resolvehost(&nat_ip, NULL, NULL); + lport = 0; + lproto = PROTO_NONE; + hostent = sip_resolvehost(&nat_ip, &lport, &lproto); hostent2su(&dst.to, hostent, 0, nat_port); dst.proto=PROTO_UDP; dst.send_sock=contact->socket;

9 years, 11 months

[tracker] Comment added: CRASH: segfault in parser/parse_via.c

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#478 - CRASH: segfault in parser/parse_via.c User who did this - Daniel-Constantin Mierla (miconda) ---------- I had a wrong command, wanted to get output of: p *t->uas.request ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=478#comment1740 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Comment added: FreeBSD + mariadb make fail

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#503 - FreeBSD + mariadb make fail User who did this - Daniel-Constantin Mierla (miconda) ---------- What version are you using? The line is in the Makefile for db_mysql module: * https://github.com/kamailio/kamailio/blob/master/modules/db_mysql/Makefile#… ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=503#comment1739 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Task closed: tm: possible crash if trying to aapend branch on cancelled transaction

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#498 - tm: possible crash if trying to aapend branch on cancelled transaction User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Patch pushed to master. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=498 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

git:master:7a6b8657: tm: don't clean local vars when trying to append a new branch to an active canceled transaction

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7a6b86576220b423c4dc5ccab7e7f22a50be27bd URL: https://github.com/kamailio/kamailio/commit/7a6b86576220b423c4dc5ccab7e7f22… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2014-12-22T18:37:25+01:00 tm: don't clean local vars when trying to append a new branch to an active canceled transaction - they are not set, reported by Ovidiu Sas, FS#498 --- Modified: modules/tm/t_append_branches.c --- Diff: https://github.com/kamailio/kamailio/commit/7a6b86576220b423c4dc5ccab7e7f22… Patch: https://github.com/kamailio/kamailio/commit/7a6b86576220b423c4dc5ccab7e7f22… --- diff --git a/modules/tm/t_append_branches.c b/modules/tm/t_append_branches.c index be9731b..9600a21 100644 --- a/modules/tm/t_append_branches.c +++ b/modules/tm/t_append_branches.c @@ -75,12 +75,16 @@ int t_append_branches(void) { LM_DBG("transaction %u:%u in status %d\n", t->hash_index, t->label, t->uas.status); /* test if transaction has already been canceled */ - if (t->flags & T_CANCELED) goto canceled; + if (t->flags & T_CANCELED) { + ser_error=E_CANCELED; + return -1; + } if ((t->uas.status >= 200 && t->uas.status<=399) || ((t->uas.status >= 600 && t->uas.status) && !(t->flags & (T_6xx | T_DISABLE_6xx))) ) { - LM_DBG("transaction %u:%u in status %d: cannot append new branch\n", t->hash_index, t->label, t->uas.status); + LM_DBG("transaction %u:%u in status %d: cannot append new branch\n", + t->hash_index, t->label, t->uas.status); return -1; } @@ -90,7 +94,8 @@ int t_append_branches(void) { outgoings = t->nr_of_outgoings; orig_msg = t->uas.request; - LM_DBG("Call %.*s: %d (%d) outgoing branches\n",orig_msg->callid->body.len, orig_msg->callid->body.s,outgoings, nr_branches); + LM_DBG("Call %.*s: %d (%d) outgoing branches\n",orig_msg->callid->body.len, + orig_msg->callid->body.s,outgoings, nr_branches); lowest_ret=E_UNSPEC; added_branches=0; @@ -142,7 +147,8 @@ int t_append_branches(void) { clear_branches(); - LM_DBG("Call %.*s: %d (%d) outgoing branches after clear_branches()\n",orig_msg->callid->body.len, orig_msg->callid->body.s,outgoings, nr_branches); + LM_DBG("Call %.*s: %d (%d) outgoing branches after clear_branches()\n", + orig_msg->callid->body.len, orig_msg->callid->body.s,outgoings, nr_branches); setbflagsval(0, backup_bflags); /* update message flags, if changed in branch route */ @@ -169,7 +175,8 @@ int t_append_branches(void) { if (branch_ret==i) { /* success */ success_branch++; if (unlikely(has_tran_tmcbs(t, TMCB_REQUEST_OUT))) - run_trans_callbacks_with_buf( TMCB_REQUEST_OUT, &t->uac[nr_branches].request, + run_trans_callbacks_with_buf( TMCB_REQUEST_OUT, + &t->uac[nr_branches].request, orig_msg, 0, -orig_msg->REQ_METHOD); } else /* new branch added */

9 years, 11 months

← Newer
1
...
4
5
6
7
8
9
10
...
26
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2014