sr-dev April 2014

sr-dev@lists.kamailio.org

26 participants
304 discussions

OT: Excessive or fatal bounces for yahoo, hotmail, ...
by Daniel-Constantin Mierla 29 Apr '14

29 Apr '14

Hello, this morning were reported over 100 "excessive or fatal bounces" for delivery from mailing list to yahoo, hotmail/live (and few other that might be hosted) email addresses. This is unusual high and I spotted several addresses that were active recently and unlikely to have their email address gone. Is anyone here aware of similar issues and potential fixes? I guess yahoo/hotmail servers simply reject the emails sent by mailman of mailing lists. Any hint would be appreciated... Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

1 0

[tracker] Comment added: crash in debugger module (kamailio 4.1.2)
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#423 - crash in debugger module (kamailio 4.1.2) User who did this - Daniel-Constantin Mierla (miconda) ---------- debugger_api.c:1191 is a comment in 4.1 branch, with no recent patch that could have shifted lines. The core is somehow invalid, a new one should be caught. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=423#comment1423 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#410 - textops: add functions to convert and append multipart bodies. User who did this - Víctor Seva (linuxmaniac) ---------- Revised patches: - fix license. Check memory allocation. Return value using str* parameter. - use str instead of str* for str_append. Remove some commented logs, but the rest are quite nice when devel debugging, at least for me. Fix comments. Negate expression done. Thanks for reviewing. ---------- One or more files have been attached. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=410#comment1422 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core: new internal msg flag added - FL_RR_ADDED
by Daniel-Constantin Mierla 28 Apr '14

28 Apr '14

Module: sip-router Branch: master Commit: 79a01b9df71bdc4329ee14e29d5c5ef230116bd2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=79a01b9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 29 00:05:16 2014 +0200 core: new internal msg flag added - FL_RR_ADDED - marks a sip request when record route is added --- parser/msg_parser.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/parser/msg_parser.h b/parser/msg_parser.h index f25bec9..33d0475 100644 --- a/parser/msg_parser.h +++ b/parser/msg_parser.h @@ -122,6 +122,7 @@ typedef enum request_method { #define FL_TM_RPL_MATCHED (1<<15) /* tm matched reply already */ #define FL_RPL_SUSPENDED (1<<16) /* for async reply processing */ #define FL_BODY_MULTIPART (1<<17) /* body modified is multipart */ +#define FL_RR_ADDED (1<<18) /* Record-Route header was added */ /* WARNING: Value (1 << 28) is temporarily reserved for use in kamailio call_control * module (flag FL_USE_CALL_CONTROL )! */

1 0

git:master: textopsx: msg_apply_changes() returns error if record route was added
by Daniel-Constantin Mierla 28 Apr '14

28 Apr '14

Module: sip-router Branch: master Commit: 25a0534b11b5585eafa579d0ea3760438afd4ef7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=25a0534… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 29 00:12:16 2014 +0200 textopsx: msg_apply_changes() returns error if record route was added --- modules/textopsx/textopsx.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/textopsx/textopsx.c b/modules/textopsx/textopsx.c index 629681c..207eba6 100644 --- a/modules/textopsx/textopsx.c +++ b/modules/textopsx/textopsx.c @@ -164,6 +164,11 @@ static int msg_apply_changes_f(sip_msg_t *msg, char *str1, char *str2) obuf.s = generate_res_buf_from_sip_res(msg, (unsigned int*)&obuf.len, BUILD_NO_VIA1_UPDATE); } else { + if(msg->msg_flags & FL_RR_ADDED) { + LM_ERR("cannot apply msg changes after adding record-route" + " header - it breaks conditional 2nd header\n"); + return -1; + } obuf.s = build_req_buf_from_sip_req(msg, (unsigned int*)&obuf.len, &dst, BUILD_NO_PATH|BUILD_NO_LOCAL_VIA|BUILD_NO_VIA1_UPDATE);

1 0

git:master: rr: use internal msg flags to mark a request with record route added
by Daniel-Constantin Mierla 28 Apr '14

28 Apr '14

Module: sip-router Branch: master Commit: cc84b46d473236d162a852c3604eacfc88e56ba2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cc84b46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 29 00:01:53 2014 +0200 rr: use internal msg flags to mark a request with record route added --- modules/rr/rr_mod.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/modules/rr/rr_mod.c b/modules/rr/rr_mod.c index 1628f3b..8a7311d 100644 --- a/modules/rr/rr_mod.c +++ b/modules/rr/rr_mod.c @@ -61,7 +61,6 @@ int enable_socket_mismatch_warning = 1; /*!< enable socket mismatch warning */ static str custom_user_spec = {NULL, 0}; pv_spec_t custom_user_avp; -static unsigned int last_rr_msg; ob_api_t rr_obb; MODULE_VERSION @@ -268,7 +267,7 @@ static int w_record_route(struct sip_msg *msg, char *key, char *bar) { str s; - if (msg->id == last_rr_msg) { + if (msg->msg_flags & FL_RR_ADDED) { LM_ERR("Double attempt to record-route\n"); return -1; } @@ -280,7 +279,7 @@ static int w_record_route(struct sip_msg *msg, char *key, char *bar) if ( record_route( msg, key?&s:0 )<0 ) return -1; - last_rr_msg = msg->id; + msg->msg_flags |= FL_RR_ADDED; return 1; } @@ -289,7 +288,7 @@ static int w_record_route_preset(struct sip_msg *msg, char *key, char *key2) { str s; - if (msg->id == last_rr_msg) { + if (msg->msg_flags & FL_RR_ADDED) { LM_ERR("Duble attempt to record-route\n"); return -1; } @@ -316,7 +315,7 @@ static int w_record_route_preset(struct sip_msg *msg, char *key, char *key2) return -1; done: - last_rr_msg = msg->id; + msg->msg_flags |= FL_RR_ADDED; return 1; } @@ -328,7 +327,7 @@ static int w_record_route_advertised_address(struct sip_msg *msg, char *addr, ch { str s; - if (msg->id == last_rr_msg) { + if (msg->msg_flags & FL_RR_ADDED) { LM_ERR("Double attempt to record-route\n"); return -1; } @@ -340,7 +339,7 @@ static int w_record_route_advertised_address(struct sip_msg *msg, char *addr, ch if ( record_route_advertised_address( msg, &s ) < 0) return -1; - last_rr_msg = msg->id; + msg->msg_flags |= FL_RR_ADDED; return 1; }

1 0

git:master: parser: add internal flag FL_BODY_MULTIPART
by Victor Seva 28 Apr '14

28 Apr '14

Module: sip-router Branch: master Commit: 0dc5f4bcc7c95bffed4855cba537ccf8a1cad876 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0dc5f4b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Fri Mar 21 21:52:03 2014 +0100 parser: add internal flag FL_BODY_MULTIPART This will be set if the body has been converted to multipart/mixed or a new part has been appended to it. This will trigger the core to check and fix the boundaries of the body. --- parser/msg_parser.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/parser/msg_parser.h b/parser/msg_parser.h index 724ebef..f25bec9 100644 --- a/parser/msg_parser.h +++ b/parser/msg_parser.h @@ -121,6 +121,7 @@ typedef enum request_method { #define FL_USE_UAC_TO (1<<14) /* take TO hdr from UAC instead of UAS */ #define FL_TM_RPL_MATCHED (1<<15) /* tm matched reply already */ #define FL_RPL_SUSPENDED (1<<16) /* for async reply processing */ +#define FL_BODY_MULTIPART (1<<17) /* body modified is multipart */ /* WARNING: Value (1 << 28) is temporarily reserved for use in kamailio call_control * module (flag FL_USE_CALL_CONTROL )! */

1 0

[tracker] Comment added: textops: add functions to convert and append multipart bodies.
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#410 - textops: add functions to convert and append multipart bodies. User who did this - Daniel-Constantin Mierla (miconda) ---------- First patch can be applied. You should do it soon as I have another flag to add in the very near future. Second patch: - license has to be bsd, being contribution to core - has leaks - you have to allocate after you check the parameters. In case of errors, free the previous allocated pointers - you don't check if result->s allocation returns valid pointer or null - does it really need to allocate the str*? Shouldn't work with allocating the (str*)->s? The output can be a parameter instead of returned pointer, or eventually a static str variable inside the function. I see append_str() is used twice in the 3rd patch, returned pointer being always freed. Third patch: - not completely reviewed, but - fb and ob are set via append_str(), but only fb and ob are freed, i haven't seen fb->s, ob->s being freed - quite some number of commented logs, maybe they should removed - aesthetics: - preferable to use /**/ for commenting, // is c++ style, although most c compilers are fine with it now - negate expression in the first IF inside check_boundaries() -- if(msg->msg_flags&FL_BODY_MULTIPART) -- and return immediately if true to avoid useless 'clean:' operations, as most of the traffic will be without mutipart bodies. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=410#comment1421 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: crash in debugger module (kamailio 4.1.2)
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#423 - crash in debugger module (kamailio 4.1.2) User who did this - Ovidiu Sas (osas) ---------- No, it was during normal operation. The debugger module was loaded, but no modules were activated: loadmodule "debugger.so" modparam("debugger", "mod_hash_size", 5) modparam("debugger", "mod_level_mode", 1) ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=423#comment1420 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: zombie dialogs in state 5
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#424 - zombie dialogs in state 5 User who did this - Daniel-Constantin Mierla (miconda) ---------- Is the BYE sent out and reply for it is coming back? Can you give the logs for the reply handling? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=424#comment1419 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
2
3
4
5
6
7
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2014