sr-dev April 2014

sr-dev@lists.kamailio.org

26 participants
304 discussions

[tracker] Comment added: No TCP-Children, when listening only on TLS-Sockets
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#425 - No TCP-Children, when listening only on TLS-Sockets User who did this - Carsten Bock (carstenbock) ---------- I know the workaround; but i was just wondering, if this is the way it should be. I've checked the sources and i've noticed that in main.c the number of tcp_children is calculated based on the tcp_listen interfaces (static int calc_proc_no(void), ~line 1768+). I could add a check for the tls_listen interfaces as well; i will investigate further either later today or tomorrow. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=425#comment1413 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Dialog bugs
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#282 - Dialog bugs User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Not a bug Additional comments about closing: Mixed combination. Patches were on dialog_ng and no follow up. Reopen with description for dialog module and afferent patches (if any) or if something for dialog_ng, open as appropriately (but there was no database support for dialog_ng). More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=282 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: handle dialog tracking properly when non-failing 4xx responses are involved
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#146 - handle dialog tracking properly when non-failing 4xx responses are involved User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Not a bug More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=146 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: zombie dialogs in state 5
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#424 - zombie dialogs in state 5 User who did this - Daniel-Constantin Mierla (miconda) ---------- Are you using dlg_manage() or flag for tracking the dialog? I analyzed and couldn't spot a reason for this case, the retransmitted bye should just go without affecting dialog processing (there is no new state change). Can you get the log messages with debug=3? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=424#comment1412 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Crash in kamailio core - timeout on forked destinations
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#384 - Crash in kamailio core - timeout on forked destinations User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Should be fixed in master and 4.1 - a race in handling replies. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=384 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: No TCP-Children, when listening only on TLS-Sockets
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#425 - No TCP-Children, when listening only on TLS-Sockets User who did this - Daniel-Constantin Mierla (miconda) ---------- It is kind of known issue, coming from the fact that the tls is just an layer on top of tcp. Should be fixed in a way (don't start if no tcp workers) or another (enhance it work with tls only). Meanwhile, if you don't want to expose public tcp, just do listen=tcp:127.0.0.1:5060 ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=425#comment1411 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: No TCP-Children, when listening only on TLS-Sockets
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Carsten Bock (carstenbock) Attached to Project - sip-router Summary - No TCP-Children, when listening only on TLS-Sockets Task Type - Bug Report Category - tcp Status - New Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - Hi, i've noticed the following: If i only have TLS-Listening sockets, Kamailio won't start any child-listeners for TCP. I have in my config: # SIP / UDP listen=udp:192.168.1.12:5060 # SIP / TLS listen=tls:192.168.1.12:5061 (and of course TCP enabled and stuff) => kamcmd core.ps shows, i have the "tcp main process", but no worker threads. As soon as i add a TCP-Listening socket (listen=tcp:192.168.1.12:5060), i get the correct "tcp receiver (generic) child=0" threads. Shouldn't Kamailio start TCP workers, if i want to use TLS only? More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=425 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Dialog never times-out when ka_timer < 10, even on 481 or 408(fake) response
by sip-router 28 Apr '14

28 Apr '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#417 - Dialog never times-out when ka_timer < 10, even on 481 or 408(fake) response User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Closing the issue as protections on very low keepalive timer intervals were address. For improvements, open a new item for 'enahncement' or 'feature request'. If you have a patch, will be reviewed, otherwise, someone else might pick it up and develop. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=417 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: modules/sdpops: added sdp_with_ice() function for checking if sdp
by Juha Heinanen 28 Apr '14

28 Apr '14

Module: sip-router Branch: master Commit: d28c4043637169c4e90f638102c1f4dfa06716f2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d28c404… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Mon Apr 28 12:15:54 2014 +0300 modules/sdpops: added sdp_with_ice() function for checking if sdp contains ICE candidate attribute(s) --- modules/sdpops/README | 30 ++++++++++++++++++++++++------ modules/sdpops/doc/sdpops_admin.xml | 21 +++++++++++++++++++++ modules/sdpops/sdpops_mod.c | 34 ++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 6 deletions(-) diff --git a/modules/sdpops/README b/modules/sdpops/README index 9ea8e98..ebad4bd 100644 --- a/modules/sdpops/README +++ b/modules/sdpops/README @@ -42,7 +42,8 @@ Daniel-Constantin Mierla 4.14. sdp_print(level) 4.15. sdp_get(avpvar) 4.16. sdp_content() - 4.17. sdp_get_line_startswith(avpvar, string) + 4.17. sdp_with_ice() + 4.18. sdp_get_line_startswith(avpvar, string) List of Examples @@ -62,7 +63,8 @@ Daniel-Constantin Mierla 1.14. sdp_print usage 1.15. sdp_get usage 1.16. sdp_content usage - 1.17. sdp_get_line_startswith usage + 1.17. sdp_with_ice usage + 1.18. sdp_get_line_startswith usage Chapter 1. Admin Guide @@ -93,7 +95,8 @@ Chapter 1. Admin Guide 4.14. sdp_print(level) 4.15. sdp_get(avpvar) 4.16. sdp_content() - 4.17. sdp_get_line_startswith(avpvar, string) + 4.17. sdp_with_ice() + 4.18. sdp_get_line_startswith(avpvar, string) 1. Overview @@ -143,7 +146,8 @@ Chapter 1. Admin Guide 4.14. sdp_print(level) 4.15. sdp_get(avpvar) 4.16. sdp_content() - 4.17. sdp_get_line_startswith(avpvar, string) + 4.17. sdp_with_ice() + 4.18. sdp_get_line_startswith(avpvar, string) 4.1. sdp_remove_codecs_by_id(list) @@ -401,7 +405,21 @@ if(sdp_content()) { } ... -4.17. sdp_get_line_startswith(avpvar, string) +4.17. sdp_with_ice() + + Return true if the SIP message has SDP body that contains ICE candidate + attribute(s). + + This function can be used from ANY_ROUTE. + + Example 1.17. sdp_with_ice usage +... +if(sdp_with_ice()) { + ... +} +... + +4.18. sdp_get_line_startswith(avpvar, string) Store the search part of SDP body message with line beginning with 'string' in an AVP. Return 1 if 'string' is found in SDP, -1 on error @@ -409,7 +427,7 @@ if(sdp_content()) { This function can be used from ANY_ROUTE. - Example 1.17. sdp_get_line_startswith usage + Example 1.18. sdp_get_line_startswith usage ... if(sdp_get_line_startswith("$avp(mline)", "m=")) { xlog("m-line: $avp(mline)\n"); diff --git a/modules/sdpops/doc/sdpops_admin.xml b/modules/sdpops/doc/sdpops_admin.xml index a688bfa..7373b0b 100644 --- a/modules/sdpops/doc/sdpops_admin.xml +++ b/modules/sdpops/doc/sdpops_admin.xml @@ -460,6 +460,27 @@ if(sdp_content()) { </example> </section> <section> + <title> + <function moreinfo="none">sdp_with_ice()</function> + </title> + <para> + Return true if the SIP message has SDP body that contains ICE candidate attribute(s). + </para> + <para> + This function can be used from ANY_ROUTE. + </para> + <example> + <title><function>sdp_with_ice</function> usage</title> + <programlisting format="linespecific"> +... +if(sdp_with_ice()) { + ... +} +... +</programlisting> + </example> + </section> + <section> <title> <function moreinfo="none">sdp_get_line_startswith(avpvar, string)</function> </title> diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index 3712311..a8c472f 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -58,6 +58,7 @@ static int w_sdp_remove_transport(sip_msg_t* msg, char* transport, char *bar); static int w_sdp_print(sip_msg_t* msg, char* level, char *bar); static int w_sdp_get(sip_msg_t* msg, char *bar); static int w_sdp_content(sip_msg_t* msg, char* foo, char *bar); +static int w_sdp_with_ice(sip_msg_t* msg, char* foo, char *bar); static int w_sdp_get_line_startswith(sip_msg_t* msg, char *foo, char *bar); @@ -100,6 +101,8 @@ static cmd_export_t cmds[] = { 1, 0, 0, ANY_ROUTE}, {"sdp_content", (cmd_function)w_sdp_content, 0, 0, 0, ANY_ROUTE}, + {"sdp_with_ice", (cmd_function)w_sdp_with_ice, + 0, 0, 0, ANY_ROUTE}, {"sdp_get_line_startswith", (cmd_function)w_sdp_get_line_startswith, 2, 0, 0, ANY_ROUTE}, {"bind_sdpops", (cmd_function)bind_sdpops, @@ -1424,6 +1427,37 @@ static int w_sdp_content(sip_msg_t* msg, char* foo, char *bar) /** * */ +static int w_sdp_with_ice(sip_msg_t* msg, char* foo, char *bar) +{ + str ice, body; + + ice.s = "a=candidate"; + ice.len = 11; + + body.s = get_body(msg); + if (body.s == NULL) { + LM_DBG("failed to get the message body\n"); + return -1; + } + + body.len = msg->len -(int)(body.s - msg->buf); + if (body.len == 0) { + LM_DBG("message body has length zero\n"); + return -1; + } + + if (ser_memmem(body.s, ice.s, body.len, ice.len) != NULL) { + LM_INFO("found ice attribute\n"); + return 1; + } else { + LM_INFO("did't find ice attribute\n"); + return -1; + } +} + +/** + * + */ static int w_sdp_get_line_startswith(sip_msg_t *msg, char *avp, char *s_line) { sdp_info_t *sdp = NULL;

1 0

git:master: modules/pv: use just a comma as header delimiter
by Juha Heinanen 28 Apr '14

28 Apr '14

Module: sip-router Branch: master Commit: e4792b84483c6299d096477007b1d3f54f992c67 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e4792b8… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Mon Apr 28 12:08:42 2014 +0300 modules/pv: use just a comma as header delimiter --- modules/pv/pv_core.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/modules/pv/pv_core.c b/modules/pv/pv_core.c index 3f48830..c472622 100644 --- a/modules/pv/pv_core.c +++ b/modules/pv/pv_core.c @@ -73,6 +73,9 @@ int _pv_pid = 0; #define PV_FIELD_DELIM ", " #define PV_FIELD_DELIM_LEN (sizeof(PV_FIELD_DELIM) - 1) +#define PV_HDR_DELIM "," +#define PV_HDR_DELIM_LEN (sizeof(PV_HDR_DELIM) - 1) + int pv_get_msgid(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { @@ -1649,8 +1652,8 @@ int pv_get_hdr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) LM_ERR("local buffer length exceeded\n"); return pv_get_null(msg, param, res); } - memcpy(p, PV_FIELD_DELIM, PV_FIELD_DELIM_LEN); - p += PV_FIELD_DELIM_LEN; + memcpy(p, PV_HDR_DELIM, PV_HDR_DELIM_LEN); + p += PV_HDR_DELIM_LEN; } if(p-p_ini+hf->body.len+1>p_size) {

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2014