sr-dev November 2016

sr-dev@lists.kamailio.org

27 participants
290 discussions

git:master:f6f6c7f5: statsd: free srv variable in error handling
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: master Commit: f6f6c7f55d5d1a60c1beb6091744116a6b85b397 URL: https://github.com/kamailio/kamailio/commit/f6f6c7f55d5d1a60c1beb6091744116… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T14:01:52+01:00 statsd: free srv variable in error handling --- Modified: modules/statsd/lib_statsd.c --- Diff: https://github.com/kamailio/kamailio/commit/f6f6c7f55d5d1a60c1beb6091744116… Patch: https://github.com/kamailio/kamailio/commit/f6f6c7f55d5d1a60c1beb6091744116… --- diff --git a/modules/statsd/lib_statsd.c b/modules/statsd/lib_statsd.c index 878b452..926aa3e 100644 --- a/modules/statsd/lib_statsd.c +++ b/modules/statsd/lib_statsd.c @@ -19,7 +19,7 @@ static StatsConnection statsd_connection = { bool statsd_connect(void){ - struct addrinfo *serverAddr; + struct addrinfo *serverAddr = NULL; int rc; if (statsd_connection.sock > 0){ @@ -34,12 +34,14 @@ bool statsd_connect(void){ LM_ERR( "Statsd: could not initiate server information (%s)\n", gai_strerror(rc)); + if(serverAddr) freeaddrinfo(serverAddr); return false; } statsd_connection.sock = socket(serverAddr->ai_family, SOCK_DGRAM, IPPROTO_UDP); if (statsd_connection.sock < 0 ){ LM_ERR("Statsd: could not create a socket for statsd connection\n"); + if(serverAddr) freeaddrinfo(serverAddr); return false; }

1 0

git:master:511b324f: statsd: increase buffer for miliseconds printing as function uses 21 size
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: master Commit: 511b324fc89109de1665144bea0b9162aea35eac URL: https://github.com/kamailio/kamailio/commit/511b324fc89109de1665144bea0b916… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T13:58:07+01:00 statsd: increase buffer for miliseconds printing as function uses 21 size --- Modified: modules/statsd/statsd.c --- Diff: https://github.com/kamailio/kamailio/commit/511b324fc89109de1665144bea0b916… Patch: https://github.com/kamailio/kamailio/commit/511b324fc89109de1665144bea0b916… --- diff --git a/modules/statsd/statsd.c b/modules/statsd/statsd.c index 72aa708..1a68bea 100644 --- a/modules/statsd/statsd.c +++ b/modules/statsd/statsd.c @@ -107,7 +107,7 @@ static int func_set(struct sip_msg* msg, char* key, char* val) static int func_time_start(struct sip_msg *msg, char *key) { int_str avp_key, avp_val; - char unix_time[20]; + char unix_time[24]; get_milliseconds(unix_time); avp_key.s.s = key; avp_key.s.len = strlen(avp_key.s.s);

1 0

git:master:1f2b5af4: auth_identity: safer condition not to overflow building date header
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: master Commit: 1f2b5af4bb8f0dd562ef33589736c9ab4b48b7e1 URL: https://github.com/kamailio/kamailio/commit/1f2b5af4bb8f0dd562ef33589736c9a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T13:54:39+01:00 auth_identity: safer condition not to overflow building date header --- Modified: modules/auth_identity/auth_hdrs.c --- Diff: https://github.com/kamailio/kamailio/commit/1f2b5af4bb8f0dd562ef33589736c9a… Patch: https://github.com/kamailio/kamailio/commit/1f2b5af4bb8f0dd562ef33589736c9a… --- diff --git a/modules/auth_identity/auth_hdrs.c b/modules/auth_identity/auth_hdrs.c index 708366b..238c664 100644 --- a/modules/auth_identity/auth_hdrs.c +++ b/modules/auth_identity/auth_hdrs.c @@ -551,7 +551,7 @@ int append_date(str *sdate, int idatesize, time_t *tout, struct sip_msg *msg) } ilen=strftime(date_str, sizeof(date_str), AUTH_TIME_FORMAT, bd_time); - if (ilen > sizeof(date_hf) - strlen("Date: \r\n") || ilen==0) { + if (ilen >= sizeof(date_hf) - strlen("Date: \r\n.") || ilen==0) { LOG(L_ERR, "AUTH_IDENTITY:append_date: unexpected time length\n"); return -3; }

1 0

git:master:1d2c16c2: presence: free cloned dialog_id in case of errors
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: master Commit: 1d2c16c2c65d65bc6bb348800a935712eacfaca9 URL: https://github.com/kamailio/kamailio/commit/1d2c16c2c65d65bc6bb348800a93571… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T13:50:42+01:00 presence: free cloned dialog_id in case of errors --- Modified: modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/1d2c16c2c65d65bc6bb348800a93571… Patch: https://github.com/kamailio/kamailio/commit/1d2c16c2c65d65bc6bb348800a93571… --- diff --git a/modules/presence/presentity.c b/modules/presence/presentity.c index 4c8c914..3f79cfa 100644 --- a/modules/presence/presentity.c +++ b/modules/presence/presentity.c @@ -430,11 +430,13 @@ int delete_presentity_if_dialog_id_exists(presentity_t* presentity, char* dialog pa_dbf.free_result(pa_db, result); result = NULL; free(db_dialog_id); + db_dialog_id = NULL; return 1; } free(db_dialog_id); + db_dialog_id = NULL; } } @@ -693,10 +695,13 @@ int update_presentity(struct sip_msg* msg, presentity_t* presentity, str* body, check_if_dialog(*body, &is_dialog, &dialog_id); if ( dialog_id ) { if (delete_presentity_if_dialog_id_exists(presentity, dialog_id) < 0) { + free(dialog_id); + dialog_id = NULL; goto error; } free(dialog_id); + dialog_id = NULL; } LM_DBG("inserting %d cols into table\n",n_query_cols); @@ -795,6 +800,10 @@ int update_presentity(struct sip_msg* msg, presentity_t* presentity, str* body, if(check_if_dialog(*body, &is_dialog, &dialog_id)< 0) { LM_ERR("failed to check if dialog stored\n"); + if(dialog_id) { + free(dialog_id); + dialog_id = NULL; + } goto error; } @@ -808,13 +817,26 @@ int update_presentity(struct sip_msg* msg, presentity_t* presentity, str* body, if(check_if_dialog(old_body, &is_dialog, &old_dialog_id)< 0) { LM_ERR("failed to check if dialog stored\n"); + if(old_dialog_id) { + free(old_dialog_id); + old_dialog_id = NULL; + } goto error; } - if(is_dialog==0 ) /* if the old body has no dialog - overwrite */ + /* if the old body has no dialog - overwrite */ + if(is_dialog==0 ) { + if(old_dialog_id) { + free(old_dialog_id); + old_dialog_id = NULL; + } goto after_dialog_check; + } - free(old_dialog_id); + if(old_dialog_id) { + free(old_dialog_id); + old_dialog_id = NULL; + } sender.s = (char*)row_vals[rez_sender_col].val.string_val; sender.len= strlen(sender.s);

1 0

git:master:745196cb: jansson: init structure to avoid compile warnings
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: master Commit: 745196cb59070f4922162d3fe60e825d92025548 URL: https://github.com/kamailio/kamailio/commit/745196cb59070f4922162d3fe60e825… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T13:42:58+01:00 jansson: init structure to avoid compile warnings (cherry picked from commit 852a82c330d5c73b6c402e519e3d6ec8ac610665) --- Modified: modules/jansson/jansson_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/745196cb59070f4922162d3fe60e825… Patch: https://github.com/kamailio/kamailio/commit/745196cb59070f4922162d3fe60e825… --- diff --git a/modules/jansson/jansson_funcs.c b/modules/jansson/jansson_funcs.c index 5498789..e99eb64 100644 --- a/modules/jansson/jansson_funcs.c +++ b/modules/jansson/jansson_funcs.c @@ -135,7 +135,7 @@ int janssonmod_set(unsigned int append, struct sip_msg* msg, char* type_in, json_t* result_json = NULL; json_t* value = NULL; char* freeme = NULL; - json_error_t parsing_error; + json_error_t parsing_error = {0}; char* endptr; /* check the type */

1 0

git:master:936baa97: xmpp: shift head of connection list when first is closed
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: master Commit: 936baa97ec450b41c1d1c57098d2b463247657e2 URL: https://github.com/kamailio/kamailio/commit/936baa97ec450b41c1d1c57098d2b46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T13:42:46+01:00 xmpp: shift head of connection list when first is closed (cherry picked from commit ca4083f37326188cc5c64a148854b239234515df) --- Modified: modules/xmpp/xmpp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/936baa97ec450b41c1d1c57098d2b46… Patch: https://github.com/kamailio/kamailio/commit/936baa97ec450b41c1d1c57098d2b46… --- diff --git a/modules/xmpp/xmpp_server.c b/modules/xmpp/xmpp_server.c index 380dd64..6a9dfbe 100644 --- a/modules/xmpp/xmpp_server.c +++ b/modules/xmpp/xmpp_server.c @@ -451,7 +451,7 @@ int xmpp_server_child_process(int data_pipe) int listen_fd; fd_set fdset; struct xmpp_connection *conn; - + snprintf(local_secret, sizeof(local_secret), "%s", random_secret()); while ((listen_fd = net_listen(xmpp_domain, xmpp_port)) < 0) { @@ -463,13 +463,17 @@ int xmpp_server_child_process(int data_pipe) FD_ZERO(&fdset); FD_SET(data_pipe, &fdset); FD_SET(listen_fd, &fdset); - + /* check for dead connections */ for (conn = conn_list; conn; ) { struct xmpp_connection *next = conn->next; - if (conn->type == CONN_DEAD) + if (conn->type == CONN_DEAD) { + if(conn == conn_list) { + conn_list = next; + } conn_free(conn); + } conn = next; } @@ -488,7 +492,7 @@ int xmpp_server_child_process(int data_pipe) } else { conn->type = CONN_DEAD; } - } + } if (conn->fd != -1) FD_SET(conn->fd, &fdset);

1 0

git:4.4:852a82c3: jansson: init structure to avoid compile warnings
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: 4.4 Commit: 852a82c330d5c73b6c402e519e3d6ec8ac610665 URL: https://github.com/kamailio/kamailio/commit/852a82c330d5c73b6c402e519e3d6ec… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T13:41:59+01:00 jansson: init structure to avoid compile warnings --- Modified: modules/jansson/jansson_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/852a82c330d5c73b6c402e519e3d6ec… Patch: https://github.com/kamailio/kamailio/commit/852a82c330d5c73b6c402e519e3d6ec… --- diff --git a/modules/jansson/jansson_funcs.c b/modules/jansson/jansson_funcs.c index 5498789..e99eb64 100644 --- a/modules/jansson/jansson_funcs.c +++ b/modules/jansson/jansson_funcs.c @@ -135,7 +135,7 @@ int janssonmod_set(unsigned int append, struct sip_msg* msg, char* type_in, json_t* result_json = NULL; json_t* value = NULL; char* freeme = NULL; - json_error_t parsing_error; + json_error_t parsing_error = {0}; char* endptr; /* check the type */

1 0

git:4.4:ca4083f3: xmpp: shift head of connection list when first is closed
by Daniel-Constantin Mierla 02 Nov '16

02 Nov '16

Module: kamailio Branch: 4.4 Commit: ca4083f37326188cc5c64a148854b239234515df URL: https://github.com/kamailio/kamailio/commit/ca4083f37326188cc5c64a148854b23… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-11-02T13:41:59+01:00 xmpp: shift head of connection list when first is closed --- Modified: modules/xmpp/xmpp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/ca4083f37326188cc5c64a148854b23… Patch: https://github.com/kamailio/kamailio/commit/ca4083f37326188cc5c64a148854b23… --- diff --git a/modules/xmpp/xmpp_server.c b/modules/xmpp/xmpp_server.c index 380dd64..6a9dfbe 100644 --- a/modules/xmpp/xmpp_server.c +++ b/modules/xmpp/xmpp_server.c @@ -451,7 +451,7 @@ int xmpp_server_child_process(int data_pipe) int listen_fd; fd_set fdset; struct xmpp_connection *conn; - + snprintf(local_secret, sizeof(local_secret), "%s", random_secret()); while ((listen_fd = net_listen(xmpp_domain, xmpp_port)) < 0) { @@ -463,13 +463,17 @@ int xmpp_server_child_process(int data_pipe) FD_ZERO(&fdset); FD_SET(data_pipe, &fdset); FD_SET(listen_fd, &fdset); - + /* check for dead connections */ for (conn = conn_list; conn; ) { struct xmpp_connection *next = conn->next; - if (conn->type == CONN_DEAD) + if (conn->type == CONN_DEAD) { + if(conn == conn_list) { + conn_list = next; + } conn_free(conn); + } conn = next; } @@ -488,7 +492,7 @@ int xmpp_server_child_process(int data_pipe) } else { conn->type = CONN_DEAD; } - } + } if (conn->fd != -1) FD_SET(conn->fd, &fdset);

1 0

git:master:11de6877: pkg/kamailio/deb: version set to 5.0.0-dev7
by Victor Seva 02 Nov '16

02 Nov '16

Module: kamailio Branch: master Commit: 11de68777142a82d093e1095ff75243e7cfa387a URL: https://github.com/kamailio/kamailio/commit/11de68777142a82d093e1095ff75243… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-11-02T13:30:38+01:00 pkg/kamailio/deb: version set to 5.0.0-dev7 * refresh xenial --- Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/squeeze/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/11de68777142a82d093e1095ff75243… Patch: https://github.com/kamailio/kamailio/commit/11de68777142a82d093e1095ff75243…

1 0

git:4.4:d29fd285: modules: readme files regenerated - crypto ...
by Kamailio Dev 02 Nov '16

02 Nov '16

Module: kamailio Branch: 4.4 Commit: d29fd2852f9125f88e52312cf6b0f78355a5db3a URL: https://github.com/kamailio/kamailio/commit/d29fd2852f9125f88e52312cf6b0f78… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2016-11-02T11:01:24+01:00 modules: readme files regenerated - crypto ... --- Modified: modules/crypto/README Modified: modules/dispatcher/README Modified: modules/nathelper/README Modified: modules/permissions/README Modified: modules/sanity/README --- Diff: https://github.com/kamailio/kamailio/commit/d29fd2852f9125f88e52312cf6b0f78… Patch: https://github.com/kamailio/kamailio/commit/d29fd2852f9125f88e52312cf6b0f78…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2016