sr-dev January 2017

sr-dev@lists.kamailio.org

33 participants
538 discussions

git:master:f6da027c: cfgt: check first out of range index

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f6da027c4701fa1de02cf49bb1c4528849d052a9 URL: https://github.com/kamailio/kamailio/commit/f6da027c4701fa1de02cf49bb1c4528… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-30T16:45:26+01:00 cfgt: check first out of range index --- Modified: src/modules/cfgt/cfgt_json.c --- Diff: https://github.com/kamailio/kamailio/commit/f6da027c4701fa1de02cf49bb1c4528… Patch: https://github.com/kamailio/kamailio/commit/f6da027c4701fa1de02cf49bb1c4528… --- diff --git a/src/modules/cfgt/cfgt_json.c b/src/modules/cfgt/cfgt_json.c index 458ef93..2974adf 100644 --- a/src/modules/cfgt/cfgt_json.c +++ b/src/modules/cfgt/cfgt_json.c @@ -92,7 +92,7 @@ int _cfgt_xavp_dump_lookup(pv_param_t *param) xname = (pv_xavp_name_t*)param->pvn.u.dname; - while(_cfgt_xavp_dump[i]!=NULL&&i<CFGT_XAVP_DUMP_SIZE) + while(i<CFGT_XAVP_DUMP_SIZE && _cfgt_xavp_dump[i]!=NULL) { if(_cfgt_xavp_dump[i]->len==xname->name.len) { @@ -386,4 +386,4 @@ int cfgt_get_json(struct sip_msg* msg, unsigned int mask, srjson_doc_t *jdoc, error: srjson_Delete(jdoc, head); return -1; -} \ No newline at end of file +}

7 years, 10 months

git:master:d81a8fcb: pkg/kamailio/deb: use default-libmysqlclient-dev/default-mysql-client

by Victor Seva

Module: kamailio Branch: master Commit: d81a8fcbc6183b5474d2d9315ad72fa342c30cf1 URL: https://github.com/kamailio/kamailio/commit/d81a8fcbc6183b5474d2d9315ad72fa… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-30T16:17:14+01:00 pkg/kamailio/deb: use default-libmysqlclient-dev/default-mysql-client --- Modified: pkg/kamailio/deb/debian/backports/jessie Modified: pkg/kamailio/deb/debian/backports/precise Modified: pkg/kamailio/deb/debian/backports/squeeze Modified: pkg/kamailio/deb/debian/backports/trusty Modified: pkg/kamailio/deb/debian/backports/wheezy Modified: pkg/kamailio/deb/debian/backports/xenial Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control --- Diff: https://github.com/kamailio/kamailio/commit/d81a8fcbc6183b5474d2d9315ad72fa… Patch: https://github.com/kamailio/kamailio/commit/d81a8fcbc6183b5474d2d9315ad72fa…

7 years, 10 months

git:master:c7212940: Merge pull request #955 from grumvalski/serial_suspend

by GitHub

Module: kamailio Branch: master Commit: c7212940b7bddd296475fe62fac7f1bda61cc74e URL: https://github.com/kamailio/kamailio/commit/c7212940b7bddd296475fe62fac7f1b… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-01-30T16:12:59+01:00 Merge pull request #955 from grumvalski/serial_suspend tm: reset T_ASYNC_CONTINUE flag in t_suspend --- Modified: src/modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/c7212940b7bddd296475fe62fac7f1b… Patch: https://github.com/kamailio/kamailio/commit/c7212940b7bddd296475fe62fac7f1b… --- diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c index a23429d..5703493 100644 --- a/src/modules/tm/t_suspend.c +++ b/src/modules/tm/t_suspend.c @@ -143,7 +143,8 @@ int t_suspend(struct sip_msg *msg, *hash_index = t->hash_index; *label = t->label; - + /* reset the continue flag to be able to suspend in a failure route */ + t->flags &= ~T_ASYNC_CONTINUE; /* backup some extra info that can be used in continuation logic */ t->async_backup.backup_route = get_route_type();

7 years, 10 months

git:master:f81149d8: tm: reset T_ASYNC_CONTINUE flag in t_suspend

by grumvalski

Module: kamailio Branch: master Commit: f81149d820246242db0e48f32948784b9db4ce82 URL: https://github.com/kamailio/kamailio/commit/f81149d820246242db0e48f32948784… Author: grumvalski <federico.cabiddu(a)gmail.com> Committer: grumvalski <federico.cabiddu(a)gmail.com> Date: 2017-01-29T09:10:23+01:00 tm: reset T_ASYNC_CONTINUE flag in t_suspend --- Modified: src/modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/f81149d820246242db0e48f32948784… Patch: https://github.com/kamailio/kamailio/commit/f81149d820246242db0e48f32948784… --- diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c index a23429d..5703493 100644 --- a/src/modules/tm/t_suspend.c +++ b/src/modules/tm/t_suspend.c @@ -143,7 +143,8 @@ int t_suspend(struct sip_msg *msg, *hash_index = t->hash_index; *label = t->label; - + /* reset the continue flag to be able to suspend in a failure route */ + t->flags &= ~T_ASYNC_CONTINUE; /* backup some extra info that can be used in continuation logic */ t->async_backup.backup_route = get_route_type();

7 years, 10 months

[kamailio/kamailio] tm: reset T_ASYNC_CONTINUE flag in t_suspend (#955)

by Federico Cabiddu

Related to http://lists.sip-router.org/pipermail/sr-users/2017-January/095772.html Resetting the flag in t_suspend allows adding new branches in a failure route while suspending the transaction. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/955 -- Commit Summary -- * tm: reset T_ASYNC_CONTINUE flag in t_suspend -- File Changes -- M src/modules/tm/t_suspend.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/955.patch https://github.com/kamailio/kamailio/pull/955.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/955

7 years, 10 months

git:master:02cca18d: pkg/kamailio/deb: remove dnssec from stretch/sid due #851

by Victor Seva

Module: kamailio Branch: master Commit: 02cca18d4c39797c82715a90a781afb1157253bd URL: https://github.com/kamailio/kamailio/commit/02cca18d4c39797c82715a90a781afb… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-30T14:07:12+01:00 pkg/kamailio/deb: remove dnssec from stretch/sid due #851 --- Modified: pkg/kamailio/deb/debian/backports/sid Modified: pkg/kamailio/deb/debian/backports/stretch Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules --- Diff: https://github.com/kamailio/kamailio/commit/02cca18d4c39797c82715a90a781afb… Patch: https://github.com/kamailio/kamailio/commit/02cca18d4c39797c82715a90a781afb…

7 years, 10 months

git:master:4d128677: corex: close fd if ftell() fails inside file_read()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4d128677eeaed3ec3a4dfea88ee16767bf2552a7 URL: https://github.com/kamailio/kamailio/commit/4d128677eeaed3ec3a4dfea88ee1676… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-30T13:21:53+01:00 corex: close fd if ftell() fails inside file_read() --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4d128677eeaed3ec3a4dfea88ee1676… Patch: https://github.com/kamailio/kamailio/commit/4d128677eeaed3ec3a4dfea88ee1676… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index a489731..5f3c110 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -343,6 +343,7 @@ static int w_file_read(sip_msg_t *msg, char *fn, char *vn) fsize = ftell(f); if(fsize<0) { LM_ERR("ftell failed on file: %.*s\n", fname.len, fname.s); + fclose(f); return -1; } fseek(f, 0, SEEK_SET);

7 years, 10 months

git:master:05481295: jsonrpc: init len variable to avoid invalid usage

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 054812952fa9e006b39d604535833c18f4fdada5 URL: https://github.com/kamailio/kamailio/commit/054812952fa9e006b39d604535833c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-30T13:15:00+01:00 jsonrpc: init len variable to avoid invalid usage --- Modified: src/modules/jsonrpcs/jsonrpcs_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/054812952fa9e006b39d604535833c1… Patch: https://github.com/kamailio/kamailio/commit/054812952fa9e006b39d604535833c1… --- diff --git a/src/modules/jsonrpcs/jsonrpcs_mod.c b/src/modules/jsonrpcs/jsonrpcs_mod.c index c641d0a..f44fb9e 100644 --- a/src/modules/jsonrpcs/jsonrpcs_mod.c +++ b/src/modules/jsonrpcs/jsonrpcs_mod.c @@ -951,6 +951,7 @@ static struct rpc_delayed_ctx* jsonrpc_delayed_ctx_new(jsonrpc_ctx_t* ctx) ret=0; shm_msg=0; + len = 0; if (ctx->reply_sent) { LM_ERR("response already sent - cannot create a delayed context\n");

7 years, 10 months

git:master:d7b30d21: http_async_client: memset query_params to 0

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d7b30d21004166a00d3674ef172bcebb9ae34a97 URL: https://github.com/kamailio/kamailio/commit/d7b30d21004166a00d3674ef172bceb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-30T12:50:07+01:00 http_async_client: memset query_params to 0 - goto done in case of error could end up with some field not initialized --- Modified: src/modules/http_async_client/async_http.c --- Diff: https://github.com/kamailio/kamailio/commit/d7b30d21004166a00d3674ef172bceb… Patch: https://github.com/kamailio/kamailio/commit/d7b30d21004166a00d3674ef172bceb… --- diff --git a/src/modules/http_async_client/async_http.c b/src/modules/http_async_client/async_http.c index f4b248d..57d203a 100644 --- a/src/modules/http_async_client/async_http.c +++ b/src/modules/http_async_client/async_http.c @@ -234,19 +234,17 @@ void notification_socket_cb(int fd, short event, void *arg) query = ((str)aq->query); + memset(&query_params, 0, sizeof(http_m_params_t)); query_params.timeout = aq->query_params.timeout; query_params.tls_verify_peer = aq->query_params.tls_verify_peer; query_params.tls_verify_host = aq->query_params.tls_verify_host; query_params.authmethod = aq->query_params.authmethod; - query_params.headers = NULL; for (i = 0 ; i < aq->query_params.headers.len ; i++) { query_params.headers = curl_slist_append(query_params.headers, aq->query_params.headers.t[i]); } query_params.method = aq->query_params.method; - query_params.tls_client_cert.s = NULL; - query_params.tls_client_cert.len = 0; if (aq->query_params.tls_client_cert.s && aq->query_params.tls_client_cert.len > 0) { if (shm_str_dup(&query_params.tls_client_cert, &(aq->query_params.tls_client_cert)) < 0) { LM_ERR("Error allocating query_params.tls_client_cert\n"); @@ -254,8 +252,6 @@ void notification_socket_cb(int fd, short event, void *arg) } } - query_params.tls_client_key.s = NULL; - query_params.tls_client_key.len = 0; if (aq->query_params.tls_client_key.s && aq->query_params.tls_client_key.len > 0) { if (shm_str_dup(&query_params.tls_client_key, &(aq->query_params.tls_client_key)) < 0) { LM_ERR("Error allocating query_params.tls_client_key\n"); @@ -263,8 +259,6 @@ void notification_socket_cb(int fd, short event, void *arg) } } - query_params.tls_ca_path.s = NULL; - query_params.tls_ca_path.len = 0; if (aq->query_params.tls_ca_path.s && aq->query_params.tls_ca_path.len > 0) { if (shm_str_dup(&query_params.tls_ca_path, &(aq->query_params.tls_ca_path)) < 0) { LM_ERR("Error allocating query_params.tls_ca_path\n"); @@ -272,20 +266,17 @@ void notification_socket_cb(int fd, short event, void *arg) } } - query_params.body.s = NULL; - query_params.body.len = 0; if (aq->query_params.body.s && aq->query_params.body.len > 0) { if (shm_str_dup(&query_params.body, &(aq->query_params.body)) < 0) { LM_ERR("Error allocating query_params.body\n"); goto done; } } - - query_params.username = NULL; + if (aq->query_params.username) { len = strlen(aq->query_params.username); query_params.username = shm_malloc(len+1); - + if(query_params.username == NULL) { LM_ERR("error in shm_malloc\n"); goto done; @@ -294,12 +285,11 @@ void notification_socket_cb(int fd, short event, void *arg) strncpy(query_params.username, aq->query_params.username, len); query_params.username[len] = '\0'; } - - query_params.password = NULL; + if (aq->query_params.password) { len = strlen(aq->query_params.password); query_params.password = shm_malloc(len+1); - + if(query_params.password == NULL) { LM_ERR("error in shm_malloc\n"); goto done; @@ -342,7 +332,7 @@ void notification_socket_cb(int fd, short event, void *arg) shm_free(query_params.username); query_params.username = NULL; } - + if (query_params.password) { shm_free(query_params.password); query_params.password = NULL;

7 years, 10 months

git:master:08327019: core: parser - updated old log messages

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 08327019aa52f5386ed29e37a7cac6822f2b4276 URL: https://github.com/kamailio/kamailio/commit/08327019aa52f5386ed29e37a7cac68… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-29T17:52:40+01:00 core: parser - updated old log messages --- Modified: src/core/parser/parse_addr_spec.c Modified: src/core/parser/parse_cseq.c Modified: src/core/parser/parse_from.c Modified: src/core/parser/parse_param.c Modified: src/core/parser/parse_to.c --- Diff: https://github.com/kamailio/kamailio/commit/08327019aa52f5386ed29e37a7cac68… Patch: https://github.com/kamailio/kamailio/commit/08327019aa52f5386ed29e37a7cac68…

7 years, 10 months

← Newer
1
...
7
8
9
10
11
12
13
...
54
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2017