sr-dev November 2017

sr-dev@lists.kamailio.org

26 participants
481 discussions

git:master:8fbf7d83: lcr: exported load_gws() variants to kemi framework

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8fbf7d83b1dbeedf1ee53895aadbf6e99321432d URL: https://github.com/kamailio/kamailio/commit/8fbf7d83b1dbeedf1ee53895aadbf6e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-24T11:05:21+01:00 lcr: exported load_gws() variants to kemi framework --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/8fbf7d83b1dbeedf1ee53895aadbf6e… Patch: https://github.com/kamailio/kamailio/commit/8fbf7d83b1dbeedf1ee53895aadbf6e…

7 years

git:master:e8a79182: lcr: clang format the code

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e8a79182a76b306fad13c9cb12eb9f2c4c658b14 URL: https://github.com/kamailio/kamailio/commit/e8a79182a76b306fad13c9cb12eb9f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-24T11:05:21+01:00 lcr: clang format the code --- Modified: src/modules/lcr/hash.c Modified: src/modules/lcr/hash.h Modified: src/modules/lcr/lcr_mod.c Modified: src/modules/lcr/lcr_mod.h Modified: src/modules/lcr/lcr_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/e8a79182a76b306fad13c9cb12eb9f2… Patch: https://github.com/kamailio/kamailio/commit/e8a79182a76b306fad13c9cb12eb9f2…

7 years

Jenkins build became unstable: kamailio44-nightly-binaries » i386,wheezy,slave #122

by jenkins＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…>

7 years

Jenkins build became unstable: kamailio44-nightly-binaries » amd64,trusty,slave #122

by jenkins＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…>

7 years

Jenkins build became unstable: kamailio44-nightly-source » wheezy,master #123

by jenkins＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio44-nightly-source/distribution=whe…>

7 years

Jenkins build became unstable: kamailio44-nightly-source » trusty,master #123

by jenkins＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio44-nightly-source/distribution=tru…>

7 years

rfc: clang format the code

by Daniel-Constantin Mierla

Hello, it was discussed during the last irc devel meeting and everyone there agreed to use clang-format to format the source code: - https://clang.llvm.org/docs/ClangFormat.html Is any developer (maybe not present during the irc devel meeting) opposing this? It is not going to be all at once, because some of the structures and initialization of them may be preferred to be kept with a custom format for being easier to read -- to have a section in the file not formatted, it has to be enclosed in between comments: /* clang-format off */ ... /* clang-format o. */ But for the rest of the code (i.e., functions) I think it will be better to agree on a format and try to use it. The clang-formatting should be done when one needs to update code in some files. Over the years, developers come and go, having each one with a custom formatting style is hard to maintain properly in long term. There are modules that do not indent coherently code inside blocks, using a mixture, more or less no style. This makes it hard for other developers to review in case of reported issues, but also for new comers to get familiar with the code. In the source tree there is already a .clang-format file which defines the options for formatting. It was used by me and other developers already -- I did it mainly in my modules or those components that do not have an active maintainer. But I plan to do it also on the components that have currently a maintainer at the moment I need to work on that code (e.g., fix some issue or export functions to kemi framework). My process of clang-formatting a module is like: - edit the files to add clang-format off/on comments around the parts I want to preserve as they are (typically mod exports -- params, functions, kemi -- and intialization of structures that are aligned to a specific indentation that makes it easier to read). - run: clang-format -i src/modules/modname/*.{c,h} - commit with these changes, no new feature or bug fix must be done in the same commit (can be combined with removing the history comments) If one wants different options inside .clang-format, please propose and let's discuss which one is preferred by the majority of the current developers. If no one shows anything against in a matter of few days, it will be considered accepted (after all, one can re-indent on own style if the rule is not accepted or overturned). Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com

7 years