sr-dev November 2017

sr-dev@lists.kamailio.org

26 participants
481 discussions

git:master:bea0b53c: app_python: implemented rpc command to list kemi functions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: bea0b53ce57f08ab9fc019c19f616b3b67795d64 URL: https://github.com/kamailio/kamailio/commit/bea0b53ce57f08ab9fc019c19f616b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-23T12:45:25+01:00 app_python: implemented rpc command to list kemi functions - kamctl rpc app_python.api_list --- Modified: src/modules/app_python/app_python_mod.c Modified: src/modules/app_python/apy_kemi.c Modified: src/modules/app_python/apy_kemi.h --- Diff: https://github.com/kamailio/kamailio/commit/bea0b53ce57f08ab9fc019c19f616b3… Patch: https://github.com/kamailio/kamailio/commit/bea0b53ce57f08ab9fc019c19f616b3…

7 years

[kamailio/kamailio] rtpengine: fixed segfault when using read_sdp_pv (#1326)

by Phil Lavin

#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This was an odd one. I can't see how `read_sdp_pv` ever worked. When the old SDP is deleted with `del_lump` from the SIP `msg`, the lump pointer is calculated assuming that `body` is a pointer relative to `msg`. When `read_sdp_pv` is set, `body` pointer is set to something entirely different and doing pointer maths relative to `msg` causes integer overflows and results in a segfault on `del_lump`. This change explicitly gets the body pointer (`cur_body`) relative to `msg` before trying to `del_lump`. If it's preferable, I can have it only do this if `read_sdp_pv` is set but I figured it's not a heavy operation and it's safer to always do it. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1326 -- Commit Summary -- * rtpengine: fixed segfault when using read_sdp_pv -- File Changes -- M src/modules/rtpengine/rtpengine.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1326.patch https://github.com/kamailio/kamailio/pull/1326.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1326

7 years

git:master:76085672: Merge pull request #1326 from phil-lavin/bugfix-rtpengine-read-sdp

by GitHub

Module: kamailio Branch: master Commit: 76085672c0f00d8539ab16652d4404266ad8184c URL: https://github.com/kamailio/kamailio/commit/76085672c0f00d8539ab16652d44042… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-11-23T11:59:23+01:00 Merge pull request #1326 from phil-lavin/bugfix-rtpengine-read-sdp rtpengine: fixed segfault when using read_sdp_pv --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/76085672c0f00d8539ab16652d44042… Patch: https://github.com/kamailio/kamailio/commit/76085672c0f00d8539ab16652d44042… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index e3468d04a8..9704693eee 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3328,6 +3328,7 @@ rtpengine_offer_answer(struct sip_msg *msg, const char *flags, int op, int more) str body, newbody; struct lump *anchor; pv_value_t pv_val; + str cur_body = {0, 0}; dict = rtpp_function_call_ok(&bencbuf, msg, op, flags, &body); if (!dict) @@ -3357,7 +3358,12 @@ rtpengine_offer_answer(struct sip_msg *msg, const char *flags, int op, int more) pkg_free(newbody.s); } else { - anchor = del_lump(msg, body.s - msg->buf, body.len, 0); + /* get the body from the message as body ptr may have changed */ + cur_body.len = 0; + cur_body.s = get_body(msg); + cur_body.len = msg->buf + msg->len - cur_body.s; + + anchor = del_lump(msg, cur_body.s - msg->buf, cur_body.len, 0); if (!anchor) { LM_ERR("del_lump failed\n"); goto error_free;

7 years

git:master:36cb7534: rtpengine: fixed segfault when using read_sdp_pv

by Phil Lavin

Module: kamailio Branch: master Commit: 36cb753441a78bd13ded119cd468f32623f09fbf URL: https://github.com/kamailio/kamailio/commit/36cb753441a78bd13ded119cd468f32… Author: Phil Lavin <phil.lavin(a)cloudcall.com> Committer: Phil Lavin <phil.lavin(a)cloudcall.com> Date: 2017-11-23T10:22:42Z rtpengine: fixed segfault when using read_sdp_pv - Obtain body pointer fresh from the SIP message as when using read_sdp_pv the body pointer is overwritten --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/36cb753441a78bd13ded119cd468f32… Patch: https://github.com/kamailio/kamailio/commit/36cb753441a78bd13ded119cd468f32… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index e3468d04a8..9704693eee 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3328,6 +3328,7 @@ rtpengine_offer_answer(struct sip_msg *msg, const char *flags, int op, int more) str body, newbody; struct lump *anchor; pv_value_t pv_val; + str cur_body = {0, 0}; dict = rtpp_function_call_ok(&bencbuf, msg, op, flags, &body); if (!dict) @@ -3357,7 +3358,12 @@ rtpengine_offer_answer(struct sip_msg *msg, const char *flags, int op, int more) pkg_free(newbody.s); } else { - anchor = del_lump(msg, body.s - msg->buf, body.len, 0); + /* get the body from the message as body ptr may have changed */ + cur_body.len = 0; + cur_body.s = get_body(msg); + cur_body.len = msg->buf + msg->len - cur_body.s; + + anchor = del_lump(msg, cur_body.s - msg->buf, cur_body.len, 0); if (!anchor) { LM_ERR("del_lump failed\n"); goto error_free;

7 years

git:master:4bd1d70c: tm: fixed condition in via_matching()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4bd1d70c2804ee2a1d29bd911275aa241577cfc1 URL: https://github.com/kamailio/kamailio/commit/4bd1d70c2804ee2a1d29bd911275aa2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-23T11:49:36+01:00 tm: fixed condition in via_matching() - introduced in previous commit --- Modified: src/modules/tm/t_lookup.c --- Diff: https://github.com/kamailio/kamailio/commit/4bd1d70c2804ee2a1d29bd911275aa2… Patch: https://github.com/kamailio/kamailio/commit/4bd1d70c2804ee2a1d29bd911275aa2… --- diff --git a/src/modules/tm/t_lookup.c b/src/modules/tm/t_lookup.c index 98a7bf97b9..49d02111f1 100644 --- a/src/modules/tm/t_lookup.c +++ b/src/modules/tm/t_lookup.c @@ -264,11 +264,11 @@ static inline int via_matching( struct via_body *inv_via, ack_via->host.len)!=0) return 0; if (inv_via->port!=ack_via->port) { - if(!(inv_via->port==0 - && (ack_via->port==SIP_PORT || ack_via->port==SIPS_PORT))) + if(inv_via->port==0 + && ack_via->port!=SIP_PORT && ack_via->port!=SIPS_PORT) return 0; - if(!(ack_via->port==0 - && (inv_via->port==SIP_PORT || inv_via->port==SIPS_PORT))) + if(ack_via->port==0 + && inv_via->port!=SIP_PORT && inv_via->port!=SIPS_PORT) return 0; } if (inv_via->transport.len!=ack_via->transport.len) @@ -279,9 +279,9 @@ static inline int via_matching( struct via_body *inv_via, if (inv_via->port!=ack_via->port && (inv_via->port==0 || ack_via->port==0)) { - /* test SIPS_PORT (5061) is used with TLS transport*/ + /* test SIPS_PORT (5061) is used with TLS transport */ if(inv_via->port==SIPS_PORT || ack_via->port==SIPS_PORT) { - if(ack_via->transport.len!=3 + if(inv_via->transport.len!=3 || memcmp(inv_via->transport.s, "TLS", 3)!=0) { return 0; }

7 years

Jenkins build became unstable: kamailio50-nightly-binaries » amd64,xenial,slave #99

by jenkins＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio50-nightly-binaries/architecture=a…>

7 years

Jenkins build became unstable: kamailio50-nightly-binaries » i386,trusty,slave #99

by jenkins＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio50-nightly-binaries/architecture=i…>

7 years

Jenkins build became unstable: kamailio50-nightly-binaries » amd64,trusty,slave #99

by jenkins＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio50-nightly-binaries/architecture=a…>

7 years

[kamailio/kamailio] pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject (#1323)

by sergey-safarov

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1323 -- Commit Summary -- * pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject -- File Changes -- A .gitmodules (3) A pkg/docker (1) M pkg/kamailio/alpine/APKBUILD (1) D pkg/kamailio/alpine_docker/Dockerfile (5) D pkg/kamailio/alpine_docker/README.md (85) D pkg/kamailio/alpine_docker/build.sh (144) D pkg/kamailio/alpine_docker/hooks/pre_build (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1323.patch https://github.com/kamailio/kamailio/pull/1323.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1323

7 years

git:master:137e2896: Merge pull request #1323 from sergey-safarov/docker

by GitHub

Module: kamailio Branch: master Commit: 137e2896a5aa3be3f7a881354e476018db8802b4 URL: https://github.com/kamailio/kamailio/commit/137e2896a5aa3be3f7a881354e47601… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-11-23T10:34:20+01:00 Merge pull request #1323 from sergey-safarov/docker pkg/kamailio/alpine_docker: Alpine docker scripts moved to subproject --- Added: .gitmodules Added: pkg/docker Modified: pkg/kamailio/alpine/APKBUILD Removed: pkg/kamailio/alpine_docker/Dockerfile Removed: pkg/kamailio/alpine_docker/README.md Removed: pkg/kamailio/alpine_docker/build.sh Removed: pkg/kamailio/alpine_docker/hooks/pre_build --- Diff: https://github.com/kamailio/kamailio/commit/137e2896a5aa3be3f7a881354e47601… Patch: https://github.com/kamailio/kamailio/commit/137e2896a5aa3be3f7a881354e47601…

7 years

← Newer
1
...
20
21
22
23
24
25
26
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2017