sr-dev November 2018

sr-dev@lists.kamailio.org

22 participants
298 discussions

[kamailio/kamailio] tm: bad error in log (#1727)

by lazedo

### Description tm module writes a misleading log error that `triggers` ops alerts.  ### Troubleshooting #### Reproduction using this partial script ``` event_route[core:worker-one-init] { async_route("DEFERRED_CLEANUP", "20"); } route[DEFERRED_CLEANUP] { xlog("L_INFO", "processing deferred cleanup\n"); } ``` #### Log Messages  ``` 2018-11-15T19:22:44.547049+00:00 apps001 kamailio[2105]: INFO: <script>: processing deferred cleanup 2018-11-15T19:22:44.554085+00:00 apps001 kamailio[2105]: ERROR: tm [t_reply.c:551]: _reply_light(): no resolved dst to send reply to ``` ### Possible Solutions i silence the error with the below patch but i'm pretty sure its not the proper way to do it. ``` diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 8a95fe7..99c59db 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -548,7 +548,9 @@ * the chances for this increase a lot. */ if (unlikely(!trans->uas.response.dst.send_sock)) { - LM_ERR("no resolved dst to send reply to\n"); + if(is_local(trans)) { + LM_ERR("no resolved dst to send reply to\n"); + } } else { if (likely(SEND_PR_BUFFER( rb, buf, len )>=0)){ if (unlikely(code>=200 && !is_local(trans) && ```  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.0-dev0 (x86_64/linux) 37bff4-dirty flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. ``` * **Operating System**:  ``` Linux 2.6.32-754.el6.x86_64 #1 SMP Tue Jun 19 21:26:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1727

5 years, 8 months

[kamailio/kamailio] Wrong QOP value in UAC auth_alg (#1684)

by Sebastian Lauwers

### Description While trying to setup a handoff to a third party SIP trunk with authentication, I ran into some issues with said authentication. I'm using qop auth on the inbound leg (and `consume_credentials()`), and then UAC to authenticate against the SIP trunk with different credentials. The third party SIP trunk offers qop auth/auth-int. I manually tried to verify the digest that Kamailio was sending, but couldn't. I added some logging to the `auth_alg.c` file, and ran the whole thing again. HA1 is calculated correctly, and so is HA2. However, the final step of the algorithm produced an incorrect value. After further debugging, I realised that the issue comes from https://github.com/kamailio/kamailio/blob/master/src/modules/uac/auth_alg.c…. More specifically, in my case, the value passed on to `MD5Update` is `auth,auth-int`, instead of the simple `auth` I was expecting (uac doesn't support auth-int). ### Troubleshooting #### SIP Traffic I have PCAPs demonstrating the issue and the hack/fix below. I'd rather not post them publicly, however, I am happy to share them privately with Kamailio devs. In essence: ``` -> INVITE sip:12345@someprovider.org:5060;transport=tcp <- 401 Unauthorized WWW-Authenticate: Digest realm="someprovider.org", qop="auth,auth-int", nonce="5BCF48671749b873534dc63e76d5594f3988555f" -> INVITE sip:12345@someprovider.org:5060;transport=tcp Authorization: Digest username="redacted", realm="someprovider.org", nonce="5BCF48671749b873534dc63e76d5594f3988555f", uri="sip:12345@eu.out.didww.com:5060;transport=tcp", qop=auth, nc=00000001, cnonce="2106889321", response="redacted71d4c9ce119dcf3ec56209e", algorithm=MD5 ``` ### Possible Solutions The hack I've used for the time being is to replace: ```c MD5Update(&Md5Ctx, ":", 1); MD5Update(&Md5Ctx, auth->qop.s, auth->qop.len); MD5Update(&Md5Ctx, ":", 1); ``` with: ```c MD5Update(&Md5Ctx, ":auth:", 6); ``` Obviously, I realise this is not the correct fix, but I figured I'd let the experts fix the value of `auth->qop.len`. I can spend more time on this, if required, but I don't know exactly what the "correct" solution is. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 5.3.1 ``` * **Operating System**: Dockerized version of Kamailio on Ubuntu xenial: ``` kamailio/kamailio:5.1.6-xenial ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1684

5 years, 8 months

git:master:8b71c46b: async: return error if trying to execute for faked message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8b71c46ba0db05051ee24bf88491f00387e1ca8b URL: https://github.com/kamailio/kamailio/commit/8b71c46ba0db05051ee24bf88491f00… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T15:29:05+01:00 async: return error if trying to execute for faked message - GH #1727 --- Modified: src/modules/async/async_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/8b71c46ba0db05051ee24bf88491f00… Patch: https://github.com/kamailio/kamailio/commit/8b71c46ba0db05051ee24bf88491f00… --- diff --git a/src/modules/async/async_mod.c b/src/modules/async/async_mod.c index d039ea0bd1..88affb3bbd 100644 --- a/src/modules/async/async_mod.c +++ b/src/modules/async/async_mod.c @@ -28,6 +28,7 @@ #include "../../core/sr_module.h" #include "../../core/dprint.h" #include "../../core/ut.h" +#include "../../core/fmsg.h" #include "../../core/pvar.h" #include "../../core/timer_proc.h" #include "../../core/route_struct.h" @@ -153,6 +154,11 @@ static int w_async_sleep(sip_msg_t *msg, char *sec, char *str2) if(msg == NULL) return -1; + if(faked_msg_match(msg)) { + LM_ERR("invalid usage for faked message\n"); + return -1; + } + if(async_workers <= 0) { LM_ERR("no async mod timer workers (modparam missing?)\n"); return -1; @@ -210,6 +216,11 @@ int ki_async_route(sip_msg_t *msg, str *rn, int s) int ri; sr_kemi_eng_t *keng = NULL; + if(faked_msg_match(msg)) { + LM_ERR("invalid usage for faked message\n"); + return -1; + } + keng = sr_kemi_eng_get(); if(keng == NULL) { ri = route_lookup(&main_rt, rn->s); @@ -285,6 +296,11 @@ int ki_async_task_route(sip_msg_t *msg, str *rn) int ri; sr_kemi_eng_t *keng = NULL; + if(faked_msg_match(msg)) { + LM_ERR("invalid usage for faked message\n"); + return -1; + } + keng = sr_kemi_eng_get(); if(keng == NULL) { ri = route_lookup(&main_rt, rn->s);

5 years, 8 months

git:master:ab72c5e7: core: function to test if a msg structure is faked request

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ab72c5e7188266baef0da70f1aa7d7d28b6d077c URL: https://github.com/kamailio/kamailio/commit/ab72c5e7188266baef0da70f1aa7d7d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T15:29:05+01:00 core: function to test if a msg structure is faked request --- Modified: src/core/fmsg.c Modified: src/core/fmsg.h --- Diff: https://github.com/kamailio/kamailio/commit/ab72c5e7188266baef0da70f1aa7d7d… Patch: https://github.com/kamailio/kamailio/commit/ab72c5e7188266baef0da70f1aa7d7d… --- diff --git a/src/core/fmsg.c b/src/core/fmsg.c index 9a84954f0b..28d24cd116 100644 --- a/src/core/fmsg.c +++ b/src/core/fmsg.c @@ -103,3 +103,8 @@ sip_msg_t* faked_msg_get_next_clear(void) } return faked_msg_next_clear(); } + +int faked_msg_match(sip_msg_t *tmsg) +{ + return ( tmsg == &_faked_msg ) ? 1 : 0; +} diff --git a/src/core/fmsg.h b/src/core/fmsg.h index b279100269..99eb9f61b3 100644 --- a/src/core/fmsg.h +++ b/src/core/fmsg.h @@ -29,5 +29,6 @@ sip_msg_t* faked_msg_next(void); sip_msg_t* faked_msg_get_next(void); sip_msg_t* faked_msg_next_clear(void); sip_msg_t* faked_msg_get_next_clear(void); +int faked_msg_match(sip_msg_t *tmsg); #endif

5 years, 8 months

user login with domain

by Saranga Nagesh

Hi, How can i allow to register with multiple domains and restrict with ip address user should register to asterisk with domain which given to user extension how can i do that. Thanks & Best Regards, Nagesh Saranga

5 years, 8 months

[kamailio/kamailio] rr module is_direction("downstream") and $ruid("dir") always evaluate downstream to true. (#1729)

by Surendra Tiwari

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1729

5 years, 8 months

Still Failing: kamailio/kamailio#6676 (master - a98d06f)

by Travis CI

Build Update for kamailio/kamailio ------------------------------------- Build: #6676 Status: Still Failing Duration: 6 mins and 46 secs Commit: a98d06f (master) Author: Daniel-Constantin Mierla Message: Merge pull request #1730 from ycaner06/patch-11 textops: fixed get_body_part function for non-multipart contents error View the changeset: https://github.com/kamailio/kamailio/compare/70f7a0e39d03...a98d06fcd32a View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/456931169?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

5 years, 8 months

Still Failing: kamailio/kamailio#6675 (master - 70f7a0e)

by Travis CI

Build Update for kamailio/kamailio ------------------------------------- Build: #6675 Status: Still Failing Duration: 7 mins and 27 secs Commit: 70f7a0e (master) Author: Daniel-Constantin Mierla Message: kamctl: regenerated sql creation scripts View the changeset: https://github.com/kamailio/kamailio/compare/ed861cfe7f0f...70f7a0e39d03 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/456929684?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

5 years, 8 months

git:master:a98d06fc: Merge pull request #1730 from ycaner06/patch-11

by GitHub

Module: kamailio Branch: master Commit: a98d06fcd32a0f9aa48ccb12e9056fa84f9d739e URL: https://github.com/kamailio/kamailio/commit/a98d06fcd32a0f9aa48ccb12e9056fa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2018-11-19T12:57:26+01:00 Merge pull request #1730 from ycaner06/patch-11 textops: fixed get_body_part function for non-multipart contents error --- Modified: src/core/msg_translator.c Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/a98d06fcd32a0f9aa48ccb12e9056fa… Patch: https://github.com/kamailio/kamailio/commit/a98d06fcd32a0f9aa48ccb12e9056fa… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 83cdd134ca..a272aeb6bc 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -1713,7 +1713,7 @@ int get_boundary(struct sip_msg* msg, str* boundary) msg->content_type->body.len); if (params.s == NULL) { - LM_INFO("Content-Type hdr has no params <%.*s>\n", + LM_INFO("Content-Type hdr has no boundary params <%.*s>\n", msg->content_type->body.len, msg->content_type->body.s); return -1; } diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index 40827baeae..ff784642e5 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -2761,7 +2761,7 @@ static int ki_remove_multibody(sip_msg_t* msg, str* content_type) } if(get_boundary(msg, &boundary)!=0) { - LM_ERR("Cannot get boundary. Is body multipart?\n"); + LM_ERR("Cannot get boundary from Content type header. Is body multipart?\n"); return -1; } @@ -2851,18 +2851,23 @@ static int ki_get_body_part_helper(sip_msg_t* msg, str* ctype, pv_spec_t *dst, body.s = get_body(msg); if (body.s == 0) { - LM_ERR("failed to get the message body\n"); + LM_ERR("failed to get the content message body\n"); return -1; } body.len = msg->len - (int)(body.s - msg->buf); if (body.len == 0) { - LM_DBG("message body has zero length\n"); + LM_DBG("Content body has zero length\n"); return -1; } if(get_boundary(msg, &boundary)!=0) { - LM_ERR("Cannot get boundary. Is body multipart?\n"); - return -1; + LM_DBG("Content is not multipart so return all content body as string\n"); + memset(&val, 0, sizeof(pv_value_t)); + val.flags = PV_VAL_STR; + val.rs.s = body.s; + val.rs.len =body.len; + dst->setf(msg, &dst->pvp, (int)EQ_T, &val); + return 1; } start = body.s; @@ -2968,7 +2973,7 @@ static int get_body_part_helper(sip_msg_t* msg, char* ctype, char* ovar, int mod str content_type; if(ctype==0) { - LM_ERR("invalid parameters\n"); + LM_ERR("invalid Content-type parameters\n"); return -1; } @@ -3680,7 +3685,7 @@ int ki_in_list_prefix(sip_msg_t* _m, str* subject, str* list, str* vsep) { int sep; char *at, *past, *next_sep, *s; - + if(subject==NULL || subject->len<=0 || list==NULL || list->len<=0 || vsep==NULL || vsep->len<=0) return -1;

5 years, 8 months

git:master:2daa351d: core : add word to log get_boundary function

by GitHub

Module: kamailio Branch: master Commit: 2daa351dd0cf716284ff90cd57d2241ee97f165d URL: https://github.com/kamailio/kamailio/commit/2daa351dd0cf716284ff90cd57d2241… Author: Yasin CANER <ycaner06(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2018-11-19T10:00:40+03:00 core : add word to log get_boundary function added word to log for more understanding --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/2daa351dd0cf716284ff90cd57d2241… Patch: https://github.com/kamailio/kamailio/commit/2daa351dd0cf716284ff90cd57d2241… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 83cdd134ca..a272aeb6bc 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -1713,7 +1713,7 @@ int get_boundary(struct sip_msg* msg, str* boundary) msg->content_type->body.len); if (params.s == NULL) { - LM_INFO("Content-Type hdr has no params <%.*s>\n", + LM_INFO("Content-Type hdr has no boundary params <%.*s>\n", msg->content_type->body.len, msg->content_type->body.s); return -1; }

5 years, 8 months

← Newer
1
...
13
14
15
16
17
18
19
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2018