sr-dev November 2018

sr-dev@lists.kamailio.org

22 participants
298 discussions

git:master:95d56e98: siptrace: convert status code to string using static buffer function
by Daniel-Constantin Mierla 19 Nov '18

19 Nov '18

Module: kamailio Branch: master Commit: 95d56e986e90b0d9a7527d7fa026cb510b41d9c5 URL: https://github.com/kamailio/kamailio/commit/95d56e986e90b0d9a7527d7fa026cb5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T10:01:21+01:00 siptrace: convert status code to string using static buffer function --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/95d56e986e90b0d9a7527d7fa026cb5… Patch: https://github.com/kamailio/kamailio/commit/95d56e986e90b0d9a7527d7fa026cb5… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index d1d32661fa..7de96b4b5d 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1136,7 +1136,7 @@ static void trace_onreply_in(struct cell *t, int type, struct tmcb_params *ps) siptrace_data_t sto; sip_msg_t *msg; sip_msg_t *req; - char statusbuf[8]; + char statusbuf[INT2STR_MAX_LEN]; if(t == NULL || t->uas.request == 0 || ps == NULL) { LM_DBG("no uas request, local transaction\n"); @@ -1170,8 +1170,11 @@ static void trace_onreply_in(struct cell *t, int type, struct tmcb_params *ps) sto.method = get_cseq(msg)->method; - strcpy(statusbuf, int2str(ps->code, &sto.status.len)); - sto.status.s = statusbuf; + sto.status.s = int2strbuf(ps->code, statusbuf, INT2STR_MAX_LEN, &sto.status.len); + if(sto.status.s == 0) { + LM_ERR("failure to get the status string\n"); + return; + } sto.fromip.len = snprintf(sto.fromip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", siptrace_proto_name(msg->rcv.proto), @@ -1218,7 +1221,7 @@ static void trace_onreply_out(struct cell *t, int type, struct tmcb_params *ps) struct sip_msg *msg; struct sip_msg *req; struct ip_addr to_ip; - char statusbuf[8]; + char statusbuf[INT2STR_MAX_LEN]; dest_info_t *dst; if(t == NULL || t->uas.request == 0 || ps == NULL) { @@ -1293,8 +1296,11 @@ static void trace_onreply_out(struct cell *t, int type, struct tmcb_params *ps) } } - strcpy(statusbuf, int2str(ps->code, &sto.status.len)); - sto.status.s = statusbuf; + sto.status.s = int2strbuf(ps->code, statusbuf, INT2STR_MAX_LEN, &sto.status.len); + if(sto.status.s == 0) { + LM_ERR("failure to get the status string\n"); + return; + } memset(&to_ip, 0, sizeof(struct ip_addr)); dst = ps->dst; @@ -1341,7 +1347,7 @@ static void trace_sl_onreply_out(sl_cbp_t *slcbp) siptrace_data_t sto; sip_msg_t *msg; ip_addr_t to_ip; - char statusbuf[5]; + char statusbuf[INT2STR_MAX_LEN]; if(slcbp == NULL || slcbp->req == NULL) { LM_ERR("bad parameters\n"); @@ -1385,8 +1391,11 @@ static void trace_sl_onreply_out(sl_cbp_t *slcbp) } } - strcpy(statusbuf, int2str(slcbp->code, &sto.status.len)); - sto.status.s = statusbuf; + sto.status.s = int2strbuf(slcbp->code, statusbuf, INT2STR_MAX_LEN, &sto.status.len); + if(sto.status.s == 0) { + LM_ERR("failure to get the status string\n"); + return; + } memset(&to_ip, 0, sizeof(struct ip_addr)); if(slcbp->dst == 0) {

1 0

Still Failing: kamailio/kamailio#6670 (master - c571efe)
by Travis CI 19 Nov '18

19 Nov '18

Build Update for kamailio/kamailio ------------------------------------- Build: #6670 Status: Still Failing Duration: 6 mins and 3 secs Commit: c571efe (master) Author: Daniel-Constantin Mierla Message: smsops: free after error log message printing a field View the changeset: https://github.com/kamailio/kamailio/compare/372993c82d2e...c571efefebc3 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/456861437?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

git:master:c571efef: smsops: free after error log message printing a field
by Daniel-Constantin Mierla 19 Nov '18

19 Nov '18

Module: kamailio Branch: master Commit: c571efefebc305b2049eb55458cb0ac1dc3202bb URL: https://github.com/kamailio/kamailio/commit/c571efefebc305b2049eb55458cb0ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T09:47:58+01:00 smsops: free after error log message printing a field --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/c571efefebc305b2049eb55458cb0ac… Patch: https://github.com/kamailio/kamailio/commit/c571efefebc305b2049eb55458cb0ac… --- diff --git a/src/modules/smsops/smsops_impl.c b/src/modules/smsops/smsops_impl.c index 8150d081d6..8df667bb77 100644 --- a/src/modules/smsops/smsops_impl.c +++ b/src/modules/smsops/smsops_impl.c @@ -564,9 +564,9 @@ int decode_3gpp_sms(struct sip_msg *msg) { // Check for malicious length, which might cause buffer overflow if(udh_read + ie->data.len + 2 /* two octets are read so far */ > udh_len) { - pkg_free(ie); LM_ERR("IE Lenght for IE id %d is bigger than the remaining User-Data element!\n", ie->identifier); + pkg_free(ie); return -1; }

1 0

Still Failing: kamailio/kamailio#6668 (master - 372993c)
by Travis CI 19 Nov '18

19 Nov '18

Build Update for kamailio/kamailio ------------------------------------- Build: #6668 Status: Still Failing Duration: 5 mins and 56 secs Commit: 372993c (master) Author: Daniel-Constantin Mierla Message: tm: t_serial - safety check for searched xavps View the changeset: https://github.com/kamailio/kamailio/compare/78225d064a76...372993c82d2e View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/456854246?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

git:master:372993c8: tm: t_serial - safety check for searched xavps
by Daniel-Constantin Mierla 19 Nov '18

19 Nov '18

Module: kamailio Branch: master Commit: 372993c82d2ebdafe9f7e1a672a3e3141a8ae2f5 URL: https://github.com/kamailio/kamailio/commit/372993c82d2ebdafe9f7e1a672a3e31… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T09:24:39+01:00 tm: t_serial - safety check for searched xavps --- Modified: src/modules/tm/t_serial.c --- Diff: https://github.com/kamailio/kamailio/commit/372993c82d2ebdafe9f7e1a672a3e31… Patch: https://github.com/kamailio/kamailio/commit/372993c82d2ebdafe9f7e1a672a3e31… --- diff --git a/src/modules/tm/t_serial.c b/src/modules/tm/t_serial.c index 8f8ee0646d..68b8afc1c3 100644 --- a/src/modules/tm/t_serial.c +++ b/src/modules/tm/t_serial.c @@ -599,10 +599,18 @@ int ki_t_next_contacts(struct sip_msg* msg) xavp_rm(prev_xavp, NULL); vavp = xavp_get(&q_flag_name, xavp->val.v.xavp); - q_flag = vavp->val.v.i; + if(vavp) { + q_flag = vavp->val.v.i; + } else { + q_flag = 0; + } vavp = xavp_get(&uri_name, xavp->val.v.xavp); - uri = vavp->val.v.s; + if(vavp) { + uri = vavp->val.v.s; + } else { + uri.len = 0; + } vavp = xavp_get(&dst_uri_name, xavp->val.v.xavp); if (vavp != NULL) {

1 0

git:master:cb8d366d: db_redis: log message if failure to get reply
by Daniel-Constantin Mierla 19 Nov '18

19 Nov '18

Module: kamailio Branch: master Commit: cb8d366d6c5cc9a0af7159e8be65444ac23f47a1 URL: https://github.com/kamailio/kamailio/commit/cb8d366d6c5cc9a0af7159e8be65444… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T09:19:58+01:00 db_redis: log message if failure to get reply --- Modified: src/modules/db_redis/redis_connection.c --- Diff: https://github.com/kamailio/kamailio/commit/cb8d366d6c5cc9a0af7159e8be65444… Patch: https://github.com/kamailio/kamailio/commit/cb8d366d6c5cc9a0af7159e8be65444… --- diff --git a/src/modules/db_redis/redis_connection.c b/src/modules/db_redis/redis_connection.c index e030472d9e..6743a97cf1 100644 --- a/src/modules/db_redis/redis_connection.c +++ b/src/modules/db_redis/redis_connection.c @@ -394,7 +394,9 @@ void db_redis_consume_replies(km_redis_con_t *con) { redis_key_t *query; while (con->append_counter > 0 && con->con && !con->con->err) { LM_DBG("consuming outstanding reply %u", con->append_counter); - db_redis_get_reply(con, (void**)&reply); + if(db_redis_get_reply(con, (void**)&reply) != REDIS_OK) { + LM_DBG("failure to get the reply\n"); + } if (reply) { freeReplyObject(reply); reply = NULL;

1 0

Still Failing: kamailio/kamailio#6667 (master - 78225d0)
by Travis CI 19 Nov '18

19 Nov '18

Build Update for kamailio/kamailio ------------------------------------- Build: #6667 Status: Still Failing Duration: 6 mins and 16 secs Commit: 78225d0 (master) Author: Daniel-Constantin Mierla Message: htable: use local variable for name in log message instead of null htable pointer View the changeset: https://github.com/kamailio/kamailio/compare/f465d2410084...78225d064a76 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/456850836?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

git:master:78225d06: htable: use local variable for name in log message instead of null htable pointer
by Daniel-Constantin Mierla 19 Nov '18

19 Nov '18

Module: kamailio Branch: master Commit: 78225d064a76a5d5a3dbd198a4ae38f6423dd272 URL: https://github.com/kamailio/kamailio/commit/78225d064a76a5d5a3dbd198a4ae38f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T09:10:46+01:00 htable: use local variable for name in log message instead of null htable pointer --- Modified: src/modules/htable/ht_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/78225d064a76a5d5a3dbd198a4ae38f… Patch: https://github.com/kamailio/kamailio/commit/78225d064a76a5d5a3dbd198a4ae38f… --- diff --git a/src/modules/htable/ht_dmq.c b/src/modules/htable/ht_dmq.c index 33dd72e8d4..d5ff1af645 100644 --- a/src/modules/htable/ht_dmq.c +++ b/src/modules/htable/ht_dmq.c @@ -576,11 +576,15 @@ int ht_dmq_handle_sync(srjson_doc_t* jdoc) { } ht = ht_get_table(&htname); - if(ht==NULL) - LM_WARN("unable to get table %.*s\n", ht->name.len, ht->name.s); + if(ht==NULL) { + LM_WARN("unable to get table %.*s\n", + htname.len, (htname.s)?htname.s:""); + } - if (ht_set_cell_ex(ht, &cname, type, &val, 0, expire - now) < 0) - LM_WARN("unable to set cell %.*s in table %.*s\n", cname.len, cname.s, ht->name.len, ht->name.s); + if (ht_set_cell_ex(ht, &cname, type, &val, 0, expire - now) < 0) { + LM_WARN("unable to set cell %.*s in table %.*s\n", + cname.len, cname.s, ht->name.len, ht->name.s); + } cell = cell->next; }

1 0

git:master:e0256096: htable: init vars in ht_dmq_handle_sync() to avoid compile warnings
by Daniel-Constantin Mierla 19 Nov '18

19 Nov '18

Module: kamailio Branch: master Commit: e0256096742a1f86e571949a5ffcf5e453401977 URL: https://github.com/kamailio/kamailio/commit/e0256096742a1f86e571949a5ffcf5e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-19T09:07:33+01:00 htable: init vars in ht_dmq_handle_sync() to avoid compile warnings --- Modified: src/modules/htable/ht_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/e0256096742a1f86e571949a5ffcf5e… Patch: https://github.com/kamailio/kamailio/commit/e0256096742a1f86e571949a5ffcf5e… --- diff --git a/src/modules/htable/ht_dmq.c b/src/modules/htable/ht_dmq.c index f1fe069f17..33dd72e8d4 100644 --- a/src/modules/htable/ht_dmq.c +++ b/src/modules/htable/ht_dmq.c @@ -537,17 +537,16 @@ int ht_dmq_send_sync(dmq_node_t* node) { int ht_dmq_handle_sync(srjson_doc_t* jdoc) { LM_DBG("handling sync\n"); - srjson_t* cells; - srjson_t* cell; - srjson_t* it; - str htname; - str cname; - int type; - int_str val; - int expire; - ht_t* ht; - time_t now; - + srjson_t* cells = NULL; + srjson_t* cell = NULL; + srjson_t* it = NULL; + str htname = STR_NULL; + str cname = STR_NULL; + int type = 0; + int_str val = {0}; + int expire = 0; + ht_t* ht = NULL; + time_t now = 0; cells = jdoc->root->child; cell = cells->child;

1 0

[kamailio/kamailio] dispatcher : xavp_get fix in ds_update_dst (#1725)
by lazedo 17 Nov '18

17 Nov '18

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1725 -- Commit Summary -- * dispatcher : xavp_get fix in ds_update_dst -- File Changes -- M src/modules/dispatcher/dispatch.c (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1725.patch https://github.com/kamailio/kamailio/pull/1725.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1725

3 5

← Newer
1
...
15
16
17
18
19
20
21
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2018