sr-dev December 2018

sr-dev@lists.kamailio.org

23 participants
313 discussions

by Daniel-Constantin Mierla

With the season holiday just starting, it's again a good time to express my thanks and greetings to all the friends, developers and community members that made 2018 another great year for Kamailio project. Enjoy the holidays! Merry Christmas! Daniel * Santa is flying Kamailio! * -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - May 6-8, 2019 - www.kamailioworld.com

5 years, 6 months

[kamailio/kamailio] jsonrpcs_exec for the rtpengine cache gives memory leak (#1778)

by ovoshlook

### Description  We are buidling some kind of our own rtpengine dispatcher based on our own algorithm using kemi Lua. In one of the functions we are calling: `local reqBody = function(command, params) return json.encode({ jsonrpc = "2.0", method = "rtpengine." .. command, params = params }) end KSR.jsonrpcs.exec(reqBody("show", { "all" })) local data = json.decode(KSR.pv.get("$jsonrpl(body)")) ` And watching **free_mem** decrasing in case of every call of this function If we are commenting this - nothing happens P.S. We are doing the same for the dispatcher module but did not find memory leak for it: `local reqBody = function (command,params) return json.encode( { jsonrpc = "2.0", method = "dispatcher." ..command, params = params } ) end KSR.jsonrpcs.exec(reqBody( "list" ) ) local data = json.decode( KSR.pv.get("$jsonrpl(body)") ) ` ### Troubleshooting #### Reproduction To reproduce this issue suppose will be enough to call code above #### Debugging Data test results for 10000 calls total/300 per second (sipp based) memory stats on the start shmem:fragments = 2 | shmem:free_size = 63131408 shmem:max_used_size = 3994704 shmem:real_used_size = 3977456 shmem:total_size = 67108864 shmem:used_size = 3205144 memory stats on the end shmem:fragments = 5 | shmem:free_size = 60106232 shmem:max_used_size = 7019952 shmem:real_used_size = 7002632 shmem:total_size = 67108864 shmem:used_size = 4150008 ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) 7d1964 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 7d1964 compiled on 03:23:23 Oct 5 2018 with gcc 6.3.0 ``` * **Operating System**:  ``` 1 machine: SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux 2 machine: SMP Debian 4.9.110-3+deb9u2 (2018-08-13) x86_64 GNU/Linux ``` If will need any additional info just let me know P.S. We also tried to find what can give this behavior on the rtpengine.c but didn't figured out yet -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1778

5 years, 6 months

git:master:8afbefda: textops: pkg free pmatch for regex_substring()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8afbefda8b77db19f38c7f8984fe683c30ffc95d URL: https://github.com/kamailio/kamailio/commit/8afbefda8b77db19f38c7f8984fe683… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-24T14:04:16+01:00 textops: pkg free pmatch for regex_substring() --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/8afbefda8b77db19f38c7f8984fe683… Patch: https://github.com/kamailio/kamailio/commit/8afbefda8b77db19f38c7f8984fe683… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index abf8e3e785..ab7d894bdd 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -833,6 +833,7 @@ static int ki_regex_substring(sip_msg_t* msg, str *input, str *regex, if (0 != rc) { LM_ERR("regular experession coudnt be compiled, Error code: (%d)\n", rc); + pkg_free(pmatch); regfree(&preg); return -1; } @@ -841,12 +842,14 @@ static int ki_regex_substring(sip_msg_t* msg, str *input, str *regex, regfree(&preg); if(rc!=0) { LM_DBG("no matches\n"); + pkg_free(pmatch); return -2; } /* matched */ if (pmatch[mindex].rm_so==-1) { LM_WARN("invalid offset for regular expression result\n"); + pkg_free(pmatch); return -1; } @@ -855,6 +858,7 @@ static int ki_regex_substring(sip_msg_t* msg, str *input, str *regex, if (pmatch[mindex].rm_so==pmatch[mindex].rm_eo) { LM_WARN("Matched string is empty\n"); + pkg_free(pmatch); return -1; } @@ -863,6 +867,7 @@ static int ki_regex_substring(sip_msg_t* msg, str *input, str *regex, if(tempstr.s== NULL || tempstr.len<=0) { LM_WARN("matched token is null\n"); + pkg_free(pmatch); return -1; } @@ -871,6 +876,7 @@ static int ki_regex_substring(sip_msg_t* msg, str *input, str *regex, valx.rs.len=tempstr.len; LM_DBG("result: %.*s\n", valx.rs.len, valx.rs.s); pvresult->setf(msg, &pvresult->pvp, (int)EQ_T, &valx); + pkg_free(pmatch); return 1; }

5 years, 6 months

git:master:73842a6f: textops: proper parameter no for fixup_regex_substring()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 73842a6fc548ae79751f98bdaa717e95e46850e4 URL: https://github.com/kamailio/kamailio/commit/73842a6fc548ae79751f98bdaa717e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-24T14:01:15+01:00 textops: proper parameter no for fixup_regex_substring() --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/73842a6fc548ae79751f98bdaa717e9… Patch: https://github.com/kamailio/kamailio/commit/73842a6fc548ae79751f98bdaa717e9… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index 3db4626232..abf8e3e785 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -923,7 +923,7 @@ static int fixup_regex_substring(void** param, int param_no) return fixup_spve_all(param, param_no); } - if (param_no == 3 || param_no == 3) { + if (param_no == 3 || param_no == 4) { return fixup_igp_all(param, param_no); }

5 years, 6 months

git:5.2:1a3a485a: pkg/kamailio/deb: add kamailio-python3-modules

by Victor Seva

Module: kamailio Branch: 5.2 Commit: 1a3a485ac13218b4b34366b452428a34d1e2191d URL: https://github.com/kamailio/kamailio/commit/1a3a485ac13218b4b34366b452428a3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-24T09:46:23+01:00 pkg/kamailio/deb: add kamailio-python3-modules (cherry picked from commit c78a53004777f498fcef63ae74a11723da950625) --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/debian/backports/precise Modified: pkg/kamailio/deb/debian/backports/wheezy Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/debian/rules Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/jessie/rules Modified: pkg/kamailio/deb/precise/rules Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/trusty/rules Modified: pkg/kamailio/deb/wheezy/rules Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/1a3a485ac13218b4b34366b452428a3… Patch: https://github.com/kamailio/kamailio/commit/1a3a485ac13218b4b34366b452428a3…

5 years, 6 months

[kamailio/kamailio] Broken Kamailio repository for CentOS 7 (#1604)

by pwakano

### Description Centos RPM repo is generating Kamailio 5.0.7 packages that can't be installed ### Troubleshooting #### Reproduction By using the repo https://download.opensuse.org/repositories/home:/kamailio:/v5.0.x-rpms/Cent… when trying to install Kamailio 5.0.7, yum returns this error: ``` Downloading packages: Delta RPMs disabled because /usr/bin/applydeltarpm not installed. kamailio-5.0.7-3.el7.centos.x8 FAILED http://download.opensuse.org/repositories/home%3A/kamailio%3A/v5.0.x-rpms/C…: [Errno 14] HTTP Error 416 - Requested Range Not Satisfiable Trying other mirror. ``` #### Debugging Data #### Log Messages #### SIP Traffic ### Possible Solutions  ### Additional Information * **Operating System**: ``` $ cat /etc/redhat-release CentOS Linux release 7.4.1708 (Core) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1604

5 years, 6 months

Broken: kamailio/kamailio#6824 (master - c78a530)

by Travis CI

Build Update for kamailio/kamailio ------------------------------------- Build: #6824 Status: Broken Duration: 6 mins and 6 secs Commit: c78a530 (master) Author: Victor Seva Message: pkg/kamailio/deb: add kamailio-python3-modules View the changeset: https://github.com/kamailio/kamailio/compare/5ba65fcb0b7b...c78a53004777 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/471785053?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

5 years, 6 months

git:master:c78a5300: pkg/kamailio/deb: add kamailio-python3-modules

by Victor Seva

Module: kamailio Branch: master Commit: c78a53004777f498fcef63ae74a11723da950625 URL: https://github.com/kamailio/kamailio/commit/c78a53004777f498fcef63ae74a1172… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-24T08:50:11+01:00 pkg/kamailio/deb: add kamailio-python3-modules --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/debian/backports/precise Modified: pkg/kamailio/deb/debian/backports/wheezy Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/debian/rules Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/jessie/rules Modified: pkg/kamailio/deb/precise/rules Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/trusty/rules Modified: pkg/kamailio/deb/wheezy/rules Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/c78a53004777f498fcef63ae74a1172… Patch: https://github.com/kamailio/kamailio/commit/c78a53004777f498fcef63ae74a1172…

5 years, 6 months

git:master:5ba65fcb: core: cleanup, remove local_malloc/local_free #define in core

by Henning Westerholt

Module: kamailio Branch: master Commit: 5ba65fcb0b7bea9c79d83fdbc24239e7351e543d URL: https://github.com/kamailio/kamailio/commit/5ba65fcb0b7bea9c79d83fdbc24239e… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-23T22:50:43+01:00 core: cleanup, remove local_malloc/local_free #define in core - remove the unused local_malloc and local_free #define in the core - they were introduced in 2002 and not touched in the repository since this time - they pointed to pkg_malloc and pkg_free --- Modified: src/core/io_wait.c Modified: src/core/io_wait.h Modified: src/core/resolve.c Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/5ba65fcb0b7bea9c79d83fdbc24239e… Patch: https://github.com/kamailio/kamailio/commit/5ba65fcb0b7bea9c79d83fdbc24239e…

5 years, 6 months

git:master:e3ecad34: core: use generic PKG_MEM_ERROR, SHM_ERROR and _CRITICAL helper defines in core

by Henning Westerholt

Module: kamailio Branch: master Commit: e3ecad34bb13e72b16a4213e7ce785194e88c534 URL: https://github.com/kamailio/kamailio/commit/e3ecad34bb13e72b16a4213e7ce7851… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-23T22:37:22+01:00 core: use generic PKG_MEM_ERROR, SHM_ERROR and _CRITICAL helper defines in core - refactoring of the core to use generic PKG_MEM_ERROR, SHM_ERROR, PKG_MEM_CRITICAL, SHM_MEM_CRITICAL and SYS_MEM_ERROR helper defines - unify many different error messages in different spellings - add a few missing error handler for allocation errors after (found with a complete review of all memory allocation functions in core) - no other functional changes, change has been reviewed two times --- Modified: src/core/action.c Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/cfg/cfg.c Modified: src/core/cfg/cfg_ctx.c Modified: src/core/cfg/cfg_script.c Modified: src/core/cfg/cfg_select.c Modified: src/core/cfg/cfg_struct.c Modified: src/core/cfg_parser.c Modified: src/core/core_cmd.c Modified: src/core/counters.c Modified: src/core/data_lump.c Modified: src/core/data_lump_rpl.c Modified: src/core/dns_cache.c Modified: src/core/dset.c Modified: src/core/dst_blacklist.c Modified: src/core/error.c Modified: src/core/flags.c Modified: src/core/forward.c Modified: src/core/io_wait.c Modified: src/core/ip_addr.c Modified: src/core/kemi.c Modified: src/core/lock_alloc.h Modified: src/core/locking.c Modified: src/core/mod_fix.c Modified: src/core/modparam.c Modified: src/core/msg_translator.c Modified: src/core/name_alias.h Modified: src/core/nonsip_hooks.c Modified: src/core/parser/contact/contact.c Modified: src/core/parser/contact/parse_contact.c Modified: src/core/parser/digest/digest.c Modified: src/core/parser/msg_parser.c Modified: src/core/parser/parse_addr_spec.c Modified: src/core/parser/parse_allow.c Modified: src/core/parser/parse_content.c Modified: src/core/parser/parse_date.c Modified: src/core/parser/parse_disposition.c Modified: src/core/parser/parse_diversion.c Modified: src/core/parser/parse_event.c Modified: src/core/parser/parse_expires.c Modified: src/core/parser/parse_fline.c Modified: src/core/parser/parse_from.c Modified: src/core/parser/parse_identity.c Modified: src/core/parser/parse_identityinfo.c Modified: src/core/parser/parse_param.c Modified: src/core/parser/parse_ppi_pai.c Modified: src/core/parser/parse_refer_to.c Modified: src/core/parser/parse_require.c Modified: src/core/parser/parse_rpid.c Modified: src/core/parser/parse_rr.c Modified: src/core/parser/parse_sipifmatch.c Modified: src/core/parser/parse_subscription_state.c Modified: src/core/parser/parse_supported.c Modified: src/core/parser/parse_via.c Modified: src/core/parser/sdp/sdp.c Modified: src/core/parser/sdp/sdp_helpr_funcs.c Modified: src/core/ppcfg.c Modified: src/core/proxy.c Modified: src/core/pt.c Modified: src/core/pvapi.c Modified: src/core/re.c Modified: src/core/receive.c Modified: src/core/resolve.c Modified: src/core/route.c Modified: src/core/route_struct.c Modified: src/core/rpc_lookup.c Modified: src/core/rvalue.c Modified: src/core/script_cb.c Modified: src/core/select.c Modified: src/core/select_buf.c Modified: src/core/sip_msg_clone.c Modified: src/core/socket_info.c Modified: src/core/sr_module.c Modified: src/core/stats.c Modified: src/core/str.c Modified: src/core/str_hash.h Modified: src/core/switch.c Modified: src/core/tcp_main.c Modified: src/core/tcp_read.c Modified: src/core/timer.c Modified: src/core/timer_proc.c Modified: src/core/udp_server.c Modified: src/core/usr_avp.c Modified: src/core/ut.c Modified: src/core/xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/e3ecad34bb13e72b16a4213e7ce7851… Patch: https://github.com/kamailio/kamailio/commit/e3ecad34bb13e72b16a4213e7ce7851…

5 years, 6 months

← Newer
1
...
12
13
14
15
16
17
18
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2018