sr-dev December 2018

sr-dev@lists.kamailio.org

23 participants
314 discussions

git:master:1b610f18: secfilter: fix memmory leak on error
by Jose Luis Verdeguer 20 Dec '18

20 Dec '18

Module: kamailio Branch: master Commit: 1b610f186f2cab65453f74f58fa0cce9cf944b8b URL: https://github.com/kamailio/kamailio/commit/1b610f186f2cab65453f74f58fa0cce… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2018-12-20T10:51:03+01:00 secfilter: fix memmory leak on error --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:7b2175dd: secfilter: simplify secf_get_contact()
by Jose Luis Verdeguer 20 Dec '18

20 Dec '18

Module: kamailio Branch: master Commit: 7b2175dde6335926934e88b21533f8fa4cc5e7e3 URL: https://github.com/kamailio/kamailio/commit/7b2175dde6335926934e88b21533f8f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2018-12-20T10:51:03+01:00 secfilter: simplify secf_get_contact() --- Modified: src/modules/secfilter/secfilter_hdr.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]7b2175dde6335926934e88b21533f8f… Patch: https://github.com/kamailio/kamailio/commit/7b2175dde6335926934e88b21533f8f… --- diff --git a/src/modules/secfilter/secfilter_hdr.c b/src/modules/secfilter/secfilter_hdr.c index 4880b6a534..7e3a4feeb4 100644 --- a/src/modules/secfilter/secfilter_hdr.c +++ b/src/modules/secfilter/secfilter_hdr.c @@ -141,40 +141,32 @@ int secf_get_to(struct sip_msg *msg, str *name, str *user, str *domain) /* get 'contact' header */ int secf_get_contact(struct sip_msg *msg, str *user, str *domain) { - str contact = {NULL, 0}; - struct sip_uri parsed_uri; + struct sip_uri uri; + contact_t *contact; - if(msg == NULL) - return -1; - if(msg->contact == NULL) + if((parse_headers(msg, HDR_CONTACT_F, 0) == -1) || !msg->contact) + return 1; + + if(!msg->contact->parsed && parse_contact(msg->contact) < 0) { + LM_ERR("cannot parse the Contact header\n"); return 1; - if(!msg->contact->parsed && (parse_contact(msg->contact) < 0)) { - LM_ERR("Error parsing contact header (%.*s)\n", msg->contact->body.len, - msg->contact->body.s); - return -1; - } - if(((contact_body_t *)msg->contact->parsed)->contacts - && ((contact_body_t *)msg->contact->parsed)->contacts->uri.s != NULL - && ((contact_body_t *)msg->contact->parsed)->contacts->uri.len - > 0) { - contact.s = ((contact_body_t *)msg->contact->parsed)->contacts->uri.s; - contact.len = - ((contact_body_t *)msg->contact->parsed)->contacts->uri.len; } - if(contact.s == NULL) + + contact = ((contact_body_t *)msg->contact->parsed)->contacts; + if(!contact) { return 1; + } - if(parse_uri(contact.s, contact.len, &parsed_uri) < 0) { - LM_ERR("Error parsing contact uri header (%.*s)\n", contact.len, - contact.s); - return -1; + if(parse_uri(contact->uri.s, contact->uri.len, &uri) < 0) { + LM_ERR("cannot parse the Contact URI\n"); + return 1; } - user->s = parsed_uri.user.s; - user->len = parsed_uri.user.len; + user->s = uri.user.s; + user->len = uri.user.len; - domain->s = parsed_uri.host.s; - domain->len = parsed_uri.host.len; + domain->s = uri.host.s; + domain->len = uri.host.len; return 0; } [View Less]

1 0

git:master:6180cf1b: secfilter: reduce code copy&paste
by Jose Luis Verdeguer 20 Dec '18

20 Dec '18

Module: kamailio Branch: master Commit: 6180cf1b9ee1c5655c8915e7dfaca8e3b785eb90 URL: https://github.com/kamailio/kamailio/commit/6180cf1b9ee1c5655c8915e7dfaca8e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2018-12-20T10:51:03+01:00 secfilter: reduce code copy&paste --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:d8f595fe: core: fix compilation warnings
by Victor Seva 19 Dec '18

19 Dec '18

Module: kamailio Branch: master Commit: d8f595fe4bb4cec6049e86202b95e40ae849b165 URL: https://github.com/kamailio/kamailio/commit/d8f595fe4bb4cec6049e86202b95e40… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-20T00:26:20+01:00 core: fix compilation warnings > core/tcp_main.c:1135:13: warning: result of comparison of constant 18446744073709551615 with expression of type 'uint32_t' (aka '… [View More]

1 0

git:master:89e89e02: cnxcc: fix compilation warnings
by Victor Seva 19 Dec '18

19 Dec '18

Module: kamailio Branch: master Commit: 89e89e023d923d2dbec694509b9f958bbed6d3ad URL: https://github.com/kamailio/kamailio/commit/89e89e023d923d2dbec694509b9f958… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-20T00:16:25+01:00 cnxcc: fix compilation warnings > warning: field precision should have type 'int', but argument has type 'size_t' (aka 'unsigned long') [-Wformat] --- Modified: … [View More]

1 0

git:master:7d9d9fe2: ndb_redis: fix compilation warnings
by Victor Seva 19 Dec '18

19 Dec '18

Module: kamailio Branch: master Commit: 7d9d9fe21a121a38d4a3861ce252a1a485a35c71 URL: https://github.com/kamailio/kamailio/commit/7d9d9fe21a121a38d4a3861ce252a1a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-20T00:06:45+01:00 ndb_redis: fix compilation warnings > warning: field precision should have type 'int', but argument has type 'size_t' (aka 'unsigned long') [-Wformat] --- Modified:… [View More]

1 0

git:master:da18d99e: topos_redis: fix compilation warnings
by Victor Seva 19 Dec '18

19 Dec '18

Module: kamailio Branch: master Commit: da18d99e509c86ac21f04cf36184cadfe16fce83 URL: https://github.com/kamailio/kamailio/commit/da18d99e509c86ac21f04cf36184cad… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-20T00:09:39+01:00 topos_redis: fix compilation warnings > warning: field precision should have type 'int', but argument has type 'size_t' (aka 'unsigned long') [-Wformat] --- … [View More]

1 0

[kamailio/kamailio] secfilter: free initial struct of shared memory on mod_destroy (#1769)
by Victor Seva 19 Dec '18

19 Dec '18

seems that ``secf_data`` was never freed You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1769 -- Commit Summary -- * secfilter: free initial struct of shared memory on mod_destroy -- File Changes -- M src/modules/secfilter/secfilter.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1769.patch https://github.com/kamailio/kamailio/pull/1769.diff -- You are receiving this because you are subscribed to this … [View More]

2 1

git:master:eb374d71: secfilter: free initial struct of shared memory on mod_destroy
by Jose Luis Verdeguer 19 Dec '18

19 Dec '18

Module: kamailio Branch: master Commit: eb374d7167e9be15dca0a30a402418fb5993bf69 URL: https://github.com/kamailio/kamailio/commit/eb374d7167e9be15dca0a30a402418f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2018-12-19T18:43:28+01:00 secfilter: free initial struct of shared memory on mod_destroy --- Modified: src/modules/secfilter/secfilter.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:bfbbc231: secfilter: clang-format
by Victor Seva 19 Dec '18

19 Dec '18

Module: kamailio Branch: master Commit: bfbbc2311530a5d9ef0d2cde0aef01f652acbc93 URL: https://github.com/kamailio/kamailio/commit/bfbbc2311530a5d9ef0d2cde0aef01f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-19T18:18:54+01:00 secfilter: clang-format --- Modified: src/modules/secfilter/secfilter.c Modified: src/modules/secfilter/secfilter_db.c Modified: src/modules/secfilter/secfilter_rpc.c … [View More]

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2018