sr-dev January 2019

sr-dev@lists.kamailio.org

27 participants
301 discussions

[kamailio/kamailio] dialog: The result of this check is always false (#1791)
by Jose Luis Verdeguer 09 Jan '19

09 Jan '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #1783 #### Description  The result of this check is always false (or I think so because I always obtain 0!=8) and the function dlg_new_dialog() is never executed. The function dlg_new_dialog() must be executed to save the new dialog. In other case the cnxcc module (I don know if there are more modules affected) doesn't work. Can anyone review if this check is important, please? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1791 -- Commit Summary -- * dialog: The result of this check is always false and the function dlg_new_dialog() is never executed -- File Changes -- M src/modules/dialog/dlg_handlers.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1791.patch https://github.com/kamailio/kamailio/pull/1791.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1791

2 6

[kamailio/kamailio] Update for Readme Dispatcher module (#1800)
by Jurijs I 09 Jan '19

09 Jan '19

Update for Readme Dispatcher module. I added some minor comments for dispatcher module, what I think might be useful for somebody.   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1800 -- Commit Summary -- * Update for Readme Dispatcher module -- File Changes -- M src/modules/dispatcher/README (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1800.patch https://github.com/kamailio/kamailio/pull/1800.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1800

1 2

git:master:56e5e6a8: modules: readme files regenerated - cnxcc ... [skip ci]
by Kamailio Dev 09 Jan '19

09 Jan '19

Module: kamailio Branch: master Commit: 56e5e6a8fa06cb0cd4855df5f405f9a1d89e7123 URL: https://github.com/kamailio/kamailio/commit/56e5e6a8fa06cb0cd4855df5f405f9a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-01-09T14:16:38+01:00 modules: readme files regenerated - cnxcc ... [skip ci] --- Modified: src/modules/cnxcc/README --- Diff: https://github.com/kamailio/kamailio/commit/56e5e6a8fa06cb0cd4855df5f405f9a… Patch: https://github.com/kamailio/kamailio/commit/56e5e6a8fa06cb0cd4855df5f405f9a… --- diff --git a/src/modules/cnxcc/README b/src/modules/cnxcc/README index 24d73ddaf2..d2e317de72 100644 --- a/src/modules/cnxcc/README +++ b/src/modules/cnxcc/README @@ -415,12 +415,14 @@ route[CNXCC] { $var(client) = "test-client"; $var(credit) = "50"; + $var(connect_cost) = "3.0"; $var(cost_per_sec) = "0.5"; $var(i_pulse) = 30; $var(f_pulse) = 6; if (!cnxcc_set_max_credit("$var(client)", "$var(credit)", + "$var(connect_cost)", "$var(cost_per_sec)", "$var(i_pulse)", "$var(f_pulse)")) {

1 0

git:master:404f4037: dialog: do not require dlg_flag parameter to be set
by Daniel-Constantin Mierla 09 Jan '19

09 Jan '19

Module: kamailio Branch: master Commit: 404f403786478a917637186446bb285e8e32cc59 URL: https://github.com/kamailio/kamailio/commit/404f403786478a917637186446bb285… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-01-09T14:16:19+01:00 dialog: do not require dlg_flag parameter to be set - using dlg_manage() should be enough for tracking dialogs --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/404f403786478a917637186446bb285… Patch: https://github.com/kamailio/kamailio/commit/404f403786478a917637186446bb285… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index ce69fc94ca..497176a760 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -515,8 +515,8 @@ static int mod_init(void) return -1; /* param checkings */ - if (dlg_flag>MAX_FLAG) { - LM_ERR("invalid dlg flag %d!!\n",dlg_flag); + if (dlg_flag!=-1 && dlg_flag>MAX_FLAG) { + LM_ERR("invalid dlg flag %d!!\n", dlg_flag); return -1; } diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 96406bde35..c80ca7d59f 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -761,8 +761,10 @@ void dlg_onreq(struct cell* t, int type, struct tmcb_params *param) } } if (dlg==NULL) { - if((req->flags&dlg_flag_mask)!=dlg_flag_mask) + if((dlg_flag_mask==0) || (req->flags&dlg_flag_mask)!=dlg_flag_mask) { + LM_DBG("flag not set for creating a new dialog\n"); return; + } LM_DBG("dialog creation on config flag\n"); dlg_new_dialog(req, t, 1); dlg = dlg_get_ctx_dialog();

1 0

[kamailio/kamailio] cnxcc: fix example code in doc file adding the new parameter in the cnxcc_set_max_credit() function (#1799)
by Jose Luis Verdeguer 09 Jan '19

09 Jan '19

#### Description  fix example code in doc file adding the new parameter in the cnxcc_set_max_credit() function You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1799 -- Commit Summary -- * cnxcc: fix example code in doc file adding the new parameter [skip ci] -- File Changes -- M src/modules/cnxcc/doc/cnxcc_admin.xml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1799.patch https://github.com/kamailio/kamailio/pull/1799.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1799

1 1

git:master:25accffd: cnxcc: fix example code in doc file adding the new parameter [skip ci]
by Jose Luis Verdeguer 09 Jan '19

09 Jan '19

Module: kamailio Branch: master Commit: 25accffdbd9dab458e95125630b2129986656fd2 URL: https://github.com/kamailio/kamailio/commit/25accffdbd9dab458e95125630b2129… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2019-01-09T14:07:19+01:00 cnxcc: fix example code in doc file adding the new parameter [skip ci] --- Modified: src/modules/cnxcc/doc/cnxcc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/25accffdbd9dab458e95125630b2129… Patch: https://github.com/kamailio/kamailio/commit/25accffdbd9dab458e95125630b2129… --- diff --git a/src/modules/cnxcc/doc/cnxcc_admin.xml b/src/modules/cnxcc/doc/cnxcc_admin.xml index 4ffb81b449..4284437a8b 100644 --- a/src/modules/cnxcc/doc/cnxcc_admin.xml +++ b/src/modules/cnxcc/doc/cnxcc_admin.xml @@ -519,12 +519,14 @@ route[CNXCC] { $var(client) = "test-client"; $var(credit) = "50"; + $var(connect_cost) = "3.0"; $var(cost_per_sec) = "0.5"; $var(i_pulse) = 30; $var(f_pulse) = 6; if (!cnxcc_set_max_credit("$var(client)", "$var(credit)", + "$var(connect_cost)", "$var(cost_per_sec)", "$var(i_pulse)", "$var(f_pulse)")) {

1 0

[kamailio/kamailio] Wanted HTTP/2 parser (#1794)
by sergey-safarov 09 Jan '19

09 Jan '19

### Description Current `parser_fline.c` is not supports HTTP/2 protocol and generates errors like below This is happens because [`HTTP_VERSION`](https://github.com/kamailio/kamailio/blob/cfc89db53c087382c29d809dc0bc56f7351af2d1/src/core/parser/parse_fline.c#L102) macro designed to work only with [`HTTP/1.x`](https://github.com/kamailio/kamailio/blob/cfc89db53c087382c29d809dc0bc56f7351af2d1/src/core/parser/parse_fline.h#L49) protocol. ### Expected behavior Response from `HTTP/2` enabled server is parsed without error. #### Actual observed behavior ``` 246(251) ERROR: <core> [core/parser/parse_fline.c:257]: parse_first_line(): parse_first_line: bad message (offset: 11) 246(251) ERROR: <core> [core/parser/msg_parser.c:675]: parse_msg(): ERROR: parse_msg: message=<HTTP/2 200 date: Tue, 08 Jan 2019 15:12:16 GMT content-type: text/html; charset=UTF-8 server: Apache/2.4.37 (Amazon) OpenSSL/1.0.2k-fips PHP/7.2.11 cache-control: no-transform,public,max-age=300,s-maxage=900, no-cache, private set-cookie: laravel_session=eyJpdiI6ImZGbU96ajZPV2lkVGZLeHJFNlwvNEJ3PT0iLCJ2YWx1ZSI6IjZmdWdLT0JNNUNFU1ppRWtOTVlmTVphaG4yM25ZcHFWUmUrdlhpMXlYZ2dKK3NYT3JmeG82MkNrSW9VZHdhRkgiLCJtYWMiOiI5MmI1ZWY1YWY1ZDQ3N2Q5ZGMyNzY2OGM2M2ZmNGNlNmY1MGRmYzcyMDhkZTFjM2ZkOTFjMWJlNTRkZmM3MmJkIn0%3D; expires=Tue, 08-Jan-2019 18:12:16 GMT; Max-Age=10800; path=/; httponly access-control-allow-headers: origin, x-requested-with, content-type access-control-allow-methods: PUT, GET, POST, DELETE, OPTIONS {"type":"registration_update","error_code":200,"text_description":"registration_update request succedded","call_id":"FrrQl6Dp~l"}> ``` #### Debugging Data None #### Log Messages None #### SIP Traffic None ### Possible Solutions Not know by me ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` / # kamailio -v version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 03:24:34 Nov 23 2018 with gcc 8.2.0 ``` * **Operating System**: ``` / # cat /etc/os-release NAME="Alpine Linux" ID=alpine VERSION_ID=3.8.0 PRETTY_NAME="Alpine Linux v3.8" HOME_URL="http://alpinelinux.org" BUG_REPORT_URL="http://bugs.alpinelinux.org" ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1794

2 4

[kamailio/kamailio] dialog: Error registering a dialog that causes the cnxcc module doesn't work correctly (#1783)
by Jose Luis Verdeguer 09 Jan '19

09 Jan '19

### Description I have been checking the reason why the cnxcc module doesn't work and I have seen that the problem is in the dialog module. Cnxcc uses dialog callback functions to obtain the data of the new dialogs. However there is a check that always gives incorrect and the creation of the new dialog is never executed. The check is this: ``` if((req->flags&dlg_flag_mask)!=dlg_flag_mask) return; LM_DBG("dialog creation on config flag\n"); dlg_new_dialog(req, t, 1); dlg = dlg_get_ctx_dialog(); ```  I don't know is this check is important and I don't know if this is the best solution but removing this check the cnxcc module works fine for me. ``` diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 96406bde3..ddfdffc27 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -761,8 +761,6 @@ void dlg_onreq(struct cell* t, int type, struct tmcb_params *param) } } if (dlg==NULL) { - if((req->flags&dlg_flag_mask)!=dlg_flag_mask) - return; LM_DBG("dialog creation on config flag\n"); dlg_new_dialog(req, t, 1); dlg = dlg_get_ctx_dialog(); ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.0-dev1 (x86_64/linux) eb3fd4-dirty flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: eb3fd4 -dirty compiled on 14:06:31 Jan 2 2019 with gcc 6.3.0 ``` * **Operating System**:  ``` Linux pepelux 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1783

1 2

git:5.2:ead1feb8: tm: Add fixup for PVS in fixup_t_check_status
by Hugh Waite 09 Jan '19

09 Jan '19

Module: kamailio Branch: 5.2 Commit: ead1feb83283dc9c4875f8d6afd57eea4359f64a URL: https://github.com/kamailio/kamailio/commit/ead1feb83283dc9c4875f8d6afd57ee… Author: Hugh Waite <hughw273(a)gmail.com> Committer: Hugh Waite <hughw273(a)gmail.com> Date: 2019-01-09T10:18:53Z tm: Add fixup for PVS in fixup_t_check_status - Allows PVs including $avp(...) to be passed to t_check_status --- Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/ead1feb83283dc9c4875f8d6afd57ee… Patch: https://github.com/kamailio/kamailio/commit/ead1feb83283dc9c4875f8d6afd57ee… --- diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 49db7d4507..c8afee9c4c 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -664,6 +664,9 @@ static int fixup_t_check_status(void** param, int param_no) { int ret; + ret = fix_param(FPARAM_PVS, param); + if (ret <= 0) return ret; + ret = fix_param(FPARAM_AVP, param); if (ret <= 0) return ret;

1 0

git:5.1:440ba8f9: tm: Add fixup for PVS in fixup_t_check_status
by Hugh Waite 09 Jan '19

09 Jan '19

Module: kamailio Branch: 5.1 Commit: 440ba8f9b37c61a6f631a5a8a0552a2215128fad URL: https://github.com/kamailio/kamailio/commit/440ba8f9b37c61a6f631a5a8a0552a2… Author: Hugh Waite <hughw273(a)gmail.com> Committer: Hugh Waite <hughw273(a)gmail.com> Date: 2019-01-09T10:19:19Z tm: Add fixup for PVS in fixup_t_check_status - Allows PVs including $avp(...) to be passed to t_check_status --- Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/440ba8f9b37c61a6f631a5a8a0552a2… Patch: https://github.com/kamailio/kamailio/commit/440ba8f9b37c61a6f631a5a8a0552a2… --- diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index da569ad832..14860635a8 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -662,6 +662,9 @@ static int fixup_t_check_status(void** param, int param_no) { int ret; + ret = fix_param(FPARAM_PVS, param); + if (ret <= 0) return ret; + ret = fix_param(FPARAM_AVP, param); if (ret <= 0) return ret;

1 0

← Newer
1
...
22
23
24
25
26
27
28
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2019