sr-dev January 2019

sr-dev@lists.kamailio.org

27 participants
302 discussions

git:master:c740e2f3: tm: Add fixup for PVS in fixup_t_check_status
by Hugh Waite 08 Jan '19

08 Jan '19

Module: kamailio Branch: master Commit: c740e2f3da746c2f8c6f488fa926dc5d348ea43a URL: https://github.com/kamailio/kamailio/commit/c740e2f3da746c2f8c6f488fa926dc5… Author: Hugh Waite <hugh.waite(a)newvoicemedia.com> Committer: Hugh Waite <hugh.waite(a)newvoicemedia.com> Date: 2019-01-04T16:02:09Z tm: Add fixup for PVS in fixup_t_check_status - Allows PVs including $avp(...) to be passed to t_check_status --- Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/c740e2f3da746c2f8c6f488fa926dc5… Patch: https://github.com/kamailio/kamailio/commit/c740e2f3da746c2f8c6f488fa926dc5… --- diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 49db7d4507..c8afee9c4c 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -664,6 +664,9 @@ static int fixup_t_check_status(void** param, int param_no) { int ret; + ret = fix_param(FPARAM_PVS, param); + if (ret <= 0) return ret; + ret = fix_param(FPARAM_AVP, param); if (ret <= 0) return ret;

1 0

git:master:ae0797ee: Merge pull request #1796 from que273/master
by GitHub 08 Jan '19

08 Jan '19

Module: kamailio Branch: master Commit: ae0797ee8e2519d2bf3399c494642ffd3db2f9f9 URL: https://github.com/kamailio/kamailio/commit/ae0797ee8e2519d2bf3399c494642ff… Author: Hugh Waite <que273(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2019-01-08T17:04:05Z Merge pull request #1796 from que273/master tm: Add fixup for PVS in fixup_t_check_status --- Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/ae0797ee8e2519d2bf3399c494642ff… Patch: https://github.com/kamailio/kamailio/commit/ae0797ee8e2519d2bf3399c494642ff… --- diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c index 49db7d4507..c8afee9c4c 100644 --- a/src/modules/tm/tm.c +++ b/src/modules/tm/tm.c @@ -664,6 +664,9 @@ static int fixup_t_check_status(void** param, int param_no) { int ret; + ret = fix_param(FPARAM_PVS, param); + if (ret <= 0) return ret; + ret = fix_param(FPARAM_AVP, param); if (ret <= 0) return ret;

1 0

[kamailio/kamailio] tm: Add fixup for PVS in fixup_t_check_status (#1796)
by Hugh Waite 08 Jan '19

08 Jan '19

- Allows PVs including $avp(...) to be passed to t_check_status   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #1795 #### Description Allows $avp(...) in the parameter to t_check_status You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1796 -- Commit Summary -- * tm: Add fixup for PVS in fixup_t_check_status -- File Changes -- M src/modules/tm/tm.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1796.patch https://github.com/kamailio/kamailio/pull/1796.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1796

2 2

Re: [sr-dev] [kamailio/kamailio] topos_redis: check the branch value to avoid using uninitialized fields (cfc89db)
by dtryba 08 Jan '19

08 Jan '19

I'll try this patch on the affected machines. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/cfc89db53c087382c29d809dc0bc56f…

1 0

[kamailio/kamailio] 5.1.6 tps_redis_load_branch SIGSEGV (#1784)
by dtryba 08 Jan '19

08 Jan '19

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1784

2 4

git:5.1:74b8fbf0: topos_redis: check the branch value to avoid using uninitialized fields
by Daniel-Constantin Mierla 08 Jan '19

08 Jan '19

Module: kamailio Branch: 5.1 Commit: 74b8fbf0fc820d48a0203b81d2cd41f6e84dc5c5 URL: https://github.com/kamailio/kamailio/commit/74b8fbf0fc820d48a0203b81d2cd41f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-01-08T15:18:22+01:00 topos_redis: check the branch value to avoid using uninitialized fields - GH #1784 (cherry picked from commit cfc89db53c087382c29d809dc0bc56f7351af2d1) (cherry picked from commit 7c551812960dd1cfc2901a7a46bbf3010df47cd7) --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/74b8fbf0fc820d48a0203b81d2cd41f… Patch: https://github.com/kamailio/kamailio/commit/74b8fbf0fc820d48a0203b81d2cd41f… --- diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c index 22279e0138..a72dd7c266 100644 --- a/src/modules/topos_redis/topos_redis_storage.c +++ b/src/modules/topos_redis/topos_redis_storage.c @@ -737,8 +737,13 @@ int tps_redis_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, LM_ERR("failed to load the INVITE branch value\n"); return -1; } + memset(&id, 0, sizeof(tps_data_t)); xvbranch1 = &id.x_vbranch1; } + if(xvbranch1->len<=0 || xvbranch1->s==NULL) { + LM_DBG("branch value not found (mode: %u)\n", mode); + return 1; + } rp = _tps_redis_cbuf; memcpy(rp, _tps_redis_bprefix.s, _tps_redis_bprefix.len); memcpy(rp + _tps_redis_bprefix.len,

1 0

git:5.2:7c551812: topos_redis: check the branch value to avoid using uninitialized fields
by Daniel-Constantin Mierla 08 Jan '19

08 Jan '19

Module: kamailio Branch: 5.2 Commit: 7c551812960dd1cfc2901a7a46bbf3010df47cd7 URL: https://github.com/kamailio/kamailio/commit/7c551812960dd1cfc2901a7a46bbf30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-01-08T15:17:28+01:00 topos_redis: check the branch value to avoid using uninitialized fields - GH #1784 (cherry picked from commit cfc89db53c087382c29d809dc0bc56f7351af2d1) --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/7c551812960dd1cfc2901a7a46bbf30… Patch: https://github.com/kamailio/kamailio/commit/7c551812960dd1cfc2901a7a46bbf30… --- diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c index 2f78d21dce..ed8a7616dc 100644 --- a/src/modules/topos_redis/topos_redis_storage.c +++ b/src/modules/topos_redis/topos_redis_storage.c @@ -737,8 +737,13 @@ int tps_redis_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, LM_ERR("failed to load the INVITE branch value\n"); return -1; } + memset(&id, 0, sizeof(tps_data_t)); xvbranch1 = &id.x_vbranch1; } + if(xvbranch1->len<=0 || xvbranch1->s==NULL) { + LM_DBG("branch value not found (mode: %u)\n", mode); + return 1; + } rp = _tps_redis_cbuf; memcpy(rp, _tps_redis_bprefix.s, _tps_redis_bprefix.len); memcpy(rp + _tps_redis_bprefix.len,

1 0

git:master:cfc89db5: topos_redis: check the branch value to avoid using uninitialized fields
by Daniel-Constantin Mierla 08 Jan '19

08 Jan '19

Module: kamailio Branch: master Commit: cfc89db53c087382c29d809dc0bc56f7351af2d1 URL: https://github.com/kamailio/kamailio/commit/cfc89db53c087382c29d809dc0bc56f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-01-08T12:24:27+01:00 topos_redis: check the branch value to avoid using uninitialized fields - GH #1784 --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/cfc89db53c087382c29d809dc0bc56f… Patch: https://github.com/kamailio/kamailio/commit/cfc89db53c087382c29d809dc0bc56f… --- diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c index 2f78d21dce..ed8a7616dc 100644 --- a/src/modules/topos_redis/topos_redis_storage.c +++ b/src/modules/topos_redis/topos_redis_storage.c @@ -737,8 +737,13 @@ int tps_redis_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, LM_ERR("failed to load the INVITE branch value\n"); return -1; } + memset(&id, 0, sizeof(tps_data_t)); xvbranch1 = &id.x_vbranch1; } + if(xvbranch1->len<=0 || xvbranch1->s==NULL) { + LM_DBG("branch value not found (mode: %u)\n", mode); + return 1; + } rp = _tps_redis_cbuf; memcpy(rp, _tps_redis_bprefix.s, _tps_redis_bprefix.len); memcpy(rp + _tps_redis_bprefix.len,

1 0

[kamailio/kamailio] Pepelux/cnxcc (#1790)
by Jose Luis Verdeguer 07 Jan '19

07 Jan '19

#### Description  Only a correction in doc file You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1790 -- Commit Summary -- * cnxcc: New improvement for the cnxcc module. With this changes it is possible to account the connect cost for the call. This is useful for calls to premium numbers that have connection charges * Merge branch 'master' of github.com:kamailio/kamailio into pepelux/cnxcc * Merge branch 'master' of github.com:kamailio/kamailio into pepelux/cnxcc * Merge branch 'master' of github.com:kamailio/kamailio into pepelux/cnxcc -- File Changes -- -- Patch Links -- https://github.com/kamailio/kamailio/pull/1790.patch https://github.com/kamailio/kamailio/pull/1790.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1790

1 1

git:5.2:06610073: acc_json: proper check if the mqueue name is set and the module can be loaded
by Daniel-Constantin Mierla 07 Jan '19

07 Jan '19

Module: kamailio Branch: 5.2 Commit: 06610073bb490355d87a774a74716195d3c01192 URL: https://github.com/kamailio/kamailio/commit/06610073bb490355d87a774a7471619… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-01-07T15:36:15+01:00 acc_json: proper check if the mqueue name is set and the module can be loaded (cherry picked from commit 7ce278d8accaaaa2b9c4b8fa349672826b5511f7) --- Modified: src/modules/acc_json/acc_json_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/06610073bb490355d87a774a7471619… Patch: https://github.com/kamailio/kamailio/commit/06610073bb490355d87a774a7471619… --- diff --git a/src/modules/acc_json/acc_json_mod.c b/src/modules/acc_json/acc_json_mod.c index 908d7d0eb9..55f2bb11f9 100644 --- a/src/modules/acc_json/acc_json_mod.c +++ b/src/modules/acc_json/acc_json_mod.c @@ -115,7 +115,8 @@ static int mod_init(void) if(output_mqueue_str && (load_mq_api(&mq_api) != 0)) { LM_ERR("can't load mqueue module API, disabling json acc to mqueue\n"); output_mqueue_str = NULL; - } else { + } + if(output_mqueue_str) { q_name.s = output_mqueue_str; q_name.len = strlen(output_mqueue_str); }

1 0

← Newer
1
...
24
25
26
27
28
29
30
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2019