I tried to implement dynamic registering/unregistering of siptrace
module sl callbacks, but it turned out that sl module lacks API function
to unregister a callback.
-- Juha
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #1208
#### Description
p->headers.t is dynamically allocated header_list_add() in and should be freed with free_async_query().
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1407
-- Commit Summary --
* http_async_client: memory mismanagement
-- File Changes --
M src/modules/http_async_client/async_http.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1407.patchhttps://github.com/kamailio/kamailio/pull/1407.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1407
#### Pre-Submission Checklist
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
The FHS 3.0 ([/run](https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s15.html) and [/var/run](https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s13.html)) has deprecated /var/run in favor of /run. Current distributions have done so for a long time (for example in Debian since 6.0 “squeeze”), even though they provide a compatibility symlink from /var/run to /run. But software like systemd have started emitting warnings when using /var/run, for example for its PIDFile directive, which pollute the logs.
I've included a change to a man page, because even though it looks like a similar case to the READMEs, I didn't find any part of the build system generating 8 section man pages. And I've not split this into components, as it is a global change, and seems preferable to have an atomic and bisectable commit.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2110
-- Commit Summary --
* all: Switch from deprecated /var/run to /run
-- File Changes --
M doc/scripts/cdefs2doc/dump_cfg_defs.pl (2)
M doc/scripts/cdefs2doc/dump_counters.pl (2)
M doc/scripts/cdefs2doc/dump_rpcs.pl (2)
M doc/scripts/cdefs2doc/dump_selects.pl (2)
M doc/tutorials/cfg_list/Makefile (2)
M doc/tutorials/counter_list/Makefile (2)
M doc/tutorials/rpc_list/Makefile (2)
M doc/tutorials/select_list/Makefile (2)
M etc/kamailio.cfg (6)
M misc/examples/ims/icscf/kamailio.cfg (6)
M misc/examples/ims/pcscf/kamailio.cfg (6)
M misc/examples/ims/scscf/kamailio.cfg (6)
M misc/examples/kemi/kamailio-basic-kemi.cfg (6)
M misc/examples/mixed/kamailio-minimal-anycast.cfg (6)
M misc/examples/mixed/kamailio-minimal-proxy.cfg (6)
M misc/examples/pkg/kamailio-basic.cfg (6)
M misc/examples/pkg/kamailio-oob.cfg (6)
M misc/examples/scripts/sr (2)
M misc/examples/webrtc/kamailio-default-websocket.cfg (6)
M pkg/kamailio/alpine/APKBUILD (4)
M pkg/kamailio/alpine/kamailio.initd (4)
M pkg/kamailio/deb/bionic/kamailio.postinst (2)
M pkg/kamailio/deb/bionic/rules (2)
M pkg/kamailio/deb/buster/kamailio.postinst (2)
M pkg/kamailio/deb/buster/rules (2)
M pkg/kamailio/deb/debian/kamailio.postinst (2)
M pkg/kamailio/deb/debian/rules (2)
M pkg/kamailio/deb/jessie/kamailio.postinst (2)
M pkg/kamailio/deb/jessie/rules (2)
M pkg/kamailio/deb/precise/kamailio.postinst (2)
M pkg/kamailio/deb/precise/rules (2)
M pkg/kamailio/deb/sid/kamailio.postinst (2)
M pkg/kamailio/deb/sid/rules (2)
M pkg/kamailio/deb/stretch/kamailio.postinst (2)
M pkg/kamailio/deb/stretch/rules (2)
M pkg/kamailio/deb/trusty/kamailio.postinst (2)
M pkg/kamailio/deb/trusty/rules (2)
M pkg/kamailio/deb/wheezy/kamailio.postinst (2)
M pkg/kamailio/deb/wheezy/rules (2)
M pkg/kamailio/deb/xenial/kamailio.postinst (2)
M pkg/kamailio/deb/xenial/rules (2)
M pkg/kamailio/obs/kamailio.init (8)
M pkg/kamailio/obs/kamailio.service (2)
M pkg/kamailio/openbsd/patches/patch-scripts_kamctlrc (4)
M pkg/kamailio/oracle/el6/kamailio.init (4)
M pkg/kamailio/oracle/el7/kamailio.service (4)
M pkg/kamailio/oracle/el7/kamailio.sysconfig (2)
M pkg/kamailio/oracle/kamailio.logrotate (2)
M src/Makefile (34)
M src/modules/call_control/call_control.c (2)
M src/modules/call_control/doc/call_control.8 (4)
M src/modules/call_control/doc/call_control_admin.xml (4)
M src/modules/cfgt/doc/cfgt_admin.xml (2)
M src/modules/ctl/ctl.cfg (2)
M src/modules/ctl/doc/ctl.xml (4)
M src/modules/ctl/doc/ctl_params.xml (4)
M src/modules/ctl/doc/ctl_rpc.xml (4)
M src/modules/db_mysql/doc/db_mysql_admin.xml (2)
M src/modules/dispatcher/doc/dispatcher_admin.xml (2)
M src/modules/ims_diameter_server/examples/kamailio.cfg (2)
M src/modules/ims_ocs/examples/full/kamailio.cfg (4)
M src/modules/ims_ocs/examples/simple/kamailio.cfg (4)
M src/modules/mediaproxy/doc/mediaproxy_admin.xml (4)
M src/modules/mediaproxy/mediaproxy.c (2)
M src/modules/nat_traversal/doc/nat_traversal_admin.xml (2)
M src/modules/sipdump/doc/sipdump_admin.xml (2)
M test/unit/7.cfg (2)
M utils/kamctl/kamctl.base (2)
M utils/kamctl/kamctl.rpcfifo (2)
M utils/kamctl/kamctlrc (6)
M utils/pdbt/debian/pdb-server.init.d (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2110.patchhttps://github.com/kamailio/kamailio/pull/2110.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2110
Daniel-Constantin Mierla writes:
> There is also a rpc command to turn tracinf on/off, but it doesn't
> affect the trace_mode=1. Again, for the next major release we should
> revise and make those options work for all variants: mirroring or save
> to db, with control via modparams and rpc...
I looked at the code and looks like callbacks are not
unregistered/registered again when tracing is turned off/on by rpc
command. Doesn't that affect performance negatively?
-- Juha
Hello,
after couple of months waiting for feedback about the workaround with the
preloaded shared library to set the PTHREAD_PROCESS_SHARED attribute for
pthread mutex/rwlock in order to avoid deadlocks and as it seems to be the
solution, I just pushed a few commits to move that code in the core of
kamailio.
It this way the initialization with the PTHREAD_PROCESS_SHARED attribute is
done by default when libssl v1.1 is detected at compile time, without the
need of using the approach with a preloaded library.
The shared library is still kept in the tls module:
*
https://github.com/kamailio/kamailio/tree/master/src/modules/tls/utils/open…
Probably is going to be removed in the near future.
I am asking the community members that use Kamailio on systems with libssl
v1.1+ to test the master branch and give feedback. The master branch is
anyhow in testing phase for preparing the next major release v5.3.0, so it
will help for that as well.
If no issue is going to be reported soon, the commits will be backported to
stable branches, to re-enable smooth use of Kamailio with libssl v1.1+.
When libssl v1.1+ is detected, the core links with pthread, but that was
already present in the Makefiles.defs for different compile options. The
pthread more or less a default library on linuxes/unixes, so this should
not introduce any major dependency to the Kamailio core.
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
- URL: https://github.com/kamailio/kamailio/commit/f66b2dd426e3436f9b4f6beed103049…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
kamctl: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/0d97878f03a6e7bd67aa8831a0c4c2d…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
doc/: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/e29dce787fde168166e2b7f8cf6320c…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2019-10-25T12:00:46+02:00
etc/kamailio.cfg: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/9c8021e8610d36895e732b557a0bd6f…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
misc/examples: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/cbf9f0dd213311613dced20e9dca8d4…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
pkg/deb: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/475a54cb04c0594c3fdaffb0a07d370…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
pkg: rpm, alpine - switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/296eb91192774c9e13312209c046c3a…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
utils/pdbt: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/e2d6074eca8b2592dec16e0eebc42a7…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
test: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/3a099381bcdfc5e0f27653b810309eb…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
src/Makefile: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/2c23d3872d3c0da3eda932b1e967018…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
call_control: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/f387c139b955ae52d9db2ebc074f36b…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
cfgt: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/88d9bbaffc7efc16c6e518c114c4958…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
ctl: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/6654649fe6a81bc32d50dd26054554c…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:46+02:00
db_mysql: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/0fd22771627cc51bf201d27b823d63d…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:47+02:00
dispatcher: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/fef78617dd70a5d22832653411a48a0…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:47+02:00
mediaproxy: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/b21f1e6c98a8c0b4468e3bf0dfda186…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:47+02:00
sipdump: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/2649f6415980940619759c6430b88c1…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:47+02:00
nat_traversal: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/47d96692f80cce90a8174615bb79dce…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:47+02:00
ims_ocs: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
- URL: https://github.com/kamailio/kamailio/commit/2b78f00b6aa0916276ab2732d5c462d…
Author: Guillem Jover <gjover(a)sipwise.com>
Date: 2019-10-25T12:00:47+02:00
ims_diameter_server: switch from deprecated /var/run to /run
The FHS 3.0 [F] has deprecated /var/run in favor of /run. Current
distributions have done so for a long time (for example in Debian
since 6.0 âsqueezeâ), even though they provide a compatibility
symlink from /var/run to /run. But software like systemd have
started emitting warnings when using /var/run, for example for
its PIDFile directive, which pollutes the logs.
Several packages not exist in CentOS 8 repos.
Will wait until docker centos:8 image available and i will try fix
**Not existed deps**
```
nothing provides hiredis-devel
nothing provides GeoIP-devel
nothing provides mysql-devel
nothing provides python
nothing provides python-devel
nothing provides radiusclient-ng-devel
nothing provides squirrel-devel
nothing provides python2-rpm-macros
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2078