sr-dev October 2019

sr-dev@lists.kamailio.org

22 participants
436 discussions

unused variable
by Juha Heinanen 01 Oct '19

01 Oct '19

With latest master, I got this: CC (gcc) [M db_mysql.so] km_dbase.o km_dbase.c: In function 'db_mysql_submit_query': km_dbase.c:71:9: warning: unused variable 't' [-Wunused-variable] time_t t; ^ It would be nice if devs would try to compile the code after making changes. -- Juha

2 2

git:master:fa5f3645: jsonrpcc: removed old todo file
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: fa5f36454f2ef5fb4e55dd05f746430d9786e842 URL: https://github.com/kamailio/kamailio/commit/fa5f36454f2ef5fb4e55dd05f746430… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T09:04:01+02:00 jsonrpcc: removed old todo file --- Removed: src/modules/jsonrpcc/TODO --- Diff: https://github.com/kamailio/kamailio/commit/fa5f36454f2ef5fb4e55dd05f746430… Patch: https://github.com/kamailio/kamailio/commit/fa5f36454f2ef5fb4e55dd05f746430… --- diff --git a/src/modules/jsonrpcc/TODO b/src/modules/jsonrpcc/TODO deleted file mode 100644 index f0e19152f1..0000000000 --- a/src/modules/jsonrpcc/TODO +++ /dev/null @@ -1,2 +0,0 @@ -* "Reliable" Notifications (implement using requests, and failover on error; ignore non-error responses) ? -* Implement timout for non-Linux systems

1 0

git:master:a6caed41: ims_qos: fixed typo in comments (timout -> timeout)
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: a6caed41166e555d7297abbae6017c5c54262662 URL: https://github.com/kamailio/kamailio/commit/a6caed41166e555d7297abbae6017c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T09:02:56+02:00 ims_qos: fixed typo in comments (timout -> timeout) --- Modified: src/modules/ims_qos/rx_str.c --- Diff: https://github.com/kamailio/kamailio/commit/a6caed41166e555d7297abbae6017c5… Patch: https://github.com/kamailio/kamailio/commit/a6caed41166e555d7297abbae6017c5… --- diff --git a/src/modules/ims_qos/rx_str.c b/src/modules/ims_qos/rx_str.c index efa9617222..6b243e85a4 100644 --- a/src/modules/ims_qos/rx_str.c +++ b/src/modules/ims_qos/rx_str.c @@ -104,8 +104,8 @@ int rx_send_str(str *rx_session_id) { if (auth->u.auth.state == AUTH_ST_DISCON) { // If we are in DISCON is because an STR was already sent - // so just wait for STA or for Grace Timout to happen - LM_DBG("Hmmm, auth session already in disconnected state\n"); + // so just wait for STA or for Grace Timeout to happen + LM_DBG("auth session already in disconnected state\n"); cdpb.AAASessionsUnlock(auth->hash); return CSCF_RETURN_FALSE; }

1 0

git:master:56313380: sms: fixed typo in comments (timout -> timeout)
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 5631338036c405b1e8c7fe8a1e320db2eb63c3f9 URL: https://github.com/kamailio/kamailio/commit/5631338036c405b1e8c7fe8a1e320db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T09:01:29+02:00 sms: fixed typo in comments (timout -> timeout) --- Modified: src/modules/sms/libsms_modem.c Modified: src/modules/sms/libsms_modem.h --- Diff: https://github.com/kamailio/kamailio/commit/5631338036c405b1e8c7fe8a1e320db… Patch: https://github.com/kamailio/kamailio/commit/5631338036c405b1e8c7fe8a1e320db… --- diff --git a/src/modules/sms/libsms_modem.c b/src/modules/sms/libsms_modem.c index 5093d28ee2..fe0be1f8a7 100644 --- a/src/modules/sms/libsms_modem.c +++ b/src/modules/sms/libsms_modem.c @@ -125,7 +125,7 @@ int put_command( struct modem *mdm, char* cmd, int cmd_len, char* answer, } } } - /* repeat until timout */ + /* repeat until timeout */ }while (timeoutcounter<timeout); if (!answer_e) diff --git a/src/modules/sms/libsms_modem.h b/src/modules/sms/libsms_modem.h index feeb6acac9..7eb0a80b04 100644 --- a/src/modules/sms/libsms_modem.h +++ b/src/modules/sms/libsms_modem.h @@ -31,7 +31,7 @@ typedef int(*cds_report)( struct modem* , char* , int ); /* put_command - Sends a command to the modem and waits max timout*0.1 seconds for an answer. + Sends a command to the modem and waits max timeout*0.1 seconds for an answer. The function returns the length of the answer. The answer can be Ok, ERROR or expect. The command may be empty or NULL */

1 0

git:master:75e0e0f4: db_mysql: fixed typo in comments (timout -> timeout)
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 75e0e0f4d693e207d2035f84c3e1ddc9cc715ec4 URL: https://github.com/kamailio/kamailio/commit/75e0e0f4d693e207d2035f84c3e1ddc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T08:59:44+02:00 db_mysql: fixed typo in comments (timout -> timeout) --- Modified: src/modules/db_mysql/km_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/75e0e0f4d693e207d2035f84c3e1ddc… Patch: https://github.com/kamailio/kamailio/commit/75e0e0f4d693e207d2035f84c3e1ddc… --- diff --git a/src/modules/db_mysql/km_dbase.c b/src/modules/db_mysql/km_dbase.c index 3014d374f6..eaff3276b6 100644 --- a/src/modules/db_mysql/km_dbase.c +++ b/src/modules/db_mysql/km_dbase.c @@ -89,7 +89,7 @@ static int db_mysql_submit_query(const db1_con_t* _h, const str* _s) } } /* - * We're doing later a query anyway that will reset the timout of the server, + * We're doing later a query anyway that will reset the timeout of the server, * so it makes sense to set the timestamp value to the actual time in order * to prevent unnecessary pings. */

1 0

Re: [sr-dev] unused variable
by Juha Heinanen 01 Oct '19

01 Oct '19

Juha Heinanen writes: > It would be nice if devs would try to compile the code after making changes. I apologize. It was stupid statement. -- Juha

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2019