sr-dev October 2019

sr-dev@lists.kamailio.org

22 participants
436 discussions

git:5.2:f24fb5cd: core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087)

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: f24fb5cd5509dd7c539bf1c36b2676220dc1e826 URL: https://github.com/kamailio/kamailio/commit/f24fb5cd5509dd7c539bf1c36b26762… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-02T12:44:25+02:00 core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087) (cherry picked from commit aeea940adaddc12c1467a0ac8f5e34d14b1339be) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/f24fb5cd5509dd7c539bf1c36b26762… Patch: https://github.com/kamailio/kamailio/commit/f24fb5cd5509dd7c539bf1c36b26762… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index 80020a96ff..fd74441bf6 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -937,6 +937,12 @@ struct rdata* get_record(char* name, int type, int flags) *last=rd; last=&(rd->next); break; + case T_OPT: + /* skip DNS extensions, e.g. EDNS0 */ + rd->rdata=0; + *last=rd; + last=&(rd->next); + break; default: LM_ERR("unknown type %d\n", rtype); rd->rdata=0;

5 years, 1 month

[kamailio/kamailio] Kamailio logs errors due to unsupported EDNS0 extension in DNS responses (#2087)

by Florian Floimair

### Description We are running Kamailio in a Microsoft Azure VM. Azure started adding EDNS0 support - in the form of OPT pseudo-records at the end of replies - a few weeks ago and since then we see a lot of ERROR entries in Kamailio log. These do however have no function impact. >From what I can see they are simply not handled in core/resolv.c (EDNS0 is type 41). Version in use is latest 5.2 package from Kamailio repo on Debian 9 (Stretch). Log entries provided below ### Troubleshooting None, as this has no functional impact aside from filling the logs. #### Reproduction I can provide pcap of DNS traffic that contains EDNS0 OPT pseudo-entries on request. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` Oct 1 14:02:01 kamailio /usr/sbin/kamailio[78878]: ERROR: <core> [core/resolve.c:941]: get_record(): unknown type 41 ``` These lines are seen repeatedly only differing in timestamp and PID of kamailio process. In total about 40% of log entries are like the one above. #### SIP Traffic  not related to SIP, but to DNS ### Possible Solutions Add EDNS0 type 41 in core/resolv.c and don't fire an ERROR in the logs. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**:  ``` Debian 9.11 Linux kamailio 4.19.0-0.bpo.5-cloud-amd64 #1 SMP Debian 4.19.37-3~bpo9+1 (2019-05-18) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2087

5 years, 1 month

git:master:58047ba6: app_perl: first destroy old interpreter before creating the new one

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 58047ba61d0cbceebc8c85590970a573fc396aa5 URL: https://github.com/kamailio/kamailio/commit/58047ba61d0cbceebc8c85590970a57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-02T08:32:21+02:00 app_perl: first destroy old interpreter before creating the new one - on interpreter reset, the new one may inherit globals from the old one, if that is not yet destroyed --- Modified: src/modules/app_perl/app_perl_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/58047ba61d0cbceebc8c85590970a57… Patch: https://github.com/kamailio/kamailio/commit/58047ba61d0cbceebc8c85590970a57… --- diff --git a/src/modules/app_perl/app_perl_mod.c b/src/modules/app_perl/app_perl_mod.c index 942581c6d6..954b354638 100644 --- a/src/modules/app_perl/app_perl_mod.c +++ b/src/modules/app_perl/app_perl_mod.c @@ -262,6 +262,8 @@ PerlInterpreter *parser_init(void) { * */ int unload_perl(PerlInterpreter *p) { + /* clean and reset everything */ + PL_perl_destruct_level = 1; perl_destruct(p); perl_free(p); @@ -276,26 +278,26 @@ int unload_perl(PerlInterpreter *p) { */ int perl_reload(void) { - - PerlInterpreter *new_perl; - - new_perl = parser_init(); - - if (new_perl) { + if(my_perl) { unload_perl(my_perl); - my_perl = new_perl; + } + my_perl = parser_init(); + #ifdef PERL_EXIT_DESTRUCT_END - PL_exit_flags |= PERL_EXIT_DESTRUCT_END; + PL_exit_flags |= PERL_EXIT_DESTRUCT_END; #else #warning Perl 5.8.x should be used. Please upgrade. #warning This binary will be unsupported. - PL_exit_flags |= PERL_EXIT_EXPECTED; + PL_exit_flags |= PERL_EXIT_EXPECTED; #endif + + if(my_perl) { + LM_DBG("new perl interpreter initialized\n"); return 0; } else { - return -1; + LM_CRIT("failed to initialize a new perl interpreter - exiting\n"); + exit(-1); } - }

5 years, 1 month

git:master:fc542100: tls: option to set custom random bytess generator

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: fc542100d85a013272dde869e54173a7d5a062f4 URL: https://github.com/kamailio/kamailio/commit/fc542100d85a013272dde869e54173a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T23:07:54+02:00 tls: option to set custom random bytess generator - attempt to fix GH #2077 which exposes a crash in the libssl v1.1 default random bytes generator --- Added: src/modules/tls/tls_rand.c Added: src/modules/tls/tls_rand.h Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fc542100d85a013272dde869e54173a… Patch: https://github.com/kamailio/kamailio/commit/fc542100d85a013272dde869e54173a…

5 years, 1 month

[kamailio/kamailio] Create reverse-of-a-number (#2088)

by ankit-proton

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2088 -- Commit Summary -- * Create reverse-of-a-number -- File Changes -- A reverse-of-a-number (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2088.patch https://github.com/kamailio/kamailio/pull/2088.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2088

5 years, 1 month

git:master:325d1e6d: core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087)

by Henning Westerholt

Module: kamailio Branch: master Commit: 325d1e6d53b3db3265d6f76ec34bb3d6a31419c4 URL: https://github.com/kamailio/kamailio/commit/325d1e6d53b3db3265d6f76ec34bb3d… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-01T18:02:44+02:00 core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/325d1e6d53b3db3265d6f76ec34bb3d… Patch: https://github.com/kamailio/kamailio/commit/325d1e6d53b3db3265d6f76ec34bb3d… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index de5a30398e..6edc47e506 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -32,6 +32,13 @@ #include <resolv.h> #include <string.h> +/* older glibc < 2.25 does not include T_OPT in nameser_compat.h yet */ +#if __GLIBC__ == 2 && __GLIBC_MINOR__ < 25 +#ifndef T_OPT +#define T_OPT ns_t_opt +#endif +#endif + #include "resolve.h" #include "compiler_opt.h" #include "dprint.h"

5 years, 1 month

git:master:dd594481: modules: readme files regenerated - siptrace ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: dd594481ee5478d4509c2e53d88a4e309e7dad67 URL: https://github.com/kamailio/kamailio/commit/dd594481ee5478d4509c2e53d88a4e3… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-01T13:46:53+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/dd594481ee5478d4509c2e53d88a4e3… Patch: https://github.com/kamailio/kamailio/commit/dd594481ee5478d4509c2e53d88a4e3…

5 years, 1 month

git:master:51e72659: modules: readme files regenerated - siptrace ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 51e72659699b5f15b1a4b8827247e0bcdd587fab URL: https://github.com/kamailio/kamailio/commit/51e72659699b5f15b1a4b8827247e0b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-01T17:01:51+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/51e72659699b5f15b1a4b8827247e0b… Patch: https://github.com/kamailio/kamailio/commit/51e72659699b5f15b1a4b8827247e0b…

5 years, 1 month

git:master:1d014c04: siptrace: fix (copy and paste) errors in siptrace docs

by Henning Westerholt

Module: kamailio Branch: master Commit: 1d014c04cfc67d5ed7c3bd440bcf05eb76b1fc73 URL: https://github.com/kamailio/kamailio/commit/1d014c04cfc67d5ed7c3bd440bcf05e… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-01T17:00:36+02:00 siptrace: fix (copy and paste) errors in siptrace docs --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1d014c04cfc67d5ed7c3bd440bcf05e… Patch: https://github.com/kamailio/kamailio/commit/1d014c04cfc67d5ed7c3bd440bcf05e… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index df8fe2f017..abf3f47c26 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -571,7 +571,7 @@ sip_trace("sip:10.1.1.2:5085", "$ci-abc", "d"); <section id="siptrace.f.sip_trace_mode"> <title> - <function moreinfo="none">sip_trace_mode(tmode])</function> + <function moreinfo="none">sip_trace_mode(tmode)</function> </title> <para> Set the tracing mode: message, transaction or dialog. Only the first @@ -587,7 +587,6 @@ sip_trace("sip:10.1.1.2:5085", "$ci-abc", "d"); <para> This function can be used in ANY_ROUTE. </para> - </emphasis> <example> <title><function>sip_trace_mode()</function> usage</title> <programlisting format="linespecific">

5 years, 1 month

git:master:aeea940a: core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087)

by Henning Westerholt

Module: kamailio Branch: master Commit: aeea940adaddc12c1467a0ac8f5e34d14b1339be URL: https://github.com/kamailio/kamailio/commit/aeea940adaddc12c1467a0ac8f5e34d… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-01T16:41:19+02:00 core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/aeea940adaddc12c1467a0ac8f5e34d… Patch: https://github.com/kamailio/kamailio/commit/aeea940adaddc12c1467a0ac8f5e34d… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index 5169c85cab..de5a30398e 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -951,6 +951,12 @@ struct rdata* get_record(char* name, int type, int flags) *last=rd; last=&(rd->next); break; + case T_OPT: + /* skip DNS extensions, e.g. EDNS0 */ + rd->rdata=0; + *last=rd; + last=&(rd->next); + break; default: LM_ERR("unknown type %d\n", rtype); rd->rdata=0;

5 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2019