Module: kamailio
Branch: master
Commit: 4a657005a5c4eff88e48dc2b8847d5800a90bead
URL: https://github.com/kamailio/kamailio/commit/4a657005a5c4eff88e48dc2b8847d58…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2019-10-22T09:57:07+02:00
smsops: fix spelling error
---
Modified: src/modules/smsops/smsops_impl.c
---
Diff: https://github.com/kamailio/kamailio/commit/4a657005a5c4eff88e48dc2b8847d58…
Patch: https://github.com/kamailio/kamailio/commit/4a657005a5c4eff88e48dc2b8847d58…
---
diff --git a/src/modules/smsops/smsops_impl.c b/src/modules/smsops/smsops_impl.c
index 8dfe70163a..83d83a7a8e 100644
--- a/src/modules/smsops/smsops_impl.c
+++ b/src/modules/smsops/smsops_impl.c
@@ -543,7 +543,7 @@ int decode_3gpp_sms(struct sip_msg *msg) {
// Check for malicious length, which might cause buffer overflow
if(udh_len > body.len - p) {
- LM_ERR("TP-User-Data-Lenght is bigger than the remaining message buffer!\n");
+ LM_ERR("TP-User-Data-Length is bigger than the remaining message buffer!\n");
return -1;
}
@@ -564,7 +564,7 @@ int decode_3gpp_sms(struct sip_msg *msg) {
// Check for malicious length, which might cause buffer overflow
if(udh_read + ie->data.len + 2 /* two octets are read so far */ > udh_len) {
- LM_ERR("IE Lenght for IE id %d is bigger than the remaining User-Data element!\n",
+ LM_ERR("IE Length for IE id %d is bigger than the remaining User-Data element!\n",
ie->identifier);
pkg_free(ie);
return -1;
Module: kamailio
Branch: master
Commit: 3c24dd27056c48528bc33bd90d680b9483785a18
URL: https://github.com/kamailio/kamailio/commit/3c24dd27056c48528bc33bd90d680b9…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2019-10-22T08:31:18+02:00
modules: readme files regenerated - imc ... [skip ci]
---
Modified: src/modules/imc/README
---
Diff: https://github.com/kamailio/kamailio/commit/3c24dd27056c48528bc33bd90d680b9…
Patch: https://github.com/kamailio/kamailio/commit/3c24dd27056c48528bc33bd90d680b9…
---
diff --git a/src/modules/imc/README b/src/modules/imc/README
index 1e5f79ef55..e07a66276f 100644
--- a/src/modules/imc/README
+++ b/src/modules/imc/README
@@ -36,6 +36,8 @@ Anca-Maria Vamanu
3.5. imc_cmd_start_char (str)
3.6. outbound_proxy (str)
3.7. extra_hdrs (str)
+ 3.8. create_on_join (integer)
+ 3.9. check_on_create (integer)
4. Functions
@@ -62,8 +64,10 @@ Anca-Maria Vamanu
1.5. Set imc_cmd_start_char parameter
1.6. Set outbound_proxy parameter
1.7. Set extra_hdrs parameter
- 1.8. Usage of imc_manager() function
- 1.9. List of commands
+ 1.8. Set create_on_join parameter
+ 1.9. Set check_on_create parameter
+ 1.10. Usage of imc_manager() function
+ 1.11. List of commands
Chapter 1. Admin Guide
@@ -84,6 +88,8 @@ Chapter 1. Admin Guide
3.5. imc_cmd_start_char (str)
3.6. outbound_proxy (str)
3.7. extra_hdrs (str)
+ 3.8. create_on_join (integer)
+ 3.9. check_on_create (integer)
4. Functions
@@ -145,6 +151,8 @@ Chapter 1. Admin Guide
3.5. imc_cmd_start_char (str)
3.6. outbound_proxy (str)
3.7. extra_hdrs (str)
+ 3.8. create_on_join (integer)
+ 3.9. check_on_create (integer)
3.1. db_url (str)
@@ -229,6 +237,31 @@ modparam("imc", "outbound_proxy", "sip:kamailio.org;transport=tcp")
modparam("imc", "extra_hdrs", "P-Flags: 3\r\n")
...
+3.8. create_on_join (integer)
+
+ If set to 1 and user requests to join a non-existing room, the room
+ will be automatically created. If set to 0, joinin a non-existing room
+ returns an error.
+
+ The default value is 1.
+
+ Example 1.8. Set create_on_join parameter
+...
+modparam("imc", "create_on_join", 0)
+...
+
+3.9. check_on_create (integer)
+
+ If set to 1, the chat server will report an error if the user attempts
+ to create a room that already exists.
+
+ The default value is 0.
+
+ Example 1.9. Set check_on_create parameter
+...
+modparam("imc", "check_on_create", 1)
+...
+
4. Functions
4.1. imc_manager()
@@ -242,7 +275,7 @@ modparam("imc", "extra_hdrs", "P-Flags: 3\r\n")
This function can be used from REQUEST_ROUTE. See command description
for error codes returned by this function.
- Example 1.8. Usage of imc_manager() function
+ Example 1.10. Usage of imc_manager() function
...
# the rooms will be named chat-xyz to avoid overlapping
# with usernames
@@ -305,7 +338,7 @@ kamcmd imc_list_members _room_
Next picture presents the list of commands and their parameters.
- Example 1.9. List of commands
+ Example 1.11. List of commands
...
1.create
@@ -377,10 +410,21 @@ kamcmd imc_list_members _room_
-only the owner of a room has the right to destroy it
-error case: return codes: -110 -- -119
-9.list
+9.members
-list members in a room
-error case: return codes: -100 -- -109
+10.add
+ -adds a user to a room
+ -takes 2 parameters:
+ 1)the complete address of the user
+ 2)the address of the room -if not present it will be considered
+ to be the address in the To header of the message
+ -only certain users have the right to add other users: the owner
+ and the administrators
+ -eg: #add sip:john@kamailio.org sip:chat-000@kamailio.org
+ or #add john(a)kamailio.org sent to sip:chat-000@kamailio.org
+ -error case: return codes: -50 -- -59
...
8. Installation
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
Multiple rules with the same prefix and with the stopper flag are added. All the rules have the same priority in the target table.
When routing calls to this prefix (load_gw + next_gw), the LCR module does not load balance the calls, it always sends to the same GW.
#### Reproduction
Scenario is the following, the LCR rules have one default GW which is reachable via an empty rule. However, a certain prefix must not be sent there, so a rule with the stopper flag is added pointing to another GW. This works fine and the default GW is never attempted.
However, for load balance purposes, it is necessary to send calls to this prefix to 2 different GWs. So another rule with the same prefix is added with the stopper flag set too. The target table was updated accordingly and has the same priority.
When we have all this setup, by calling "next_gw()" we always get the same GW (which is random depending on the DB situation I think). The other(s) GW is never attempted.
This does not allow to load balance 2 GWs for rules with the stopper flag.
Given the stopper flag should prevent selecting shorter prefixes, it should not restrict the routing for rules with the same prefix (same length). Having this, the load balance of stopper rules would be possible.
### Possible Solutions
Apparently, there is no workaround, expect by not using the stopper flag, however then there is a risk of sending calls to GWs with shorter prefix length which is not desired.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
kamailio -v
version: kamailio 5.2.2 (x86_64/linux) 67f967
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 67f967
compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5
```
* **Operating System**:
```
uname -a
Linux uat1-sbc-0002 3.10.0-1062.1.2.el7.x86_64 #1 SMP Mon Sep 30 14:19:46 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2105
Hi
I am using kamailio 4.4.2 for load-balancing
modparam("dispatcher", "dst_avp", "$avp(dsdst)")
$avp(dsdst) getting proper dispathcer value.
But this value is null in request_route under iif (is_method("CANCEL")){ }
How to get the correct dispatcher value for a particular call
--
Thanks and regards
Vinod.M.N
