sr-dev October 2019

sr-dev@lists.kamailio.org

22 participants
436 discussions

git:master:ca12494e: modules: readme files regenerated - tls ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: ca12494ec776babab86897eba35b88424a707c69 URL: https://github.com/kamailio/kamailio/commit/ca12494ec776babab86897eba35b884… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-07T15:16:37+02:00 modules: readme files regenerated - tls ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/ca12494ec776babab86897eba35b884… Patch: https://github.com/kamailio/kamailio/commit/ca12494ec776babab86897eba35b884… --- diff --git a/src/modules/tls/README b/src/modules/tls/README index b0d9fa2601..650a964b58 100644 --- a/src/modules/tls/README +++ b/src/modules/tls/README @@ -1435,12 +1435,14 @@ end The following options are avaialble: * krand - use internal kam_rand() function * fastrand - use internal fastrand function - * cryptorand - use internal cryptorand function + * cryptorand - use internal cryptorand (fortuna) function + + Note: the krand and fastrand engines are not recommended for use on + systems requiring strong security, as they may not generate numbers + with enough randomness. The default value is empty (not set) for libssl v1.0.x or older, and - "cryptorand" for libssl v1.1.x or newer. The krand and fastrand engines - are not recommended for production use, as they will not generate - secure enough random numbers. + "cryptorand" for libssl v1.1.x or newer. Example 1.45. Set rand_engine parameter ...

5 years, 1 month

git:5.3:39864192: tls: docs - documented cryptorand engine for prng

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 398641926648a32b635f39f655ae3231038b9c3d URL: https://github.com/kamailio/kamailio/commit/398641926648a32b635f39f655ae323… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-07T15:13:58+02:00 tls: docs - documented cryptorand engine for prng --- Modified: src/modules/tls/doc/params.xml --- Diff: https://github.com/kamailio/kamailio/commit/398641926648a32b635f39f655ae323… Patch: https://github.com/kamailio/kamailio/commit/398641926648a32b635f39f655ae323… --- diff --git a/src/modules/tls/doc/params.xml b/src/modules/tls/doc/params.xml index 6028642b5f..dc6494c2db 100644 --- a/src/modules/tls/doc/params.xml +++ b/src/modules/tls/doc/params.xml @@ -1251,7 +1251,7 @@ end is not designed for multi-process applications and can result in a crash. Therefore set the PRNG engine to one of the options listed in this section. If libssl 1.1.x (or newer) is detected at compile time, then - the PRNG engine is set to "fastrand". + the PRNG engine is set to "cryptorand". </para> <para> The following options are avaialble: @@ -1259,10 +1259,16 @@ end <itemizedlist> <listitem><para>krand - use internal kam_rand() function</para></listitem> <listitem><para>fastrand - use internal fastrand function</para></listitem> + <listitem><para>cryptorand - use internal cryptorand (fortuna) function</para></listitem> </itemizedlist> + <para> + Note: the krand and fastrand engines are not recommended for use on + systems requiring strong security, as they may not generate numbers + with enough randomness. + </para> <para> The default value is empty (not set) for libssl v1.0.x or older, and - "fastrand" for libssl v1.1.x or newer. + "cryptorand" for libssl v1.1.x or newer. </para> <example> <title>Set <varname>rand_engine</varname> parameter</title>

5 years, 1 month

git:5.3:58f6eb7b: tls: add cryptorand (fortuna) engine for PRNG if libssl v1.1.0+

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 58f6eb7b8bbd6e22994f4b147b6c2fc9c7d1daa0 URL: https://github.com/kamailio/kamailio/commit/58f6eb7b8bbd6e22994f4b147b6c2fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-07T14:57:06+02:00 tls: add cryptorand (fortuna) engine for PRNG if libssl v1.1.0+ - set it to be the default PRNG with libssl v1.1.0+ --- Modified: src/modules/tls/tls_mod.c Modified: src/modules/tls/tls_rand.c Modified: src/modules/tls/tls_rand.h --- Diff: https://github.com/kamailio/kamailio/commit/58f6eb7b8bbd6e22994f4b147b6c2fc… Patch: https://github.com/kamailio/kamailio/commit/58f6eb7b8bbd6e22994f4b147b6c2fc… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index 75d8aa8fd2..424fad8a08 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -453,6 +453,9 @@ int ksr_rand_engine_param(modparam_t type, void* val) } else if(reng->len == 8 && strncasecmp(reng->s, "fastrand", 8) == 0) { LM_DBG("setting fastrand random engine\n"); RAND_set_rand_method(RAND_ksr_fastrand_method()); + } else if (reng->len == 10 && strncasecmp(reng->s, "cryptorand", 10) == 0) { + LM_DBG("setting cryptorand random engine\n"); + RAND_set_rand_method(RAND_ksr_cryptorand_method()); } #endif return 0; @@ -563,8 +566,8 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) register_tls_hooks(&tls_h); #if OPENSSL_VERSION_NUMBER >= 0x10100000L - LM_DBG("setting fastrand random engine\n"); - RAND_set_rand_method(RAND_ksr_fastrand_method()); + LM_DBG("setting cryptorand random engine\n"); + RAND_set_rand_method(RAND_ksr_cryptorand_method()); #endif sr_kemi_modules_add(sr_kemi_tls_exports); diff --git a/src/modules/tls/tls_rand.c b/src/modules/tls/tls_rand.c index bc80f658c3..3cb2e8a712 100644 --- a/src/modules/tls/tls_rand.c +++ b/src/modules/tls/tls_rand.c @@ -129,4 +129,46 @@ const RAND_METHOD *RAND_ksr_fastrand_method(void) return &_ksr_fastrand_method; } + +/* + * Implementation with Fortuna cryptographic PRNG. + * We are not strictly implementing the OpenSSL API here - we will + * not return an error if the PRNG has not been seeded with enough + * randomness to ensure an unpredictable byte sequence. + */ +static int ksr_cryptorand_bytes(unsigned char *outdata, int size) +{ + if (size < 0) { + return 0; + } else if (size == 0) { + return 1; + } + + sr_get_pseudo_random_bytes(outdata, size); + return 1; +} + +static int ksr_cryptorand_status(void) +{ + return 1; +} + +/* + * We don't have a dedicated function for pseudo-random + * bytes, just use the secure version as well for it. + */ +const RAND_METHOD _ksr_cryptorand_method = { + NULL, + ksr_cryptorand_bytes, + NULL, + NULL, + ksr_cryptorand_bytes, + ksr_cryptorand_status +}; + +const RAND_METHOD *RAND_ksr_cryptorand_method(void) +{ + return &_ksr_cryptorand_method; +} + #endif /* OPENSSL_VERSION_NUMBER >= 0x10100000L */ diff --git a/src/modules/tls/tls_rand.h b/src/modules/tls/tls_rand.h index d1a3f0d37f..c73d36b8d9 100644 --- a/src/modules/tls/tls_rand.h +++ b/src/modules/tls/tls_rand.h @@ -27,6 +27,7 @@ const RAND_METHOD *RAND_ksr_krand_method(void); const RAND_METHOD *RAND_ksr_fastrand_method(void); +const RAND_METHOD *RAND_ksr_cryptorand_method(void); #endif /* OPENSSL_VERSION_NUMBER >= 0x10100000L */ #endif

5 years, 1 month

Errored: kamailio/kamailio#7889 (master - 49a7893)

by Travis CI

Build Update for kamailio/kamailio ------------------------------------- Build: #7889 Status: Errored Duration: 1 min and 47 secs Commit: 49a7893 (master) Author: Henning Westerholt Message: tls: update name and mailing list in tls_cert.sh script View the changeset: https://github.com/kamailio/kamailio/compare/b0538d6515ad...49a78933845f View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/594505407?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

5 years, 1 month

git:master:49a78933: tls: update name and mailing list in tls_cert.sh script

by Henning Westerholt

Module: kamailio Branch: master Commit: 49a78933845f136f8f7caaf7e24e6cdcf206cbb5 URL: https://github.com/kamailio/kamailio/commit/49a78933845f136f8f7caaf7e24e6cd… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-07T11:50:29+02:00 tls: update name and mailing list in tls_cert.sh script --- Modified: src/modules/tls/tls_cert.sh --- Diff: https://github.com/kamailio/kamailio/commit/49a78933845f136f8f7caaf7e24e6cd… Patch: https://github.com/kamailio/kamailio/commit/49a78933845f136f8f7caaf7e24e6cd… --- diff --git a/src/modules/tls/tls_cert.sh b/src/modules/tls/tls_cert.sh index 9e1cd7fa3c..dc9ea24380 100755 --- a/src/modules/tls/tls_cert.sh +++ b/src/modules/tls/tls_cert.sh @@ -11,7 +11,7 @@ # Configuration variables ############################################################################# NAME=$MAIN_NAME -if [ -z "$NAME" ] ; then NAME="sip-router"; fi; +if [ -z "$NAME" ] ; then NAME="kamailio"; fi; DEFAULT_DIR="/usr/local/etc/$NAME" DEFAULT_DAYS=365 DEFAULT_INFO="Self-signed certificate for $NAME" @@ -102,7 +102,7 @@ AUTHOR Written by Jan Janak <jan(a)iptel.org> REPORTING BUGS - Report bugs to <sr-dev(a)sip-router.org> + Report bugs to <sr-dev(a)lists.kamailio.org> EOF } #usage

5 years, 1 month

git:5.2:dbd4bc09: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.2 Commit: dbd4bc0944664c861a31f42c4c70eac148312969 URL: https://github.com/kamailio/kamailio/commit/dbd4bc0944664c861a31f42c4c70eac… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-07T11:46:59+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/dbd4bc0944664c861a31f42c4c70eac… Patch: https://github.com/kamailio/kamailio/commit/dbd4bc0944664c861a31f42c4c70eac…

5 years, 1 month

git:master:876c0529: pkg/docker: updated kamailio-ci subproject

by Sergey Safarov

Module: kamailio Branch: master Commit: 876c0529962678f7f0c610dd7190cb42d623f2a7 URL: https://github.com/kamailio/kamailio/commit/876c0529962678f7f0c610dd7190cb4… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-10-07T12:28:17+03:00 pkg/docker: updated kamailio-ci subproject --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/876c0529962678f7f0c610dd7190cb4… Patch: https://github.com/kamailio/kamailio/commit/876c0529962678f7f0c610dd7190cb4… --- diff --git a/pkg/docker b/pkg/docker index b92a1c899b..4b81cba4c2 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit b92a1c899b8c474afadd0cf29dd7cb4ea01a3466 +Subproject commit 4b81cba4c293f79ef3b4ae4a8c391d0da220878e

5 years, 1 month

git:5.2:466075c0: tls: Makefile - do not enclose fortuna lib in quotes

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.2 Commit: 466075c0c9145cf676ffac8102af23478cc1a244 URL: https://github.com/kamailio/kamailio/commit/466075c0c9145cf676ffac8102af234… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-07T11:44:09+02:00 tls: Makefile - do not enclose fortuna lib in quotes - bsd make keeps them in compile/ldd command (cherry picked from commit f07893606b2129f3a7f24a7d1f7fee619f9b8105) --- Modified: src/modules/tls/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/466075c0c9145cf676ffac8102af234… Patch: https://github.com/kamailio/kamailio/commit/466075c0c9145cf676ffac8102af234… --- diff --git a/src/modules/tls/Makefile b/src/modules/tls/Makefile index 02f879cc42..7e3c409a70 100644 --- a/src/modules/tls/Makefile +++ b/src/modules/tls/Makefile @@ -28,7 +28,7 @@ else # E.g.: make TLS_HOOKS=1 TLS_EXTRA_LIBS="-lz -lkrb5" endif -TLS_EXTRA_LIBS="-L. -lfortuna" +TLS_EXTRA_LIBS= -L. -lfortuna LIBS+= $(TLS_EXTRA_LIBS) # dcm: tls.cfg installed via local 'install-cfg' to update paths

5 years, 1 month

git:5.2:1ccb215b: xmlrpc: clean allocated buffer for reply when no more memory for reason value

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.2 Commit: 1ccb215b96f3dc0bd49ea3feb00f9e8f1a5c1fda URL: https://github.com/kamailio/kamailio/commit/1ccb215b96f3dc0bd49ea3feb00f9e8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-07T11:43:55+02:00 xmlrpc: clean allocated buffer for reply when no more memory for reason value (cherry picked from commit 36a4b16117d79f1a30a9f929350f75ab8bfd5d2a) (cherry picked from commit aa875e297bea05828f319d71fc68c44969931231) --- Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/1ccb215b96f3dc0bd49ea3feb00f9e8… Patch: https://github.com/kamailio/kamailio/commit/1ccb215b96f3dc0bd49ea3feb00f9e8… --- diff --git a/src/modules/xmlrpc/xmlrpc.c b/src/modules/xmlrpc/xmlrpc.c index 9521af2386..7552b4d7f1 100644 --- a/src/modules/xmlrpc/xmlrpc.c +++ b/src/modules/xmlrpc/xmlrpc.c @@ -2509,7 +2509,7 @@ static int ki_xmlrpc_reply(sip_msg_t* msg, int rcode, str* reason) reply.reason = as_asciiz(reason); if (reply.reason == NULL) { ERR("No memory left\n"); - return -1; + goto error; } if (reply.code >= 300) {

5 years, 1 month

git:5.2:6beb87f1: tls: use fastrand() for the corresponding rand_engine

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.2 Commit: 6beb87f165d9926cd14eb0bd4d57f4167232121c URL: https://github.com/kamailio/kamailio/commit/6beb87f165d9926cd14eb0bd4d57f41… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-07T11:43:55+02:00 tls: use fastrand() for the corresponding rand_engine (cherry picked from commit f877069e141749796ec02a78ce16342f9e120ef7) (cherry picked from commit 52dda341500c697b988f600d3ae6f1b0065670bc) --- Modified: src/modules/tls/tls_rand.c --- Diff: https://github.com/kamailio/kamailio/commit/6beb87f165d9926cd14eb0bd4d57f41… Patch: https://github.com/kamailio/kamailio/commit/6beb87f165d9926cd14eb0bd4d57f41… --- diff --git a/src/modules/tls/tls_rand.c b/src/modules/tls/tls_rand.c index 9101251dd7..bc80f658c3 100644 --- a/src/modules/tls/tls_rand.c +++ b/src/modules/tls/tls_rand.c @@ -93,13 +93,13 @@ static int ksr_fastrand_bytes(unsigned char *outdata, int size) } while(size >= sizeof(int)) { - r = kam_rand(); + r = fastrand(); memcpy(outdata, &r, sizeof(int)); size -= sizeof(int); outdata += sizeof(int); } if(size>0) { - r = kam_rand(); + r = fastrand(); memcpy(outdata, &r, size); } return 1;

5 years, 1 month

← Newer
1
...
32
33
34
35
36
37
38
...
44
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2019