hello all
we are trying to rewrite our code to lua kemi, and we have found some
issues/questions until we would like to share with you.
-module call_obj not exported, we have tested a patch for the module to
export the functions to kemi, which seems works fine
-KSR.xlog.xinfo seems not able to select a facility as we currently can
like xlog("LOG_LOCAL7", "L_NOTICE", "$var(xxxx)");
-module sipt not exported yet, must use ksr.x.modf ? will be exported for a
future version?
-on 5.3.0-dev5 we don't see the KSR.dialog.var_sets() and
KSR.dialog.var_get/e/w() functions in the code, so we do use KSR.pv
functions to set and retrieve those dialog vars. However i see them on
master branch. Which kamailio release would have them?
-sdpops function sdp_with_codecs_by_name seems to not me exported, is it on
a todo list?
-textops module, missing remove_hf and append_hf functions exported. We
already did a patch for the remove_hf, despite we could work with textopsx
remove_hf_value function to get the almost the same functionality.
However, with append_hf i'm having some more issues.
We cannot use modf to exec those funtions, we get something like
For ---> KSR.x.modf("append_hf", "User-Agent: test", "To");
I get something like ----> Jun 27 07:19:16 proxy-1
/usr/local/kamailio/sbin/kamailio[5525]: ERROR: app_lua [app_lua_sr.c:188]:
lua_sr_modf(): function 'append_hf' has fixup - cannot be used
I could append a new header and not only at the end of the message by
replacing a header called the same way, by doing something like
KSR.textopsx.insert_hf_value("header", "value");
KSR.textopsx.remove_hf_value("header[-1]");
but i'm not able to insert a header after another different one like we can
do with append_hf("header:value", "To") for instance.
Is it expected to have it on a next commit those append_hf and remove_hf
exported.
Would we do a pull request with the ki_remove_hf we already have and the
call_obj functions too? We can check to export append_hf too if it's not
planned to be done
thanks a lot and regards
david
This is new module in Kamailio, named hiops module. I am developing and it take few time to done.
In all over the module i used LM_INFO instead of LM_DBG, just for much easy troubleshooting. And also I would use lock for share memory in all project. These are some 'todo' project that i have to do.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1856
-- Commit Summary --
* add received_in_via function(use it in hiops module)
* developing hiops module
-- File Changes --
M src/core/msg_translator.c (25)
M src/core/msg_translator.h (3)
A src/modules/hiops (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1856.patchhttps://github.com/kamailio/kamailio/pull/1856.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1856
On Kamailio 5.3.0 (`ad1905`) on CentOS 7, with `libcurl` 7.29.0-46, an `http_connect()` request to an unresponsive server...
```
http_connect("stuff", "/url, "$var(http_res)");
```
.. correctly sets `$var(http_res)` to `28`, which is an operation timeout per https://curl.haxx.se/libcurl/c/libcurl-errors.html.
However, `$curlerror($var(http_res))` returns the value `"No error"`. This is not quite as promised in https://kamailio.org/docs/modules/5.3.x/modules/http_client.html#idm480.
Thanks in advance!
-- Alex
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2154