sr-dev February 2019

sr-dev@lists.kamailio.org

23 participants
336 discussions

git:master:a70fd487: dispatcher: more details for use_default param with dispatcher.list file
by Daniel-Constantin Mierla 27 Feb '19

27 Feb '19

Module: kamailio Branch: master Commit: a70fd487a7509be41e558a9f54efaa7f038fd3e2 URL: https://github.com/kamailio/kamailio/commit/a70fd487a7509be41e558a9f54efaa7… Author: denyspozniak <denys.pozniak(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-27T09:05:03+01:00 dispatcher: more details for use_default param with dispatcher.list file --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a70fd487a7509be41e558a9f54efaa7… Patch: https://github.com/kamailio/kamailio/commit/a70fd487a7509be41e558a9f54efaa7… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index d28324f20d..580959f046 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -301,9 +301,10 @@ modparam("dispatcher", "force_dst", 1) The name of the XAVP which will hold the list with addresses and associated properties, in the order they have been selected by the chosen algorithm. If use_default is 1, the values of last XAVP correspond - to the last address in destination set. The first XAVP is the current - selected destination. All the other addresses from the destination set - will be added in the XAVP list to be able to implement serial forking. + to the last address in destination set. In case of using dispatcher.list file, + you have to set the priority field for each destination to ensure a particular order there. + The first XAVP is the current selected destination. All the other addresses + from the destination set will be added in the XAVP list to be able to implement serial forking. </para> <note> <para>

1 0

git:master:e5bffb30: htable: use kemi wrapper to execute routing functions
by Daniel-Constantin Mierla 26 Feb '19

26 Feb '19

Module: kamailio Branch: master Commit: e5bffb306c45f7a0f0f672368884f430d63c09ba URL: https://github.com/kamailio/kamailio/commit/e5bffb306c45f7a0f0f672368884f43… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-26T19:09:44+01:00 htable: use kemi wrapper to execute routing functions --- Modified: src/modules/htable/ht_api.c Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/e5bffb306c45f7a0f0f672368884f43… Patch: https://github.com/kamailio/kamailio/commit/e5bffb306c45f7a0f0f672368884f43… --- diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c index f129c5d48f..9809f107ea 100644 --- a/src/modules/htable/ht_api.c +++ b/src/modules/htable/ht_api.c @@ -1128,7 +1128,7 @@ void ht_handle_expired_record(ht_t *ht, ht_cell_t *cell) run_top_route(event_rt.rlist[ht->evex_index], fmsg, 0); } else { if(keng!=NULL) { - if(keng->froute(fmsg, EVENT_ROUTE, + if(sr_kemi_route(keng, fmsg, EVENT_ROUTE, &ht_event_callback, &ht->evex_name)<0) { LM_ERR("error running event route kemi callback\n"); } diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index 580e3bc881..268241cf3c 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -288,7 +288,7 @@ static int child_init(int rank) run_top_route(event_rt.rlist[rt], fmsg, &ctx); } else { if(keng!=NULL) { - if(keng->froute(fmsg, EVENT_ROUTE, + if(sr_kemi_route(keng, fmsg, EVENT_ROUTE, &ht_event_callback, &evname)<0) { LM_ERR("error running event route kemi callback\n"); return -1;

1 0

git:master:3008874c: rtimer: use kemi wrapper to execute routing functions
by Daniel-Constantin Mierla 26 Feb '19

26 Feb '19

Module: kamailio Branch: master Commit: 3008874c1971d09cb71cf8560fc280cfc305dadc URL: https://github.com/kamailio/kamailio/commit/3008874c1971d09cb71cf8560fc280c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-26T19:01:28+01:00 rtimer: use kemi wrapper to execute routing functions --- Modified: src/modules/rtimer/rtimer_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/3008874c1971d09cb71cf8560fc280c… Patch: https://github.com/kamailio/kamailio/commit/3008874c1971d09cb71cf8560fc280c… --- diff --git a/src/modules/rtimer/rtimer_mod.c b/src/modules/rtimer/rtimer_mod.c index 22141905b6..018986b663 100644 --- a/src/modules/rtimer/rtimer_mod.c +++ b/src/modules/rtimer/rtimer_mod.c @@ -201,7 +201,7 @@ void stm_timer_exec(unsigned int ticks, void *param) if(keng==NULL) { run_top_route(main_rt.rlist[rt->route], fmsg, 0); } else { - if(keng->froute(fmsg, EVENT_ROUTE, &rt->route_name, &evname)<0) { + if(sr_kemi_route(keng, fmsg, EVENT_ROUTE, &rt->route_name, &evname)<0) { LM_ERR("error running event route kemi callback [%.*s]\n", rt->route_name.len, rt->route_name.s); }

1 0

git:master:31586e9e: tm: use kemi wrapper to execute routing functions
by Daniel-Constantin Mierla 26 Feb '19

26 Feb '19

Module: kamailio Branch: master Commit: 31586e9e4eb0c43e1e34ad3ac730ba5f0942e838 URL: https://github.com/kamailio/kamailio/commit/31586e9e4eb0c43e1e34ad3ac730ba5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-26T18:59:16+01:00 tm: use kemi wrapper to execute routing functions --- Modified: src/modules/tm/t_fwd.c Modified: src/modules/tm/t_reply.c Modified: src/modules/tm/t_suspend.c Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/31586e9e4eb0c43e1e34ad3ac730ba5… Patch: https://github.com/kamailio/kamailio/commit/31586e9e4eb0c43e1e34ad3ac730ba5… --- diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c index 985b96f190..398c27a844 100644 --- a/src/modules/tm/t_fwd.c +++ b/src/modules/tm/t_fwd.c @@ -347,7 +347,7 @@ static int prepare_new_uac( struct cell *t, struct sip_msg *i_req, bctx = sr_kemi_act_ctx_get(); init_run_actions_ctx(&ctx); sr_kemi_act_ctx_set(&ctx); - if(keng->froute(i_req, BRANCH_ROUTE, + if(sr_kemi_route(keng, i_req, BRANCH_ROUTE, sr_kemi_cbname_lookup_idx(branch_route), NULL)<0) { LM_ERR("error running branch route kemi callback\n"); } diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 411bf1be47..122d11c846 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -999,7 +999,7 @@ int run_failure_handlers(struct cell *t, struct sip_msg *rpl, /* run a failure_route action if some was marked */ keng = sr_kemi_eng_get(); if(unlikely(keng!=NULL)) { - if(keng->froute(faked_req, FAILURE_ROUTE, + if(sr_kemi_route(keng, faked_req, FAILURE_ROUTE, sr_kemi_cbname_lookup_idx(on_failure), NULL)<0) { LM_ERR("error running failure route kemi callback\n"); } @@ -1073,7 +1073,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* run a branch_failure_route action if some was marked */ keng = sr_kemi_eng_get(); if(unlikely(keng!=NULL)) { - if(keng->froute(faked_req, BRANCH_FAILURE_ROUTE, + if(sr_kemi_route(keng, faked_req, BRANCH_FAILURE_ROUTE, sr_kemi_cbname_lookup_idx(on_branch_failure), NULL)<0) { LM_ERR("error running branch failure route kemi callback\n"); } @@ -2415,7 +2415,7 @@ int reply_received( struct sip_msg *p_msg ) bctx = sr_kemi_act_ctx_get(); init_run_actions_ctx(&ctx); sr_kemi_act_ctx_set(&ctx); - keng->froute(p_msg, TM_ONREPLY_ROUTE, + sr_kemi_route(keng, p_msg, TM_ONREPLY_ROUTE, sr_kemi_cbname_lookup_idx(onreply_route), NULL); sr_kemi_act_ctx_set(bctx); } else { diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c index 205c945d4c..c37957daba 100644 --- a/src/modules/tm/t_suspend.c +++ b/src/modules/tm/t_suspend.c @@ -314,7 +314,7 @@ int t_continue_helper(unsigned int hash_index, unsigned int label, if(cbparam && cbparam->s) { evname = *cbparam; } - if(keng->froute(faked_req, FAILURE_ROUTE, cbname, + if(sr_kemi_route(keng, faked_req, FAILURE_ROUTE, cbname, &evname)<0) { LM_ERR("error running event route kemi callback\n"); return -1; @@ -392,8 +392,8 @@ int t_continue_helper(unsigned int hash_index, unsigned int label, if(cbparam && cbparam->s) { evname = *cbparam; } - if(keng->froute(t->uac[branch].reply, TM_ONREPLY_ROUTE, - cbname, &evname)<0) { + if(sr_kemi_route(keng, t->uac[branch].reply, + TM_ONREPLY_ROUTE, cbname, &evname)<0) { LM_ERR("error running event route kemi callback\n"); } } else { diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index 29f298a5d5..1686bd157b 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -273,7 +273,7 @@ static inline int t_run_local_req( LM_WARN("event callback (%s) set, but no cfg engine\n", tm_event_callback.s); } else { - if(keng->froute(&lreq, EVENT_ROUTE, + if(sr_kemi_route(keng, &lreq, EVENT_ROUTE, &tm_event_callback, &evname)<0) { LM_ERR("error running event route kemi callback\n"); }

1 0

git:master:23b65718: core: use kemi exec route wrapper for onsend_route and child one init event
by Daniel-Constantin Mierla 26 Feb '19

26 Feb '19

Module: kamailio Branch: master Commit: 23b65718462a6bbc860fe7b4159d3c7aac34d3b8 URL: https://github.com/kamailio/kamailio/commit/23b65718462a6bbc860fe7b4159d3c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-26T18:42:23+01:00 core: use kemi exec route wrapper for onsend_route and child one init event --- Modified: src/core/action.c Modified: src/core/onsend.h --- Diff: https://github.com/kamailio/kamailio/commit/23b65718462a6bbc860fe7b4159d3c7… Patch: https://github.com/kamailio/kamailio/commit/23b65718462a6bbc860fe7b4159d3c7… --- diff --git a/src/core/action.c b/src/core/action.c index ca5586153b..83b1f708cd 100644 --- a/src/core/action.c +++ b/src/core/action.c @@ -1685,7 +1685,7 @@ int run_child_one_init_route(void) } else { bctx = sr_kemi_act_ctx_get(); sr_kemi_act_ctx_set(&ctx); - if(keng->froute(fmsg, EVENT_ROUTE, + if(sr_kemi_route(keng, fmsg, EVENT_ROUTE, &kemi_event_route_callback, &evname)<0) { LM_ERR("error running event route kemi callback\n"); return -1; diff --git a/src/core/onsend.h b/src/core/onsend.h index 90dbf8c8f0..e435a27f0a 100644 --- a/src/core/onsend.h +++ b/src/core/onsend.h @@ -93,7 +93,7 @@ static inline int run_onsend(sip_msg_t* orig_msg, dest_info_t* dst, if(keng) { bctx = sr_kemi_act_ctx_get(); sr_kemi_act_ctx_set(&ra_ctx); - ret=keng->froute(orig_msg, ONSEND_ROUTE, NULL, NULL); + ret=sr_kemi_route(keng, orig_msg, ONSEND_ROUTE, NULL, NULL); sr_kemi_act_ctx_set(bctx); } else { ret=run_actions(&ra_ctx, onsend_rt.rlist[DEFAULT_RT], orig_msg);

1 0

git:master:48686943: core: receive - use kemi wrapper to execute top keng routes
by Daniel-Constantin Mierla 26 Feb '19

26 Feb '19

Module: kamailio Branch: master Commit: 48686943aa37747a9a7581a5eb8c69098ce324d7 URL: https://github.com/kamailio/kamailio/commit/48686943aa37747a9a7581a5eb8c690… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-26T18:42:23+01:00 core: receive - use kemi wrapper to execute top keng routes - reset the select static buffer - GH #1829 --- Modified: src/core/receive.c --- Diff: https://github.com/kamailio/kamailio/commit/48686943aa37747a9a7581a5eb8c690… Patch: https://github.com/kamailio/kamailio/commit/48686943aa37747a9a7581a5eb8c690… --- diff --git a/src/core/receive.c b/src/core/receive.c index 19db2901a7..be12808ea7 100644 --- a/src/core/receive.c +++ b/src/core/receive.c @@ -326,11 +326,11 @@ int receive_msg(char *buf, unsigned int len, struct receive_info *rcv_info) } if(unlikely(cidlockset)) { rec_lock_set_get(ksr_route_locks_set, cidlockidx); - if(keng->froute(msg, REQUEST_ROUTE, NULL, NULL) < 0) + if(sr_kemi_route(keng, msg, REQUEST_ROUTE, NULL, NULL) < 0) LM_NOTICE("negative return code from engine function\n"); rec_lock_set_release(ksr_route_locks_set, cidlockidx); } else { - if(keng->froute(msg, REQUEST_ROUTE, NULL, NULL) < 0) + if(sr_kemi_route(keng, msg, REQUEST_ROUTE, NULL, NULL) < 0) LM_NOTICE("negative return code from engine function\n"); } } else { @@ -409,10 +409,10 @@ int receive_msg(char *buf, unsigned int len, struct receive_info *rcv_info) sr_kemi_act_ctx_set(&ctx); if(unlikely(cidlockset)) { rec_lock_set_get(ksr_route_locks_set, cidlockidx); - ret = keng->froute(msg, CORE_ONREPLY_ROUTE, NULL, NULL); + ret = sr_kemi_route(keng, msg, CORE_ONREPLY_ROUTE, NULL, NULL); rec_lock_set_release(ksr_route_locks_set, cidlockidx); } else { - ret = keng->froute(msg, CORE_ONREPLY_ROUTE, NULL, NULL); + ret = sr_kemi_route(keng, msg, CORE_ONREPLY_ROUTE, NULL, NULL); } sr_kemi_act_ctx_set(bctx); } else {

1 0

git:master:6be53f64: core: kemi - wraper to execute top routing function
by Daniel-Constantin Mierla 26 Feb '19

26 Feb '19

Module: kamailio Branch: master Commit: 6be53f64755358334e9f1c0971ce886a5e299efb URL: https://github.com/kamailio/kamailio/commit/6be53f64755358334e9f1c0971ce886… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-26T18:42:23+01:00 core: kemi - wraper to execute top routing function - reset the static buffer for selects and script flags --- Modified: src/core/kemi.c Modified: src/core/kemi.h --- Diff: https://github.com/kamailio/kamailio/commit/6be53f64755358334e9f1c0971ce886… Patch: https://github.com/kamailio/kamailio/commit/6be53f64755358334e9f1c0971ce886… --- diff --git a/src/core/kemi.c b/src/core/kemi.c index d15e0216fd..3457c6e860 100644 --- a/src/core/kemi.c +++ b/src/core/kemi.c @@ -31,6 +31,7 @@ #include "data_lump.h" #include "data_lump_rpl.h" #include "strutils.h" +#include "select_buf.h" #include "mem/shm.h" #include "parser/parse_uri.h" #include "parser/parse_from.h" @@ -2265,3 +2266,20 @@ str *sr_kemi_param_map_get_params(int *ptypes) sret.len = strlen(sret.s); return &sret; } + +/** + * + */ +int sr_kemi_route(sr_kemi_eng_t *keng, sip_msg_t *msg, int rtype, + str *ename, str *edata) +{ + flag_t sfbk; + int ret; + + sfbk = getsflags(); + setsflagsval(0); + reset_static_buffer(); + ret = keng->froute(msg, rtype, ename, edata); + setsflagsval(sfbk); + return ret; +} diff --git a/src/core/kemi.h b/src/core/kemi.h index 51ea72b43b..3321dd8b4e 100644 --- a/src/core/kemi.h +++ b/src/core/kemi.h @@ -145,4 +145,7 @@ str *sr_kemi_param_map_get_params(int *ptypes); int sr_kemi_core_set_drop(sip_msg_t *msg); +int sr_kemi_route(sr_kemi_eng_t *keng, sip_msg_t *msg, int rtype, + str *ename, str *edata); + #endif

1 0

Unwanted INVITE while using TMCB_ACK_NEG_IN callback
by Ionut Razvan Ionita 26 Feb '19

26 Feb '19

Hi, My name is Ionut and I am a new developer in VoIP dev team in 1&1. Maybe you can help me with the following problem. I have the following scenario: UAC sends invite to UAS via Kamailio proxy, UAS responds with 491. I am trying to catch the ACK from the UAC in siptrace module using TMCB_ACK_NEG_IN. I successfully trace this message but there's one more unwanted call to this callback. It gets called for an INVITE request which I don't want to trace since the callback is called ACK_NEG_IN. From my understanding, this call is issued right after the ACK is sent to the UAS, which, for me, doesn't seem to be correct, since the callback should trace in ACKs not outs. TM code that's calling this callback is in t_reply.c:2291. Is this a bug? I can fix this issue easily in my code by checking whether or not the current message is an ACK in siptrace but it would be great if we would work for a fix to this issue. Regards, Ionut

1 0

[kamailio/kamailio] Imc improvements (#1869)
by Jan Janak 26 Feb '19

26 Feb '19

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This patch set contains a bunch of improvements to the imc module. Most of the changes are backwards-compatible, but some change the semantics of individual imc commands slightly. I have tested the changes with the Zoiper client on Android and with a custom WebRTC client. The motivation behind these changes was to make the imc module a bit more consistent, predictable, and usable. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1869 -- Commit Summary -- * Rename command "deny" to "reject" * Minor language fixes * Rename "exit" to "leave", keep backward compatiblity * Remove code duplication. * Collect chat room related strings in one place. * Use STR_FMT in formatted string arguments. * Use correct command prefix in the invite message. * Make behavior of "#join" when room does not exist configurable * Define message prefix with a macro * Make behavior of "#create" configurable when room already exists * Pass both parsed and unparsed URIs to all command handlers * Consistent handling of command parameters. * Make #create command arguments optional * Rename command #list to #members. * Cleanup in invite related messages. * Consistent formatting of room/user names. * Improved #join command handling * Notify user #leaving a room. * Make message buffer larger * A small fix in #join * Check arguments in #invite * Implement command #add * Implement command #rooms * Add In-Reply-To header to MESSAGEs generated in response * Add Supported header to all chat room MESSAGEs. * Report error if room owner sends #leave -- File Changes -- M src/modules/imc/README (6) M src/modules/imc/doc/imc_admin.xml (62) M src/modules/imc/imc.c (92) M src/modules/imc/imc.h (8) M src/modules/imc/imc_cmd.c (1595) M src/modules/imc/imc_cmd.h (66) M src/modules/imc/imc_mng.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1869.patch https://github.com/kamailio/kamailio/pull/1869.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1869

2 2

git: new commits in branch master
by Daniel-Constantin Mierla 26 Feb '19

26 Feb '19

- URL: https://github.com/kamailio/kamailio/commit/9ce119126c6d618b83fe2a2ba6caeea… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: rename command "deny" to "reject" Since the command effectively "rejects" an invitation, the word "reject" is a better match. Keep "deny" as an alias to the command for backward compatibility. - URL: https://github.com/kamailio/kamailio/commit/196c2e360d29189e318f6a16c6d7945… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: minor language fixes - URL: https://github.com/kamailio/kamailio/commit/cc4778b4ec537cabdd7cceb0d2cfde0… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: rename "exit" to "leave", keep backward compatiblity The command name "leave" better describes what the command does and is less confusing for users (coincidentally, source code comments and debugging messages also use leave, not exit). The command name "exit" is kept as an alias for backward compatibility. - URL: https://github.com/kamailio/kamailio/commit/3261a0aefbcd9c9d7e412b699ef3431… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: remove code duplication. A significant portion of the functions handling invite and remove was duplicated code. Refactor the code into a common function. - URL: https://github.com/kamailio/kamailio/commit/3318a7f95fb4c5b38d1da0afd60db03… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: collect chat room related strings in one place. Rather than embedding strings directly in the functions that use them, it is better to have them collected at one place so that they can be easily modified. Later, we may turn the strings into module parameters so that they can be customized at startup time, e.g., to translate them. - URL: https://github.com/kamailio/kamailio/commit/95335ae341085f6eeecde53362bc0db… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: use STR_FMT in formatted string arguments. This makes the code somewhat shorter and safer. - URL: https://github.com/kamailio/kamailio/commit/b66870a0ff94399d9af284062a16ceb… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: use correct command prefix in the invite message. When showing the INVITATION to the user, make sure to show the actual command prefix that has been configured via the module parameter. - URL: https://github.com/kamailio/kamailio/commit/4e2a3682569ebdfb33f09a3251382b2… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: make behavior of "#join" when room does not exist configurable Before, the command "#join" would automatically create the room and add the user to the room if it does not exist. That behavior can be confusing, especially on mobile where it is easy to miss-type room name. With the default behavior, the user would be added to the wrong room in that case. This patch introduces module parameter "create_on_join" which makes this behavior configurable. If set to 0, command join will not create the room if it does not exist and would send an error back to the user instead. - URL: https://github.com/kamailio/kamailio/commit/ab87f61a5889ad90229b0d3ec9dcae0… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: define message prefix with a macro This simple change makes it much easier to consistently change the prefix across all messages sent to the user. By default, the prefix is "*** ". - URL: https://github.com/kamailio/kamailio/commit/56c012664e9aadcb5f61f1093710d73… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: make behavior of "#create" configurable when room already exists The default behavior of the create command is to silently add the user to a group of one already exists. This can be confusing in some scenarios, e.g., when the user miss-types the room number. This patch adds a module parameter called "check_on_create" which makes it possible to customize this behavior. If set and the user attempts to create a room that already exists, the command will report an error. - URL: https://github.com/kamailio/kamailio/commit/dbdf69264d65a72490bea33b68b2d04… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: pass both parsed and unparsed URIs to all command handlers In order for the command handler to be able to send a response back when the corresponding room does not exist, e.g., when sending an error message, the handler must have access to the original unparsed URI. This change fixes one bug on the side: when sending a response, the response will be sent to the correct part number which was part of the original SIP URI. Previously, port numbers were ignored since the SIP URI to send the message to was constructed just from the username and domain parts. - URL: https://github.com/kamailio/kamailio/commit/b39822eff0c0857f9b5a5220504ad6d… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: consistent handling of command parameters. Most (all) commands takes parametes in one of the following forms: username, username@domain, sip:username@domain. The purpose of this change is to provide consistent handling of such parameters across all commands and their arguments. If a command takes a user or a room as a parameter, the user can provide just a username, username@domain, or a full URI sip:username@domain. The imc module will automatically obtain missing parts from other parts of the message, e.g., the Request-URI or From headers. In addition, all debugging and logging messages print the full URI of users and rooms. This significantly helps with debugging and development. - URL: https://github.com/kamailio/kamailio/commit/b00433b7710b7c4f879341258edad78… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: make #create command arguments optional With no arguments, the room name is taken from To header and the room will be made public. With one argument, if the value is 'private', a private room with name from To is created. If the value of the single argument is anything else, it is taken as room name and the room will be made public. With two argument, the first argument is room name and the second argument must be string 'private'. This change makes the #create command consistent with all other commands where the room/user name is also optional. - URL: https://github.com/kamailio/kamailio/commit/39457968f10be50b5ccf3f81c71dd68… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: rename command #list to #members. List was not very good name for the command, because the user would not know whether the command lists rooms or members within a room. The alias "list" is kept for backward compatibility. - URL: https://github.com/kamailio/kamailio/commit/e10974fd6d0ace3654e6b45eb6b5a9e… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: cleanup in invite related messages. In the original version, when the user receives an invitation to join the room, it was not obvious who is inviting. - URL: https://github.com/kamailio/kamailio/commit/d7e3d921a41de6ebc40ed13a788b9a0… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: consistent formatting of room/user names. No matter in which message a room URI or user URI is printed, always use the same function to consistent format the resulting string. In most cases, this means printing just the username portion of the full URI. - URL: https://github.com/kamailio/kamailio/commit/3de5f6da6a07c2d1afec7ddd3fdd6d1… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: improved #join command handling This patch improves the overall handling of the #join command on the chat server. If a user attempts to join a room they are already a member of, notify the user, instead of sending a broadcast that the user has joined again to the entire room. If a user attempts to join a private room, notify them that private rooms are by invitation only with a unicast message and send a broadcast to the entire room about the join attempt so that administrators can see the join attempt in order to decide whether or not to send an invitation to the user. - URL: https://github.com/kamailio/kamailio/commit/afe2a81a8e9ded484b4b161e3cd629e… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: notify user #leaving a room. When a user chooses to leave a room, send the broadcast first. That way, the broadcast will include the leaving user and they will be able to see that they have left the room successfully. Also, this behavior is consistent with the behavior of #join. - URL: https://github.com/kamailio/kamailio/commit/7ad7bb300e4ef2feb9691d7e6e0b2be… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: make message buffer larger Enlarge the buffer so that longer messages and user lists can be sent. A larger buffer is fine when TCP and or TLS is used. - URL: https://github.com/kamailio/kamailio/commit/ce45d49d837d5ba0f02ebba48899ef5… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: a small fix in #join When a user has left or been removed from a room and try to join again, make sure to test the IMC_MEMBER_DELETED flag, otherwise they'd be getting a message that they are already in the room. - URL: https://github.com/kamailio/kamailio/commit/d6760d680bed15d0f90c402ffca9b98… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: check arguments in #invite The command has one required argument: the name/URI of the user to be invited to the room. - URL: https://github.com/kamailio/kamailio/commit/ec243a6a205b647a83e3a3535fca362… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: implement command #add The command can be used by room owners and administrators to explicitly add other users as members to the room. It works a bit like the command #invite, except that the added user will have no chance to accept or reject the request. - URL: https://github.com/kamailio/kamailio/commit/e742fe4dc56e8ba37b4058996e037c8… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: implement command #rooms The command can be used to list all the rooms available on the chat server. - URL: https://github.com/kamailio/kamailio/commit/1073c6d0a133df342983829e430415a… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: add In-Reply-To header to MESSAGEs generated in response When generating a MESSAGE in response to a command, add a In-Reply-To header field to the second message with the Call-ID of the (original) message that carried the command. A chat client could then use the In-Reply-To header field to correlate requests and responses carried in-band in chat messages. - URL: https://github.com/kamailio/kamailio/commit/42a66e4f075c244e41e8b828f394e94… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: add Supported header to all chat room MESSAGEs. The header contains value "kamailio/imc" which indicates that the end-point is a chat room that supports the in-band signaling protocol implemented by Kamailio's imc module. - URL: https://github.com/kamailio/kamailio/commit/ba4de81405c7e1801ea7cafb5bbf5c8… Author: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-02-26T17:24:33+01:00 imc: report error if room owner sends #leave Previously, if the room owner send the #leave command, the room would have been automatically destroyed. That is somewhat dangerous and error prone, e.g., if the user sends the #leave command to the wrong room. With this patch, #leave reports an error if used by a room owner and the user is encouraged to use #destroy instead.

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
34
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2019