sr-dev April 2020

sr-dev@lists.kamailio.org

33 participants
420 discussions

[kamailio/kamailio] Configure permissions module without database (#2037)

by Sebastian Damm

### Description In our setup, we try to eliminate setup configuration in database and replace it with files. The advantage is, that we can maintain those files via puppet or ansible, and since we always rewrite the whole file, we don't have to take care about deleting obsolete entries. We can run different Kamailio versions without having problems with the version table when using the same database. And finally, we can stop all those local mysqld processes on a lot of machines. Modules like the dispatcher module were easy to change. But the permissions module is not prepared to run without database, if you want to use `allow_trusted()` or `allow_source_address()` and similar. The only option to feed those functions with data is a database table. ### Expected behavior We would like to place files for trusted and address into the Kamailio directory and have Kamailio read from those files during startup or after reload commands. #### Actual observed behavior Data for trusted and address have to reside inside a database. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2037

4 years, 6 months

[kamailio/kamailio] Allow more options on dispatcher.set_state (#2085)

by duarterocha91

Greetings, Dispatcher RPC command allows to change the runtime state of a GW using its Group ID and the IP. In my implementation i have 2 Kamailio machines in an HA setup and, as such, i have the GW configured twice with same group_id and different sockets (Different HA adressess - one for each machine). I would like to be able to disable on runtime GWs that are configured with an HA adress that isn't present yet on that machine. To be able do that, the combination of GroupID + IP is not enough, but Socket + IP would be enough. Is this possible to implement ? Best Regards -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2085

4 years, 6 months

[kamailio/kamailio] error: 'pkg/docker' does not have a commit checked out (#2003)

by Daniel-Constantin Mierla

When I just tried to do a commit today, I got the following error: ``` kamailio $ git ci . error: 'pkg/docker' does not have a commit checked out fatal: updating files failed ``` It is related to the `pkg/docker` submodule referencing to kamailio/kamailio-ci. Not sure if this is due to a new git version or something else, because I did commits in that folder a few days ago. To get is sorted out, I did: ``` kamailio $ git submodule update pkg/docker Submodule path 'pkg/docker' not initialized Maybe you want to use 'update --init'? kamailio $ git submodule update --init pkg/docker Submodule 'pkg/docker' (https://github.com/kamailio/kamailio-ci.git) registered for path 'pkg/docker' Cloning into '/.../kamailio/pkg/docker'... Submodule path 'pkg/docker': checked out 'b92a1c899b8c474afadd0cf29dd7cb4ea01a3466' ``` Then it worked to do the commit. I wonder if this is going to break the process we were used with, specially the installation guidelines from GIT repo. Therefore I open this item to see if we really need the to have `pkg/docker` submodule, or better have the docker files directly in the repo. Other options to keep things sane and simple? Git version: ``` $ git --version git version 2.22.0 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2003

4 years, 6 months

possible bug on kemi dlg_ontimeout

by David Escartin

Hello all Testing dialog timeout event callback for kemi lua setup on kamailio 5.4.0-dev3 (x86_64/linux) d74157-dirty, i had some problems to perform the dlg timeroute behaviour the same as we could on native version. If i used KSR.dialog.var_sets to set $dlg_ctx(timeout_route), I saw that on a dialog timeout, the dlg_ontimeout event route was not triggered, and only the dialog callback was executed with evname dialog:end. (only executing event_route -1 on state 5) So i'm guessing that the kemi dialog var_sets is for $dlg_var only (¿?) Anycase, If i used KSR.pv.sets, i saw the kamailio was crashing ..... 16(5579) DEBUG: dialog [dlg_hash.c:1013]: dlg_ref_helper(): ref dlg 0x7f9a961f5f90 with 1 -> 3 16(5579) DEBUG: dialog [dlg_handlers.c:1589]: dlg_ontimeout(): executing route -1 on timeout 22(5645) CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 8 22(5645) DEBUG: <core> [core/tcp_main.c:3762]: handle_ser_child(): dead child 16, pid 5579 (shutting down?) .... Adding some debug, i could see that the call was not attempting the kemi function of line 1598 of dlg_handlers.c, and was trying the code i think was for native on line 1593. We think the issue is that the toroute is defined as unsigned dlg_hash.h: unsigned int toroute; /*!< index of route that is executed on timeout */ but after that when setting $dlg_ctx(timeout_route) with pv module, it tries to compare an integer being unsigned, so it's always true and never uses kemi with this change we made it work + if ((int)(dlg->toroute) > 0) { + /*if(dlg->toroute>0) {*/ but i don't know maybe there is a better way to do it. best regards david

4 years, 6 months

[kamailio/kamailio] Debian package version don't support distribution upgrades (#2160)

by Bas Couwenberg

When upgrading from stretch to buster the kamailio packages aren't upgraded because the 5.3.1+stretch version is greater than 5.3.1+buster: ``` $ dpkg --compare-versions 5.3.1+stretch gt 5.3.1+buster ; echo $? 0 ``` The package version should include the release version instead of its codename, e.g. 5.3.1+deb9u1 & 5.3.1+deb10u1 like done for [stable updates](https://www.debian.org/doc/manuals/developers-reference/pkgs.en.ht…: ``` $ dpkg --compare-versions 5.3.1+deb10u1 gt 5.3.1+deb9u1 ; echo $? 0 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2160

4 years, 6 months

[kamailio/kamailio] support pkg-config when detecting libxml2 (#2199)

by Victor Seva

>From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949521: > your package is using `xml2-config` to detect and use libxml2. I'm removing that script, so please update your build system to use pkg-config instead. > >Additionally, your package is not failing to build, so it's creating binaries that are not linked against libxml2 anymore: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199

4 years, 6 months

[kamailio/kamailio] ims_registrar_scscf: pass event type as parameter (#2296)

by alexyosifov

- pass event type as parameter in notify_subscribers()   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2296 -- Commit Summary -- * ims_registrar_scscf: pass event type as parameter -- File Changes -- M src/modules/ims_registrar_scscf/cxdx_callbacks.c (4) M src/modules/ims_registrar_scscf/reg_rpc.c (2) M src/modules/ims_registrar_scscf/registrar_notify.c (6) M src/modules/ims_registrar_scscf/registrar_notify.h (2) M src/modules/ims_registrar_scscf/save.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2296.patch https://github.com/kamailio/kamailio/pull/2296.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2296

4 years, 6 months

[kamailio/kamailio] ims_registrar_scscf: fix aor generation in lookup() (#2292)

by alexyosifov

- Generate AoR in lookup() from parsed uri user and host. Skipping all user's and host's parameters.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2292 -- Commit Summary -- * ims_registrar_scscf: fix aor generation in lookup() -- File Changes -- M src/modules/ims_registrar_scscf/lookup.c (55) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2292.patch https://github.com/kamailio/kamailio/pull/2292.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2292

4 years, 6 months

[kamailio/kamailio] ndb_redis: redis_cmd() doesn't return error with a faulty command (#2300)

by Victor Seva

### Description Detected that a command like this was not returning <0 ``` if(redis_cmd("test", "HSET dd field1", "r")) { [...] } ``` Same command on redis-cli: ``` # redis-cli 127.0.0.1:6379> HSET dd field1 (error) ERR wrong number of arguments for 'hset' command ``` ### Troubleshooting #### Reproduction I've added some debug to the code and I find out that the command is returning: ``` Apr 23 10:55:02 spce proxy[12880]: DEBUG: ndb_redis [redis_client.c:956]: redisc_exec(): rpl->rplRedis->type:3 ``` That's an INTEGER. From hiredis/read.h: ``` #define REDIS_REPLY_INTEGER 3 #define REDIS_REPLY_NIL 4 #define REDIS_REPLY_STATUS 5 #define REDIS_REPLY_ERROR 6 ``` I've created a simple test code to check the same command: ``` #include <stdio.h> #include <stdarg.h> #include "hiredis.h" void check(redisContext *c, const char *cmd, ...) { va_list ap; va_start(ap,cmd); redisReply *r = redisvCommand(c, cmd, ap); va_end(ap); if(r == NULL) { printf("reply NULL\n"); } printf("reply->type:%d\n", r->type); freeReplyObject(r); } int main(void) { redisContext *c = redisConnect("127.0.0.1", 6379); if (c == NULL || c->err) { if (c) { printf("Error: %s\n", c->errstr); } else { printf("Can't allocate redis context\n"); } return 1; } check(c, "HSET dd field"); redisFree(c); return 0; } ``` ``` root@spce:/usr/local/devel# cc t.c -o t -lhiredis -I/usr/include/hiredis root@spce:/usr/local/devel# ./t reply->type:6 ``` No problems there. The reply is ERROR. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, NO_SIG_DEBUG, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2300

4 years, 6 months

ICMP port-unreachable for UDP INVITEs

by James Browne

I've searched, but I cannot find anything recent about this. My kamailio 5.0.8 proxy sends an INVITE downstream over UDP and gets an ICMP port-unreachable response from the UAS. Apparently ignoring this, it re-transmits the INVITEs and eventually times out and sends to the next host (from the SRV lookup). According to RFC 3261 (https://tools.ietf.org/html/rfc3261#section-8.1.3.1), If a fatal transport error is reported by the transport layer (generally, due to fatal ICMP errors in UDP or connection failures in TCP), the condition MUST be treated as a 503 (Service Unavailable) status code. Does kamailio support handling ICMP responses to INVITEs (and therefore either failing over immediately, or sending 503 upstream immediately)? I don't know for sure the "correct" behavior because the RFC3261 is so old and because ICMP responses are limited in size and therefore can't guarantee to uniquely identify the transactions that caused them.

4 years, 6 months

← Newer
1
...
7
8
9
10
11
12
13
...
42
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2020