sr-dev March 2021

sr-dev@lists.kamailio.org

28 participants
489 discussions

[kamailio/kamailio] lrkproxy: compile warning (#2663)

by Daniel-Constantin Mierla

Compiling the new `lrkproxy` module with clang throws the following warning: ``` CC (gcc) [M lrkproxy.so] lrkproxy.o lrkproxy.c:1228:28: warning: address of array 'e->node->lrkp_n_c->internal_ip' will always evaluate to 'true' [-Wpointer-bool-conversion] if (e->node->lrkp_n_c->internal_ip && flags) { ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~ 1 warning generated. ``` Looks like something that needs to be sorted out, comparison with an array address. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2663

3 years, 8 months

git:master:821eec50: Makefile.groups: added group for jwt module

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 821eec50f255af18fc452b2eb573d650d779fb6d URL: https://github.com/kamailio/kamailio/commit/821eec50f255af18fc452b2eb573d65… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-10T16:18:32+01:00 Makefile.groups: added group for jwt module --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/821eec50f255af18fc452b2eb573d65… Patch: https://github.com/kamailio/kamailio/commit/821eec50f255af18fc452b2eb573d65… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index a8ae0a3109..fa7c6dd719 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -184,6 +184,9 @@ mod_list_uuid=uuid # - modules depending on ev library mod_list_ev=evapi +# - modules depending on libjwt library +mod_list_jwt=jwt + # - modules depending on kazoo/rabbitmq mod_list_kazoo=kazoo @@ -256,6 +259,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \ $(mod_list_kafka) \ $(mod_list_mqtt) \ $(mod_list_secsipid) \ + $(mod_list_jwt) \ $(mod_list_rtp_media_server) @@ -446,6 +450,9 @@ module_group_kuuid=$(mod_list_uuid) # pkg libev modules module_group_kev=$(mod_list_ev) +# pkg jwt module +module_group_kjwt=$(mod_list_jwt) + # pkg kazoo module module_group_kkazoo=$(mod_list_kazoo)

3 years, 8 months

git:master:93691313: jwt: new module adding json web token generation and validation

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 93691313f3873dca681b82c7f402ee4467894dad URL: https://github.com/kamailio/kamailio/commit/93691313f3873dca681b82c7f402ee4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-10T16:18:32+01:00 jwt: new module adding json web token generation and validation --- Added: src/modules/jwt/Makefile Added: src/modules/jwt/README Added: src/modules/jwt/doc/Makefile Added: src/modules/jwt/doc/jwt.xml Added: src/modules/jwt/doc/jwt_admin.xml Added: src/modules/jwt/jwt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/93691313f3873dca681b82c7f402ee4… Patch: https://github.com/kamailio/kamailio/commit/93691313f3873dca681b82c7f402ee4…

3 years, 8 months

[kamailio/kamailio] lrkproxy-fixed issue#2663 (#2666)

by mojtabaesfandiari

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2666 -- Commit Summary -- * Merge pull request #1 from kamailio/master * Merge pull request #2 from kamailio/master * Merge pull request #3 from kamailio/master * lrkproxy:fix flag parameter in change_media_sdp * Merge branch 'lrkproxy_warning2663' -- File Changes -- M src/modules/lrkproxy/lrkproxy.c (15) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2666.patch https://github.com/kamailio/kamailio/pull/2666.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2666

3 years, 8 months

git:master:e35f0fe5: lrkproxy:fix flags condition in change_media_sdp function

by mojtaba

Module: kamailio Branch: master Commit: e35f0fe59155b9efac8d3d9fe979c4ea78df7f02 URL: https://github.com/kamailio/kamailio/commit/e35f0fe59155b9efac8d3d9fe979c4e… Author: mojtaba <mespio(a)gmail.com> Committer: mojtaba <mespio(a)gmail.com> Date: 2021-03-10T15:30:30+03:30 lrkproxy:fix flags condition in change_media_sdp function --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/e35f0fe59155b9efac8d3d9fe979c4e… Patch: https://github.com/kamailio/kamailio/commit/e35f0fe59155b9efac8d3d9fe979c4e… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index 2c0405c8a5..1ef69bb9ac 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1224,18 +1224,21 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const start_sdp_c = strstr(off, "c=IN IP4"); start_sdp_m = strstr(off, "m=audio"); - //if enabled then set direction, - if (e->node->lrkp_n_c->internal_ip && flags) { + //The external_ip should be set in config file for relaying RTP media between NIC. +// if (e->node->lrkp_n_c->external_ip && flags) { + if(flags) { if (strstr(flags, "ei")) { ip_selected = e->node->lrkp_n_c->internal_ip;// lrk_node->internal_ip; } else if (strstr(flags, "ie")) { ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; } else { - LM_INFO("no flags found\n"); - return 0; + LM_INFO("unknown flags, use internal_ip\n"); + ip_selected = e->node->lrkp_n_c->internal_ip; } - } else { - ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; + } + else { + LM_INFO("no flags set, use internal_ip\n"); + ip_selected = e->node->lrkp_n_c->internal_ip; } if (op == OP_OFFER) {

3 years, 8 months

[kamailio/kamailio] Revert "lrkproxy-fixed issue#2663" (#2667)

by Daniel-Constantin Mierla

Reverts kamailio/kamailio#2666 Too many changes pushed, it requires time to review first. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2667 -- Commit Summary -- * Revert "lrkproxy-fixed issue#2663" -- File Changes -- M src/modules/lrkproxy/lrkproxy.c (15) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2667.patch https://github.com/kamailio/kamailio/pull/2667.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2667

3 years, 8 months

git:master:0010029f: Merge pull request #2667 from kamailio/revert-2666-master

by GitHub

Module: kamailio Branch: master Commit: 0010029f95542b27ca197f071dd455aad04a9537 URL: https://github.com/kamailio/kamailio/commit/0010029f95542b27ca197f071dd455a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-03-10T12:06:53+01:00 Merge pull request #2667 from kamailio/revert-2666-master Revert "lrkproxy-fixed issue#2663" --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/0010029f95542b27ca197f071dd455a… Patch: https://github.com/kamailio/kamailio/commit/0010029f95542b27ca197f071dd455a… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index 1ef69bb9ac..2c0405c8a5 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1224,21 +1224,18 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const start_sdp_c = strstr(off, "c=IN IP4"); start_sdp_m = strstr(off, "m=audio"); - //The external_ip should be set in config file for relaying RTP media between NIC. -// if (e->node->lrkp_n_c->external_ip && flags) { - if(flags) { + //if enabled then set direction, + if (e->node->lrkp_n_c->internal_ip && flags) { if (strstr(flags, "ei")) { ip_selected = e->node->lrkp_n_c->internal_ip;// lrk_node->internal_ip; } else if (strstr(flags, "ie")) { ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; } else { - LM_INFO("unknown flags, use internal_ip\n"); - ip_selected = e->node->lrkp_n_c->internal_ip; + LM_INFO("no flags found\n"); + return 0; } - } - else { - LM_INFO("no flags set, use internal_ip\n"); - ip_selected = e->node->lrkp_n_c->internal_ip; + } else { + ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; } if (op == OP_OFFER) {

3 years, 8 months

git:master:9ceba23d: Revert "lrkproxy-fixed issue#2663"

by GitHub

Module: kamailio Branch: master Commit: 9ceba23d170a03c584c149d5a9fa7ef633995eac URL: https://github.com/kamailio/kamailio/commit/9ceba23d170a03c584c149d5a9fa7ef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-03-10T12:06:10+01:00 Revert "lrkproxy-fixed issue#2663" --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/9ceba23d170a03c584c149d5a9fa7ef… Patch: https://github.com/kamailio/kamailio/commit/9ceba23d170a03c584c149d5a9fa7ef… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index 1ef69bb9ac..2c0405c8a5 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1224,21 +1224,18 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const start_sdp_c = strstr(off, "c=IN IP4"); start_sdp_m = strstr(off, "m=audio"); - //The external_ip should be set in config file for relaying RTP media between NIC. -// if (e->node->lrkp_n_c->external_ip && flags) { - if(flags) { + //if enabled then set direction, + if (e->node->lrkp_n_c->internal_ip && flags) { if (strstr(flags, "ei")) { ip_selected = e->node->lrkp_n_c->internal_ip;// lrk_node->internal_ip; } else if (strstr(flags, "ie")) { ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; } else { - LM_INFO("unknown flags, use internal_ip\n"); - ip_selected = e->node->lrkp_n_c->internal_ip; + LM_INFO("no flags found\n"); + return 0; } - } - else { - LM_INFO("no flags set, use internal_ip\n"); - ip_selected = e->node->lrkp_n_c->internal_ip; + } else { + ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; } if (op == OP_OFFER) {

3 years, 8 months

git:master:1e71e135: Merge pull request #2666 from mojtabaesfandiari/master

by GitHub

Module: kamailio Branch: master Commit: 1e71e135ce800159f4f2611ec6b133aa2e4d3a41 URL: https://github.com/kamailio/kamailio/commit/1e71e135ce800159f4f2611ec6b133a… Author: mojtabaesfandiari <45168300+mojtabaesfandiari(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2021-03-10T14:28:02+03:30 Merge pull request #2666 from mojtabaesfandiari/master lrkproxy-fixed issue#2663 --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/1e71e135ce800159f4f2611ec6b133a… Patch: https://github.com/kamailio/kamailio/commit/1e71e135ce800159f4f2611ec6b133a… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index 2c0405c8a5..1ef69bb9ac 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1224,18 +1224,21 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const start_sdp_c = strstr(off, "c=IN IP4"); start_sdp_m = strstr(off, "m=audio"); - //if enabled then set direction, - if (e->node->lrkp_n_c->internal_ip && flags) { + //The external_ip should be set in config file for relaying RTP media between NIC. +// if (e->node->lrkp_n_c->external_ip && flags) { + if(flags) { if (strstr(flags, "ei")) { ip_selected = e->node->lrkp_n_c->internal_ip;// lrk_node->internal_ip; } else if (strstr(flags, "ie")) { ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; } else { - LM_INFO("no flags found\n"); - return 0; + LM_INFO("unknown flags, use internal_ip\n"); + ip_selected = e->node->lrkp_n_c->internal_ip; } - } else { - ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; + } + else { + LM_INFO("no flags set, use internal_ip\n"); + ip_selected = e->node->lrkp_n_c->internal_ip; } if (op == OP_OFFER) {

3 years, 8 months

git:master:de87efee: Merge branch 'lrkproxy_warning2663'

by mojtaba

Module: kamailio Branch: master Commit: de87efee6d78ca54db679f2283c53f9addad5cea URL: https://github.com/kamailio/kamailio/commit/de87efee6d78ca54db679f2283c53f9… Author: mojtaba <mespio(a)gmail.com> Committer: mojtaba <mespio(a)gmail.com> Date: 2021-03-10T13:56:04+03:30 Merge branch 'lrkproxy_warning2663' --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/de87efee6d78ca54db679f2283c53f9… Patch: https://github.com/kamailio/kamailio/commit/de87efee6d78ca54db679f2283c53f9… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index 2c0405c8a5..1ef69bb9ac 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1224,18 +1224,21 @@ static int change_media_sdp(sip_msg_t *msg, struct lrkproxy_hash_entry *e, const start_sdp_c = strstr(off, "c=IN IP4"); start_sdp_m = strstr(off, "m=audio"); - //if enabled then set direction, - if (e->node->lrkp_n_c->internal_ip && flags) { + //The external_ip should be set in config file for relaying RTP media between NIC. +// if (e->node->lrkp_n_c->external_ip && flags) { + if(flags) { if (strstr(flags, "ei")) { ip_selected = e->node->lrkp_n_c->internal_ip;// lrk_node->internal_ip; } else if (strstr(flags, "ie")) { ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; } else { - LM_INFO("no flags found\n"); - return 0; + LM_INFO("unknown flags, use internal_ip\n"); + ip_selected = e->node->lrkp_n_c->internal_ip; } - } else { - ip_selected = e->node->lrkp_n_c->external_ip; //lrk_node->external_ip; + } + else { + LM_INFO("no flags set, use internal_ip\n"); + ip_selected = e->node->lrkp_n_c->internal_ip; } if (op == OP_OFFER) {

3 years, 8 months

← Newer
1
...
37
38
39
40
41
42
43
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2021