sr-dev March 2021

sr-dev@lists.kamailio.org

28 participants
489 discussions

git:master:d3a36ed6: usrloc: adjusted rpc reply text when the location domain table is not found

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d3a36ed6757eeda42dc32608a63b857ee9a67bb9 URL: https://github.com/kamailio/kamailio/commit/d3a36ed6757eeda42dc32608a63b857… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-09T12:27:10+01:00 usrloc: adjusted rpc reply text when the location domain table is not found --- Modified: src/modules/usrloc/ul_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/d3a36ed6757eeda42dc32608a63b857… Patch: https://github.com/kamailio/kamailio/commit/d3a36ed6757eeda42dc32608a63b857… --- diff --git a/src/modules/usrloc/ul_rpc.c b/src/modules/usrloc/ul_rpc.c index 63c45381b5..d45a8e2783 100644 --- a/src/modules/usrloc/ul_rpc.c +++ b/src/modules/usrloc/ul_rpc.c @@ -402,7 +402,7 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) /* look for table */ dom = rpc_find_domain( &table ); if (dom == NULL) { - rpc->fault(ctx, 500, "Domain not found"); + rpc->fault(ctx, 500, "Domain table not found"); return; } @@ -476,7 +476,7 @@ static void ul_rpc_rm_aor(rpc_t* rpc, void* ctx) /* look for table */ dom = rpc_find_domain( &table ); if (dom == NULL) { - rpc->fault(ctx, 500, "Domain not found"); + rpc->fault(ctx, 500, "Domain table not found"); return; } @@ -520,7 +520,7 @@ static void ul_rpc_rm_contact(rpc_t* rpc, void* ctx) /* look for table */ dom = rpc_find_domain( &table ); if (dom == NULL) { - rpc->fault(ctx, 500, "Domain not found"); + rpc->fault(ctx, 500, "Domain table not found"); return; } @@ -661,7 +661,7 @@ static void ul_rpc_add(rpc_t* rpc, void* ctx) /* look for table */ dom = rpc_find_domain( &table ); if (dom == NULL) { - rpc->fault(ctx, 500, "Domain not found"); + rpc->fault(ctx, 500, "Domain table not found"); return; }

3 years, 8 months

git:master:0c4becd7: pv: handle missing fields (otcid, instance) for $banch() and $sbranch()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0c4becd70428ef15be76fb0aa53932e5803c6bd0 URL: https://github.com/kamailio/kamailio/commit/0c4becd70428ef15be76fb0aa53932e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-09T11:39:48+01:00 pv: handle missing fields (otcid, instance) for $banch() and $sbranch() --- Modified: src/modules/pv/pv_branch.c --- Diff: https://github.com/kamailio/kamailio/commit/0c4becd70428ef15be76fb0aa53932e… Patch: https://github.com/kamailio/kamailio/commit/0c4becd70428ef15be76fb0aa53932e…

3 years, 8 months

git:master:6c5895c3: modules: readme files regenerated - topos ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 6c5895c302f669ab679bdaec10514a7b04dcde18 URL: https://github.com/kamailio/kamailio/commit/6c5895c302f669ab679bdaec10514a7… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-09T10:46:25+01:00 modules: readme files regenerated - topos ... [skip ci] --- Modified: src/modules/topos/README Modified: src/modules/topos_redis/README --- Diff: https://github.com/kamailio/kamailio/commit/6c5895c302f669ab679bdaec10514a7… Patch: https://github.com/kamailio/kamailio/commit/6c5895c302f669ab679bdaec10514a7… --- diff --git a/src/modules/topos/README b/src/modules/topos/README index 1dcff2ad07..39a113ce36 100644 --- a/src/modules/topos/README +++ b/src/modules/topos/README @@ -10,7 +10,13 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> +Frederic Gaisnon + + <frederic.gaisnon(a)gmail.com> + Copyright © 2016 FhG FOKUS + + Copyright © 2021 MomentTech __________________________________________________________________ Table of Contents @@ -112,8 +118,8 @@ Chapter 1. Admin Guide It also works for SIP MESSAGE or other requests that do not create a dialog -- record_route() must be used for them as well, the headers are not going to be in the messages sent to the network, they are needed to - know local addresses used to communicate with each side. At this moment - it is not designed to work for presence (SUBSCRIBE-based) dialogs. The + know local addresses used to communicate with each side. This module is + designed to work for presence (SUBSCRIBE-based) dialogs too. The REGISTER and PUBLISH requests are skipped from processing by this module, expected to be terminated on a local SIP server. @@ -225,7 +231,10 @@ modparam("topos", "branch_expire", 300) mind that the module does not update the dialog timestamp after the initial call setup on re-INVITEs or other in-dialog messages. So set a large enough value (according your longest call duration) to prevent - problems in re-writing messages. + problems in re-writing messages. This key is only relevant for INVITE + dialog. SUBSCRIBE dialog records lifetime are based on value set in + expires header. Moreover each re-SUBSCRIBEs update the dialog + timestamp. Default value is 10800 (3 hours). diff --git a/src/modules/topos_redis/README b/src/modules/topos_redis/README index c1b038dffc..619902729f 100644 --- a/src/modules/topos_redis/README +++ b/src/modules/topos_redis/README @@ -10,9 +10,15 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> +Frederic Gaisnon + + <frederic.gaisnon(a)gmail.com> + Copyright © 2017 kamailio.org Copyright © 2017 flowroute.com + + Copyright © 2021 MomentTech __________________________________________________________________ Table of Contents

3 years, 8 months

[kamailio/kamailio] support subscribe dialog (topos + topos_redis) (#2662)

by fgaisnon

#### Pre-Submission Checklist    - [x ] Commit message has the format required by CONTRIBUTING guide - [x ] Commits are split per component (core, individual modules, libs, utils, ...) - [x ] Each component has a single commit (if not, squash them into one commit) - [x ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x ] Small bug fix (non-breaking change which fixes an issue) - [x ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description topos_redis: support SUBSCRIBE dialog topos: SUBSCRIBE dialog topos: documentation for SUBSCRIBE dialog topos: add description for dialog_expire key Add support for dialog subscribe when using topos. When a Subscribe is received, a Subscribe dialog is created. Dialog TTL is set according to expire received in SIP request. At each resubscribe the TTL is refresh according to expires set in SIP request. Notify (in-dialog) with header event set are supposed to be inside a Subscribe dialog. bugfix: topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part In this case we have a sip uri like : sip:@host htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2662 -- Commit Summary -- * topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part * topos_redis: support SUBSCRIBE dialog * htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated -- File Changes -- M src/modules/htable/htable.c (4) M src/modules/topos/doc/topos.xml (9) M src/modules/topos/doc/topos_admin.xml (7) M src/modules/topos/tps_msg.c (5) M src/modules/topos/tps_storage.c (41) M src/modules/topos/tps_storage.h (2) M src/modules/topos_redis/doc/topos_redis.xml (9) M src/modules/topos_redis/topos_redis_storage.c (75) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2662.patch https://github.com/kamailio/kamailio/pull/2662.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2662

3 years, 8 months

git:master:19c69e80: htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated

by frederic

Module: kamailio Branch: master Commit: 19c69e8094570a60eaf056ecac57ed26fce9d3a7 URL: https://github.com/kamailio/kamailio/commit/19c69e8094570a60eaf056ecac57ed2… Author: frederic <frederic.gaisnon(a)mmtt.fr> Committer: frederic <frederic.gaisnon(a)mmtt.fr> Date: 2021-02-16T11:10:11+01:00 htable: ht_dmq_replicate_action was always called on ht_rm_items even if dmq was not activated --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/19c69e8094570a60eaf056ecac57ed2… Patch: https://github.com/kamailio/kamailio/commit/19c69e8094570a60eaf056ecac57ed2… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index d05cf5227d..1bb36657de 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -484,7 +484,7 @@ static int ht_rm_items(sip_msg_t* msg, str* hname, str* op, str *val, case 2: if(strncmp(op->s, "re", 2)==0) { isval.s = *val; - if (ht_dmq_replicate_action(HT_DMQ_RM_CELL_RE, &ht->name, NULL, + if ((ht->dmqreplicate > 0) && ht_dmq_replicate_action(HT_DMQ_RM_CELL_RE, &ht->name, NULL, AVP_VAL_STR, &isval, mkey)!=0) { LM_ERR("dmq relication failed (op %d)\n", mkey); } @@ -494,7 +494,7 @@ static int ht_rm_items(sip_msg_t* msg, str* hname, str* op, str *val, return 1; } else if(strncmp(op->s, "sw", 2)==0) { isval.s = *val; - if (ht_dmq_replicate_action(HT_DMQ_RM_CELL_SW, &ht->name, NULL, + if ((ht->dmqreplicate > 0) &&ht_dmq_replicate_action(HT_DMQ_RM_CELL_SW, &ht->name, NULL, AVP_VAL_STR, &isval, mkey)!=0) { LM_ERR("dmq relication failed (op %d)\n", mkey); }

3 years, 8 months

git:master:d189be29: Merge pull request #2662 from fgaisnon/master

by GitHub

Module: kamailio Branch: master Commit: d189be29f85df4a5d3480bc9707f5cf770bea5cd URL: https://github.com/kamailio/kamailio/commit/d189be29f85df4a5d3480bc9707f5cf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2021-03-09T10:32:10+01:00 Merge pull request #2662 from fgaisnon/master support subscribe dialog (topos + topos_redis) --- Modified: src/modules/htable/htable.c Modified: src/modules/topos/doc/topos.xml Modified: src/modules/topos/doc/topos_admin.xml Modified: src/modules/topos/tps_msg.c Modified: src/modules/topos/tps_storage.c Modified: src/modules/topos/tps_storage.h Modified: src/modules/topos_redis/doc/topos_redis.xml Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/d189be29f85df4a5d3480bc9707f5cf… Patch: https://github.com/kamailio/kamailio/commit/d189be29f85df4a5d3480bc9707f5cf…

3 years, 8 months

git:master:aed3a523: topos_redis: support SUBSCRIBE dialog

by frederic

Module: kamailio Branch: master Commit: aed3a523ffd68bd2fdac78b9be68335a72aa78ce URL: https://github.com/kamailio/kamailio/commit/aed3a523ffd68bd2fdac78b9be68335… Author: frederic <frederic.gaisnon(a)mmtt.fr> Committer: frederic <frederic.gaisnon(a)mmtt.fr> Date: 2021-02-16T10:27:42+01:00 topos_redis: support SUBSCRIBE dialog --- Modified: src/modules/topos_redis/doc/topos_redis.xml Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/aed3a523ffd68bd2fdac78b9be68335… Patch: https://github.com/kamailio/kamailio/commit/aed3a523ffd68bd2fdac78b9be68335…

3 years, 8 months

git:master:3333c392: topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part

by frederic

Module: kamailio Branch: master Commit: 3333c39230d0fffb2ef22c238b1410c302f0c8c7 URL: https://github.com/kamailio/kamailio/commit/3333c39230d0fffb2ef22c238b1410c… Author: frederic <frederic.gaisnon(a)mmtt.fr> Committer: frederic <frederic.gaisnon(a)mmtt.fr> Date: 2021-02-09T10:54:37+01:00 topos: when contact mode is set to 1, contact uri created is malformed if received contact has no user part topos: SUBSCRIBE dialog topos: documentation for SUBSCRIBE dialog topos: add description for dialog_expire key --- Modified: src/modules/topos/doc/topos.xml Modified: src/modules/topos/doc/topos_admin.xml Modified: src/modules/topos/tps_msg.c Modified: src/modules/topos/tps_storage.c Modified: src/modules/topos/tps_storage.h --- Diff: https://github.com/kamailio/kamailio/commit/3333c39230d0fffb2ef22c238b1410c… Patch: https://github.com/kamailio/kamailio/commit/3333c39230d0fffb2ef22c238b1410c…

3 years, 8 months

[kamailio/kamailio] Extreme logging in 5.4.4 (#2661)

by Alexandru Pirvulescu

### Description  Extreme logging introduced in 5.4.4 here: https://github.com/kamailio/kamailio/blob/2015cfdfd777085dad98a606fc41946af… and here: https://github.com/kamailio/kamailio/blob/2015cfdfd777085dad98a606fc41946af… ### Troubleshooting Logging level for these should be DEBUG? #### Reproduction  Install Kamailio 5.4.4. #### Debugging Data  ``` ``` #### Log Messages  ``` 20(70) INFO: ctl [io_listener.c:518]: handle_stream_read(): bytes processed: 29 20(70) INFO: ctl [io_listener.c:498]: handle_stream_read(): bytes read: 35 20(70) INFO: ctl [io_listener.c:518]: handle_stream_read(): bytes processed: 35 20(70) INFO: ctl [io_listener.c:498]: handle_stream_read(): bytes read: 18 20(70) INFO: ctl [io_listener.c:518]: handle_stream_read(): bytes processed: 18 20(70) INFO: ctl [io_listener.c:498]: handle_stream_read(): bytes read: 29 20(70) INFO: ctl [io_listener.c:518]: handle_stream_read(): bytes processed: 29 20(70) INFO: ctl [io_listener.c:498]: handle_stream_read(): bytes read: 29 20(70) INFO: ctl [io_listener.c:518]: handle_stream_read(): bytes processed: 29 ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.4.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2661

3 years, 8 months

git:5.4:2788f985: ctl: info log messages made debug

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: 2788f985fc4a5146c50bba15febe73fee874f9e6 URL: https://github.com/kamailio/kamailio/commit/2788f985fc4a5146c50bba15febe73f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-05T07:35:50+01:00 ctl: info log messages made debug - used to troubleshoot infite loop on shut down phase - GH #2661 (cherry picked from commit 38acfb59dde232b1a9f0ffc206fb46b320cd8e10) --- Modified: src/modules/ctl/io_listener.c --- Diff: https://github.com/kamailio/kamailio/commit/2788f985fc4a5146c50bba15febe73f… Patch: https://github.com/kamailio/kamailio/commit/2788f985fc4a5146c50bba15febe73f… --- diff --git a/src/modules/ctl/io_listener.c b/src/modules/ctl/io_listener.c index 93ce89c948..ac8f64fc90 100644 --- a/src/modules/ctl/io_listener.c +++ b/src/modules/ctl/io_listener.c @@ -495,7 +495,7 @@ static int handle_stream_read(struct stream_connection* s_c, int idx) DBG("handle_stream read: eof on %s\n", s_c->parent->name); goto close_connection; } - LM_INFO("bytes read: %d\n", bytes_read); + LM_DBG("bytes read: %d\n", bytes_read); r->end+=bytes_read; if (bytes_read && (bytes_read<r->bytes_to_go)){ r->bytes_to_go-=bytes_read; @@ -515,7 +515,7 @@ static int handle_stream_read(struct stream_connection* s_c, int idx) /* error while processing the packet => close the connection */ goto close_connection; } - LM_INFO("bytes processed: %d\n", bytes_processed); + LM_DBG("bytes processed: %d\n", bytes_processed); r->proc+=bytes_processed; r->bytes_to_go=bytes_needed; if (bytes_needed>0){

3 years, 8 months

← Newer
1
...
40
41
42
43
44
45
46
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2021