<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This change modifies the `pv_auth_check` function to take an optional second password argument `passwd2`. The motivation for this change is to allow authenticating against two passwords, which is useful if you want to eg. rotate passwords periodically and still allow using the previous password during a transition period. You can technically do this with two calls to `pv_auth_check`, but with `nonce_count` enabled the first call will invalidate nc which will always cause the second call to fail.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3126
-- Commit Summary --
* auth: Add pv_auth_check overload with second passwd parameter
-- File Changes --
M src/modules/auth/auth_mod.c (143)
M src/modules/auth/doc/auth_functions.xml (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3126.patchhttps://github.com/kamailio/kamailio/pull/3126.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3126
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3126(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
By default when doing dns failover the tm module will try next ips only when receiving 503 code or no response.
the new failover_reply_codes provides a way to try next ip when receiving specific codes or class code.
for example try next ip even if the previous one returned 408
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3129
-- Commit Summary --
* Enable tm dns failover to try next ip on receiving code other than 503
-- File Changes --
M src/modules/tm/doc/params.xml (25)
M src/modules/tm/t_funcs.c (11)
M src/modules/tm/t_reply.c (12)
M src/modules/tm/t_reply.h (4)
M src/modules/tm/tm.c (139)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3129.patchhttps://github.com/kamailio/kamailio/pull/3129.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3129
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3129(a)github.com>
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If you submit a feature request (or enhancement) add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
All ips destination of DNS Failover are tried only if either no response or 503 response.
I woud like to try others ips when receiving code other than 503 response (example when receiving 408 from a previous one).
<!--
Explain what you did, what you expected to happen, and what actually happened.
-->
### Expected behavior
#### Actual observed behavior
#### Debugging Data
```
None
```
#### Log Messages
<!--
Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
None
```
#### SIP Traffic
<!--
If the issue is exposed by processing specific SIP messages, grab them with ngrep or save in a pcap file, then add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site).
-->
```
obvious
```
### Possible Solutions
A possible solution will be to modify the reply_received function of tm's t_reply.c file.
```
int reply_received( struct sip_msg *p_msg )
{
}
```
<!--
If you found a solution or workaround for the issue, describe it. Ideally, provide a pull request with a improvement.
-->
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
(paste your output here)
```
* **Operating System**:
<!--
Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...;
Kernel details (output of `uname -a`)
-->
```
(paste your output here)
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3122
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3122(a)github.com>
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [X] Related to issue #3091
#### Description
`module_group_standard` and `slack` are not build on FreeBSD environment.
The proposed patch fixes it and makes the module is consistent with the rest of modules.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3130
-- Commit Summary --
* Makefile.groups: renamed malloc_test to misctest
* slack: Makefile - support for FreeBSD build
-- File Changes --
M src/Makefile.groups (2)
M src/modules/slack/Makefile (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3130.patchhttps://github.com/kamailio/kamailio/pull/3130.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3130
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3130(a)github.com>