sr-dev July 2022

sr-dev@lists.kamailio.org

11 participants
230 discussions

[kamailio/kamailio] dialog: set context iuid for CANCEL requests (PR #3096)
by descartin 26 Aug '22

26 Aug '22

set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Using kamailio 5.4 version, we have seen that dlg_isflagset is not detecting a dialog flag set in the request route for the initial INVITE, when a CANCEL request arrives. We have applied this change to set the dialog context unique ide for this request. Since it's done on dlg_onreply, dlg_onroute and dlg_ontimeout functions. This way, dlg_get_by_iuid(&dctx->iuid) in the function ki_dlg_isflagset is not NULL and dialog flags are detected. Is this change correct? Or can it generate any kind of issues? thanks a lot and regards David You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3096 -- Commit Summary -- * dialog: set context iuid for CANCEL requests to let isflagset function return the right value in case a dialog flag was previously set on the call -- File Changes -- M src/modules/dialog/dlg_handlers.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3096.patch https://github.com/kamailio/kamailio/pull/3096.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3096 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3096(a)github.com>

3 6

[kamailio/kamailio] pv: add monotonic clock to TimeVal pseudovariable (PR #3191)
by Matteo 23 Aug '22

23 Aug '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Sometime is helpful to have a monotonic timer to attach to events in order to discard out-of-order ones on receiving side. Current time values are not ideal since are subject to clock skews, adjustment and so on. Since we have system monotonic clock we can use that value to have a monotonic counter. To be 100% fair CLOCK_MONOTONIC can still be skewed only by ntp adjustment, that's why we try to use CLOCK_MONOTONIC_RAW which is linux-only (afaik) that do not suffer from such adjustments. The new pseudovariable is `$TV(Sm)`, which returns the monotonic counter as a string. Note that even if is based on clock, it starts from an unspecified point in time, so should really be treated as an always increasing counter. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3191 -- Commit Summary -- * pv: add monotonic clock to TimeVal pseudovariable -- File Changes -- M src/modules/pv/pv_time.c (24) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3191.patch https://github.com/kamailio/kamailio/pull/3191.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3191 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3191(a)github.com>

2 5

[kamailio/kamailio] incomplete values and Wrong Counting for $hfl and $hflc (Issue #3194)
by patrickarton 22 Aug '22

22 Aug '22

3 4

[kamailio/kamailio] Path MTU discovery for IPv6 (PR #3141)
by vanrein 21 Aug '22

21 Aug '22

#### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches (no, it is a requirement to use UDP/IPv6 with everyone) - [X] Tested changes locally (same results as before with the Kamailio test framework) - [ ] Related to issue #3119 #### Description The IPv6 support for Path MTU discovery is absent, but IPv6 has no DF flag to allow downstream fragmentation. See Issue #3119 for my discovery / learning path. In short, unconnected UDP sockets do not learn Path MTU problems, so a message dropped once will be dropped again on resend. Using `IPV6_PMTUDISC_WANT`, any knowledge in the kernel can be used to fragment the message at sending time, as intended for IPv6. These patches actually correct two IPv6-related things in the `core/udp_server.c`, 1. Benefit from any kernel knowledge about Path MTU for IPv6 2. The same option to learn from UDP_ERRORS is now available for IPv6 Do note that the last has not been implemented for IPv4 or IPv6. It is more useful for IPv6, allowing instant "tm" resends for Path MTU, but not "sl" I think. I cannot do that work, but this brings IPv6 to the same level as IPv4. ``` commit 0f90cff05c1a448eb2f85f83b4c087ab32ede11 Author: Rick van Rein <rick(a)openfortress.nl> Date: Sat Jun 11 10:57:32 2022 +0000 core: Issue 3119. Handling ICMPv6 Packet too Big - This was only defined for IPv4 under flag UDP_ERRORS - IPv6 has no toggle DF to clear for en-route fragmentation - Kamailio currently does not collect with recvmsg(...,MSG_ERRQUEUE) - The benefits of adding that can be instant resends for "tm" messages - Note that "sl" messages will have been forgotten at this point commit 6b404b5f9807174177bee36eaf3543be0794f55e Author: Rick van Rein <rick(a)openfortress.nl> Date: Sat Jun 11 10:44:27 2022 +0000 core: Issue #3119. Path MTU kernel info for IPv6 - For IPv4, DF is an option; for IPv6 it is always active - This makes pmtu_discover an IPv4-only option - This means that we should set IPV6_MTU_DISCOVER to IPV6_PMTUDISC_WANT - Unconnected UDP sockets can now learn from ICMPv6 "Packet too Big" - As a result, hitting a Path MTU upper bound is a learning process - This should stop consistent SIP packet drops due to Path MTU ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3141 -- Commit Summary -- * core: Issue #3119. Path MTU kernel info for IPv6 * core: Issue 3119. Handling ICMPv6 Packet too Big -- File Changes -- M doc/misc/NEWS (2) M src/core/udp_server.c (44) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3141.patch https://github.com/kamailio/kamailio/pull/3141.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3141 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3141(a)github.com>

3 13

[kamailio/kamailio] usrloc keepalive does not work for TLS connections (Issue #3178)
by abrezinsky 17 Aug '22

17 Aug '22

### Description The keepalive (ka*) features of usrloc does not work for TLS connections (and probably TCP). If a TLS connection is registered, the keepalive code attempts to send OPTIONS packets to the endpoint using UDP. Additionally, a TCP/TLS connection is not re-used and the code attempts to create a new one each request. ### Troubleshooting #### Reproduction Enable keepalive and register a phone using TLS #### Log Messages Kamailio Host: 10.15.5.116 Phone: 10.15.5.117 Phone is registered and seen in the registry ``` kamctl ul show { "jsonrpc": "2.0", "result": { "Domains": [{ "Domain": { "Domain": "location", "Size": 1024, "AoRs": [{ "Info": { "AoR": "anonymous", "HashID": 3819435025, "Contacts": [{ "Contact": { "Address": "sips:anonymous@10.15.5.117:5061", "Expires": 3531, "Q": -1, "Call-ID": "d06e987694afb559", "CSeq": 521595368, "User-Agent": "testclient/1.0", "Received": "[not set]", "Path": "[not set]", "State": "CS_NEW", "Flags": 0, "CFlags": 0, "Socket": "tls:10.15.5.116:5061", "Methods": 7903, "Ruid": "uloc-62c87f5c-1b6b-2", "Instance": "<urn:uuid:00000000-0000-1000-8000-0010492e1879>", "Reg-Id": 0, "Server-Id": 0, "Tcpconn-Id": 17, "Keepalive": 0, "Last-Keepalive": 1657310753, "KA-Roundtrip": 0, "Last-Modified": 1657310753 } }] } } ], "Stats": { "Records": 1, "Max-Slots": 1 } } }] }, "id": 14871 ``` When the keepalive code runs it shows the following: ``` Jul 8 14:27:52 localhost kamailio[6976]: 33(7012) DEBUG: usrloc [ul_keepalive.c:112]: ul_ka_urecord(): keepalive for aor: anonymous Jul 8 14:27:52 localhost kamailio[6976]: 33(7012) DEBUG: usrloc [ul_keepalive.c:235]: ul_ka_urecord(): keepalive request (len: 295) [[ Jul 8 14:27:52 localhost kamailio[6976]: OPTIONS sips:anonymous@10.15.5.117:5061 SIP/2.0 Jul 8 14:27:52 localhost kamailio[6976]: Via: SIP/2.0/UDP 10.15.5.116:5061;branch=z9hG4bKx.20.1.0 Jul 8 14:27:52 localhost kamailio[6976]: From: <sips:10.15.5.116:5061>;tag=uloc-62c87f5c-1b71-1-e3a7f411-62c88538-cc68d-14.1 Jul 8 14:27:52 localhost kamailio[6976]: To: <sip:anonymous@kamailio.org> Jul 8 14:27:52 localhost kamailio[6976]: Call-ID: ksrulka-20.1 Jul 8 14:27:52 localhost kamailio[6976]: CSeq: 80 OPTIONS Jul 8 14:27:52 localhost kamailio[6976]: Content-Length: 0 Jul 8 14:27:52 localhost kamailio[6976]: #015 Jul 8 14:27:52 localhost kamailio[6976]: ]] Jul 8 14:27:52 localhost kamailio[6976]: 33(7012) ERROR: <core> [core/udp_server.c:597]: udp_send(): sendto(sock, buf: 0x7fffe728ece0, len: 295, 0, dst: (10.15.5.117:5061), tolen: 16) - err: Bad file descriptor (9) ``` ### Possible Solutions There are 2 problems here. First, the address record does not have a transport defined. https://github.com/kamailio/kamailio/blob/a466d0b73a66b18419555eca437136f1b… at this point, `sdst.s` is "sips:anonymous@10.15.5.117:5061" so parse_uri returns a proto of `UDP`. If you override the value to "sips:anonymous@10.15.5.117:5061;transport=tls" then the code works as expected. The protocol is detected as TLS and the OPTIONS message generated later has the correct `Via` header. I'm not sure if the problem is that the address record is missing the transport, or if we need to infer the transport from the socket connection. The second issue is that the keepalive code doesn't re-use TCP/TLS connections. In the ul_ka_send() function ) all of the socket IDs hardcoded to '0' https://github.com/kamailio/kamailio/blob/a466d0b73a66b18419555eca437136f1b… This is easily fixable by adding in ``` if(uc->tcpconn_id) { idst.id = uc->tcpconn_id; } ``` to `ul_ka_urecord()` and removing all of the `kadst->id=0;` lines from the `ul_ka_send()` function. This works for in-memory during testing. I believe the tcpconn_id field needs to be set in ul_ka_db_records if you're returning it from the DB. I don't have an environment setup to test that. With those two changes made (hardcoding the transport and fixing the connection id) the keepalives are sent and work as expected: ``` 33(19413) DEBUG: usrloc [ul_keepalive.c:112]: ul_ka_urecord(): keepalive for aor: anonymous 33(19413) DEBUG: usrloc [ul_keepalive.c:169]: ul_ka_urecord(): MANUALLY OVERRIDING SDST: sips:anonymous@10.15.5.117:5061;transport=tls 33(19413) DEBUG: usrloc [ul_keepalive.c:247]: ul_ka_urecord(): keepalive request (len: 288) [[ OPTIONS sips:anonymous@10.15.5.117:5061 SIP/2.0 Via: SIP/2.0/TLS 10.15.5.116:5061;branch=z9hG4bKx.33.1.0 From: <sips:10.15.5.116:5061>;tag=uloc-62c8af83-4bd9-1-e3a7f411-62c8b37f-f2a22-21.1 To: <sip:anonymous@kamailio.org> Call-ID: ksrulka-33.1 CSeq: 80 OPTIONS Content-Length: 0 ]] 33(19413) DEBUG: <core> [core/tcp_main.c:1644]: _tcpconn_find(): found connection by id: 1 33(19413) DEBUG: <core> [core/tcp_main.c:2539]: tcpconn_send_put(): found fd in cache (4, 0x7fbaef193db8, 1) 33(19413) DEBUG: <core> [core/tcp_main.c:2761]: tcpconn_do_send(): sending... 33(19413) DEBUG: <core> [core/tcp_main.c:2794]: tcpconn_do_send(): after real write: c= 0x7fbaef193db8 n=317 fd=4 ``` I assume that we'd want to re-use a TCP/TLS connection but maybe that needs to be an option (ka_reuse_tcp) if other people are expecting the current behavior of creating a new connection for each new keepalive request. ### Additional Information ``` version: kamailio 5.7.0-dev0 (x86_64/linux) a466d0 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a466d0 compiled on 11:27:35 Jul 8 2022 with gcc 8.3.0 ``` * **Operating System**: Debian Buster -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3178 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3178(a)github.com>

3 6

[kamailio/kamailio] tls: add timestamp and sni info for a session (PR #3193)
by Stefan Mititelu 17 Aug '22

17 Aug '22

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3193 -- Commit Summary -- * tls: add timestamp and sni info for a session -- File Changes -- M src/core/tcp_conn.h (1) M src/core/tcp_main.c (1) M src/modules/tls/tls_rpc.c (18) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3193.patch https://github.com/kamailio/kamailio/pull/3193.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3193 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3193(a)github.com>

4 17

[kamailio/kamailio] [stirshaken] add identity header in reply messages or to a separate variable (#2770)
by sergei lavrov 14 Aug '22

14 Aug '22

### Description I'm unable to add the generated `Identity` value to reply message when `kamailio` acts as a redirect server and replies with `302 Moved Temporarily` instead of relaying `INVITE`. This code doesn't work, i.e. no `Identity` header in `302 Moved Temporarily` message: ``` if (stirshaken_add_identity($var(x5u), $var(attest), $var(origtn_val), $var(desttn_val), $var(origid)) == 1) { append_branch("sip:$rU@127.0.0.1:6060"); sl_send_reply("302", "Moved Temporarily"); exit; } ``` ### Expected behavior It would be nice if the `stirshaken_add_identity_*` functions would add the generated `Identity` header to the reply messages too, or store the generated `Identity` header in a separate variable, like `$identity`, for the future processing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2770

4 10

[kamailio/kamailio] secfilter: Wrong format on RPC response data (Issue #2992)
by Olle E. Johansson 12 Aug '22

12 Aug '22

secfilter RPC functions to get statistics use a console format to printing data, suitable for **kamcmd** but not for any RPC method. This should be converted to a machine-parsable data structure (much like dispatcher, usrloc and htable data dumps). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2992 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/2992(a)github.com>

2 3

[kamailio/kamailio] Fix ksr_version_control() for FreeBSD build (PR #3184)
by Boris Korzun 12 Aug '22

12 Aug '22

2 2

[kamailio/kamailio] uac_redirect: segfault when calling get_redirects("1") [regression] (Issue #3197)
by Alex Hermann 12 Aug '22

12 Aug '22

Since updating to 5.6, Kamailio segfaults when calling `get_redirects("1")`. ``` #0 0x000055d12c93c527 in get_str_fparam (dst=dst@entry=0x7ffd246edfe0, msg=msg@entry=0x7f83973b6a80, param=0x0) at core/sr_module.c:1646 val = {n = 1, s = {s = 0x1 <error: Cannot access memory at address 0x1>, len = 749136082}, re = 0x1} ret = <optimized out> avp = <optimized out> pv_val = {rs = {s = 0x1 <error: Cannot access memory at address 0x1>, len = 749136082}, ri = 1, flags = 0} __func__ = "get_str_fparam" #1 0x00007f838d2f0a17 in w_get_redirect2 (msg=0x7f83973b6a80, max_c=0x0, reason=<optimized out>) at uac_redirect.c:337 n = <optimized out> max = <optimized out> sreason = {s = 0x1a <error: Cannot access memory at address 0x1a>, len = -828131391} __func__ = "w_get_redirect2" #2 0x000055d12c975624 in do_action (h=h@entry=0x7ffd246ee820, a=a@entry=0x7f83cedd3670, msg=msg@entry=0x7f83973b6a80) at core/action.c:1085 ret = <optimized out> v = <optimized out> ... ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3197 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3197(a)github.com>

4 5

← Newer
1
...
9
10
11
12
13
14
15
...
23
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2022