<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3198
-- Commit Summary --
* uac.reg_add
-- File Changes --
M src/modules/uac/doc/uac_admin.xml (2)
M src/modules/uac/uac_reg.c (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3198.patchhttps://github.com/kamailio/kamailio/pull/3198.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3198
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3198(a)github.com>
ubuntu 18.04 , kamailio v5.3.8 :
UE A and B register sucess on kamailio server over tcp. When UE A calls UE B, kamailio server receive the INVITE over tcp from UE A, then it send invite to UE B. But the invite sent by kamailio to UE B is over UDP. Then UE B returns ICMP Destination unreachable(Port unreachable).
Is the error configuration related or a bug?
Any kind of help is highly appreciated.
Best Regards,
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3203
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3203(a)github.com>
Module: kamailio
Branch: master
Commit: 8fa77cf95a1e985405d3471fc5655e2ec6a2e192
URL: https://github.com/kamailio/kamailio/commit/8fa77cf95a1e985405d3471fc5655e2…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-07-27T09:31:30+02:00
modules: readme files regenerated - acc ... [skip ci]
---
Modified: src/modules/acc/README
---
Diff: https://github.com/kamailio/kamailio/commit/8fa77cf95a1e985405d3471fc5655e2…
Patch: https://github.com/kamailio/kamailio/commit/8fa77cf95a1e985405d3471fc5655e2…
---
diff --git a/src/modules/acc/README b/src/modules/acc/README
index 878623d24f..1ea4e6f98d 100644
--- a/src/modules/acc/README
+++ b/src/modules/acc/README
@@ -529,6 +529,11 @@ Note
information given will not be stored in the CDR as they cannot be
accessed by the end of the call when the CDR is logged.
+ The dialog module needs to be engaged on the dialogs that should be
+ accounted, that they will be tracked by the server. This is usally done
+ by calling the function dlg_manage() or setting the dlg_flag. Refer to
+ the documentation of the dialog module for more information.
+
Sometimes, dialogs expire because the UA has a problem and a final
message is never transmitted. You can toggle on/off the generation of
CDR-based logging in such cases with only the dlg_vars showing by using
Module: kamailio
Branch: master
Commit: 3ec40d792df5bcee838eee3e5e0e89a2ebdcc453
URL: https://github.com/kamailio/kamailio/commit/3ec40d792df5bcee838eee3e5e0e89a…
Author: Henning Westerholt <hw(a)gilawa.com>
Committer: Henning Westerholt <hw(a)gilawa.com>
Date: 2022-07-27T07:26:57Z
acc: add some explanation that dialogs need to be tracked for CDR accounting
---
Modified: src/modules/acc/doc/acc_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/3ec40d792df5bcee838eee3e5e0e89a…
Patch: https://github.com/kamailio/kamailio/commit/3ec40d792df5bcee838eee3e5e0e89a…
---
diff --git a/src/modules/acc/doc/acc_admin.xml b/src/modules/acc/doc/acc_admin.xml
index 04fe28a8da7..42f4b88bd11 100644
--- a/src/modules/acc/doc/acc_admin.xml
+++ b/src/modules/acc/doc/acc_admin.xml
@@ -324,6 +324,13 @@ if (uri=~"sip:+40") /* calls to Romania */ {
end of the call when the CDR is logged.
</para>
+ <para>
+ The dialog module needs to be engaged on the dialogs that should be accounted, that
+ they will be tracked by the server. This is usally done by calling the function
+ <emphasis>dlg_manage()</emphasis> or setting the <emphasis>dlg_flag</emphasis>.
+ Refer to the documentation of the dialog module for more information.
+ </para>
+
<para>
Sometimes, dialogs expire because the UA has a problem and a final message is never
transmitted. You can toggle on/off the generation of CDR-based logging in such cases
Module: kamailio
Branch: master
Commit: 3a3003b42ce6eadbc9b12e45fd4668f12e783cfb
URL: https://github.com/kamailio/kamailio/commit/3a3003b42ce6eadbc9b12e45fd4668f…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2022-07-27T08:16:23+02:00
modules: readme files regenerated - nathelper ... [skip ci]
---
Modified: src/modules/nathelper/README
---
Diff: https://github.com/kamailio/kamailio/commit/3a3003b42ce6eadbc9b12e45fd4668f…
Patch: https://github.com/kamailio/kamailio/commit/3a3003b42ce6eadbc9b12e45fd4668f…
---
diff --git a/src/modules/nathelper/README b/src/modules/nathelper/README
index 0b5abfb614..e091d2018f 100644
--- a/src/modules/nathelper/README
+++ b/src/modules/nathelper/README
@@ -731,9 +731,11 @@ if(is_rfc1918("$rd")) {
5.9. set_contact_alias([trim])
Adds an “;alias=ip~port~transport” parameter to the contact URI
- containing the received ip, port, and transport protocol. The new
- contact URI is immediately visible to other modules in the way the
- fix_nated_contact() does it.
+ containing the received ip, port, and transport protocol. The update of
+ contact URI is signaled to a few other modules in the way the
+ fix_nated_contact() does it by using the internal flags. The new value
+ is not visible to pseudo-variables and it does not change the SIP
+ message buffer.
Meaning of parameters:
* trim - by default, set_contact_alias() will not detect and trim an
<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for bug reports.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment).
-->
### Description
The docs for `set_contact_alias()` says:
> **The new contact URI is immediately visible to other modules** in the way the fix_nated_contact() does it.
I don't know exactly what is meant by the last part of that sentence as that isn't documented, but the first part certainly doesn't hold:
The following snippet:
```
xlog("L_INFO", " Received Contact: $ct");
if (set_contact_alias()) {
xlog("L_INFO", " Aliassed Contact: $ct");
}
```
Causes these log entries:
```
2022-07-26T15:41:57.351148+02:00 proxydev001 prx1[12116]: INFO: Received Contact: sip:sipp@unknowndomain;transport=udp
2022-07-26T15:41:57.351148+02:00 proxydev001 prx1[12116]: INFO: Aliassed Contact: sip:sipp@unknowndomain;transport=udp
```
Which clearly shows that the changed uri is **not visible** to the `pv` module (which exports `$ct`).
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3201
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3201(a)github.com>
Module: kamailio
Branch: master
Commit: c009f27578e8df9aa77ab852325dad8dc710d6c8
URL: https://github.com/kamailio/kamailio/commit/c009f27578e8df9aa77ab852325dad8…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-07-27T08:04:08+02:00
nathelper: docs - rephrased the remarks about set_contact_alias()
---
Modified: src/modules/nathelper/doc/nathelper_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/c009f27578e8df9aa77ab852325dad8…
Patch: https://github.com/kamailio/kamailio/commit/c009f27578e8df9aa77ab852325dad8…
---
diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml
index d0e8a18ea4c..a8828baa74f 100644
--- a/src/modules/nathelper/doc/nathelper_admin.xml
+++ b/src/modules/nathelper/doc/nathelper_admin.xml
@@ -878,8 +878,10 @@ if(is_rfc1918("$rd")) {
<para>
Adds an <quote>;alias=ip~port~transport</quote> parameter to the
contact URI containing the received ip, port, and transport protocol.
- The new contact URI is immediately visible to other modules in the
- way the <function>fix_nated_contact()</function> does it.
+ The update of contact URI is signaled to a few other modules in the
+ way the <function>fix_nated_contact()</function> does it by using the
+ internal flags. The new value is not visible to pseudo-variables and it
+ does not change the SIP message buffer.
</para>
<para>Meaning of parameters:</para>
<itemizedlist>
### Description
Typo in function example at src/modules/siputils/doc/siputils_admin.xml:
Instead of:
...
if(is_first_hop()) { ... }
...
if(is_first_hop_mode("1")) { ... }
...
example should be:
...
if (is_first_hop()) { ... }
...
if (is_first_hop("1")) { ... }
...
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3200
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3200(a)github.com>