sr-dev July 2022

sr-dev@lists.kamailio.org

11 participants
229 discussions

by Hardik Patel

Hello Team, We are using Kamailio 5.4.7 and we found there is a random crash. We have observed the core logs and we noticed it is due to some of the RPC events. We have noticed it has been crashed from the "ctl handler" process. Please find the attached crash logs and Kamailio version details are mentioned below. version: kamailio 5.4.7 (x86_64/linux) a19fe1 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a19fe1 compiled on 02:56:57 Feb 16 2022 with gcc 8.3.0 -- Hardik Patel

2 years, 4 months

Kamailio Random Crash Alert - 5.4.7

by Hardik Patel

2 years, 4 months

[kamailio/kamailio] presence: No autocommit+rollback if no active watchers (PR #3183)

by Alessio Garzi

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This is a small performance improvement, the goal is to avoid issuing rollbacks if not necessary. On my setup, Kamailio presence executes a lot of ROLLBACKS in MariaDB since function process_dialogs() runs repeatedly. What see inside MariaDB logs is the following ``` SET autocommit=0 select `presentity_uri`,`callid`,`to_tag`,`from_tag`,`event` from `active_watchers` where `updated`=3 AND `event`<>'presence.winfo'\G ROLLBACK ``` Maybe we can improve this behaviour telling presence to do autocommit to do not execute them if the select returns zero elements? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3183 -- Commit Summary -- * presence: No autocommit+rollback if no active watchers -- File Changes -- M src/modules/presence/notify.c (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3183.patch https://github.com/kamailio/kamailio/pull/3183.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3183 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3183(a)github.com>

2 years, 4 months

git:master:c80cccd9: presence: No autocommit+rollback if no active watchers

by Victor Seva

Module: kamailio Branch: master Commit: c80cccd996dcc3b91d4f0f68a2de51104a16d1a5 URL: https://github.com/kamailio/kamailio/commit/c80cccd996dcc3b91d4f0f68a2de511… Author: Alessio Garzi <agarzi(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-07-12T15:39:33+02:00 presence: No autocommit+rollback if no active watchers - In case the active_watcher query returns no elements there is a weird situation where kamailio first runs the select for active_watcher then rollbacks. This can happen a lot of times for each second since function process_dialogs() runs repeatedly. For this reason trying to avoid the rollback can result in a quite good performance boost. --- Modified: src/modules/presence/notify.c --- Diff: https://github.com/kamailio/kamailio/commit/c80cccd996dcc3b91d4f0f68a2de511… Patch: https://github.com/kamailio/kamailio/commit/c80cccd996dcc3b91d4f0f68a2de511… --- diff --git a/src/modules/presence/notify.c b/src/modules/presence/notify.c index cf52c21c22..4980dc4b0a 100644 --- a/src/modules/presence/notify.c +++ b/src/modules/presence/notify.c @@ -2867,6 +2867,7 @@ int process_dialogs(int round, int presence_winfo) str ev_sname, winfo = str_init("presence.winfo"); int now = (int)time(NULL); int updated = 0; + int no_active_watchers = 0; db_query_f query_fn = pa_dbf.query_lock ? pa_dbf.query_lock : pa_dbf.query; query_cols[n_query_cols] = &str_updated_col; @@ -2900,13 +2901,6 @@ int process_dialogs(int round, int presence_winfo) goto error; } - if(pa_dbf.start_transaction) { - if(pa_dbf.start_transaction(pa_db, pres_db_table_lock) < 0) { - LM_ERR("in start_transaction\n"); - goto error; - } - } - /* Step 1: Find active_watchers that require notification */ if(query_fn(pa_db, query_cols, query_ops, query_vals, result_cols, n_query_cols, n_result_cols, 0, &dialog_list) @@ -2920,7 +2914,17 @@ int process_dialogs(int round, int presence_winfo) } if(dialog_list->n <= 0) + { + no_active_watchers = 1; goto done; + } + + if(pa_dbf.start_transaction) { + if(pa_dbf.start_transaction(pa_db, pres_db_table_lock) < 0) { + LM_ERR("in start_transaction\n"); + goto error; + } + } /* Step 2: Update the records so they are not notified again */ if(pa_dbf.update(pa_db, query_cols, query_ops, query_vals, update_cols, @@ -3164,7 +3168,7 @@ int process_dialogs(int round, int presence_winfo) if(dialog) pa_dbf.free_result(pa_db, dialog); - if(pa_dbf.abort_transaction) { + if(no_active_watchers == 0 && pa_dbf.abort_transaction) { if(pa_dbf.abort_transaction(pa_db) < 0) LM_ERR("in abort_transaction\n"); }

2 years, 4 months

[kamailio/kamailio] modify 'rpc uac.reg_add' (Issue #3179)

by hance2010

### Description  rpc uac.reg_add Use a dot (.) if no value should be set for auth_password, auth_ha1, contact_addr, realm,or socket ### Expected behavior https://github.com/kamailio/kamailio/blob/master/src/modules/uac/uac_reg.c#… ``` if(reg.realm.len==1 && reg.realm.s[0] == '.') { reg.realm.s = NULL; reg.realm.len = 0; } if(reg.socket.len==1 && reg.socket.s[0] == '.') { reg.socket.s = NULL; reg.socket.len = 0; } ``` #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` Master ``` * **Operating System**:  ``` Debian11 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3179 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3179(a)github.com>

2 years, 4 months

[kamailio/kamailio] core: crypto add support for SHA-512/256 for RFCs 8760/7616 (PR #3177)

by space88man

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This adds `core/` support for SHA-512/256. This is required for adding the SHA-512/256 digest algorithm to the `auth` module. References: *[RFC8760](https://datatracker.ietf.org/doc/html/rfc8760) *[RFC7616](https://datatracker.ietf.org/doc/html/rfc7616) *[SHA-512/256 initial hash values](https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3177 -- Commit Summary -- * core: crypto add support for SHA-512/256 for RFCs 8760/7616 -- File Changes -- M src/core/crypto/sha256.c (23) M src/core/crypto/sha256.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3177.patch https://github.com/kamailio/kamailio/pull/3177.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3177 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3177(a)github.com>

2 years, 4 months

git:master:805b921c: core: crypto add support for SHA-512/256 for RFCs 8760/7616

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 805b921c0d6958db1620b0712450ef7a128cb5ce URL: https://github.com/kamailio/kamailio/commit/805b921c0d6958db1620b0712450ef7… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-07-11T14:42:21+02:00 core: crypto add support for SHA-512/256 for RFCs 8760/7616 --- Modified: src/core/crypto/sha256.c Modified: src/core/crypto/sha256.h --- Diff: https://github.com/kamailio/kamailio/commit/805b921c0d6958db1620b0712450ef7… Patch: https://github.com/kamailio/kamailio/commit/805b921c0d6958db1620b0712450ef7… --- diff --git a/src/core/crypto/sha256.c b/src/core/crypto/sha256.c index d27fd016251..ba5562755d6 100644 --- a/src/core/crypto/sha256.c +++ b/src/core/crypto/sha256.c @@ -301,6 +301,18 @@ const static sha2_word64 sha512_initial_hash_value[8] = { 0x5be0cd19137e2179ULL }; +/* Initial hash value H for SHA-512/256 */ +const static sha2_word64 sha512_256_initial_hash_value[8] = { + 0x22312194FC2BF72CULL, + 0x9F555FA3C84C64C2ULL, + 0x2393B86B6F53B151ULL, + 0x963877195940EABDULL, + 0x96283EE2A88EFFE3ULL, + 0xBE5E1E2553863992ULL, + 0x2B0199FC2C85B8AAULL, + 0x0EB72DDC81C52CA2ULL +}; + /* * Constant used by SHA256/384/512_End() functions for converting the * digest to a readable hexadecimal character string: @@ -636,7 +648,7 @@ char* sr_SHA256_Data(const sha2_byte* data, size_t len, char digest[SHA256_DIGES } -/*** SHA-512: *********************************************************/ +/*** SHA-512 SHA-512/256: *********************************************************/ void sr_SHA512_Init(SHA512_CTX* context) { if (context == (SHA512_CTX*)0) { return; @@ -646,6 +658,15 @@ void sr_SHA512_Init(SHA512_CTX* context) { context->bitcount[0] = context->bitcount[1] = 0; } +void sr_SHA512_256_Init(SHA512_CTX* context) { + if (context == (SHA512_CTX*)0) { + return; + } + MEMCPY_BCOPY(context->state, sha512_256_initial_hash_value, SHA512_DIGEST_LENGTH); + MEMSET_BZERO(context->buffer, SHA512_BLOCK_LENGTH); + context->bitcount[0] = context->bitcount[1] = 0; +} + #ifdef SHA2_UNROLL_TRANSFORM /* Unrolled SHA-512 round macros: */ diff --git a/src/core/crypto/sha256.h b/src/core/crypto/sha256.h index e93bdad855a..5710ed81a96 100644 --- a/src/core/crypto/sha256.h +++ b/src/core/crypto/sha256.h @@ -97,6 +97,7 @@ char* sr_SHA384_End(SHA384_CTX*, char[SHA384_DIGEST_STRING_LENGTH]); char* sr_SHA384_Data(const uint8_t*, size_t, char[SHA384_DIGEST_STRING_LENGTH]); void sr_SHA512_Init(SHA512_CTX*); +void sr_SHA512_256_Init(SHA512_CTX*); void sr_SHA512_Update(SHA512_CTX*, const uint8_t*, size_t); void sr_SHA512_Final(sha2_byte[SHA512_DIGEST_LENGTH], SHA512_CTX*); char* sr_SHA512_End(SHA512_CTX*, char[SHA512_DIGEST_STRING_LENGTH]); @@ -117,6 +118,7 @@ char* sr_SHA384_End(); char* sr_SHA384_Data(); void sr_SHA512_Init(); +void sr_SHA512_256_Init(); void sr_SHA512_Update(); void sr_SHA512_Final(); char* sr_SHA512_End();

2 years, 4 months

[kamailio/kamailio] Disable GRUU (Issue #3181)

by adyryavko

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio -v version: kamailio 5.4.8 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**:  ``` Distributor ID: Debian Description: Debian GNU/Linux 10 (buster) Release: 10 Codename: buster ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3181 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3181(a)github.com>

2 years, 4 months

[kamailio/kamailio] trailing comma left on exclude_hf_value function (Issue #3180)

by patrickarton

2 years, 4 months

git:master:0080e06d: app_perl: Makefile - option to set the path to perl binary

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0080e06d36bc0263795fa7ff716fe0b2d218f5c1 URL: https://github.com/kamailio/kamailio/commit/0080e06d36bc0263795fa7ff716fe0b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-07-11T10:16:02+02:00 app_perl: Makefile - option to set the path to perl binary --- Modified: src/modules/app_perl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/0080e06d36bc0263795fa7ff716fe0b… Patch: https://github.com/kamailio/kamailio/commit/0080e06d36bc0263795fa7ff716fe0b… --- diff --git a/src/modules/app_perl/Makefile b/src/modules/app_perl/Makefile index 70e440e77d..36820a3c89 100644 --- a/src/modules/app_perl/Makefile +++ b/src/modules/app_perl/Makefile @@ -1,4 +1,4 @@ -# perl module makefile +# app_perl module makefile # # # WARNING: do not run this directly, it should be run by the main Makefile @@ -8,14 +8,16 @@ auto_gen=kamailioxs.c NAME=app_perl.so LIBS= +PERLBIN ?= perl + ifeq ($(PERLLDOPTS),) - LIBS+=`perl -MExtUtils::Embed -e ldopts` + LIBS+=`$(PERLBIN) -MExtUtils::Embed -e ldopts` else LIBS+=$(PERLLDOPTS) endif ifeq ($(PERLCCOPTS),) - PERLCCOPTS=$(shell perl -MExtUtils::Embed -e ccopts) + PERLCCOPTS=$(shell $(PERLBIN) -MExtUtils::Embed -e ccopts) endif DEFS+=$(PERLCCOPTS) @@ -25,7 +27,7 @@ PODFILES=kamailioxs.xs `find lib/perl -name *.pm` ifeq ($(TYPEMAP),) ifeq ($(PERLLIBPATH),) - PERLLIBPATH=`perl -MConfig -e 'print $$Config{installprivlib}'` + PERLLIBPATH=`$(PERLBIN) -MConfig -e 'print $$Config{installprivlib}'` endif TYPEMAP=$(PERLLIBPATH)/ExtUtils/typemap endif

2 years, 4 months

← Newer
1
...
13
14
15
16
17
18
19
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2022