sr-dev August 2022

sr-dev@lists.kamailio.org

16 participants
280 discussions

[kamailio/kamailio] secfilter: Wrong format on RPC response data (Issue #2992)
by Olle E. Johansson 12 Aug '22

12 Aug '22

secfilter RPC functions to get statistics use a console format to printing data, suitable for **kamcmd** but not for any RPC method. This should be converted to a machine-parsable data structure (much like dispatcher, usrloc and htable data dumps). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2992 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/2992(a)github.com>

2 3

[kamailio/kamailio] secfilter: machine-parsable data structure for RPC printing data (PR #3213)
by Jose Luis Verdeguer 12 Aug '22

12 Aug '22

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3213 -- Commit Summary -- * secfilter: machine-parsable data structure for RPC printing data -- File Changes -- M src/modules/secfilter/secfilter_rpc.c (383) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3213.patch https://github.com/kamailio/kamailio/pull/3213.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3213 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3213(a)github.com>

3 8

git:master:d5ef682e: secfilter: updated samples [skip ci]
by Jose Luis Verdeguer 12 Aug '22

12 Aug '22

Module: kamailio Branch: master Commit: d5ef682ebe98ca87021a8e2344bb94c75747f53e URL: https://github.com/kamailio/kamailio/commit/d5ef682ebe98ca87021a8e2344bb94c… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2022-08-12T16:18:48+02:00 secfilter: updated samples [skip ci] --- Modified: src/modules/secfilter/doc/secfilter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d5ef682ebe98ca87021a8e2344bb94c… Patch: https://github.com/kamailio/kamailio/commit/d5ef682ebe98ca87021a8e2344bb94c… --- diff --git a/src/modules/secfilter/doc/secfilter_admin.xml b/src/modules/secfilter/doc/secfilter_admin.xml index ce7b6cea27a..9daa67d9523 100644 --- a/src/modules/secfilter/doc/secfilter_admin.xml +++ b/src/modules/secfilter/doc/secfilter_admin.xml @@ -814,29 +814,34 @@ ... User-agent ========== -[+] Blacklisted - ----------- - 0001 -> friendly-scanner - 0002 -> pplsip - 0003 -> sipcli - 0004 -> sundayddr - 0005 -> iWar - 0006 -> sipsak - 0007 -> VaxSIPUserAgent - 0008 -> SimpleSIP - 0009 -> SIP Call - 0010 -> Ozeki - 0011 -> VoIPSec - 0012 -> SIPScan - 0013 -> Conaito - 0014 -> UsaAirport - 0015 -> PortSIP VoIP SDK - 0016 -> zxcvfdf11 - 0017 -> fdgddfg546df4g8d5f - -[+] Whitelisted - ----------- - 0001 -> my custom ua +{ + User-Agent: { + Blacklisted: { + Value: friendly-scanner + Value: pplsip + Value: sipcli + Value: sundayddr + Value: iWar + Value: sipsak + Value: VaxSIPUserAgent + Value: SimpleSIP + Value: SIP Call + Value: Ozeki + Value: VoIPSec + Value: SIPScan + Value: Conaito + Value: UsaAirport + Value: PortSIP VoIP SDK + Value: zxcvfdf11 + Value: fdgddfg546df4g8d5f + Value: siptest + Value: Nmap NSE + } + Whitelisted: { + Value: my custom ua + } + } +} ... </programlisting> </example> @@ -850,40 +855,40 @@ User-agent <programlisting format="linespecific"> ... -Blocked messages (blacklist) -============================ -[+] By user-agent : 1256 -[+] By country : 45 -[+] By from domain : 0 -[+] By to domain : 0 -[+] By contact domain: 1 -[+] By IP address : 2552 -[+] By from name : 0 -[+] By to name : 0 -[+] By contact name : 0 -[+] By from user : 316 -[+] By to user : 134 -[+] By contact user : 0 - -Allowed messages (whitelist) -============================ -[+] By user-agent : 0 -[+] By country : 478 -[+] By from domain : 0 -[+] By to domain : 0 -[+] By contact domain: 0 -[+] By IP address : 0 -[+] By from name : 0 -[+] By to name : 0 -[+] By contact name : 0 -[+] By from user : 0 -[+] By to user : 0 -[+] By contact user : 0 - -Other blocked messages -====================== -[+] Destinations : 0 -[+] SQL injection : 213 +{ + Blacklist: { + User-Agent: 1256 + Country: 45 + From-Domain: 0 + To-Domain: 0 + Contact-Domain: 1 + IP-Address: 2552 + From-Name: 0 + To-Name: 0 + Contact-Name: 0 + From-User: 316 + To-User: 0134 + Contact-User: 0 + } + Whitelist: { + User-Agent: 0 + Country: 478 + From-Domain: 0 + To-Domain: 0 + Contact-Domain: 0 + IP-Address: 0 + From-Name: 0 + To-Name: 0 + Contact-Name: 0 + From-User: 0 + To-User: 0 + Contact-User: 0 + } + Other: { + Destination: 0 + SQL-Injection: 213 + } +} ... </programlisting> </example>

1 0

git:master:fe20e16b: secfilter: machine-parsable data structure for RPC printing data
by Jose Luis Verdeguer 12 Aug '22

12 Aug '22

Module: kamailio Branch: master Commit: fe20e16bf1e1656ef794699db345eefd3d1b8ac8 URL: https://github.com/kamailio/kamailio/commit/fe20e16bf1e1656ef794699db345eef… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2022-08-12T16:18:48+02:00 secfilter: machine-parsable data structure for RPC printing data --- Modified: src/modules/secfilter/secfilter_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/fe20e16bf1e1656ef794699db345eef… Patch: https://github.com/kamailio/kamailio/commit/fe20e16bf1e1656ef794699db345eef…

1 0

[kamailio/kamailio] build warnings (Issue #3208)
by sergey-safarov 12 Aug '22

12 Aug '22

``` CC (gcc) [kamailio] core/crypto/shautils.o CC (gcc) [kamailio] core/cfg/cfg.o CC (gcc) [kamailio] core/cfg/cfg_ctx.o core/cfg/cfg_ctx.c: In function 'cfg_update_defaults': core/cfg/cfg_ctx.c:287:28: warning: the comparison will always evaluate as 'true' for the pointer operand in '(unsigned char *)&ginst->vars + (sizetype)var->offset' must not be NULL [-Waddress] 287 | if(ginst->vars + var->offset) { | ^~~~~ CC (gcc) [kamailio] core/cfg/cfg_script.o CC (gcc) [kamailio] core/cfg/cfg_select.o ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3208 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3208(a)github.com>

2 2

git:master:26785f86: core/cfg: cast pointer to long to silent compiler warning
by Daniel-Constantin Mierla 12 Aug '22

12 Aug '22

Module: kamailio Branch: master Commit: 26785f866eeadc6944af83ae1a57e8ff100f60f5 URL: https://github.com/kamailio/kamailio/commit/26785f866eeadc6944af83ae1a57e8f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-12T14:32:20+02:00 core/cfg: cast pointer to long to silent compiler warning - GH #3208 --- Modified: src/core/cfg/cfg_ctx.c --- Diff: https://github.com/kamailio/kamailio/commit/26785f866eeadc6944af83ae1a57e8f… Patch: https://github.com/kamailio/kamailio/commit/26785f866eeadc6944af83ae1a57e8f… --- diff --git a/src/core/cfg/cfg_ctx.c b/src/core/cfg/cfg_ctx.c index a1e761f3a21..a9f19464bec 100644 --- a/src/core/cfg/cfg_ctx.c +++ b/src/core/cfg/cfg_ctx.c @@ -284,7 +284,7 @@ static int cfg_update_defaults(cfg_group_meta_t *meta, meta->array = array; clone_done = 1; } - if(ginst->vars + var->offset) { + if((unsigned long)ginst->vars + var->offset) { memcpy(ginst->vars + var->offset, new_val, cfg_var_size(var)); } else { LM_ERR("invalid variable offset\n");

1 0

[kamailio/kamailio] Missing documentation of deprecated ring_insert_callid in siputils (Issue #3212)
by Niklas Larsson 12 Aug '22

12 Aug '22

### Description Upgraded to 5.6 from 5.5, looked through docs - and no mention of removal of ring_insert_callid - so upgrade failed. Found https://github.com/kamailio/kamailio/issues/2989 ### Possible Solutions Add documentation that the function is removed, and how to replace it with textops/htable and/or reply routes -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3212 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3212(a)github.com>

3 3

[kamailio/kamailio] Fix ksr_version_control() for FreeBSD build (PR #3184)
by Boris Korzun 12 Aug '22

12 Aug '22

#### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description There's a problem after upgrade to 5.6 on FreeBSD. Kamailio isn't starting successful. ``` 14:19:20.540514 kamailio 40921 - - DEBUG: <core> [core/cfg.y:1964]: yyparse(): loading module tls.so 14:19:20.540893 kamailio 40921 - - DEBUG: <core> [core/sr_module.c:513]: ksr_locate_module(): found module to load </usr/local/lib/kamailio/modules/tls.so> 14:19:20.540912 kamailio 40921 - - DEBUG: <core> [core/sr_module.c:563]: load_module(): trying to load </usr/local/lib/kamailio/modules/tls.so> 14:19:20.543301 kamailio 40921 - - ERROR: <core> [core/sr_module.c:352]: ksr_version_control(): no version info in module </usr/local/lib/kamailio/modules/tls.so>: Undefined symbol "_nss_cache_cycle_prevention_function" ``` The problem is in `ksr_version_control()` probably. In FreeBSD environment it should to flush `dlerror` before call `dlsym()` - [dlopen(3)](https://www.freebsd.org/cgi/man.cgi?query=dlopen&sektion=3&a…at=html). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3184 -- Commit Summary -- * core: fix ksr_version_control() for FreeBSD build -- File Changes -- M src/core/sr_module.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3184.patch https://github.com/kamailio/kamailio/pull/3184.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3184 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3184(a)github.com>

2 2

git:master:a8769af4: core: fix ksr_version_control() for FreeBSD build
by Daniel-Constantin Mierla 12 Aug '22

12 Aug '22

Module: kamailio Branch: master Commit: a8769af4c3a497d0f6a81cff17861e566ffa87bc URL: https://github.com/kamailio/kamailio/commit/a8769af4c3a497d0f6a81cff17861e5… Author: drTr0jan <drtr0jan(a)yandex.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-08-12T13:52:38+02:00 core: fix ksr_version_control() for FreeBSD build --- Modified: src/core/sr_module.c --- Diff: https://github.com/kamailio/kamailio/commit/a8769af4c3a497d0f6a81cff17861e5… Patch: https://github.com/kamailio/kamailio/commit/a8769af4c3a497d0f6a81cff17861e5… --- diff --git a/src/core/sr_module.c b/src/core/sr_module.c index 2d787d7f9f3..013598c2a76 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -347,6 +347,9 @@ int ksr_version_control(void *handle, char *path) char **m_flags; char* error; +#ifdef __FreeBSD__ + (void) dlerror(); +#endif m_ver=(char **)dlsym(handle, "module_version"); if ((error=(char *)dlerror())!=0) { LM_ERR("no version info in module <%s>: %s\n", path, error);

1 0

Large memory allocation on module startup
by kthulasizwe＠gmail.com 12 Aug '22

12 Aug '22

Hi Guys, I have recently modified a custom module, where I now shm_mallocxz 2MB, as part of module start up and this memory is not being used as yet. Previously, the would be smaller chunks(100 bytes at most) shm_malloced during message processing. I have observed significant runtime performance degradation from just this single change. I would appreciate any suggestions/thoughts you might have. Below are some the relevant details. OS:Alpine Linux RAM: 16GB Configured Shared memory: 4GB shm_force_alloc=1 Typical shared memory usage: 1.5GB System swapping is disabled, also observed during load testing that no mem is getting swapped.

2 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2022