sr-dev August 2022

sr-dev@lists.kamailio.org

16 participants
282 discussions

git:master:b4ab0fdc: siptrace: Update doc for the two new modparams
by Stefan Mititelu 10 Aug '22

10 Aug '22

Module: kamailio Branch: master Commit: b4ab0fdcb9f49b2a3b3cac24b20a0f4e50283468 URL: https://github.com/kamailio/kamailio/commit/b4ab0fdcb9f49b2a3b3cac24b20a0f4… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Date: 2022-08-10T10:24:51+03:00 siptrace: Update doc for the two new modparams --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b4ab0fdcb9f49b2a3b3cac24b20a0f4… Patch: https://github.com/kamailio/kamailio/commit/b4ab0fdcb9f49b2a3b3cac24b20a0f4… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index ec5a5da63c..430c35b4f8 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -656,6 +656,7 @@ modparam("siptrace", "evcb_msg", "ksr_siptrace_msg") <title><varname>trace_dialog_ack</varname> (str)</title> <para> Enable tracing of in-dialog ACK. + Before this param, one must have set the onsend() route and captured the outgoing ACK there. </para> <para> Default value is 1 (enabled). @@ -674,6 +675,8 @@ modparam("siptrace", "trace_dialog_ack", 1) <title><varname>trace_dialog_spiral</varname> (str)</title> <para> Enable tracing of dialog spirals. + A spiraled dialog is a dialog established by a SIP INVITE that loops back to the same kamailio(as next hop). + Right now, inside the siptrace code, a spiraled dialog is identified by (*params->param == NULL). </para> <para> Default value is 1 (enabled).

2 1

git:master:501421f4: siptrace: Trace in-dialog ACK and dialog spirals
by Henning Westerholt 10 Aug '22

10 Aug '22

Module: kamailio Branch: master Commit: 501421f42c17a411bde0fb2401437fa2ba1f5c66 URL: https://github.com/kamailio/kamailio/commit/501421f42c17a411bde0fb2401437fa… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-08-08T15:16:34+02:00 siptrace: Trace in-dialog ACK and dialog spirals Enable behavior via 2 new modparams. --- Modified: src/modules/siptrace/doc/siptrace_admin.xml Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/501421f42c17a411bde0fb2401437fa… Patch: https://github.com/kamailio/kamailio/commit/501421f42c17a411bde0fb2401437fa… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index c160b97275e..7852647f37d 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -651,6 +651,43 @@ modparam("siptrace", "evcb_msg", "ksr_siptrace_msg") </programlisting> </example> </section> + + <section id="siptrace.p.trace_dialog_ack"> + <title><varname>trace_dialog_ack</varname> (str)</title> + <para> + Enable tracing of in-dialog ACK. + </para> + <para> + Default value is 0 (disabled). + </para> + <example> + <title>Set <varname>trace_dialog_ack</varname> parameter</title> +<programlisting format="linespecific"> +... +modparam("siptrace", "trace_dialog_ack", 1) +... +</programlisting> + </example> + </section> + + <section id="siptrace.p.trace_dialog_spiral"> + <title><varname>trace_dialog_spiral</varname> (str)</title> + <para> + Enable tracing of dialog spirals. + </para> + <para> + Default value is 0 (disabled). + </para> + <example> + <title>Set <varname>trace_dialog_spiral</varname> parameter</title> +<programlisting format="linespecific"> +... +modparam("siptrace", "trace_dialog_spiral", 1) +... +</programlisting> + </example> + </section> + </section> <section> diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 9540e83d062..81913f064da 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -195,6 +195,10 @@ static str trace_local_ip = {NULL, 0}; static db1_con_t *db_con = NULL; /*!< database connection */ static db_func_t db_funcs; /*!< Database functions */ +int trace_dialog_ack = 0; +int trace_dialog_spiral = 0; +static int spiral_tracked; + int pv_parse_siptrace_name(pv_spec_t *sp, str *in); int pv_get_siptrace(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); @@ -263,6 +267,8 @@ static param_export_t params[] = { {"trace_init_mode", PARAM_INT, &_siptrace_init_mode}, {"trace_mode", PARAM_INT, &_siptrace_mode}, {"evcb_msg", PARAM_STR, &_siptrace_evcb_msg}, + {"trace_dialog_ack", PARAM_INT, &trace_dialog_ack}, + {"trace_dialog_spiral", PARAM_INT, &trace_dialog_spiral}, {0, 0, 0} }; /* clang-format on */ @@ -1979,12 +1985,19 @@ static void trace_dialog(struct dlg_cell* dlg, int type, struct dlg_cb_params *p } /* request - params->req */ - if (params == NULL || params->req == NULL) { + if (params == NULL || (!trace_dialog_spiral && params->req == NULL)) { LM_ERR("Invalid args!\n"); return; } - if (!(params->req->msg_flags & FL_SIPTRACE)) { + if (trace_dialog_spiral && *params->param == NULL) { + LM_DBG("Spiraled dialog!\n"); + if (dlgb.register_dlgcb(dlg, DLGCB_SPIRALED, trace_dialog, &spiral_tracked, NULL) != 0) { + LM_ERR("could not register consider_exporting() for dialog event DLGCB_SPIRALED\n"); + } + } + + if (!trace_dialog_spiral && !(params->req->msg_flags & FL_SIPTRACE)) { LM_DBG("Trace is off for this request...\n"); return; } @@ -2007,6 +2020,13 @@ static void trace_dialog(struct dlg_cell* dlg, int type, struct dlg_cb_params *p return; } + /* this will trace in-dialog ACK */ + if(trace_dialog_ack && dlgb.register_dlgcb(dlg, DLGCB_CONFIRMED, + trace_dialog_transaction, xavp->val.v.vptr, 0) != 0) { + LM_ERR("Failed to register DLGCB_CONFIRMED callback!\n"); + return; + } + if(dlgb.register_dlgcb(dlg, DLGCB_TERMINATED, trace_dialog_transaction, xavp->val.v.vptr, trace_free_info) != 0) { LM_ERR("Failed to register DLGCB_TERMINATED callback!\n");

3 2

Kamailio World Conference - Sep 7-8, 2022 - Online
by Daniel-Constantin Mierla 10 Aug '22

10 Aug '22

For the 3rd year, we are planning an online version of Kamailio World Conference! At the beginning of 2022, the situation was not clear in terms of whether pandemic would decrease enough in intensity and we would be allowed to organize an on-site event late spring/beginner of summer, when the usual Kamailio Conference took place in Berlin, therefore we chose the safety path. But we hope that next year we will return in-person to the beautiful Berlin city center! The event this year, to happen in 4 weeks from now (Sep 7-8, 2022), follows the structure from previous edition, being two afternoons with presentations about Kamailio, sharing technical solutions and open discussions, allowing the community to interact and reconnect. The website of the event: - https://kamailioworld.com/k10-online/ There is no registration required, the event will happen on live video conferencing, also streamed to youtube. A text chatting channel will be made available as well. If you want to present, just send me the title and a short description -- we encourage community members to step forward and share their knowledge. It has to be related to Kamailio and fit within a 30min slot (including the questions). The agenda will be released in the near future. The event will be used also to celebrate 21 years of Kamailio project development, first commit being done on Sep 3, 2001. Two other major celebrations for 2022 to make the party bigger: - 20 years of open source for the project -- after one year of internal development, GPL was added on Sep 19, 2002 and source code was released to public - the 10th edition of Kamailio World Conference Book the dates in your agenda! I am looking forward to a very interesting event and (re-)connecting with many of you! Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

1 0

[kamailio/kamailio] SMSOPS: body < 3 characters not transmitted (empty) (Issue #3211)
by gmaruzz 09 Aug '22

09 Aug '22

Hello, seems to me that if cellphone sends an SMS shorter than 3 characters (eg: "aa") it is sent as empty string this maybe because of some snafu in PDU "payload" management in smsops_impl.c , pointer arithmetic between different characters' coding (ASCII, UTF8, UCS2, etc) (tested with OnePlus 5t, 6t, Open5GS, SRSRAN) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3211 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3211(a)github.com>

2 7

git:master:da017867: tm: add a comment to tm_xdata_swap
by Henning Westerholt 09 Aug '22

09 Aug '22

Module: kamailio Branch: master Commit: da0178673f9a47600329fff2c3105e0fbfbd78f7 URL: https://github.com/kamailio/kamailio/commit/da0178673f9a47600329fff2c3105e0… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-08-09T14:15:04Z tm: add a comment to tm_xdata_swap --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/da0178673f9a47600329fff2c3105e0… Patch: https://github.com/kamailio/kamailio/commit/da0178673f9a47600329fff2c3105e0… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index 6149c363d4..74e47ef7d8 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -514,6 +514,7 @@ struct s_table *init_hash_table() * backup xdata from/to msg context to local var and use T lists * - mode = 0 - from msg context to _txdata and use T lists * - mode = 1 - restore to msg context from _txdata + * the function can be also used to restore the core context from transacation data */ void tm_xdata_swap(tm_cell_t *t, tm_xlinks_t *xd, int mode) {

1 0

git:master:25bec8ef: tm: use similar coding style for tm_xdata_replace as for tm_xdata_swap
by Henning Westerholt 09 Aug '22

09 Aug '22

Module: kamailio Branch: master Commit: 25bec8eff91b332530095ada3997b92edbb5cce6 URL: https://github.com/kamailio/kamailio/commit/25bec8eff91b332530095ada3997b92… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-08-09T14:05:00Z tm: use similar coding style for tm_xdata_replace as for tm_xdata_swap --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/25bec8eff91b332530095ada3997b92… Patch: https://github.com/kamailio/kamailio/commit/25bec8eff91b332530095ada3997b92… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index db6117e557..6149c363d4 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -575,10 +575,7 @@ void tm_xdata_replace(tm_xdata_t *newxd, tm_xlinks_t *bakxd) xavp_set_list(bakxd->xavps_list); xavu_set_list(bakxd->xavus_list); xavi_set_list(bakxd->xavis_list); - return; - } - - if(newxd != NULL && bakxd != NULL) { + } else if(newxd != NULL && bakxd != NULL) { LM_DBG("replace existing list in backup xd from new xd\n"); bakxd->uri_avps_from = set_avp_list( AVP_TRACK_FROM | AVP_CLASS_URI, &newxd->uri_avps_from); @@ -595,7 +592,6 @@ void tm_xdata_replace(tm_xdata_t *newxd, tm_xlinks_t *bakxd) bakxd->xavps_list = xavp_set_list(&newxd->xavps_list); bakxd->xavus_list = xavu_set_list(&newxd->xavus_list); bakxd->xavis_list = xavi_set_list(&newxd->xavis_list); - return; } }

1 0

git:master:5ad00361: tm: add some more debug messages to debug X/AVP and transaction handling
by Henning Westerholt 09 Aug '22

09 Aug '22

Module: kamailio Branch: master Commit: 5ad003617bb79ea647fbfb1eb3c3ebfc4a44280d URL: https://github.com/kamailio/kamailio/commit/5ad003617bb79ea647fbfb1eb3c3ebf… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-08-09T14:03:22Z tm: add some more debug messages to debug X/AVP and transaction handling --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/5ad003617bb79ea647fbfb1eb3c3ebf… Patch: https://github.com/kamailio/kamailio/commit/5ad003617bb79ea647fbfb1eb3c3ebf… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index de98d99e46..db6117e557 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -410,6 +410,7 @@ struct cell *build_cell(struct sip_msg *p_msg) init_synonym_id(p_msg, new_cell->md5); init_cell_lock(new_cell); t_stats_created(); + LM_DBG("created new cell %p\n", new_cell); return new_cell; error: @@ -444,6 +445,7 @@ struct cell *build_cell(struct sip_msg *p_msg) xavp_reset_list(); xavu_reset_list(); xavi_reset_list(); + LM_DBG("could not create cell\n"); return NULL; } @@ -524,6 +526,7 @@ void tm_xdata_swap(tm_cell_t *t, tm_xlinks_t *xd, int mode) x = xd; if(mode == 0) { + LM_DBG("copy X/AVPs from msg context to txdata\n"); if(t == NULL) return; x->uri_avps_from = @@ -542,7 +545,7 @@ void tm_xdata_swap(tm_cell_t *t, tm_xlinks_t *xd, int mode) x->xavus_list = xavu_set_list(&t->xavus_list); x->xavis_list = xavi_set_list(&t->xavis_list); } else if(mode == 1) { - /* restore original avp list */ + LM_DBG("restore X/AVPs msg context from txdata\n"); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, x->uri_avps_from); set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, x->uri_avps_to); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, x->user_avps_from); @@ -561,6 +564,7 @@ void tm_xdata_swap(tm_cell_t *t, tm_xlinks_t *xd, int mode) void tm_xdata_replace(tm_xdata_t *newxd, tm_xlinks_t *bakxd) { if(newxd == NULL && bakxd != NULL) { + LM_DBG("restore X/AVP msg context from backup data\n"); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, bakxd->uri_avps_from); set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, bakxd->uri_avps_to); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, bakxd->user_avps_from); @@ -575,6 +579,7 @@ void tm_xdata_replace(tm_xdata_t *newxd, tm_xlinks_t *bakxd) } if(newxd != NULL && bakxd != NULL) { + LM_DBG("replace existing list in backup xd from new xd\n"); bakxd->uri_avps_from = set_avp_list( AVP_TRACK_FROM | AVP_CLASS_URI, &newxd->uri_avps_from); bakxd->uri_avps_to =

1 0

git:master:6b83bc4c: tm: use internal function tm_xdata_swap instead of manually copy X/AVPs
by Henning Westerholt 09 Aug '22

09 Aug '22

Module: kamailio Branch: master Commit: 6b83bc4cd6da55582793321e6c1f36ff71c4233a URL: https://github.com/kamailio/kamailio/commit/6b83bc4cd6da55582793321e6c1f36f… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-08-09T13:52:42Z tm: use internal function tm_xdata_swap instead of manually copy X/AVPs --- Modified: src/modules/tm/t_hooks.c --- Diff: https://github.com/kamailio/kamailio/commit/6b83bc4cd6da55582793321e6c1f36f… Patch: https://github.com/kamailio/kamailio/commit/6b83bc4cd6da55582793321e6c1f36f…

1 0

[kamailio/kamailio] Add 5.6 branch packages for Ubuntu 22.04 (Issue #3147)
by compuwizz 09 Aug '22

09 Aug '22

Is it possible to add the 5.6 branch deb/ubuntu packages to https://deb.kamailio.org/ for Ubuntu 22.04? I see Ubuntu 22.04 native repos have kamailio 5.5 in them but I'd like to use 5.6. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3147 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3147(a)github.com>

4 7

[kamailio/kamailio] uac.reg_add (PR #3198)
by sznoname 09 Aug '22

09 Aug '22

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3198 -- Commit Summary -- * uac.reg_add -- File Changes -- M src/modules/uac/doc/uac_admin.xml (2) M src/modules/uac/uac_reg.c (10) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3198.patch https://github.com/kamailio/kamailio/pull/3198.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3198 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3198(a)github.com>

3 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2022