sr-dev January 2023

sr-dev@lists.kamailio.org

14 participants
279 discussions

[kamailio/kamailio] pdb: change log level for pdb query response time from LM_INFO to LM_DBG (PR #3296)

by mtryfoss

- using LM_INFO cause a lot of log events on a busy server with normal log level   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Proposal to change log level of the query response time. If this is of interest, it should probably be monitored in some other metric and not flood the syslog. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3296 -- Commit Summary -- * pdb: change log level for pdb query response time from LM_INFO to LM_DBG -- File Changes -- M src/modules/pdb/pdb.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3296.patch https://github.com/kamailio/kamailio/pull/3296.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3296 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3296(a)github.com>

1 year, 5 months

[kamailio/kamailio] Adding SSL support to db_redis and ndb_redis (PR #3345)

by joelbax

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description A couple of commit (1 per each module) adding SSL support to db_redis and ndb_redis. This mainly includes checking if proper parameter is provided (for ndb_redis it is `ssl` option in the DB URL and, for db_redis, a new `opt_ssl` parameter) and create a temporary SSL context that is used to initialise the redis context. db_redis is also updated with another parameter to provide a DB access password. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3345 -- Commit Summary -- * db_redis: Adding SSL support * ndb_redis: Adding SSL support -- File Changes -- M src/modules/db_redis/Makefile (8) M src/modules/db_redis/db_redis_mod.c (5) M src/modules/db_redis/redis_connection.c (43) M src/modules/db_redis/redis_connection.h (2) M src/modules/ndb_redis/Makefile (6) M src/modules/ndb_redis/redis_client.c (47) M src/modules/ndb_redis/redis_client.h (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3345.patch https://github.com/kamailio/kamailio/pull/3345.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3345 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3345(a)github.com>

1 year, 5 months

[kamailio/kamailio] Topos: Added Call-ID mask support for Topos (PR #3347)

by Harish S

Added Call-ID mask Support for Topos with API call from Topoh to mask the callID Call-ID mask happens before the request is sent downstream and unmasked when received from downstream.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3347 -- Commit Summary -- * Topos: Added Call ID mask when sending to Downstream * Topos: Added CallID Mask Document for Topos -- File Changes -- M src/modules/topos/doc/topos_admin.xml (20) M src/modules/topos/topos_mod.c (119) M src/modules/topos/tps_msg.c (37) M src/modules/topos/tps_msg.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3347.patch https://github.com/kamailio/kamailio/pull/3347.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3347 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3347(a)github.com>

1 year, 6 months

[kamailio/kamailio] rtpengine: google sanitizer aligment warning (Issue #3058)

by sergey-safarov

``` bencode.c:149:14: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 18 26 9c ^ bencode.c:50:64: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 18 26 9c ^ bencode.c:50:54: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 00 00 00 ^ bencode.c:50:48: runtime error: member access within misaligned address 0xffff9f18937f for type 'struct bencode_item_t', which requires 8 byte alignment 0xffff9f18937f: note: pointer points here 9f ff ff 00 00 14 00 00 00 00 00 00 00 98 1b 21 9f ff ff 00 00 f0 8b 9a fe ff ff 00 00 00 00 00 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3058 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3058(a)github.com>

1 year, 6 months

[kamailio/kamailio] uac_redirect: Module fails to load [regression] (Issue #3188)

by Alex Hermann

The uac_redirect fails to load in 5.6. It used to load fine before. It is complaining about the acc API, which it never did before. I don't use the acc module and fail to see why uac_redirect would need it. ``` 2022-07-15T14:41:43.813169+02:00 pc1 proxy1[381424]: ERROR: uac_redirect [../../modules/acc/acc_api.h:191]: acc_load_api(): cannot find bind_acc 2022-07-15T14:41:43.813232+02:00 pc1 proxy1[381424]: ERROR: uac_redirect [uac_redirect.c:254]: redirect_init(): cannot bind to ACC API 2022-07-15T14:41:43.813283+02:00 pc1 proxy1[381424]: ERROR: <core> [core/sr_module.c:971]: init_mod(): Error while initializing module uac_redirect (/usr/lib/x86_64-linux-gnu/kamailio/modules/uac_redirect.so) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3188 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3188(a)github.com>

1 year, 8 months

[kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

by ovoshlook

Covers setups when kamailio behind the service with HAPROXY protocol support but in other hand it also serves requests from other services that available per direct connection (such as B2BUA in the same local network). #### Pre-Submission Checklist - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [*] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [*] PR should be backported to stable branches - [*] Tested changes locally #### Description - function tcpconn_read_haproxy() returns 2 if PROXY header NOT found. - Message about no header shown at the debug level. - No errors - TCP connection successfully establishes You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2206 -- Commit Summary -- * handle tcp request with tcp_accept_haproxy even no PROXY header found * core:tcp allow to handle TCP connections even message does not contain PROXY protocol header * core:tcp allow to handle TCP connections even message does not contain PROXY protocol header -- File Changes -- M src/core/tcp_main.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2206.patch https://github.com/kamailio/kamailio/pull/2206.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2206

1 year, 8 months

[kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

by petermarianF

Enable registration of pcscf contact callback during download from db location table and inserting pcontact (normally this callback is registered during handling of REGISTER). Refuse REGISTER when pcontact is expired since [0 to 20] seconds. Within this time window a NOTIFY is expected from scscf and in order to avoid race time conditions between scscf and pcscf REGISTER will be refused. Refuse REGISTER when pcontact is expired longer than 20 seconds - send PUBLISH (contact expired) to scscf to trigger NOTIFY. In both REGISTER refused scenarios routing script should reply 500 - Deregister in progress.   #### Pre-Submission Checklist    - [ x] Commit message has the format required by CONTRIBUTING guide - [ x] Commits are split per component (core, individual modules, libs, utils, ...) - [ x] Each component has a single commit (if not, squash them into one commit) - [ x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In case a pcontact found in location db has to be inserted into pcscf cache depending on contact state also callbacks have to be registered for this pcontact. Registering of callback_pcscf_contact_cb is enabled in this module. Handling of contact expiry is usually triggered in the scscf (mem_timer_udomain which runs every 10 secs). Sending of NOTIFY to pcscf may take up to 20 seconds from start of expiry due to timing conditions. To avoid race time conditions between a REREGISTER and the expiry handler state machine in the scscf an approach is chosen to refuse a REREGISTER in time window of 20 seconds after pcontact expiry on the pcscf (thus allowing expiry handling to finish). REREGISTER is refused in this scenario with new return_code -2. In case a REREGISTER arrives at pcscf and the respective pcontact is expired longer than time window of 20 seconds registration also is refused with rc -2 and additionaly PUBLISH is sent to scscf with expiry = 0. The rc -2 shall be handled in register.cfg script as follows: pcscf_save_pending("location"); switch ($retcode) { case -1: # Missing/wrong Information in REGISTER. send_reply("400", "Information wrong - See log."); exit; break; case -2: # De-Register in Progress, or PUBLISH ongoing due to registration expiry, # or new REGISTER blocked because registration just expired (up to 20sec). append_to_reply("Retry-After: 30\r\n"); send_reply("500", "Deregister in progress - Please try again"); exit; break; } You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3317 -- Commit Summary -- * ims_registrar_pcscf: changes for ul db_mode DB_ONLY -- File Changes -- M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (21) M src/modules/ims_registrar_pcscf/notify.c (4) M src/modules/ims_registrar_pcscf/save.c (37) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3317.patch https://github.com/kamailio/kamailio/pull/3317.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3317 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3317(a)github.com>

1 year, 8 months

[kamailio/kamailio] hiops moduls (#2209)

by mojtabaesfandiari

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2209 -- Commit Summary -- * add received_in_via function(use it in hiops module) * hiops: new module in Kamailio -- File Changes -- M src/core/msg_translator.c (25) M src/core/msg_translator.h (3) A src/modules/hiops/Alarm-Indicator.c (153) A src/modules/hiops/Alarm-Indicator.h (57) A src/modules/hiops/BIT_STRING.c (189) A src/modules/hiops/BIT_STRING.h (33) A src/modules/hiops/CMakeLists.txt (92) A src/modules/hiops/Code.c (64) A src/modules/hiops/Code.h (49) A src/modules/hiops/CommunicationIdentifier.c (94) A src/modules/hiops/CommunicationIdentifier.h (43) A src/modules/hiops/GeneralizedTime.c (706) A src/modules/hiops/GeneralizedTime.h (69) A src/modules/hiops/HI1-Operation.c (94) A src/modules/hiops/HI1-Operation.h (61) A src/modules/hiops/IA5String.c (77) A src/modules/hiops/IA5String.h (27) A src/modules/hiops/INTEGER.c (1025) A src/modules/hiops/INTEGER.h (82) A src/modules/hiops/IP-value.c (130) A src/modules/hiops/IP-value.h (55) A src/modules/hiops/IPAddress.c (393) A src/modules/hiops/IPAddress.h (67) A src/modules/hiops/LawfulInterceptionIdentifier.c (126) A src/modules/hiops/LawfulInterceptionIdentifier.h (38) A src/modules/hiops/LocalTimeStamp.c (191) A src/modules/hiops/LocalTimeStamp.h (50) A src/modules/hiops/Makefile (15) A src/modules/hiops/National-HI1-ASN1parameters.c (139) A src/modules/hiops/National-HI1-ASN1parameters.h (43) A src/modules/hiops/NativeEnumerated.c (207) A src/modules/hiops/NativeEnumerated.h (32) A src/modules/hiops/NativeInteger.c (332) A src/modules/hiops/NativeInteger.h (37) A src/modules/hiops/Network-Element-Identifier.c (198) A src/modules/hiops/Network-Element-Identifier.h (60) A src/modules/hiops/Network-Identifier.c (94) A src/modules/hiops/Network-Identifier.h (48) A src/modules/hiops/Notification.c (153) A src/modules/hiops/Notification.h (57) A src/modules/hiops/OBJECT_IDENTIFIER.c (764) A src/modules/hiops/OBJECT_IDENTIFIER.h (139) A src/modules/hiops/OCTET_STRING.c (1807) A src/modules/hiops/OCTET_STRING.h (86) A src/modules/hiops/PrintableString.c (109) A src/modules/hiops/PrintableString.h (24) A src/modules/hiops/Priority.c (125) A src/modules/hiops/Priority.h (38) A src/modules/hiops/TimeStamp.c (64) A src/modules/hiops/TimeStamp.h (49) A src/modules/hiops/UTCTime.c (179) A src/modules/hiops/UTCTime.h (38) A src/modules/hiops/asn_application.h (47) A src/modules/hiops/asn_codecs.h (109) A src/modules/hiops/asn_codecs_prim.c (312) A src/modules/hiops/asn_codecs_prim.h (53) A src/modules/hiops/asn_internal.h (128) A src/modules/hiops/asn_system.h (137) A src/modules/hiops/ber_decoder.c (283) A src/modules/hiops/ber_decoder.h (64) A src/modules/hiops/ber_tlv_length.c (178) A src/modules/hiops/ber_tlv_length.h (50) A src/modules/hiops/ber_tlv_tag.c (144) A src/modules/hiops/ber_tlv_tag.h (60) A src/modules/hiops/constr_CHOICE.c (1114) A src/modules/hiops/constr_CHOICE.h (57) A src/modules/hiops/constr_SEQUENCE.c (1425) A src/modules/hiops/constr_SEQUENCE.h (60) A src/modules/hiops/constr_TYPE.c (77) A src/modules/hiops/constr_TYPE.h (180) A src/modules/hiops/constraints.c (93) A src/modules/hiops/constraints.h (63) A src/modules/hiops/der_encoder.c (201) A src/modules/hiops/der_encoder.h (68) A src/modules/hiops/hi1ops.c (682) A src/modules/hiops/hi1ops.h (102) A src/modules/hiops/hi2ops.c (1319) A src/modules/hiops/hi2ops.h (109) A src/modules/hiops/hiops.c (272) A src/modules/hiops/hiops.h (38) A src/modules/hiops/per_decoder.c (93) A src/modules/hiops/per_decoder.h (56) A src/modules/hiops/per_encoder.c (151) A src/modules/hiops/per_encoder.h (69) A src/modules/hiops/per_opentype.c (378) A src/modules/hiops/per_opentype.h (22) A src/modules/hiops/per_support.c (483) A src/modules/hiops/per_support.h (135) A src/modules/hiops/tcp_socket.c (136) A src/modules/hiops/tcp_socket.h (39) A src/modules/hiops/xer_decoder.c (368) A src/modules/hiops/xer_decoder.h (106) A src/modules/hiops/xer_encoder.c (67) A src/modules/hiops/xer_encoder.h (59) A src/modules/hiops/xer_support.c (227) A src/modules/hiops/xer_support.h (55) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2209.patch https://github.com/kamailio/kamailio/pull/2209.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2209

1 year, 9 months

[kamailio/kamailio] nathelper: ping_nated_only=1 sends 4-bytes UDP-packet pings (PR #3346)

by Дилян Палаузов

My experiments show that with ``` modparam("nathelper", "ping_nated_only", 1) modparam("nathelper", "sipping_bflag", FLB_NATSIPPING) modparam("usrloc", "nat_bflag", FLB_NATB) ``` when both FLB_NATB and FLB_NATSIPPING branch flags are set, no OPTIONS from Kamailio to UAC is generated, so I assume that nathelper.ping_nated_only=1 does force 4-bytes UDP keepalive. This change spells the above, as the behaviour currently is not specified. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3346 -- Commit Summary -- * nathelper: ping_nated_only sends 4-bytes UDP-packet pings -- File Changes -- M src/modules/nathelper/doc/nathelper_admin.xml (12) M src/modules/nathelper/examples/4to6.cfg (2) M src/modules/nathelper/examples/alg.cfg (2) M src/modules/nathelper/nathelper.c (6) M src/modules/nathelper/nhelpr_funcs.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3346.patch https://github.com/kamailio/kamailio/pull/3346.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3346 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3346(a)github.com>

1 year, 9 months

[kamailio/kamailio] websocket: move some logging from ERROR to INFO (PR #3349)

by Дилян Палаузов

I run Kamailio with ``` log_stderror=yes /* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */ debug=-1 ``` and inspect the output. Some messages from the websocket module are logged repeatedly at ERROR-level, but they are in no way errors. This changes moves such periodially logged no-error messages to debug-level INFO. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3349 -- Commit Summary -- * websocket: move some logging from ERROR to INFO -- File Changes -- M src/modules/websocket/doc/websocket_admin.xml (2) M src/modules/websocket/utf8_decode.h (2) M src/modules/websocket/ws_frame.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3349.patch https://github.com/kamailio/kamailio/pull/3349.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3349 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3349(a)github.com>

1 year, 9 months

← Newer
1
...
8
9
10
11
12
13
14
...
28
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2023