<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2209
-- Commit Summary --
* add received_in_via function(use it in hiops module)
* hiops: new module in Kamailio
-- File Changes --
M src/core/msg_translator.c (25)
M src/core/msg_translator.h (3)
A src/modules/hiops/Alarm-Indicator.c (153)
A src/modules/hiops/Alarm-Indicator.h (57)
A src/modules/hiops/BIT_STRING.c (189)
A src/modules/hiops/BIT_STRING.h (33)
A src/modules/hiops/CMakeLists.txt (92)
A src/modules/hiops/Code.c (64)
A src/modules/hiops/Code.h (49)
A src/modules/hiops/CommunicationIdentifier.c (94)
A src/modules/hiops/CommunicationIdentifier.h (43)
A src/modules/hiops/GeneralizedTime.c (706)
A src/modules/hiops/GeneralizedTime.h (69)
A src/modules/hiops/HI1-Operation.c (94)
A src/modules/hiops/HI1-Operation.h (61)
A src/modules/hiops/IA5String.c (77)
A src/modules/hiops/IA5String.h (27)
A src/modules/hiops/INTEGER.c (1025)
A src/modules/hiops/INTEGER.h (82)
A src/modules/hiops/IP-value.c (130)
A src/modules/hiops/IP-value.h (55)
A src/modules/hiops/IPAddress.c (393)
A src/modules/hiops/IPAddress.h (67)
A src/modules/hiops/LawfulInterceptionIdentifier.c (126)
A src/modules/hiops/LawfulInterceptionIdentifier.h (38)
A src/modules/hiops/LocalTimeStamp.c (191)
A src/modules/hiops/LocalTimeStamp.h (50)
A src/modules/hiops/Makefile (15)
A src/modules/hiops/National-HI1-ASN1parameters.c (139)
A src/modules/hiops/National-HI1-ASN1parameters.h (43)
A src/modules/hiops/NativeEnumerated.c (207)
A src/modules/hiops/NativeEnumerated.h (32)
A src/modules/hiops/NativeInteger.c (332)
A src/modules/hiops/NativeInteger.h (37)
A src/modules/hiops/Network-Element-Identifier.c (198)
A src/modules/hiops/Network-Element-Identifier.h (60)
A src/modules/hiops/Network-Identifier.c (94)
A src/modules/hiops/Network-Identifier.h (48)
A src/modules/hiops/Notification.c (153)
A src/modules/hiops/Notification.h (57)
A src/modules/hiops/OBJECT_IDENTIFIER.c (764)
A src/modules/hiops/OBJECT_IDENTIFIER.h (139)
A src/modules/hiops/OCTET_STRING.c (1807)
A src/modules/hiops/OCTET_STRING.h (86)
A src/modules/hiops/PrintableString.c (109)
A src/modules/hiops/PrintableString.h (24)
A src/modules/hiops/Priority.c (125)
A src/modules/hiops/Priority.h (38)
A src/modules/hiops/TimeStamp.c (64)
A src/modules/hiops/TimeStamp.h (49)
A src/modules/hiops/UTCTime.c (179)
A src/modules/hiops/UTCTime.h (38)
A src/modules/hiops/asn_application.h (47)
A src/modules/hiops/asn_codecs.h (109)
A src/modules/hiops/asn_codecs_prim.c (312)
A src/modules/hiops/asn_codecs_prim.h (53)
A src/modules/hiops/asn_internal.h (128)
A src/modules/hiops/asn_system.h (137)
A src/modules/hiops/ber_decoder.c (283)
A src/modules/hiops/ber_decoder.h (64)
A src/modules/hiops/ber_tlv_length.c (178)
A src/modules/hiops/ber_tlv_length.h (50)
A src/modules/hiops/ber_tlv_tag.c (144)
A src/modules/hiops/ber_tlv_tag.h (60)
A src/modules/hiops/constr_CHOICE.c (1114)
A src/modules/hiops/constr_CHOICE.h (57)
A src/modules/hiops/constr_SEQUENCE.c (1425)
A src/modules/hiops/constr_SEQUENCE.h (60)
A src/modules/hiops/constr_TYPE.c (77)
A src/modules/hiops/constr_TYPE.h (180)
A src/modules/hiops/constraints.c (93)
A src/modules/hiops/constraints.h (63)
A src/modules/hiops/der_encoder.c (201)
A src/modules/hiops/der_encoder.h (68)
A src/modules/hiops/hi1ops.c (682)
A src/modules/hiops/hi1ops.h (102)
A src/modules/hiops/hi2ops.c (1319)
A src/modules/hiops/hi2ops.h (109)
A src/modules/hiops/hiops.c (272)
A src/modules/hiops/hiops.h (38)
A src/modules/hiops/per_decoder.c (93)
A src/modules/hiops/per_decoder.h (56)
A src/modules/hiops/per_encoder.c (151)
A src/modules/hiops/per_encoder.h (69)
A src/modules/hiops/per_opentype.c (378)
A src/modules/hiops/per_opentype.h (22)
A src/modules/hiops/per_support.c (483)
A src/modules/hiops/per_support.h (135)
A src/modules/hiops/tcp_socket.c (136)
A src/modules/hiops/tcp_socket.h (39)
A src/modules/hiops/xer_decoder.c (368)
A src/modules/hiops/xer_decoder.h (106)
A src/modules/hiops/xer_encoder.c (67)
A src/modules/hiops/xer_encoder.h (59)
A src/modules/hiops/xer_support.c (227)
A src/modules/hiops/xer_support.h (55)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2209.patchhttps://github.com/kamailio/kamailio/pull/2209.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2209
[View Less]
My experiments show that with
```
modparam("nathelper", "ping_nated_only", 1)
modparam("nathelper", "sipping_bflag", FLB_NATSIPPING)
modparam("usrloc", "nat_bflag", FLB_NATB)
```
when both FLB_NATB and FLB_NATSIPPING branch flags are set, no OPTIONS from Kamailio to UAC is generated, so I assume that nathelper.ping_nated_only=1 does force 4-bytes UDP keepalive.
This change spells the …
[View More]above, as the behaviour currently is not specified.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3346
-- Commit Summary --
* nathelper: ping_nated_only sends 4-bytes UDP-packet pings
-- File Changes --
M src/modules/nathelper/doc/nathelper_admin.xml (12)
M src/modules/nathelper/examples/4to6.cfg (2)
M src/modules/nathelper/examples/alg.cfg (2)
M src/modules/nathelper/nathelper.c (6)
M src/modules/nathelper/nhelpr_funcs.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3346.patchhttps://github.com/kamailio/kamailio/pull/3346.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3346
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3346(a)github.com>
[View Less]
I run Kamailio with
```
log_stderror=yes
/* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */
debug=-1
```
and inspect the output. Some messages from the websocket module are logged repeatedly at ERROR-level, but they are in no way errors. This changes moves such periodially logged no-error messages to debug-level INFO.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3349
-- Commit Summary --
* websocket: move some …
[View More]logging from ERROR to INFO
-- File Changes --
M src/modules/websocket/doc/websocket_admin.xml (2)
M src/modules/websocket/utf8_decode.h (2)
M src/modules/websocket/ws_frame.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3349.patchhttps://github.com/kamailio/kamailio/pull/3349.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3349
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3349(a)github.com>
[View Less]
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3344
-- Commit Summary --
* test/ : typos
* snmpstats: typos
-- File Changes --
M src/modules/snmpstats/doc/snmpstats_admin.xml (8)
M src/modules/snmpstats/hashTable.c (2)
M src/modules/snmpstats/hashTable.h (2)
M src/modules/snmpstats/interprocess_buffer.c (6)
M src/modules/snmpstats/mibs/KAMAILIO-MIB (10)
M src/modules/snmpstats/mibs/KAMAILIO-REG-MIB (6)
…
[View More] M src/modules/snmpstats/mibs/KAMAILIO-SIP-COMMON-MIB (4)
M src/modules/snmpstats/mibs/KAMAILIO-SIP-SERVER-MIB (6)
M src/modules/snmpstats/mibs/KAMAILIO-TC (4)
M src/modules/snmpstats/snmpObjects.c (2)
M src/modules/snmpstats/snmpSIPContactTable.c (2)
M src/modules/snmpstats/snmpSIPContactTable.h (2)
M src/modules/snmpstats/snmpSIPRegUserLookupTable.c (4)
M src/modules/snmpstats/snmpSIPRegUserLookupTable.h (2)
M src/modules/snmpstats/snmpSIPStatusCodesTable.c (4)
M src/modules/snmpstats/sub_agent.c (2)
M test/misc/cfg/mobile61.cfg (2)
M test/misc/cfg/nc.cfg (8)
M test/misc/cfg/struas.cfg (2)
M test/misc/cfg/test1.cfg (2)
M test/misc/cfg/use_jab.cfg (2)
M test/misc/code/atomic_test.c (2)
M test/misc/code/atomic_test2.c (2)
M test/misc/code/basex.c (2)
M test/misc/code/shoot.c (2)
M test/misc/code/shoot2.c (2)
M test/misc/code/udp.c (6)
M test/misc/extra/gcc_version.sh (2)
M test/unit/5.cfg (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3344.patchhttps://github.com/kamailio/kamailio/pull/3344.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3344
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3344(a)github.com>
[View Less]
The documentation of rr.custom_user_avp speaks about option `enable_username`, but there is no such option.
I assume the documentation means `add_username`.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3352
-- Commit Summary --
* rr: doc — replace enable_username with add_username
-- File Changes --
M src/modules/rr/doc/rr_admin.xml (6)
M src/modules/rr/doc/rr_devel.xml (10)
M src/modules/rr/loose.c (10)
M …
[View More]src/modules/rr/loose.h (6)
M src/modules/rr/rr_mod.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3352.patchhttps://github.com/kamailio/kamailio/pull/3352.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3352
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3352(a)github.com>
[View Less]
I use Kamailio with `log_stderror=yes`. When Kamailio receives confirmation from the Websocket reverse proxy, it logs on stderr
```
23(24) ERROR: <core> [core/parser/parse_fline.c:271]: parse_first_line(): parse_first_line: bad message (offset: 22)
23(24) ERROR: <core> [core/parser/msg_parser.c:749]: parse_msg(): ERROR: parse_msg: message=<HTTP/1.1 101 Switching Protocols
Sia: SIP/2.0/TCP 111.11.111.11:47418
Sec-WebSocket-Protocol: sip
Upgrade: websocket
…
[View More]Connection: upgrade
Sec-WebSocket-Accept: Ak3/c/aw3iyHnFkDDHabw1iXcqY=
Content-Length: 0
>
23(24) ERROR: <core> [core/msg_translator.c:3256]: build_sip_msg_from_buf(): parsing failed
```
Without the included `\n` here the subsequent messages are logged on the same line as `parsing failed`.
For the record, I use this NGINX configuration:
```
location /sip {
proxy_http_version 1.1;
proxy_set_header "Accept-Encoding" ""; # delete header before sending it to Kamailio
proxy_set_header "Pragma" "";
proxy_set_header "Cache-control" "";
proxy_set_header "User-Agent" "";
proxy_set_header Host $host;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $http_connection;
proxy_pass http://123.12.123.12:5060;
proxy_read_timeout 86400;
}
```
and it leads to that unparsable message above.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3348
-- Commit Summary --
* core: msg_translator.c put new line after «parsing failed» error message
-- File Changes --
M src/core/msg_translator.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3348.patchhttps://github.com/kamailio/kamailio/pull/3348.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3348
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3348(a)github.com>
[View Less]