- Add new function to clear OpenSSL errors prior to any SSL_* call
- Apply function where appropriate
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [x] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR proposes similar fixes like https://github.com/kamailio/kamailio/pull/3607.
OpenSSL docs suggest that the error stack must be empty for [SSL_get_error() to work reliably](https://www.openssl.org/docs/man3.0/man3/SSL_get_error.html).
_Note: This has not been tested like previous PR and any feedback of course is appreciated._
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3612
-- Commit Summary --
* cdp: Add and apply cdp_openssl_clear_errors function
-- File Changes --
M src/modules/cdp/cdp_tls.c (2)
M src/modules/cdp/receiver.c (3)
A src/modules/cdp/utils.c (21)
M src/modules/cdp/utils.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3612.patchhttps://github.com/kamailio/kamailio/pull/3612.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3612
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3612(a)github.com>
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
The new parameter connect_timeout_ms (global) / timeout_ms (in httpcon) allows to specify a timeout in milliseconds on curl requests.
If this parameter is defined (non zero), then the timeout in seconds is ignored.
If either timeout or timeout_ms is defined at connection level, then they take precedence over the global parameters.
These principles also apply to the file configuration.
The timeout in ms is used internally to set CURLOPT_TIMEOUT_MS.
The value is shown in ms when using RPC "httpclient.listcon".
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3611
-- Commit Summary --
* http_client: Add parameter connect_timeout_ms / timeout_ms (2)
-- File Changes --
M src/modules/http_client/curlcon.c (103)
M src/modules/http_client/doc/http_client_admin.xml (32)
M src/modules/http_client/functions.c (24)
M src/modules/http_client/http_client.c (12)
M src/modules/http_client/http_client.h (13)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3611.patchhttps://github.com/kamailio/kamailio/pull/3611.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3611
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3611(a)github.com>
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Add function to get dialog by internal hash entry and id. This is needed by my other ongoing changes to the ims_charging module for restoring records from database.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3613
-- Commit Summary --
* ims_dialog: Add function to get dialog by hash entry and id
-- File Changes --
M src/modules/ims_dialog/dlg_handlers.c (19)
M src/modules/ims_dialog/dlg_handlers.h (8)
M src/modules/ims_dialog/dlg_load.h (5)
M src/modules/ims_dialog/ims_dialog.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3613.patchhttps://github.com/kamailio/kamailio/pull/3613.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3613
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3613(a)github.com>
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
The new parameter connect_timeout_ms (global) / timeout_ms (in httpcon) allows to specify a timeout in milliseconds on curl requests.
If this parameter is defined (non zero), then the timeout in seconds is ignored.
See https://curl.se/libcurl/c/CURLOPT_TIMEOUT_MS.html
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3609
-- Commit Summary --
* http_client: Add parameter connect_timeout_ms / timeout_ms
-- File Changes --
M src/modules/http_client/curlcon.c (55)
M src/modules/http_client/doc/http_client_admin.xml (29)
M src/modules/http_client/functions.c (22)
M src/modules/http_client/http_client.c (12)
M src/modules/http_client/http_client.h (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3609.patchhttps://github.com/kamailio/kamailio/pull/3609.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3609
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3609(a)github.com>